54625 2011-02-17 01:22:58 -0800 [chromium] GradientSkia: use the common Gradient stop sorting methods. 2011-03-03 21:12:29 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 55742 1 noel.gordon noel.gordon abarth commit-queue eric jamesr reed senorblanco webkit.review.bot oldest_to_newest 352674 0 noel.gordon 2011-02-17 01:22:58 -0800 Address a code FIXME. 352677 1 82768 noel.gordon 2011-02-17 01:27:39 -0800 Created attachment 82768 Patch 353029 2 82768 jamesr 2011-02-17 11:04:27 -0800 Comment on attachment 82768 Patch R=me 353967 3 82768 commit-queue 2011-02-18 18:32:26 -0800 Comment on attachment 82768 Patch Rejecting attachment 82768 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-a..." exit_code: 2 Last 500 characters of output: c (refs/remotes/trunk) M Source/WebCore/ChangeLog M Source/WebCore/platform/graphics/skia/GradientSkia.cpp r79063 = 29f47ae159022f5b8d71afc2ca3b29c700d3739a (refs/remotes/trunk) M Source/WebKit2/ChangeLog M Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp M Source/WebKit2/WebProcess/WebPage/WebPage.cpp r79064 = 8c69a75bf9b2ef43953139bbda1848f2a4ca9f84 (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/trunk. Full output: http://queues.webkit.org/results/7939200 353970 4 jamesr 2011-02-18 18:47:48 -0800 Looks like this doesn't apply to ToT any more. Would you mind merging+uploading, Noel? 353975 5 commit-queue 2011-02-18 19:01:56 -0800 The commit-queue encountered the following flaky tests while processing attachment 82768: http/tests/security/cross-frame-access-port-explicit-domain.html bug 54668 (author: sam@webkit.org) The commit-queue is continuing to process your patch. 354229 6 noel.gordon 2011-02-19 16:54:07 -0800 (In reply to comment #4) > Looks like this doesn't apply to ToT any more. Would you mind merging+uploading, Noel? No worries. I'm away for a week, and will merge+upload on my return. 358890 7 84015 noel.gordon 2011-02-27 21:48:56 -0800 Created attachment 84015 patch - merge and reupload 358891 8 webkit.review.bot 2011-02-27 21:51:26 -0800 Attachment 84015 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/skia/GradientSkia.cpp:118: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] Suppressing further [whitespace/carriage_return] reports for this file. Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 358892 9 84016 noel.gordon 2011-02-27 21:55:18 -0800 Created attachment 84016 patch - merge and reupload #2 359533 10 commit-queue 2011-02-28 17:31:14 -0800 The commit-queue encountered the following flaky tests while processing attachment 84016: http/tests/websocket/tests/close-on-navigate-new-location.html bug 55431 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 359538 11 84016 commit-queue 2011-02-28 17:34:07 -0800 Comment on attachment 84016 patch - merge and reupload #2 Clearing flags on attachment: 84016 Committed r79950: <http://trac.webkit.org/changeset/79950> 359539 12 commit-queue 2011-02-28 17:34:11 -0800 All reviewed patches have been landed. Closing bug. 359561 13 webkit.review.bot 2011-02-28 18:03:37 -0800 http://trac.webkit.org/changeset/79950 might have broken SnowLeopard Intel Release (Build) 82768 2011-02-17 01:27:39 -0800 2011-02-27 21:49:20 -0800 Patch patch-git-stop-sorting.diff text/plain 1862 noel.gordon ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmYzg5MzE2Li4xZTZiYTAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDItMTcgIE5vZWwgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0g R3JhZGllbnRTa2lhOiB1c2UgdGhlIGNvbW1vbiBHcmFkaWVudCBzdG9wIHNvcnRpbmcgbWV0aG9k cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0NjI1 CisKKyAgICAgICAgUmVtb3ZlIEZJWE1FOiBjYWxsIHRoZSBHcmFkaWVudC5jcHAgc3RvcCBzdG9y dGluZyByb3V0aW5lcywgbm8gbmVlZCB0bworICAgICAgICBkdXBsaWNhdGUgdGhhdCBjb2RlIGhl cmVpbi4KKworICAgICAgICBObyBjaGFuZ2UgaW4gYmVoYXZpb3IsIHNvIG5vIG5ldyB0ZXN0cy4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhZGllbnRTa2lhLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkdyYWRpZW50OjpwbGF0Zm9ybUdyYWRpZW50KToKKwogMjAxMS0wMi0x NiAgQnJpYW4gUnluZXIgIDxicnluZXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERhcmluIEZpc2hlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3NraWEvR3JhZGllbnRTa2lhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3NraWEvR3JhZGllbnRTa2lhLmNwcAppbmRleCBhNjM2ZDEwLi4yNTFlYmM5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYWRpZW50U2tp YS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFkaWVu dFNraWEuY3BwCkBAIC0xMTAsMjMgKzExMCwxNCBAQCBzdGF0aWMgdm9pZCBmaWxsU3RvcHMoY29u c3QgR3JhZGllbnQ6OkNvbG9yU3RvcCogc3RvcERhdGEsCiAgICAgfQogfQogCi1zdGF0aWMgaW5s aW5lIGJvb2wgY29tcGFyZVN0b3BzKGNvbnN0IEdyYWRpZW50OjpDb2xvclN0b3AmIGEsIGNvbnN0 IEdyYWRpZW50OjpDb2xvclN0b3AmIGIpCi17Ci0gICAgcmV0dXJuIGEuc3RvcCA8IGIuc3RvcDsK LX0KLQogU2tTaGFkZXIqIEdyYWRpZW50OjpwbGF0Zm9ybUdyYWRpZW50KCkKIHsKICAgICBpZiAo bV9ncmFkaWVudCkKICAgICAgICAgcmV0dXJuIG1fZ3JhZGllbnQ7CiAKLSAgICAvLyBGSVhNRTog VGhpcyBhbmQgY29tcGFyZVN0b3BzKCkgYXJlIGFsc28gaW4gR3JhZGllbnQuY3BwIGFuZAotICAg IC8vIENTU0dyYWRpZW50VmFsdWUuY3BwOyBwcm9iYWJseSBzaG91bGQgcmVmYWN0b3IgaW4gV2Vi S2l0LgotICAgIGlmICghbV9zdG9wc1NvcnRlZCkgewotICAgICAgICBpZiAobV9zdG9wcy5zaXpl KCkpCi0gICAgICAgICAgICBzdGQ6OnN0YWJsZV9zb3J0KG1fc3RvcHMuYmVnaW4oKSwgbV9zdG9w cy5lbmQoKSwgY29tcGFyZVN0b3BzKTsKLSAgICAgICAgbV9zdG9wc1NvcnRlZCA9IHRydWU7Ci0g ICAgfQorICAgIHNvcnRTdG9wc0lmTmVjZXNzYXJ5KCk7CisgICAgQVNTRVJUKG1fc3RvcHNTb3J0 ZWQpOworCiAgICAgc2l6ZV90IGNvdW50VXNlZCA9IHRvdGFsU3RvcHNOZWVkZWQobV9zdG9wcy5k YXRhKCksIG1fc3RvcHMuc2l6ZSgpKTsKICAgICBBU1NFUlQoY291bnRVc2VkID49IDIpOwogICAg IEFTU0VSVChjb3VudFVzZWQgPj0gbV9zdG9wcy5zaXplKCkpOwo= 84015 2011-02-27 21:48:56 -0800 2011-02-27 21:53:50 -0800 patch - merge and reupload patch-git-stop-sorting.diff text/plain 1834 noel.gordon ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ODBlZjlkLi45YmFiMzg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDItMjcgIE5vZWwgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgorICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIEdy YWRpZW50U2tpYTogdXNlIHRoZSBjb21tb24gR3JhZGllbnQgc3RvcCBzb3J0aW5nIG1ldGhvZHMu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDYyNQor CisgICAgICAgIFJlbW92ZSBhIEZJWE1FOiBjYWxsIHRoZSBHcmFkaWVudC5jcHAgc3RvcCBzdG9y dGluZyByb3V0aW5lcywgbm8gbmVlZAorICAgICAgICB0byBkdXBsaWNhdGUgdGhhdCBjb2RlIGhl cmVpbi4KKworICAgICAgICBObyBjaGFuZ2UgaW4gYmVoYXZpb3IsIHNvIG5vIG5ldyB0ZXN0cy4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhZGllbnRTa2lhLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkdyYWRpZW50OjpwbGF0Zm9ybUdyYWRpZW50KToKKwogMjAxMS0wMi0y NyAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYWRpZW50U2tpYS5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYWRpZW50U2tpYS5jcHAKaW5kZXggMWJiOGQyMC4u ZmRhMjI3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tp YS9HcmFkaWVudFNraWEuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3NraWEvR3JhZGllbnRTa2lhLmNwcApAQCAtMTEwLDIzICsxMTAsMTMgQEAgc3RhdGljIHZvaWQg ZmlsbFN0b3BzKGNvbnN0IEdyYWRpZW50OjpDb2xvclN0b3AqIHN0b3BEYXRhLAogICAgIH0KIH0K IAotc3RhdGljIGlubGluZSBib29sIGNvbXBhcmVTdG9wcyhjb25zdCBHcmFkaWVudDo6Q29sb3JT dG9wJiBhLCBjb25zdCBHcmFkaWVudDo6Q29sb3JTdG9wJiBiKQotewotICAgIHJldHVybiBhLnN0 b3AgPCBiLnN0b3A7Ci19Ci0KIFNrU2hhZGVyKiBHcmFkaWVudDo6cGxhdGZvcm1HcmFkaWVudCgp CiB7CiAgICAgaWYgKG1fZ3JhZGllbnQpCiAgICAgICAgIHJldHVybiBtX2dyYWRpZW50OwogCi0g ICAgLy8gRklYTUU6IFRoaXMgYW5kIGNvbXBhcmVTdG9wcygpIGFyZSBhbHNvIGluIEdyYWRpZW50 LmNwcCBhbmQKLSAgICAvLyBDU1NHcmFkaWVudFZhbHVlLmNwcDsgcHJvYmFibHkgc2hvdWxkIHJl ZmFjdG9yIGluIFdlYktpdC4KLSAgICBpZiAoIW1fc3RvcHNTb3J0ZWQpIHsKLSAgICAgICAgaWYg KG1fc3RvcHMuc2l6ZSgpKQotICAgICAgICAgICAgc3RkOjpzdGFibGVfc29ydChtX3N0b3BzLmJl Z2luKCksIG1fc3RvcHMuZW5kKCksIGNvbXBhcmVTdG9wcyk7Ci0gICAgICAgIG1fc3RvcHNTb3J0 ZWQgPSB0cnVlOwotICAgIH0KKyAgICBzb3J0U3RvcHNJZk5lY2Vzc2FyeSgpOw0KKyAgICBBU1NF UlQobV9zdG9wc1NvcnRlZCk7CiAKICAgICBzaXplX3QgY291bnRVc2VkID0gdG90YWxTdG9wc05l ZWRlZChtX3N0b3BzLmRhdGEoKSwgbV9zdG9wcy5zaXplKCkpOwogICAgIEFTU0VSVChjb3VudFVz ZWQgPj0gMik7Cg== 84016 2011-02-27 21:55:18 -0800 2011-02-28 17:34:07 -0800 patch - merge and reupload #2 patch-git-stop-sorting.diff text/plain 1833 noel.gordon ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ODBlZjlkLi45YmFiMzg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDItMjcgIE5vZWwgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgorICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIEdy YWRpZW50U2tpYTogdXNlIHRoZSBjb21tb24gR3JhZGllbnQgc3RvcCBzb3J0aW5nIG1ldGhvZHMu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDYyNQor CisgICAgICAgIFJlbW92ZSBhIEZJWE1FOiBjYWxsIHRoZSBHcmFkaWVudC5jcHAgc3RvcCBzdG9y dGluZyByb3V0aW5lcywgbm8gbmVlZAorICAgICAgICB0byBkdXBsaWNhdGUgdGhhdCBjb2RlIGhl cmVpbi4KKworICAgICAgICBObyBjaGFuZ2UgaW4gYmVoYXZpb3IsIHNvIG5vIG5ldyB0ZXN0cy4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhZGllbnRTa2lhLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkdyYWRpZW50OjpwbGF0Zm9ybUdyYWRpZW50KToKKwogMjAxMS0wMi0y NyAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYWRpZW50U2tpYS5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYWRpZW50U2tpYS5jcHAKaW5kZXggMWJiOGQyMC4u MmFhZGMwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tp YS9HcmFkaWVudFNraWEuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3NraWEvR3JhZGllbnRTa2lhLmNwcApAQCAtMTEwLDIzICsxMTAsMTMgQEAgc3RhdGljIHZvaWQg ZmlsbFN0b3BzKGNvbnN0IEdyYWRpZW50OjpDb2xvclN0b3AqIHN0b3BEYXRhLAogICAgIH0KIH0K IAotc3RhdGljIGlubGluZSBib29sIGNvbXBhcmVTdG9wcyhjb25zdCBHcmFkaWVudDo6Q29sb3JT dG9wJiBhLCBjb25zdCBHcmFkaWVudDo6Q29sb3JTdG9wJiBiKQotewotICAgIHJldHVybiBhLnN0 b3AgPCBiLnN0b3A7Ci19Ci0KIFNrU2hhZGVyKiBHcmFkaWVudDo6cGxhdGZvcm1HcmFkaWVudCgp CiB7CiAgICAgaWYgKG1fZ3JhZGllbnQpCiAgICAgICAgIHJldHVybiBtX2dyYWRpZW50OwogCi0g ICAgLy8gRklYTUU6IFRoaXMgYW5kIGNvbXBhcmVTdG9wcygpIGFyZSBhbHNvIGluIEdyYWRpZW50 LmNwcCBhbmQKLSAgICAvLyBDU1NHcmFkaWVudFZhbHVlLmNwcDsgcHJvYmFibHkgc2hvdWxkIHJl ZmFjdG9yIGluIFdlYktpdC4KLSAgICBpZiAoIW1fc3RvcHNTb3J0ZWQpIHsKLSAgICAgICAgaWYg KG1fc3RvcHMuc2l6ZSgpKQotICAgICAgICAgICAgc3RkOjpzdGFibGVfc29ydChtX3N0b3BzLmJl Z2luKCksIG1fc3RvcHMuZW5kKCksIGNvbXBhcmVTdG9wcyk7Ci0gICAgICAgIG1fc3RvcHNTb3J0 ZWQgPSB0cnVlOwotICAgIH0KKyAgICBzb3J0U3RvcHNJZk5lY2Vzc2FyeSgpOworICAgIEFTU0VS VChtX3N0b3BzU29ydGVkKTsKIAogICAgIHNpemVfdCBjb3VudFVzZWQgPSB0b3RhbFN0b3BzTmVl ZGVkKG1fc3RvcHMuZGF0YSgpLCBtX3N0b3BzLnNpemUoKSk7CiAgICAgQVNTRVJUKGNvdW50VXNl ZCA+PSAyKTsK