54621 2011-02-17 00:36:47 -0800 [EFL] Remove proxy feature of soup when proxy is null 2011-02-18 23:41:37 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue kenneth leandro lucas.de.marchi tonikitoo oldest_to_newest 352646 0 gyuyoung.kim 2011-02-17 00:36:47 -0800 In void ewk_settings_proxy_uri_set(const char* proxy), it is better to remove proxy feature when parameter is NULL. 352649 1 82763 gyuyoung.kim 2011-02-17 00:41:54 -0800 Created attachment 82763 Patch 352782 2 82763 tonikitoo 2011-02-17 05:55:38 -0800 Comment on attachment 82763 Patch Please move "session" declaration line to withing the "if" block. 353200 3 82869 gyuyoung.kim 2011-02-17 15:21:48 -0800 Created attachment 82869 Fixed Patch >> Please move "session" declaration line to withing the "if" block. Do you mean that the session declaration need to be moved to if block ? I add "return" to if block. How do you think about it ? The session declaration should be declared regardless of proxy. 353360 4 82869 tonikitoo 2011-02-17 20:15:16 -0800 Comment on attachment 82869 Fixed Patch In "removes proxy feature in soup." it should be "remove". 353363 5 82909 gyuyoung.kim 2011-02-17 20:23:04 -0800 Created attachment 82909 Fixed Patch I fix the wrong spelling. Thank you for your review. 353365 6 82910 gyuyoung.kim 2011-02-17 20:25:29 -0800 Created attachment 82910 Fixed Patch I add your name to reviewer field in Changelog. Thank you. 353995 7 82910 commit-queue 2011-02-18 19:20:55 -0800 Comment on attachment 82910 Fixed Patch Clearing flags on attachment: 82910 Committed r79070: <http://trac.webkit.org/changeset/79070> 82763 2011-02-17 00:41:54 -0800 2011-02-17 20:23:04 -0800 Patch patch-proxy.txt text/plain 1516 gyuyoung.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA4Zjc5MjMyLi42M2Q4NDYyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMTcgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbRUZMXSBSZW1vdmUgcHJveHkgZmVhdHVyZSBvZiBzb3VwIHdoZW4gcHJveHkgaXMgbnVs bAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ2MjEK KworICAgICAgICBXaGVuIHByb3h5IHZhbHVlIGlzIE5VTEwsIHJlbW92ZXMgcHJveHkgZmVhdHVy ZSBpbiBzb3VwLgorCisgICAgICAgICogZXdrL2V3a19zZXR0aW5ncy5jcHA6CisgICAgICAgIChl d2tfc2V0dGluZ3NfcHJveHlfdXJpX3NldCk6CisKIDIwMTEtMDItMTYgIEd5dXlvdW5nIEtpbSAg PGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZp eC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwIGIv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAKaW5kZXggNTRlNjY0NS4uYmU4 YmY0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAK KysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAKQEAgLTI3OSwxMCAr Mjc5LDE2IEBAIEV2YXNfT2JqZWN0KiBld2tfc2V0dGluZ3NfaWNvbl9kYXRhYmFzZV9pY29uX29i amVjdF9hZGQoY29uc3QgY2hhciogdXJsLCBFdmFzKiBjCiB2b2lkIGV3a19zZXR0aW5nc19wcm94 eV91cmlfc2V0KGNvbnN0IGNoYXIqIHByb3h5KQogewogI2lmIFVTRShTT1VQKQorICAgIFNvdXBT ZXNzaW9uKiBzZXNzaW9uID0gV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OmRlZmF1bHRTZXNzaW9u KCk7CisKKyAgICBpZiAoIXByb3h5KSB7CisgICAgICAgIEVSUigibm8gcHJveHkgdXJpLiByZW1v dmUgcHJveHkgZmVhdHVyZSBpbiBzb3VwLiIpOworICAgICAgICBzb3VwX3Nlc3Npb25fcmVtb3Zl X2ZlYXR1cmVfYnlfdHlwZShzZXNzaW9uLCBTT1VQX1RZUEVfUFJPWFlfUkVTT0xWRVIpOworICAg IH0KKwogICAgIFNvdXBVUkkqIHVyaSA9IHNvdXBfdXJpX25ldyhwcm94eSk7CiAgICAgRUlOQV9T QUZFVFlfT05fTlVMTF9SRVRVUk4odXJpKTsKIAotICAgIFNvdXBTZXNzaW9uKiBzZXNzaW9uID0g V2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OmRlZmF1bHRTZXNzaW9uKCk7CiAgICAgZ19vYmplY3Rf c2V0KHNlc3Npb24sIFNPVVBfU0VTU0lPTl9QUk9YWV9VUkksIHVyaSwgTlVMTCk7CiAgICAgc291 cF91cmlfZnJlZSh1cmkpOwogI2VsaWYgVVNFKENVUkwpCg== 82869 2011-02-17 15:21:48 -0800 2011-02-17 20:15:16 -0800 Fixed Patch patch-proxy.txt text/plain 1533 gyuyoung.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA4Zjc5MjMyLi42M2Q4NDYyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMTcgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbRUZMXSBSZW1vdmUgcHJveHkgZmVhdHVyZSBvZiBzb3VwIHdoZW4gcHJveHkgaXMgbnVs bAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ2MjEK KworICAgICAgICBXaGVuIHByb3h5IHZhbHVlIGlzIE5VTEwsIHJlbW92ZXMgcHJveHkgZmVhdHVy ZSBpbiBzb3VwLgorCisgICAgICAgICogZXdrL2V3a19zZXR0aW5ncy5jcHA6CisgICAgICAgIChl d2tfc2V0dGluZ3NfcHJveHlfdXJpX3NldCk6CisKIDIwMTEtMDItMTYgIEd5dXlvdW5nIEtpbSAg PGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZp eC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwIGIv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAKaW5kZXggNTRlNjY0NS4uNDBj ODUwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAK KysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAKQEAgLTI3OSwxMCAr Mjc5LDE3IEBAIEV2YXNfT2JqZWN0KiBld2tfc2V0dGluZ3NfaWNvbl9kYXRhYmFzZV9pY29uX29i amVjdF9hZGQoY29uc3QgY2hhciogdXJsLCBFdmFzKiBjCiB2b2lkIGV3a19zZXR0aW5nc19wcm94 eV91cmlfc2V0KGNvbnN0IGNoYXIqIHByb3h5KQogewogI2lmIFVTRShTT1VQKQorICAgIFNvdXBT ZXNzaW9uKiBzZXNzaW9uID0gV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OmRlZmF1bHRTZXNzaW9u KCk7CisKKyAgICBpZiAoIXByb3h5KSB7CisgICAgICAgIEVSUigibm8gcHJveHkgdXJpLiByZW1v dmUgcHJveHkgZmVhdHVyZSBpbiBzb3VwLiIpOworICAgICAgICBzb3VwX3Nlc3Npb25fcmVtb3Zl X2ZlYXR1cmVfYnlfdHlwZShzZXNzaW9uLCBTT1VQX1RZUEVfUFJPWFlfUkVTT0xWRVIpOworICAg ICAgICByZXR1cm47CisgICAgfQorCiAgICAgU291cFVSSSogdXJpID0gc291cF91cmlfbmV3KHBy b3h5KTsKICAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTih1cmkpOwogCi0gICAgU291cFNl c3Npb24qIHNlc3Npb24gPSBXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6ZGVmYXVsdFNlc3Npb24o KTsKICAgICBnX29iamVjdF9zZXQoc2Vzc2lvbiwgU09VUF9TRVNTSU9OX1BST1hZX1VSSSwgdXJp LCBOVUxMKTsKICAgICBzb3VwX3VyaV9mcmVlKHVyaSk7CiAjZWxpZiBVU0UoQ1VSTCkK 82909 2011-02-17 20:23:04 -0800 2011-02-17 20:25:40 -0800 Fixed Patch patch-proxy.txt text/plain 1354 gyuyoung.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBmYjBlNTA0Li42NGQwYWM4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMTcgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbRUZMXSBSZW1vdmUgcHJveHkgZmVhdHVyZSBvZiBzb3VwIHdoZW4gcHJveHkgaXMgbnVs bAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ2MjEK KworICAgICAgICBXaGVuIHByb3h5IHZhbHVlIGlzIE5VTEwsIHJlbW92ZSBwcm94eSBmZWF0dXJl IGluIHNvdXAuCisKKyAgICAgICAgKiBld2svZXdrX3NldHRpbmdzLmNwcDoKKyAgICAgICAgKGV3 a19zZXR0aW5nc19wcm94eV91cmlfc2V0KToKKwogMjAxMS0wMi0xNyAgUnl1YW4gQ2hvaSAgPHJ5 dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBUYW11cmEu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcCBiL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwCmluZGV4IDU0ZTY2NDUuLjJiNmQ0 NTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwCkBAIC0yNzksNiArMjc5 LDE0IEBAIEV2YXNfT2JqZWN0KiBld2tfc2V0dGluZ3NfaWNvbl9kYXRhYmFzZV9pY29uX29iamVj dF9hZGQoY29uc3QgY2hhciogdXJsLCBFdmFzKiBjCiB2b2lkIGV3a19zZXR0aW5nc19wcm94eV91 cmlfc2V0KGNvbnN0IGNoYXIqIHByb3h5KQogewogI2lmIFVTRShTT1VQKQorICAgIFNvdXBTZXNz aW9uKiBzZXNzaW9uID0gV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OmRlZmF1bHRTZXNzaW9uKCk7 CisKKyAgICBpZiAoIXByb3h5KSB7CisgICAgICAgIEVSUigibm8gcHJveHkgdXJpLiByZW1vdmUg cHJveHkgZmVhdHVyZSBpbiBzb3VwLiIpOworICAgICAgICBzb3VwX3Nlc3Npb25fcmVtb3ZlX2Zl YXR1cmVfYnlfdHlwZShzZXNzaW9uLCBTT1VQX1RZUEVfUFJPWFlfUkVTT0xWRVIpOworICAgICAg ICByZXR1cm47CisgICAgfQorCiAgICAgU291cFVSSSogdXJpID0gc291cF91cmlfbmV3KHByb3h5 KTsKICAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTih1cmkpOwogCg== 82910 2011-02-17 20:25:29 -0800 2011-02-18 19:20:55 -0800 Fixed Patch patch-proxy.txt text/plain 1353 gyuyoung.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBmYjBlNTA0Li5jZDZmZTQ4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMTcgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBBbnRvbmlvIEdvbWVzLgorCisgICAg ICAgIFtFRkxdIFJlbW92ZSBwcm94eSBmZWF0dXJlIG9mIHNvdXAgd2hlbiBwcm94eSBpcyBudWxs CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDYyMQor CisgICAgICAgIFdoZW4gcHJveHkgdmFsdWUgaXMgTlVMTCwgcmVtb3ZlIHByb3h5IGZlYXR1cmUg aW4gc291cC4KKworICAgICAgICAqIGV3ay9ld2tfc2V0dGluZ3MuY3BwOgorICAgICAgICAoZXdr X3NldHRpbmdzX3Byb3h5X3VyaV9zZXQpOgorCiAyMDExLTAyLTE3ICBSeXVhbiBDaG9pICA8cnl1 YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRhbXVyYS4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwIGIvU291 cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAKaW5kZXggNTRlNjY0NS4uMmI2ZDQ1 NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAKKysr IGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAKQEAgLTI3OSw2ICsyNzks MTQgQEAgRXZhc19PYmplY3QqIGV3a19zZXR0aW5nc19pY29uX2RhdGFiYXNlX2ljb25fb2JqZWN0 X2FkZChjb25zdCBjaGFyKiB1cmwsIEV2YXMqIGMKIHZvaWQgZXdrX3NldHRpbmdzX3Byb3h5X3Vy aV9zZXQoY29uc3QgY2hhciogcHJveHkpCiB7CiAjaWYgVVNFKFNPVVApCisgICAgU291cFNlc3Np b24qIHNlc3Npb24gPSBXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6ZGVmYXVsdFNlc3Npb24oKTsK KworICAgIGlmICghcHJveHkpIHsKKyAgICAgICAgRVJSKCJubyBwcm94eSB1cmkuIHJlbW92ZSBw cm94eSBmZWF0dXJlIGluIHNvdXAuIik7CisgICAgICAgIHNvdXBfc2Vzc2lvbl9yZW1vdmVfZmVh dHVyZV9ieV90eXBlKHNlc3Npb24sIFNPVVBfVFlQRV9QUk9YWV9SRVNPTFZFUik7CisgICAgICAg IHJldHVybjsKKyAgICB9CisKICAgICBTb3VwVVJJKiB1cmkgPSBzb3VwX3VyaV9uZXcocHJveHkp OwogICAgIEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJOKHVyaSk7CiAK