54606 2011-02-16 18:23:56 -0800 [Chromium] Control-Up/Down do not scroll by page on Chrome/Mac 2011-02-23 02:19:02 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P2 Minor --- 0 toyoshim webkit-unassigned abarth commit-queue eric hamaji webkit.review.bot oldest_to_newest 352514 0 toyoshim 2011-02-16 18:23:56 -0800 http://code.google.com/p/chromium/issues/detail?id=68975 Control-Up/Down should be PageUp/Down on Mac. It is in most programs (Xcode, Safari, etc.) 352520 1 82734 toyoshim 2011-02-16 18:38:40 -0800 Created attachment 82734 Patch 355824 2 hamaji 2011-02-22 21:12:35 -0800 Adding [Chromium] prefix to the summary. 355827 3 82734 hamaji 2011-02-22 21:19:42 -0800 Comment on attachment 82734 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82734&action=review r=me I think you would want to set cq? when you ask a review for your patch. > Source/WebKit/chromium/ChangeLog:5 > + Control-Up/Down should be PageUp/Down on Mac. I think it's nice to have prefixes for this kind of platform specific changes. > Source/WebKit/chromium/src/WebViewImpl.cpp:809 > + // Control-Up/Down should be PageUp/Downb on Mac. s/Downb/Down/ 355838 4 83440 toyoshim 2011-02-22 21:34:58 -0800 Created attachment 83440 Patch 355840 5 webkit.review.bot 2011-02-22 21:37:21 -0800 Attachment 83440 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/src/WebViewImpl.cpp:815: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 355843 6 hamaji 2011-02-22 21:40:26 -0800 (In reply to comment #5) > Attachment 83440 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 > > Source/WebKit/chromium/src/WebViewImpl.cpp:815: One line control clauses should not use braces. [whitespace/braces] [4] > Total errors found: 1 in 2 files True... I'm wondering why this cannot be detected in the previous time. 355846 7 83441 toyoshim 2011-02-22 21:45:29 -0800 Created attachment 83441 Patch 355847 8 webkit.review.bot 2011-02-22 21:48:38 -0800 Attachment 83441 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/src/WebViewImpl.cpp:811: More than one command on the same line in if [whitespace/parens] [4] Source/WebKit/chromium/src/WebViewImpl.cpp:812: More than one command on the same line in if [whitespace/parens] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 355859 9 toyoshim 2011-02-22 21:52:43 -0800 hum... In my local environment, check-webkit-style could not detect this style check error as previous bot could not. FYI % svn info Path: . URL: http://svn.webkit.org/repository/webkit/trunk Repository Root: http://svn.webkit.org/repository/webkit Repository UUID: 268f45cc-cd09-0410-ab3c-d52691b4dbfc Revision: 78759 Node Kind: directory Schedule: normal Last Changed Author: jorlow@chromium.org Last Changed Rev: 78759 Last Changed Date: 2011-02-16 18:28:10 -0800 (Wed, 16 Feb 2011) 355865 10 83441 hamaji 2011-02-22 21:58:09 -0800 Comment on attachment 83441 Patch It looks like this check was fixed recently. http://trac.webkit.org/changeset/79102 355867 11 83445 toyoshim 2011-02-22 22:01:31 -0800 Created attachment 83445 Patch 355869 12 83445 hamaji 2011-02-22 22:04:56 -0800 Comment on attachment 83445 Patch Finally! 355871 13 toyoshim 2011-02-22 22:07:22 -0800 Yes! I'm sorry for bothering you;( 355939 14 83445 commit-queue 2011-02-23 01:42:54 -0800 Comment on attachment 83445 Patch Clearing flags on attachment: 83445 Committed r79427: <http://trac.webkit.org/changeset/79427> 355940 15 commit-queue 2011-02-23 01:43:00 -0800 All reviewed patches have been landed. Closing bug. 355955 16 webkit.review.bot 2011-02-23 02:19:02 -0800 http://trac.webkit.org/changeset/79427 might have broken Windows Release (Build) and Windows Debug (Build) 82734 2011-02-16 18:38:40 -0800 2011-02-22 21:34:54 -0800 Patch bug-54606-20110216183839.patch text/plain 1478 toyoshim SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA3ODc1OSkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDItMTYgIFRha2FzaGkgVG95b3NoaW1hICA8dG95b3NoaW1AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbnRy b2wtVXAvRG93biBzaG91bGQgYmUgUGFnZVVwL0Rvd24gb24gTWFjLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ2MDYKKworICAgICAgICAqIHNyYy9X ZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpzY3JvbGxWaWV3 V2l0aEtleWJvYXJkKToKKwogMjAxMS0wMi0xNiAgSmVyZW15IE9ybG93ICA8am9ybG93QGNocm9t aXVtLm9yZz4KIAogICAgICAgICBCYWNrIG91dCBJbmRleGVkREIgY2hhbmdlIHRoYXRzIG5vIGxv bmdlciBuZWNlc3NhcnkKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJ bXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3 SW1wbC5jcHAJKHJldmlzaW9uIDc4NzU5KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViVmlld0ltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04MDUsNiArODA1LDE2IEBAIGJvb2wg V2ViVmlld0ltcGw6OnNjcm9sbFZpZXdXaXRoS2V5Ym9hcmQKIHsKICAgICBTY3JvbGxEaXJlY3Rp b24gc2Nyb2xsRGlyZWN0aW9uOwogICAgIFNjcm9sbEdyYW51bGFyaXR5IHNjcm9sbEdyYW51bGFy aXR5OworI2lmIE9TKERBUldJTikKKyAgICAvLyBDb250cm9sLVVwL0Rvd24gc2hvdWxkIGJlIFBh Z2VVcC9Eb3duYiBvbiBNYWMuCisgICAgaWYgKG1vZGlmaWVycyAmIFdlYk1vdXNlRXZlbnQ6OkNv bnRyb2xLZXkpIHsKKyAgICAgIGlmIChrZXlDb2RlID09IFZLRVlfVVApIHsKKyAgICAgICAga2V5 Q29kZSA9IFZLRVlfUFJJT1I7CisgICAgICB9IGVsc2UgaWYgKGtleUNvZGUgPT0gVktFWV9ET1dO KSB7CisgICAgICAgIGtleUNvZGUgPSBWS0VZX05FWFQ7CisgICAgICB9CisgICAgfQorI2VuZGlm CiAgICAgaWYgKCFtYXBLZXlDb2RlRm9yU2Nyb2xsKGtleUNvZGUsICZzY3JvbGxEaXJlY3Rpb24s ICZzY3JvbGxHcmFudWxhcml0eSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICByZXR1cm4g cHJvcGFnYXRlU2Nyb2xsKHNjcm9sbERpcmVjdGlvbiwgc2Nyb2xsR3JhbnVsYXJpdHkpOwo= 83440 2011-02-22 21:34:58 -0800 2011-02-22 21:45:25 -0800 Patch bug-54606-20110222213457.patch text/plain 1488 toyoshim SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA3ODc1OSkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDItMTYgIFRha2FzaGkgVG95b3NoaW1hICA8dG95b3NoaW1AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJv bWl1bV0gQ29udHJvbC1VcC9Eb3duIHNob3VsZCBiZSBQYWdlVXAvRG93biBvbiBNYWMuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDYwNgorCisgICAg ICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6 OnNjcm9sbFZpZXdXaXRoS2V5Ym9hcmQpOgorCiAyMDExLTAyLTE2ICBKZXJlbXkgT3Jsb3cgIDxq b3Jsb3dAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEJhY2sgb3V0IEluZGV4ZWREQiBjaGFuZ2Ug dGhhdHMgbm8gbG9uZ2VyIG5lY2Vzc2FyeQpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViVmlld0ltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmNwcAkocmV2aXNpb24gNzg3NTkpCisrKyBTb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgwNSw2ICs4MDUs MTYgQEAgYm9vbCBXZWJWaWV3SW1wbDo6c2Nyb2xsVmlld1dpdGhLZXlib2FyZAogewogICAgIFNj cm9sbERpcmVjdGlvbiBzY3JvbGxEaXJlY3Rpb247CiAgICAgU2Nyb2xsR3JhbnVsYXJpdHkgc2Ny b2xsR3JhbnVsYXJpdHk7CisjaWYgT1MoREFSV0lOKQorICAgIC8vIENvbnRyb2wtVXAvRG93biBz aG91bGQgYmUgUGFnZVVwL0Rvd24gb24gTWFjLgorICAgIGlmIChtb2RpZmllcnMgJiBXZWJNb3Vz ZUV2ZW50OjpDb250cm9sS2V5KSB7CisgICAgICBpZiAoa2V5Q29kZSA9PSBWS0VZX1VQKSB7Cisg ICAgICAgIGtleUNvZGUgPSBWS0VZX1BSSU9SOworICAgICAgfSBlbHNlIGlmIChrZXlDb2RlID09 IFZLRVlfRE9XTikgeworICAgICAgICBrZXlDb2RlID0gVktFWV9ORVhUOworICAgICAgfQorICAg IH0KKyNlbmRpZgogICAgIGlmICghbWFwS2V5Q29kZUZvclNjcm9sbChrZXlDb2RlLCAmc2Nyb2xs RGlyZWN0aW9uLCAmc2Nyb2xsR3JhbnVsYXJpdHkpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAg ICAgcmV0dXJuIHByb3BhZ2F0ZVNjcm9sbChzY3JvbGxEaXJlY3Rpb24sIHNjcm9sbEdyYW51bGFy aXR5KTsK 83441 2011-02-22 21:45:29 -0800 2011-02-22 22:01:26 -0800 Patch bug-54606-20110222214527.patch text/plain 1455 toyoshim SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA3ODc1OSkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDItMTYgIFRha2FzaGkgVG95b3NoaW1hICA8dG95b3NoaW1AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJv bWl1bV0gQ29udHJvbC1VcC9Eb3duIHNob3VsZCBiZSBQYWdlVXAvRG93biBvbiBNYWMuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDYwNgorCisgICAg ICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6 OnNjcm9sbFZpZXdXaXRoS2V5Ym9hcmQpOgorCiAyMDExLTAyLTE2ICBKZXJlbXkgT3Jsb3cgIDxq b3Jsb3dAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEJhY2sgb3V0IEluZGV4ZWREQiBjaGFuZ2Ug dGhhdHMgbm8gbG9uZ2VyIG5lY2Vzc2FyeQpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViVmlld0ltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmNwcAkocmV2aXNpb24gNzg3NTkpCisrKyBTb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgwNSw2ICs4MDUs MTMgQEAgYm9vbCBXZWJWaWV3SW1wbDo6c2Nyb2xsVmlld1dpdGhLZXlib2FyZAogewogICAgIFNj cm9sbERpcmVjdGlvbiBzY3JvbGxEaXJlY3Rpb247CiAgICAgU2Nyb2xsR3JhbnVsYXJpdHkgc2Ny b2xsR3JhbnVsYXJpdHk7CisjaWYgT1MoREFSV0lOKQorICAgIC8vIENvbnRyb2wtVXAvRG93biBz aG91bGQgYmUgUGFnZVVwL0Rvd24gb24gTWFjLgorICAgIGlmIChtb2RpZmllcnMgJiBXZWJNb3Vz ZUV2ZW50OjpDb250cm9sS2V5KSB7CisgICAgICBpZiAoa2V5Q29kZSA9PSBWS0VZX1VQKSBrZXlD b2RlID0gVktFWV9QUklPUjsKKyAgICAgIGVsc2UgaWYgKGtleUNvZGUgPT0gVktFWV9ET1dOKSBr ZXlDb2RlID0gVktFWV9ORVhUOworICAgIH0KKyNlbmRpZgogICAgIGlmICghbWFwS2V5Q29kZUZv clNjcm9sbChrZXlDb2RlLCAmc2Nyb2xsRGlyZWN0aW9uLCAmc2Nyb2xsR3JhbnVsYXJpdHkpKQog ICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgcmV0dXJuIHByb3BhZ2F0ZVNjcm9sbChzY3JvbGxE aXJlY3Rpb24sIHNjcm9sbEdyYW51bGFyaXR5KTsK 83445 2011-02-22 22:01:31 -0800 2011-02-23 01:42:54 -0800 Patch bug-54606-20110222220129.patch text/plain 1473 toyoshim SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA3ODc1OSkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDItMTYgIFRha2FzaGkgVG95b3NoaW1hICA8dG95b3NoaW1AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJv bWl1bV0gQ29udHJvbC1VcC9Eb3duIHNob3VsZCBiZSBQYWdlVXAvRG93biBvbiBNYWMuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDYwNgorCisgICAg ICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6 OnNjcm9sbFZpZXdXaXRoS2V5Ym9hcmQpOgorCiAyMDExLTAyLTE2ICBKZXJlbXkgT3Jsb3cgIDxq b3Jsb3dAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEJhY2sgb3V0IEluZGV4ZWREQiBjaGFuZ2Ug dGhhdHMgbm8gbG9uZ2VyIG5lY2Vzc2FyeQpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViVmlld0ltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmNwcAkocmV2aXNpb24gNzg3NTkpCisrKyBTb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgwNSw2ICs4MDUs MTUgQEAgYm9vbCBXZWJWaWV3SW1wbDo6c2Nyb2xsVmlld1dpdGhLZXlib2FyZAogewogICAgIFNj cm9sbERpcmVjdGlvbiBzY3JvbGxEaXJlY3Rpb247CiAgICAgU2Nyb2xsR3JhbnVsYXJpdHkgc2Ny b2xsR3JhbnVsYXJpdHk7CisjaWYgT1MoREFSV0lOKQorICAgIC8vIENvbnRyb2wtVXAvRG93biBz aG91bGQgYmUgUGFnZVVwL0Rvd24gb24gTWFjLgorICAgIGlmIChtb2RpZmllcnMgJiBXZWJNb3Vz ZUV2ZW50OjpDb250cm9sS2V5KSB7CisgICAgICBpZiAoa2V5Q29kZSA9PSBWS0VZX1VQKQorICAg ICAgICBrZXlDb2RlID0gVktFWV9QUklPUjsKKyAgICAgIGVsc2UgaWYgKGtleUNvZGUgPT0gVktF WV9ET1dOKQorICAgICAgICBrZXlDb2RlID0gVktFWV9ORVhUOworICAgIH0KKyNlbmRpZgogICAg IGlmICghbWFwS2V5Q29kZUZvclNjcm9sbChrZXlDb2RlLCAmc2Nyb2xsRGlyZWN0aW9uLCAmc2Ny b2xsR3JhbnVsYXJpdHkpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgcmV0dXJuIHByb3Bh Z2F0ZVNjcm9sbChzY3JvbGxEaXJlY3Rpb24sIHNjcm9sbEdyYW51bGFyaXR5KTsK