54605 2011-02-16 18:23:18 -0800 http/tests/security/cross-frame-access-child-explicit-domain.html is flaky due to built-in timeouts 2011-02-18 19:04:47 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 pkasting pkasting commit-queue jamesr oldest_to_newest 352512 0 pkasting 2011-02-16 18:23:18 -0800 http/tests/security/cross-frame-access-child-explicit-domain.html is flaky on the Chromium Win Debug bot (see http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&group=%40ToT%20-%20chromium.org&tests=http%2Ftests%2Fsecurity%2Fcross-frame-access-child-explicit-domain.html ). This is because the test internally puts setTimeout(..., 2000) blocks around attempts to load frames. This is a recipe for flakiness. Test harnesses can kill long-running tests anyway, so it seems like we'd do better to just eliminate these timeouts entirely. 353161 1 82859 pkasting 2011-02-17 14:04:32 -0800 Created attachment 82859 patch v1 353172 2 jamesr 2011-02-17 14:17:26 -0800 The patch had the wrong mimetype and didn't have the "patch" bit set - did you use webkit-patch to upload? 353173 3 82859 jamesr 2011-02-17 14:17:53 -0800 Comment on attachment 82859 patch v1 R=me 353174 4 pkasting 2011-02-17 14:20:02 -0800 (In reply to comment #2) > The patch had the wrong mimetype and didn't have the "patch" bit set - did you use webkit-patch to upload? Oops, sorry, forgot to toggle that. (I uploaded manually.) 353978 5 commit-queue 2011-02-18 19:02:43 -0800 The commit-queue encountered the following flaky tests while processing attachment 82859: media/invalid-media-url-crash.html bug 51138 (author: inferno@chromium.org) The commit-queue is continuing to process your patch. 353979 6 82859 commit-queue 2011-02-18 19:04:42 -0800 Comment on attachment 82859 patch v1 Clearing flags on attachment: 82859 Committed r79066: <http://trac.webkit.org/changeset/79066> 353980 7 commit-queue 2011-02-18 19:04:47 -0800 All reviewed patches have been landed. Closing bug. 82859 2011-02-17 14:04:32 -0800 2011-02-18 19:04:42 -0800 patch v1 patch text/plain 4055 pkasting SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDc4OTE1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDItMTcgIFBldGVyIEthc3RpbmcgIDxw a2FzdGluZ0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDYw NQorICAgICAgICBSZW1vdmUgc29tZSB0aW1lIGxpbWl0cyBpbiBhIHRlc3QsIGxldCB0ZXN0IGhh cm5lc3NlcyBraWxsIHRoZSB0ZXN0IGlmCisgICAgICAgIGl0IHJ1bnMgbG9uZy4gIEFsc28gY2hh bmdlcyBhIGJ1c3kgbG9vcCBmcm9tIDEgbXMgdG8gNSBtcyByZXBlYXRzIHNpbmNlCisgICAgICAg IHRoaXMgc2hvdWxkIGJlIG11Y2ggbGVzcyBDUFUgYXQgbGl0dGxlIHZpc2libGUgY29zdC4KKwor ICAgICAgICAqIGh0dHAvdGVzdHMvc2VjdXJpdHkvcmVzb3VyY2VzL2Nyb3NzLWZyYW1lLWFjY2Vz cy5qczoKKyAgICAgICAgKGNhbkFjY2Vzc0ZyYW1lLnRlc3QpOgorICAgICAgICAoY2FuQWNjZXNz RnJhbWUpOgorICAgICAgICAoY2Fubm90QWNjZXNzRnJhbWUudGVzdCk6CisgICAgICAgIChjYW5u b3RBY2Nlc3NGcmFtZSk6CisgICAgICAgIChjbG9zZVdpbmRvd0FuZE5vdGlmeURvbmUuZG9uZUhh bmRsZXIpOgorICAgICAgICAoY2xvc2VXaW5kb3dBbmROb3RpZnlEb25lKToKKwogMjAxMS0wMi0x NyAgSmVyZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KIAogICAgICAgICBGaXggbWlu b3IgcHJvYmxlbSB3aXRoIHRlc3QuCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3Vy aXR5L3Jlc291cmNlcy9jcm9zcy1mcmFtZS1hY2Nlc3MuanMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9yZXNvdXJjZXMvY3Jvc3MtZnJhbWUtYWNjZXNzLmpz CShyZXZpc2lvbiA3ODczNykKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvcmVz b3VyY2VzL2Nyb3NzLWZyYW1lLWFjY2Vzcy5qcwkod29ya2luZyBjb3B5KQpAQCAtMTI2LDEyICsx MjYsNiBAQCBmdW5jdGlvbiBjYW5BY2Nlc3NGcmFtZShpZnJhbWVVUkwsIGlmcmFtCiAgICAgICAg IH0KICAgICB9LCBmYWxzZSk7CiAKLSAgICB2YXIgcnVuYXdheVRpbWVyID0gc2V0VGltZW91dChm dW5jdGlvbigpIHsKLSAgICAgICAgbG9nKCJGQUlMOiBTdWJmcmFtZSBkaWQgbm90IGZpbmlzaCBs b2FkaW5nLiIpOwotICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQotICAg ICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOwotICAgIH0sIDIwMDAp OwotCiAgICAgdmFyIHRhcmdldFdpbmRvdyA9IGZyYW1lc1swXTsKICAgICBpZiAoIXRhcmdldFdp bmRvdy5kb2N1bWVudC5ib2R5KQogICAgICAgICBsb2coIkZBSUw6IHRhcmdldFdpbmRvdyBzdGFy dGVkIHdpdGggbm8gZG9jdW1lbnQsIHdlIHdvbid0IGtub3cgaWYgdGhlIHRlc3QgcGFzc2VkIG9y IGZhaWxlZC4iKTsKQEAgLTE0NSw3ICsxMzksNiBAQCBmdW5jdGlvbiBjYW5BY2Nlc3NGcmFtZShp ZnJhbWVVUkwsIGlmcmFtCiAgICAgICAgICAgICBpZiAodGFyZ2V0V2luZG93LmRvY3VtZW50ICYm IHRhcmdldFdpbmRvdy5kb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYWNjZXNzTWUnKSkgewogICAg ICAgICAgICAgICAgIHRhcmdldFdpbmRvdy5kb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYWNjZXNz TWUnKS5pbm5lckhUTUwgPSBwYXNzTWVzc2FnZTsKICAgICAgICAgICAgICAgICBsb2cocGFzc01l c3NhZ2UpOwotICAgICAgICAgICAgICAgIGNsZWFyVGltZW91dChydW5hd2F5VGltZXIpOwogICAg ICAgICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCiAgICAgICAgICAg ICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKICAgICAgICAgICAg ICAgICByZXR1cm47CkBAIC0xNTUsNyArMTQ4LDYgQEAgZnVuY3Rpb24gY2FuQWNjZXNzRnJhbWUo aWZyYW1lVVJMLCBpZnJhbQogICAgICAgICB9CiAKICAgICAgICAgbG9nKGZhaWxNZXNzYWdlKTsK LSAgICAgICAgY2xlYXJUaW1lb3V0KHJ1bmF3YXlUaW1lcik7CiAgICAgICAgIGlmICh3aW5kb3cu bGF5b3V0VGVzdENvbnRyb2xsZXIpCiAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5u b3RpZnlEb25lKCk7CiAgICAgfQpAQCAtMTc1LDEyICsxNjcsNiBAQCBmdW5jdGlvbiBjYW5ub3RB Y2Nlc3NGcmFtZShpZnJhbWVVUkwsIGlmCiAgICAgICAgIH0KICAgICB9LCBmYWxzZSk7CiAKLSAg ICB2YXIgcnVuYXdheVRpbWVyID0gc2V0VGltZW91dChmdW5jdGlvbigpIHsKLSAgICAgICAgbG9n KCJGQUlMOiBTdWJmcmFtZSBkaWQgbm90IGZpbmlzaCBsb2FkaW5nLiIpOwotICAgICAgICBpZiAo d2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQotICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRy b2xsZXIubm90aWZ5RG9uZSgpOwotICAgIH0sIDIwMDApOwotCiAgICAgdmFyIHRhcmdldFdpbmRv dyA9IGZyYW1lc1swXTsKICAgICBpZiAoIXRhcmdldFdpbmRvdy5kb2N1bWVudC5ib2R5KQogICAg ICAgICBsb2coIkZBSUw6IHRhcmdldFdpbmRvdyBzdGFydGVkIHdpdGggbm8gZG9jdW1lbnQsIHdl IHdvbid0IGtub3cgaWYgdGhlIHRlc3QgcGFzc2VkIG9yIGZhaWxlZC4iKTsKQEAgLTE5NCw3ICsx ODAsNiBAQCBmdW5jdGlvbiBjYW5ub3RBY2Nlc3NGcmFtZShpZnJhbWVVUkwsIGlmCiAgICAgICAg ICAgICBpZiAodGFyZ2V0V2luZG93LmRvY3VtZW50ICYmIHRhcmdldFdpbmRvdy5kb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgnYWNjZXNzTWUnKSkgewogICAgICAgICAgICAgICAgIHRhcmdldFdpbmRv dy5kb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYWNjZXNzTWUnKS5pbm5lckhUTUwgPSBmYWlsTWVz c2FnZTsKICAgICAgICAgICAgICAgICBsb2coZmFpbE1lc3NhZ2UpOwotICAgICAgICAgICAgICAg IGNsZWFyVGltZW91dChydW5hd2F5VGltZXIpOwogICAgICAgICAgICAgICAgIGlmICh3aW5kb3cu bGF5b3V0VGVzdENvbnRyb2xsZXIpCiAgICAgICAgICAgICAgICAgICAgIGxheW91dFRlc3RDb250 cm9sbGVyLm5vdGlmeURvbmUoKTsKICAgICAgICAgICAgICAgICByZXR1cm47CkBAIC0yMDMsNyAr MTg4LDYgQEAgZnVuY3Rpb24gY2Fubm90QWNjZXNzRnJhbWUoaWZyYW1lVVJMLCBpZgogICAgICAg ICB9CiAKICAgICAgICAgbG9nKHBhc3NNZXNzYWdlKTsKLSAgICAgICAgY2xlYXJUaW1lb3V0KHJ1 bmF3YXlUaW1lcik7CiAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCiAg ICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CiAgICAgfQpAQCAt MjEyLDcgKzE5Niw3IEBAIGZ1bmN0aW9uIGNhbm5vdEFjY2Vzc0ZyYW1lKGlmcmFtZVVSTCwgaWYK IGZ1bmN0aW9uIGNsb3NlV2luZG93QW5kTm90aWZ5RG9uZSh3aW4pCiB7CiAgICAgd2luLmNsb3Nl KCk7Ci0gICAgc2V0VGltZW91dChkb25lSGFuZGxlciwgMSk7CisgICAgc2V0VGltZW91dChkb25l SGFuZGxlciwgNSk7CiAgICAgZnVuY3Rpb24gZG9uZUhhbmRsZXIoKSB7CiAgICAgICAgIGlmICh3 aW4uY2xvc2VkKSB7CiAgICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVy KQpAQCAtMjIwLDYgKzIwNCw2IEBAIGZ1bmN0aW9uIGNsb3NlV2luZG93QW5kTm90aWZ5RG9uZSh3 aW4pCiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIAotICAgICAgICBzZXRUaW1lb3V0 KGRvbmVIYW5kbGVyLCAxKTsKKyAgICAgICAgc2V0VGltZW91dChkb25lSGFuZGxlciwgNSk7CiAg ICAgfQogfQo=