54595 2011-02-16 15:31:12 -0800 new-run-webkit-tests: --dry-run hangs with --worker-model=processes 2011-02-17 16:46:54 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth eric mihaip ojan tony oldest_to_newest 352407 0 dpranke 2011-02-16 15:31:12 -0800 new-run-webkit-tests: --dry-run hangs with --worker-model=processes 352410 1 82711 dpranke 2011-02-16 15:34:23 -0800 Created attachment 82711 Patch 352633 2 82711 ojan 2011-02-17 00:01:15 -0800 Comment on attachment 82711 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82711&action=review > Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:122 > + keyboard_interrupted = False > + interrupted = False > + thread_timings = [] Nit: I prefer variables being defined as close to the code they're used as possible. So, I'd move these down to be around line 131 instead. 353243 3 dpranke 2011-02-17 16:46:54 -0800 Committed r78930: <http://trac.webkit.org/changeset/78930> 82711 2011-02-16 15:34:23 -0800 2011-02-17 00:01:15 -0800 Patch bug-54595-20110216153422.patch text/plain 5053 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogNzg3MzQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjNzM2Zjc2OTcwZGJlZGYwOGMyMzRkMTQwNmQ2NTc0M2Q2 ZGJiMGY5Li5iMjcxMWExMzgyMDllMTQ0YzQ0MzY1YTc0NzNjNTJmNDAxNTVlMTIyIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDItMTYgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGEgaGFuZyBp biBuZXctcnVuLXdlYmtpdC10ZXN0cyB3aGVuIHJ1biB3aXRoCisgICAgICAgIC0tZHJ5LXJ1biAt LXdvcmtlci1tb2RlbD1wcm9jZXNzZXMKKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTQ1OTUKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rlc3RfcnVubmVyMi5weToKKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzX3VuaXR0ZXN0LnB5Ogor CiAyMDExLTAyLTE2ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBSb2Jlbi4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rlc3RfcnVubmVyMi5weSBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rlc3RfcnVu bmVyMi5weQppbmRleCA5NTNjYTE0OTY2NTcwMzBmMjM4NGU0NjY1NzU0NTcwZmExNzQyMzllLi4w NTAzZTg4MDNkNTgwOWY2YmJmOTU5YzIyZDE2ODMzYzNhOGM0ODUxIDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS90ZXN0X3J1bm5l cjIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3Bh Y2thZ2UvdGVzdF9ydW5uZXIyLnB5CkBAIC0xMTcsNiArMTE3LDkgQEAgY2xhc3MgVGVzdFJ1bm5l cjIodGVzdF9ydW5uZXIuVGVzdFJ1bm5lcik6CiAgICAgICAgIHNlbGYuX3dvcmtlcl9zdGF0ZXMg PSB7fQogCiAgICAgICAgIG51bV93b3JrZXJzID0gc2VsZi5fbnVtX3dvcmtlcnMoKQorICAgICAg ICBrZXlib2FyZF9pbnRlcnJ1cHRlZCA9IEZhbHNlCisgICAgICAgIGludGVycnVwdGVkID0gRmFs c2UKKyAgICAgICAgdGhyZWFkX3RpbWluZ3MgPSBbXQogCiAgICAgICAgIHNlbGYuX3ByaW50ZXIu cHJpbnRfdXBkYXRlKCdTaGFyZGluZyB0ZXN0cyAuLi4nKQogICAgICAgICB0ZXN0X2xpc3RzID0g c2VsZi5fc2hhcmRfdGVzdHMoZmlsZV9saXN0LApAQCAtMTI2LDYgKzEyOSwxMCBAQCBjbGFzcyBU ZXN0UnVubmVyMih0ZXN0X3J1bm5lci5UZXN0UnVubmVyKToKICAgICAgICAgbWFuYWdlcl9jb25u ZWN0aW9uID0gbWFuYWdlcl93b3JrZXJfYnJva2VyLmdldChzZWxmLl9wb3J0LCBzZWxmLl9vcHRp b25zLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHNlbGYsIHdvcmtlci5Xb3JrZXIpCiAKKyAgICAgICAgaWYgc2VsZi5fb3B0aW9ucy5kcnlf cnVuOgorICAgICAgICAgICAgcmV0dXJuIChrZXlib2FyZF9pbnRlcnJ1cHRlZCwgaW50ZXJydXB0 ZWQsIHRocmVhZF90aW1pbmdzLAorICAgICAgICAgICAgICAgICAgICBzZWxmLl9ncm91cF9zdGF0 cywgc2VsZi5fYWxsX3Jlc3VsdHMpCisKICAgICAgICAgc2VsZi5fcHJpbnRlci5wcmludF91cGRh dGUoJ1N0YXJ0aW5nICVzIC4uLicgJQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBncmFtbWFyLnBsdXJhbGl6ZSgnd29ya2VyJywgbnVtX3dvcmtlcnMpKQogICAgICAgICBmb3Ig d29ya2VyX251bWJlciBpbiB4cmFuZ2UobnVtX3dvcmtlcnMpOgpAQCAtMTUwLDI2ICsxNTcsMjMg QEAgY2xhc3MgVGVzdFJ1bm5lcjIodGVzdF9ydW5uZXIuVGVzdFJ1bm5lcik6CiAgICAgICAgIGZv ciBpIGluIHhyYW5nZShudW1fd29ya2Vycyk6CiAgICAgICAgICAgICBtYW5hZ2VyX2Nvbm5lY3Rp b24ucG9zdF9tZXNzYWdlKCdzdG9wJykKIAotICAgICAgICBrZXlib2FyZF9pbnRlcnJ1cHRlZCA9 IEZhbHNlCi0gICAgICAgIGludGVycnVwdGVkID0gRmFsc2UKICAgICAgICAgdHJ5OgotICAgICAg ICAgICAgaWYgbm90IHNlbGYuX29wdGlvbnMuZHJ5X3J1bjoKLSAgICAgICAgICAgICAgICB3aGls ZSBub3Qgc2VsZi5pc19kb25lKCk6Ci0gICAgICAgICAgICAgICAgICAgICMgV2UgbG9vcCB3aXRo IGEgdGltZW91dCBpbiBvcmRlciB0byBiZSBhYmxlIHRvIGRldGVjdCB3ZWRnZWQgdGhyZWFkcy4K LSAgICAgICAgICAgICAgICAgICAgbWFuYWdlcl9jb25uZWN0aW9uLnJ1bl9tZXNzYWdlX2xvb3Ao ZGVsYXlfc2Vjcz0xLjApCi0KLSAgICAgICAgICAgICAgICBpZiBhbnkod29ya2VyX3N0YXRlLndl ZGdlZCBmb3Igd29ya2VyX3N0YXRlIGluIHNlbGYuX3dvcmtlcl9zdGF0ZXMudmFsdWVzKCkpOgot ICAgICAgICAgICAgICAgICAgICBfbG9nLmVycm9yKCcnKQotICAgICAgICAgICAgICAgICAgICBf bG9nLmVycm9yKCdSZW1haW5pbmcgd29ya2VycyBhcmUgd2VkZ2VkLCBiYWlsaW5nIG91dC4nKQot ICAgICAgICAgICAgICAgICAgICBfbG9nLmVycm9yKCcnKQotICAgICAgICAgICAgICAgIGVsc2U6 Ci0gICAgICAgICAgICAgICAgICAgIF9sb2cuZGVidWcoJ05vIHdlZGdlZCB0aHJlYWRzJykKLQot ICAgICAgICAgICAgICAgICMgTWFrZSBzdXJlIGFsbCBvZiB0aGUgd29ya2VycyBoYXZlIHNodXQg ZG93biAoaWYgcG9zc2libGUpLgotICAgICAgICAgICAgICAgIGZvciB3b3JrZXJfc3RhdGUgaW4g c2VsZi5fd29ya2VyX3N0YXRlcy52YWx1ZXMoKToKLSAgICAgICAgICAgICAgICAgICAgaWYgbm90 IHdvcmtlcl9zdGF0ZS53ZWRnZWQgYW5kIHdvcmtlcl9zdGF0ZS53b3JrZXJfY29ubmVjdGlvbi5p c19hbGl2ZSgpOgotICAgICAgICAgICAgICAgICAgICAgICAgd29ya2VyX3N0YXRlLndvcmtlcl9j b25uZWN0aW9uLmpvaW4oMC41KQotICAgICAgICAgICAgICAgICAgICAgICAgYXNzZXJ0IG5vdCB3 b3JrZXJfc3RhdGUud29ya2VyX2Nvbm5lY3Rpb24uaXNfYWxpdmUoKQorICAgICAgICAgICAgd2hp bGUgbm90IHNlbGYuaXNfZG9uZSgpOgorICAgICAgICAgICAgICAgICMgV2UgbG9vcCB3aXRoIGEg dGltZW91dCBpbiBvcmRlciB0byBiZSBhYmxlIHRvIGRldGVjdCB3ZWRnZWQgdGhyZWFkcy4KKyAg ICAgICAgICAgICAgICBtYW5hZ2VyX2Nvbm5lY3Rpb24ucnVuX21lc3NhZ2VfbG9vcChkZWxheV9z ZWNzPTEuMCkKKworICAgICAgICAgICAgaWYgYW55KHdvcmtlcl9zdGF0ZS53ZWRnZWQgZm9yIHdv cmtlcl9zdGF0ZSBpbiBzZWxmLl93b3JrZXJfc3RhdGVzLnZhbHVlcygpKToKKyAgICAgICAgICAg ICAgICBfbG9nLmVycm9yKCcnKQorICAgICAgICAgICAgICAgIF9sb2cuZXJyb3IoJ1JlbWFpbmlu ZyB3b3JrZXJzIGFyZSB3ZWRnZWQsIGJhaWxpbmcgb3V0LicpCisgICAgICAgICAgICAgICAgX2xv Zy5lcnJvcignJykKKyAgICAgICAgICAgIGVsc2U6CisgICAgICAgICAgICAgICAgX2xvZy5kZWJ1 ZygnTm8gd2VkZ2VkIHRocmVhZHMnKQorCisgICAgICAgICAgICAjIE1ha2Ugc3VyZSBhbGwgb2Yg dGhlIHdvcmtlcnMgaGF2ZSBzaHV0IGRvd24gKGlmIHBvc3NpYmxlKS4KKyAgICAgICAgICAgIGZv ciB3b3JrZXJfc3RhdGUgaW4gc2VsZi5fd29ya2VyX3N0YXRlcy52YWx1ZXMoKToKKyAgICAgICAg ICAgICAgICBpZiBub3Qgd29ya2VyX3N0YXRlLndlZGdlZCBhbmQgd29ya2VyX3N0YXRlLndvcmtl cl9jb25uZWN0aW9uLmlzX2FsaXZlKCk6CisgICAgICAgICAgICAgICAgICAgIHdvcmtlcl9zdGF0 ZS53b3JrZXJfY29ubmVjdGlvbi5qb2luKDAuNSkKKyAgICAgICAgICAgICAgICAgICAgYXNzZXJ0 IG5vdCB3b3JrZXJfc3RhdGUud29ya2VyX2Nvbm5lY3Rpb24uaXNfYWxpdmUoKQogCiAgICAgICAg IGV4Y2VwdCBLZXlib2FyZEludGVycnVwdDoKICAgICAgICAgICAgIF9sb2cuaW5mbygiSW50ZXJy dXB0ZWQsIGV4aXRpbmciKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0c191bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfdW5pdHRlc3QucHkKaW5kZXggODRm NTcxODI1NjBkZDEyYmE5OTI5OGRhZWFiYmE3ODEwOTQ5NWRlOC4uNmRlNTA1YTVlYTRmZmQxYTYw OTJjYTc2MjNjNDI2NjNmMDBkMTNkYyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0c191bml0dGVzdC5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzX3VuaXR0ZXN0LnB5 CkBAIC00NzAsNiArNDcwLDEwIEBAIGNsYXNzIE1haW5UZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToK ICAgICAgICAgaWYgY29tcGFyZV92ZXJzaW9uKHN5cywgJzIuNicpWzBdID49IDA6CiAgICAgICAg ICAgICBzZWxmLmFzc2VydFRydWUocGFzc2luZ19ydW4oWyctLXdvcmtlci1tb2RlbCcsICdwcm9j ZXNzZXMnXSkpCiAKKyAgICBkZWYgdGVzdF93b3JrZXJfbW9kZWxfX3Byb2Nlc3Nlc19hbmRfZHJ5 X3J1bihzZWxmKToKKyAgICAgICAgaWYgY29tcGFyZV92ZXJzaW9uKHN5cywgJzIuNicpWzBdID49 IDA6CisgICAgICAgICAgICBzZWxmLmFzc2VydFRydWUocGFzc2luZ19ydW4oWyctLXdvcmtlci1t b2RlbCcsICdwcm9jZXNzZXMnLCAnLS1kcnktcnVuJ10pKQorCiAgICAgZGVmIHRlc3Rfd29ya2Vy X21vZGVsX190aHJlYWRzKHNlbGYpOgogICAgICAgICBzZWxmLmFzc2VydFRydWUocGFzc2luZ19y dW4oWyctLXdvcmtlci1tb2RlbCcsICd0aHJlYWRzJ10pKQogCg==