54593 2011-02-16 15:23:53 -0800 flaky test archive uploads are always 22 bytes long 2011-02-16 19:49:06 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth commit-queue mihaip ojan oldest_to_newest 352400 0 eric 2011-02-16 15:23:53 -0800 flaky test archive uploads are always 22 bytes long I'm not entirely sure why, but I think we may need to seek the file pointer back to 0 before passing it to mechanize. Example failures: https://bugs.webkit.org/show_bug.cgi?id=51138 https://bugs.webkit.org/show_bug.cgi?id=54404 https://bugs.webkit.org/show_bug.cgi?id=54324 352403 1 82709 eric 2011-02-16 15:26:13 -0800 Created attachment 82709 Patch 352408 2 82709 mihaip 2011-02-16 15:31:28 -0800 Comment on attachment 82709 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82709&action=review > Tools/Scripts/webkitpy/tool/bot/flakytestreporter.py:176 > + file_object = results_archive.fp Maybe rename results_archive to results_archive_zip and file_object to results_archive_file to make this more clear? 352418 3 82713 eric 2011-02-16 15:41:13 -0800 Created attachment 82713 Patch for landing 352553 4 82713 commit-queue 2011-02-16 19:49:02 -0800 Comment on attachment 82713 Patch for landing Clearing flags on attachment: 82713 Committed r78779: <http://trac.webkit.org/changeset/78779> 352554 5 commit-queue 2011-02-16 19:49:06 -0800 All reviewed patches have been landed. Closing bug. 82709 2011-02-16 15:26:13 -0800 2011-02-16 15:41:09 -0800 Patch bug-54593-20110216152611.patch text/plain 2081 eric U3VidmVyc2lvbiBSZXZpc2lvbjogNzg3MzQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjNzM2Zjc2OTcwZGJlZGYwOGMyMzRkMTQwNmQ2NTc0M2Q2 ZGJiMGY5Li4yMWRjMDQzNjliNGI5Yjc4MjE2NTJmYzgxZDVmMWEwNmQ3ZjY1NjQwIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDItMTYgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGZsYWt5IHRlc3QgYXJjaGl2 ZSB1cGxvYWRzIGFyZSBhbHdheXMgMjIgYnl0ZXMgbG9uZworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ1OTMKKworICAgICAgICBTcGVjdWxhdGl2ZSBm aXggZm9yIHRoZSAyMi1ieXRlcyBidWcuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rv b2wvYm90L2ZsYWt5dGVzdHJlcG9ydGVyLnB5OgorCiAyMDExLTAyLTE2ICBBbmRlcnMgQ2FybHNz b24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBSb2Jl bi4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvZmxha3l0ZXN0 cmVwb3J0ZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L2ZsYWt5dGVzdHJl cG9ydGVyLnB5CmluZGV4IDI3MGE2NTY5ZGE5MWJkMmNhOTM3ZjMyZmFlZTY3OTJmMDMyYTI4N2Qu LmU5OTgwOTYxYmYwMWRkMzRhMDUzM2RkYmNmZDgyMzdiNWRlYTcwYzkgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvZmxha3l0ZXN0cmVwb3J0ZXIucHkKKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9mbGFreXRlc3RyZXBvcnRlci5weQpAQCAt MTczLDcgKzE3MywxMSBAQCBJZiB5b3Ugd291bGQgbGlrZSB0byB0cmFjayB0aGlzIHRlc3QgZml4 IHdpdGggYW5vdGhlciBidWcsIHBsZWFzZSBjbG9zZSB0aGlzIGJ1ZwogICAgICAgICAgICAgX2xv Zy53YXJuKCIlcyBkb2VzIG5vdCBleGlzdCBpbiByZXN1bHRzIGFyY2hpdmUsIHVwbG9hZGluZyBl bnRpcmUgYXJjaGl2ZS4iICUgcmVzdWx0c19kaWZmX3BhdGgpCiAgICAgICAgICAgICBkZXNjcmlw dGlvbiA9ICJBcmNoaXZlIG9mIGxheW91dC10ZXN0LXJlc3VsdHMgZnJvbSAlcyIgJSBib3RfaWQK ICAgICAgICAgICAgICMgcmVzdWx0c19hcmNoaXZlIGlzIGEgWmlwRmlsZSBvYmplY3QsIGdyYWIg dGhlIEZpbGUgb2JqZWN0ICguZnApIHRvIHBhc3MgdG8gTWVjaGFuaXplIGZvciB1cGxvYWRpbmcu Ci0gICAgICAgICAgICBzZWxmLl90b29sLmJ1Z3MuYWRkX2F0dGFjaG1lbnRfdG9fYnVnKGZsYWtl X2J1Z19pZCwgcmVzdWx0c19hcmNoaXZlLmZwLCBkZXNjcmlwdGlvbiwgZmlsZW5hbWU9ImxheW91 dC10ZXN0LXJlc3VsdHMuemlwIikKKyAgICAgICAgICAgIGZpbGVfb2JqZWN0ID0gcmVzdWx0c19h cmNoaXZlLmZwCisgICAgICAgICAgICAjIFJld2luZCB0aGUgZmlsZSBvYmplY3QgdG8gc3RhcnQg KHNpbmNlIE1lY2hhbml6ZSB3b24ndCBkbyB0aGF0IGF1dG9tYXRpY2FsbHkpCisgICAgICAgICAg ICAjIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ1OTMKKyAg ICAgICAgICAgIGZpbGVfb2JqZWN0LnNlZWsoMCkKKyAgICAgICAgICAgIHNlbGYuX3Rvb2wuYnVn cy5hZGRfYXR0YWNobWVudF90b19idWcoZmxha2VfYnVnX2lkLCBmaWxlX29iamVjdCwgZGVzY3Jp cHRpb24sIGZpbGVuYW1lPSJsYXlvdXQtdGVzdC1yZXN1bHRzLnppcCIpCiAKICAgICBkZWYgcmVw b3J0X2ZsYWt5X3Rlc3RzKHNlbGYsIHBhdGNoLCBmbGFreV90ZXN0X3Jlc3VsdHMsIHJlc3VsdHNf YXJjaGl2ZSk6CiAgICAgICAgIG1lc3NhZ2UgPSAiVGhlICVzIGVuY291bnRlcmVkIHRoZSBmb2xs b3dpbmcgZmxha3kgdGVzdHMgd2hpbGUgcHJvY2Vzc2luZyBhdHRhY2htZW50ICVzOlxuXG4iICUg KHNlbGYuX2JvdF9uYW1lLCBwYXRjaC5pZCgpKQo= 82713 2011-02-16 15:41:13 -0800 2011-02-16 19:49:02 -0800 Patch for landing bug-54593-20110216154111.patch text/plain 3161 eric U3VidmVyc2lvbiBSZXZpc2lvbjogNzg3MzQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjNzM2Zjc2OTcwZGJlZGYwOGMyMzRkMTQwNmQ2NTc0M2Q2 ZGJiMGY5Li5kOTc3NTU5ZmJhZTNmZGNlMDU3YmI2MjAyZTFlMDQ2ZTQ4ZjkzYjQzIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDItMTYgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE1paGFpIFBhcnBhcml0YS4KKworICAgICAgICBmbGFreSB0ZXN0IGFyY2hp dmUgdXBsb2FkcyBhcmUgYWx3YXlzIDIyIGJ5dGVzIGxvbmcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0NTkzCisKKyAgICAgICAgU3BlY3VsYXRpdmUg Zml4IGZvciB0aGUgMjItYnl0ZXMgYnVnLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90 b29sL2JvdC9mbGFreXRlc3RyZXBvcnRlci5weToKKwogMjAxMS0wMi0xNiAgQW5kZXJzIENhcmxz c29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9i ZW4uCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L2ZsYWt5dGVz dHJlcG9ydGVyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9mbGFreXRlc3Ry ZXBvcnRlci5weQppbmRleCAyNzBhNjU2OWRhOTFiZDJjYTkzN2YzMmZhZWU2NzkyZjAzMmEyODdk Li5iZWM1OTNiNmU2MDI3MzkzOWE1NTAzOThiZmVkMTlkNzFhYmZlZTRkIDEwMDY0NAotLS0gYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L2ZsYWt5dGVzdHJlcG9ydGVyLnB5CisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvZmxha3l0ZXN0cmVwb3J0ZXIucHkKQEAg LTE1OCwyMiArMTU4LDI2IEBAIElmIHlvdSB3b3VsZCBsaWtlIHRvIHRyYWNrIHRoaXMgdGVzdCBm aXggd2l0aCBhbm90aGVyIGJ1ZywgcGxlYXNlIGNsb3NlIHRoaXMgYnVnCiAgICAgICAgICAgICAg ICAgcmV0dXJuIGFyY2hpdmVkX3BhdGgKICAgICAgICAgcmV0dXJuIE5vbmUKIAotICAgIGRlZiBf YXR0YWNoX2ZhaWx1cmVfZGlmZihzZWxmLCBmbGFrZV9idWdfaWQsIGZsYWt5X3Rlc3QsIHJlc3Vs dHNfYXJjaGl2ZSk6CisgICAgZGVmIF9hdHRhY2hfZmFpbHVyZV9kaWZmKHNlbGYsIGZsYWtlX2J1 Z19pZCwgZmxha3lfdGVzdCwgcmVzdWx0c19hcmNoaXZlX3ppcCk6CiAgICAgICAgIHJlc3VsdHNf ZGlmZl9wYXRoID0gc2VsZi5fcmVzdWx0c19kaWZmX3BhdGhfZm9yX3Rlc3QoZmxha3lfdGVzdCkK ICAgICAgICAgIyBDaGVjayB0byBtYWtlIHN1cmUgdGhhdCB0aGUgcGF0aCBtYWtlcyBzZW5zZS4K ICAgICAgICAgIyBTaW5jZSB3ZSdyZSBub3QgYWN0dWFsbHkgZ2V0dGluZyB0aGlzIHBhdGggZnJv bSB0aGUgcmVzdWx0cy5odG1sCiAgICAgICAgICMgdGhlcmUgaXMgYSBjaGFuY2UgaXQncyB3cm9u Zy4KICAgICAgICAgYm90X2lkID0gc2VsZi5fdG9vbC5zdGF0dXNfc2VydmVyLmJvdF9pZCBvciAi Ym90IgotICAgICAgICBhcmNoaXZlX3BhdGggPSBzZWxmLl9maW5kX2luX2FyY2hpdmUocmVzdWx0 c19kaWZmX3BhdGgsIHJlc3VsdHNfYXJjaGl2ZSkKKyAgICAgICAgYXJjaGl2ZV9wYXRoID0gc2Vs Zi5fZmluZF9pbl9hcmNoaXZlKHJlc3VsdHNfZGlmZl9wYXRoLCByZXN1bHRzX2FyY2hpdmVfemlw KQogICAgICAgICBpZiBhcmNoaXZlX3BhdGg6Ci0gICAgICAgICAgICByZXN1bHRzX2RpZmYgPSBy ZXN1bHRzX2FyY2hpdmUucmVhZChhcmNoaXZlX3BhdGgpCisgICAgICAgICAgICByZXN1bHRzX2Rp ZmYgPSByZXN1bHRzX2FyY2hpdmVfemlwLnJlYWQoYXJjaGl2ZV9wYXRoKQogICAgICAgICAgICAg ZGVzY3JpcHRpb24gPSAiRmFpbHVyZSBkaWZmIGZyb20gJXMiICUgYm90X2lkCiAgICAgICAgICAg ICBzZWxmLl90b29sLmJ1Z3MuYWRkX2F0dGFjaG1lbnRfdG9fYnVnKGZsYWtlX2J1Z19pZCwgcmVz dWx0c19kaWZmLCBkZXNjcmlwdGlvbiwgZmlsZW5hbWU9ImZhaWx1cmUuZGlmZiIpCiAgICAgICAg IGVsc2U6CiAgICAgICAgICAgICBfbG9nLndhcm4oIiVzIGRvZXMgbm90IGV4aXN0IGluIHJlc3Vs dHMgYXJjaGl2ZSwgdXBsb2FkaW5nIGVudGlyZSBhcmNoaXZlLiIgJSByZXN1bHRzX2RpZmZfcGF0 aCkKICAgICAgICAgICAgIGRlc2NyaXB0aW9uID0gIkFyY2hpdmUgb2YgbGF5b3V0LXRlc3QtcmVz dWx0cyBmcm9tICVzIiAlIGJvdF9pZAogICAgICAgICAgICAgIyByZXN1bHRzX2FyY2hpdmUgaXMg YSBaaXBGaWxlIG9iamVjdCwgZ3JhYiB0aGUgRmlsZSBvYmplY3QgKC5mcCkgdG8gcGFzcyB0byBN ZWNoYW5pemUgZm9yIHVwbG9hZGluZy4KLSAgICAgICAgICAgIHNlbGYuX3Rvb2wuYnVncy5hZGRf YXR0YWNobWVudF90b19idWcoZmxha2VfYnVnX2lkLCByZXN1bHRzX2FyY2hpdmUuZnAsIGRlc2Ny aXB0aW9uLCBmaWxlbmFtZT0ibGF5b3V0LXRlc3QtcmVzdWx0cy56aXAiKQorICAgICAgICAgICAg cmVzdWx0c19hcmNoaXZlX2ZpbGUgPSByZXN1bHRzX2FyY2hpdmVfemlwLmZwCisgICAgICAgICAg ICAjIFJld2luZCB0aGUgZmlsZSBvYmplY3QgdG8gc3RhcnQgKHNpbmNlIE1lY2hhbml6ZSB3b24n dCBkbyB0aGF0IGF1dG9tYXRpY2FsbHkpCisgICAgICAgICAgICAjIFNlZSBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ1OTMKKyAgICAgICAgICAgIHJlc3VsdHNfYXJj aGl2ZV9maWxlLnNlZWsoMCkKKyAgICAgICAgICAgIHNlbGYuX3Rvb2wuYnVncy5hZGRfYXR0YWNo bWVudF90b19idWcoZmxha2VfYnVnX2lkLCByZXN1bHRzX2FyY2hpdmVfZmlsZSwgZGVzY3JpcHRp b24sIGZpbGVuYW1lPSJsYXlvdXQtdGVzdC1yZXN1bHRzLnppcCIpCiAKICAgICBkZWYgcmVwb3J0 X2ZsYWt5X3Rlc3RzKHNlbGYsIHBhdGNoLCBmbGFreV90ZXN0X3Jlc3VsdHMsIHJlc3VsdHNfYXJj aGl2ZSk6CiAgICAgICAgIG1lc3NhZ2UgPSAiVGhlICVzIGVuY291bnRlcmVkIHRoZSBmb2xsb3dp bmcgZmxha3kgdGVzdHMgd2hpbGUgcHJvY2Vzc2luZyBhdHRhY2htZW50ICVzOlxuXG4iICUgKHNl bGYuX2JvdF9uYW1lLCBwYXRjaC5pZCgpKQo=