54581 2011-02-16 13:36:02 -0800 [Qt] Enable tiled backing store by default in MiniBrowser. 2011-02-17 04:24:55 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned commit-queue kenneth kling oldest_to_newest 352302 0 yael 2011-02-16 13:36:02 -0800 A patch is coming soon. 352306 1 82685 yael 2011-02-16 13:40:57 -0800 Created attachment 82685 Patch. I found a problem in the tiled backing store code, so should land this once that bug is fixed. 352307 2 82685 kling 2011-02-16 13:42:56 -0800 Comment on attachment 82685 Patch. r=me 352531 3 82685 commit-queue 2011-02-16 19:00:33 -0800 Comment on attachment 82685 Patch. Rejecting attachment 82685 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-a..." exit_code: 1 Last 500 characters of output: ommit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 57, in run if self._has_valid_reviewer(changelog_entry): File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 42, in _has_valid_reviewer if changelog_entry.reviewer(): AttributeError: 'NoneType' object has no attribute 'reviewer' Full output: http://queues.webkit.org/results/7929312 352575 4 82685 commit-queue 2011-02-16 20:27:58 -0800 Comment on attachment 82685 Patch. Clearing flags on attachment: 82685 Committed r78784: <http://trac.webkit.org/changeset/78784> 352576 5 commit-queue 2011-02-16 20:28:03 -0800 All reviewed patches have been landed. Closing bug. 352654 6 kenneth 2011-02-17 00:51:50 -0800 Yael, you might want to upsteam some of our other tiling patches from our experimental branch 352753 7 yael 2011-02-17 04:24:55 -0800 (In reply to comment #6) > Yael, you might want to upsteam some of our other tiling patches from our experimental branch Absolutely! let's talk about what is there and what needs to be upstreamed :) 82685 2011-02-16 13:40:57 -0800 2011-02-16 20:27:58 -0800 Patch. 54581 text/plain 2392 yael SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc4NzMyKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTggQEAKKzIwMTEtMDItMTYgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9raWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0g RW5hYmxlIHRpbGVkIGJhY2tpbmcgc3RvcmUgYnkgZGVmYXVsdCBpbiBNaW5pQnJvd3Nlci4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0NTgxCisKKyAg ICAgICAgSW5zdGVhZCBvZiBhIGZsYWcgdG8gdHVybiBpdCBvbiwgYSBuZXcgZmxhZyBpcyBkZWZp bmVkIHRvIHR1cm4KKyAgICAgICAgdGlsZWQgYmFja2luZyBzdG9yZSBvZmYuCisKKyAgICAgICAg KiBNaW5pQnJvd3Nlci9xdC9NaW5pQnJvd3NlckFwcGxpY2F0aW9uLmNwcDoKKyAgICAgICAgKE1p bmlCcm93c2VyQXBwbGljYXRpb246OmhhbmRsZVVzZXJPcHRpb25zKToKKyAgICAgICAgKiBNaW5p QnJvd3Nlci9xdC9NaW5pQnJvd3NlckFwcGxpY2F0aW9uLmg6CisgICAgICAgIChXaW5kb3dPcHRp b25zOjpXaW5kb3dPcHRpb25zKToKKwogMjAxMS0wMi0xNiAgQW5kZXJzIENhcmxzc29uICA8YW5k ZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCkluZGV4 OiBUb29scy9NaW5pQnJvd3Nlci9xdC9NaW5pQnJvd3NlckFwcGxpY2F0aW9uLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBUb29scy9NaW5pQnJvd3Nlci9xdC9NaW5pQnJvd3NlckFwcGxpY2F0aW9uLmNwcAko cmV2aXNpb24gNzg2MTUpCisrKyBUb29scy9NaW5pQnJvd3Nlci9xdC9NaW5pQnJvd3NlckFwcGxp Y2F0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTgsNyArNTgsNyBAQCB2b2lkIE1pbmlCcm93 c2VyQXBwbGljYXRpb246OmhhbmRsZVVzZXJPCiAgICAgICAgICAgICAgPDwgIlstciBsaXN0XSIK ICAgICAgICAgICAgICA8PCAiWy1yb2JvdC10aW1lb3V0IHNlY29uZHNdIgogICAgICAgICAgICAg IDw8ICJbLXJvYm90LWV4dHJhLXRpbWUgc2Vjb25kc10iCi0gICAgICAgICAgICAgPDwgIlstdGls ZWQtYmFja2luZy1zdG9yZV0iCisgICAgICAgICAgICAgPDwgIlstY2h1bmtlZC1kcmF3aW5nLWFy ZWFdIgogICAgICAgICAgICAgIDw8ICAiWy1zZXBhcmF0ZS13ZWItcHJvY2Vzcy1wZXItd2luZG93 XSIKICAgICAgICAgICAgICA8PCAiVVJMcyI7CiAgICAgICAgIGFwcFF1aXQoMCk7CkBAIC04Nyw4 ICs4Nyw4IEBAIHZvaWQgTWluaUJyb3dzZXJBcHBsaWNhdGlvbjo6aGFuZGxlVXNlck8KICAgICBp ZiAocm9ib3RFeHRyYVRpbWVJbmRleCAhPSAtMSkKICAgICAgICAgbV9yb2JvdEV4dHJhVGltZVNl Y29uZHMgPSB0YWtlT3B0aW9uVmFsdWUoJmFyZ3MsIHJvYm90RXh0cmFUaW1lSW5kZXgpLnRvSW50 KCk7CiAKLSAgICBpZiAoYXJncy5jb250YWlucygiLXRpbGVkLWJhY2tpbmctc3RvcmUiKSkKLSAg ICAgICAgbV93aW5kb3dPcHRpb25zLnVzZVRpbGVkQmFja2luZ1N0b3JlID0gdHJ1ZTsKKyAgICBp ZiAoYXJncy5jb250YWlucygiLWNodW5rZWQtZHJhd2luZy1hcmVhIikpCisgICAgICAgIG1fd2lu ZG93T3B0aW9ucy51c2VUaWxlZEJhY2tpbmdTdG9yZSA9IGZhbHNlOwogCiAgICAgaWYgKGFyZ3Mu Y29udGFpbnMoIi1zZXBhcmF0ZS13ZWItcHJvY2Vzcy1wZXItd2luZG93IikpCiAgICAgICAgIG1f d2luZG93T3B0aW9ucy51c2VTZXBhcmF0ZVdlYlByb2Nlc3NQZXJXaW5kb3cgPSB0cnVlOwpJbmRl eDogVG9vbHMvTWluaUJyb3dzZXIvcXQvTWluaUJyb3dzZXJBcHBsaWNhdGlvbi5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL01pbmlCcm93c2VyL3F0L01pbmlCcm93c2VyQXBwbGljYXRpb24uaAkocmV2 aXNpb24gNzg2MTUpCisrKyBUb29scy9NaW5pQnJvd3Nlci9xdC9NaW5pQnJvd3NlckFwcGxpY2F0 aW9uLmgJKHdvcmtpbmcgY29weSkKQEAgLTM0LDcgKzM0LDcgQEAKIAogc3RydWN0IFdpbmRvd09w dGlvbnMgewogICAgIFdpbmRvd09wdGlvbnMoKQotICAgICAgICA6IHVzZVRpbGVkQmFja2luZ1N0 b3JlKGZhbHNlKQorICAgICAgICA6IHVzZVRpbGVkQmFja2luZ1N0b3JlKHRydWUpCiAgICAgICAg ICwgdXNlU2VwYXJhdGVXZWJQcm9jZXNzUGVyV2luZG93KGZhbHNlKQogICAgIHsKICAgICB9Cg==