54577 2011-02-16 12:47:51 -0800 [Qt] Tiles are not created for webkit2 after r77286. 2011-02-16 20:27:24 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 1 yael webkit-unassigned commit-queue kling oldest_to_newest 352269 0 yael 2011-02-16 12:47:51 -0800 When using the default tile size of 1024x1024, only one tile is created. What seems to be a typo in r77286 causes this one tile to not be created. A patch is coming soon. 352275 1 82679 yael 2011-02-16 12:52:57 -0800 Created attachment 82679 Patch. 352282 2 82679 kling 2011-02-16 13:03:29 -0800 Comment on attachment 82679 Patch. D'oh! r=me 352527 3 82679 commit-queue 2011-02-16 18:56:25 -0800 Comment on attachment 82679 Patch. Rejecting attachment 82679 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 1 Last 500 characters of output: ommit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 57, in run if self._has_valid_reviewer(changelog_entry): File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 42, in _has_valid_reviewer if changelog_entry.reviewer(): AttributeError: 'NoneType' object has no attribute 'reviewer' Full output: http://queues.webkit.org/results/7927453 352573 4 82679 commit-queue 2011-02-16 20:27:20 -0800 Comment on attachment 82679 Patch. Clearing flags on attachment: 82679 Committed r78783: <http://trac.webkit.org/changeset/78783> 352574 5 commit-queue 2011-02-16 20:27:24 -0800 All reviewed patches have been landed. Closing bug. 82679 2011-02-16 12:52:57 -0800 2011-02-16 20:27:19 -0800 Patch. 54577.patch text/plain 2934 yael SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NzI5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDItMTYgIFlhZWwgQWhh cm9uICA8eWFlbC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gVGlsZXMgYXJlIG5vdCBjcmVhdGVkIGZvciB3ZWJr aXQyIGFmdGVyIHI3NzI4Ni4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTU0NTc3CisKKyAgICAgICAgV2hlbiB1c2luZyB0aGUgZGVmYXVsdCB0aWxlIHNp emUgb2YgMTAyNHgxMDI0LCBvbmx5IG9uZSB0aWxlIGlzIGNyZWF0ZWQuCisgICAgICAgIE1ha2Ug c3VyZSB0byBjcmVhdGUgdGhpcyB0aWxlIGJ5IHVuZG9pbmcgd2hhdCBzZWVtcyB0byBiZSBhIHR5 cG8gaW4gcjc3Mjg2LgorCisgICAgICAgICogVUlQcm9jZXNzL1RpbGVkRHJhd2luZ0FyZWFQcm94 eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OlRpbGVkRHJhd2luZ0FyZWFQcm94eTo6cGFpbnQpOgor ICAgICAgICAoV2ViS2l0OjpUaWxlZERyYXdpbmdBcmVhUHJveHk6OmNyZWF0ZVRpbGVzKToKKwog MjAxMS0wMi0xNiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvVGlsZWREcmF3aW5nQXJlYVByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvVGlsZWREcmF3aW5nQXJlYVByb3h5LmNwcAkocmV2aXNpb24gNzg2MTUpCisr KyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvVGlsZWREcmF3aW5nQXJlYVByb3h5LmNwcAkod29y a2luZyBjb3B5KQpAQCAtMzQxLDggKzM0MSw4IEBAIGJvb2wgVGlsZWREcmF3aW5nQXJlYVByb3h5 OjpwYWludChjb25zdCAKICAgICBUaWxlZERyYXdpbmdBcmVhVGlsZTo6Q29vcmRpbmF0ZSB0b3BM ZWZ0ID0gdGlsZUNvb3JkaW5hdGVGb3JQb2ludChkaXJ0eVJlY3QubG9jYXRpb24oKSk7CiAgICAg VGlsZWREcmF3aW5nQXJlYVRpbGU6OkNvb3JkaW5hdGUgYm90dG9tUmlnaHQgPSB0aWxlQ29vcmRp bmF0ZUZvclBvaW50KEludFBvaW50KGRpcnR5UmVjdC5tYXhYKCksIGRpcnR5UmVjdC5tYXhZKCkp KTsKIAotICAgIGZvciAodW5zaWduZWQgeUNvb3JkaW5hdGUgPSB0b3BMZWZ0LnkoKTsgeUNvb3Jk aW5hdGUgPCBib3R0b21SaWdodC55KCk7ICsreUNvb3JkaW5hdGUpIHsKLSAgICAgICAgZm9yICh1 bnNpZ25lZCB4Q29vcmRpbmF0ZSA9IHRvcExlZnQueCgpOyB4Q29vcmRpbmF0ZSA8IGJvdHRvbVJp Z2h0LngoKTsgKyt4Q29vcmRpbmF0ZSkgeworICAgIGZvciAodW5zaWduZWQgeUNvb3JkaW5hdGUg PSB0b3BMZWZ0LnkoKTsgeUNvb3JkaW5hdGUgPD0gYm90dG9tUmlnaHQueSgpOyArK3lDb29yZGlu YXRlKSB7CisgICAgICAgIGZvciAodW5zaWduZWQgeENvb3JkaW5hdGUgPSB0b3BMZWZ0LngoKTsg eENvb3JkaW5hdGUgPD0gYm90dG9tUmlnaHQueCgpOyArK3hDb29yZGluYXRlKSB7CiAgICAgICAg ICAgICBUaWxlZERyYXdpbmdBcmVhVGlsZTo6Q29vcmRpbmF0ZSBjdXJyZW50Q29vcmRpbmF0ZSh4 Q29vcmRpbmF0ZSwgeUNvb3JkaW5hdGUpOwogICAgICAgICAgICAgUmVmUHRyPFRpbGVkRHJhd2lu Z0FyZWFUaWxlPiBjdXJyZW50VGlsZSA9IHRpbGVBdChjdXJyZW50Q29vcmRpbmF0ZSk7CiAgICAg ICAgICAgICBpZiAoY3VycmVudFRpbGUgJiYgY3VycmVudFRpbGUtPmlzUmVhZHlUb1BhaW50KCkp CkBAIC00MzgsOCArNDM4LDggQEAgdm9pZCBUaWxlZERyYXdpbmdBcmVhUHJveHk6OmNyZWF0ZVRp bGVzKAogICAgIGJvb2wgaGFzVmlzaWJsZUNoZWNrZXJzID0gZmFsc2U7CiAgICAgVGlsZWREcmF3 aW5nQXJlYVRpbGU6OkNvb3JkaW5hdGUgdG9wTGVmdCA9IHRpbGVDb29yZGluYXRlRm9yUG9pbnQo dmlzaWJsZVJlY3QubG9jYXRpb24oKSk7CiAgICAgVGlsZWREcmF3aW5nQXJlYVRpbGU6OkNvb3Jk aW5hdGUgYm90dG9tUmlnaHQgPSB0aWxlQ29vcmRpbmF0ZUZvclBvaW50KEludFBvaW50KHZpc2li bGVSZWN0Lm1heFgoKSwgdmlzaWJsZVJlY3QubWF4WSgpKSk7Ci0gICAgZm9yICh1bnNpZ25lZCB5 Q29vcmRpbmF0ZSA9IHRvcExlZnQueSgpOyB5Q29vcmRpbmF0ZSA8IGJvdHRvbVJpZ2h0LnkoKTsg Kyt5Q29vcmRpbmF0ZSkgewotICAgICAgICBmb3IgKHVuc2lnbmVkIHhDb29yZGluYXRlID0gdG9w TGVmdC54KCk7IHhDb29yZGluYXRlIDwgYm90dG9tUmlnaHQueCgpOyArK3hDb29yZGluYXRlKSB7 CisgICAgZm9yICh1bnNpZ25lZCB5Q29vcmRpbmF0ZSA9IHRvcExlZnQueSgpOyB5Q29vcmRpbmF0 ZSA8PSBib3R0b21SaWdodC55KCk7ICsreUNvb3JkaW5hdGUpIHsKKyAgICAgICAgZm9yICh1bnNp Z25lZCB4Q29vcmRpbmF0ZSA9IHRvcExlZnQueCgpOyB4Q29vcmRpbmF0ZSA8PSBib3R0b21SaWdo dC54KCk7ICsreENvb3JkaW5hdGUpIHsKICAgICAgICAgICAgIFRpbGVkRHJhd2luZ0FyZWFUaWxl OjpDb29yZGluYXRlIGN1cnJlbnRDb29yZGluYXRlKHhDb29yZGluYXRlLCB5Q29vcmRpbmF0ZSk7 CiAgICAgICAgICAgICAvLyBEaXN0YW5jZSBpcyAwIGZvciBhbGwgY3VycmVudGx5IHZpc2libGUg dGlsZXMuCiAgICAgICAgICAgICBkb3VibGUgZGlzdGFuY2UgPSB0aWxlRGlzdGFuY2UodmlzaWJs ZVJlY3QsIGN1cnJlbnRDb29yZGluYXRlKTsK