54557 2011-02-16 08:08:30 -0800 [GTK] libsoup critical warnings 2011-02-17 03:47:22 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned abarth eric svillar webkit.review.bot oldest_to_newest 352075 0 pnormand 2011-02-16 08:08:30 -0800 Happens when using the Flash plugin for instance: libsoup-CRITICAL **: soup_message_io_pause: assertion `io != NULL' failed seems like it's trying to pause a message for an already downloaded ressource. Patch incoming 352078 1 82639 pnormand 2011-02-16 08:11:17 -0800 Created attachment 82639 proposed patch 352094 2 82639 mrobinson 2011-02-16 08:35:25 -0800 Comment on attachment 82639 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=82639&action=review > Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:703 > + SoupMessage* soupMessage = d->m_soupMessage.get(); > + if (SOUP_STATUS_IS_SUCCESSFUL(soupMessage->status_code)) > + return; Hrm. Wouuld it be better to check for soupMessage->status_code != SOUP_STATUS_NONE? We don't want to cancel the message if it's finished for any reason. 352111 3 82648 pnormand 2011-02-16 08:54:20 -0800 Created attachment 82648 proposed patch 352644 4 pnormand 2011-02-17 00:26:06 -0800 Committed r78798: <http://trac.webkit.org/changeset/78798> 352734 5 webkit.review.bot 2011-02-17 03:47:22 -0800 http://trac.webkit.org/changeset/78798 might have broken GTK Linux 32-bit Debug 82639 2011-02-16 08:11:17 -0800 2011-02-16 08:54:20 -0800 proposed patch proposed-patch.patch text/plain 1982 pnormand RnJvbSAzMTkxMGYzZmUxOWY2ODM4NzdlMTg4ZDdlZGE1NTA4ZWY1ZjExZjk1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDE2IEZlYiAyMDExIDE3OjEyOjQ2ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogLi4uL3BsYXRmb3JtL25ldHdvcmsv c291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwICAgfCAgICA4ICsrKysrKy0tCiAyIGZpbGVzIGNo YW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDcx YTkxZjkuLmZmYjM5NzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wMi0xNiAg UGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gbGlic291cCBjcml0aWNhbCB3 YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTQ1NTcKKworICAgICAgICBBdm9pZCBwYXVzaW5nIGEgc291cCBtZXNzYWdlIGZvciBhbHJlYWR5 IGRvd25sb2FkZWQgcmVzb3VyY2VzLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3Vw L1Jlc291cmNlSGFuZGxlU291cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRs ZTo6cGxhdGZvcm1TZXREZWZlcnNMb2FkaW5nKToKKwogMjAxMS0wMi0xNiAgQW5kcmVhcyBLbGlu ZyAgPGtsaW5nQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGlyayBTY2h1bHpl LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291 cmNlSGFuZGxlU291cC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAv UmVzb3VyY2VIYW5kbGVTb3VwLmNwcAppbmRleCAzYjFmMTU3Li5lMmI3YTdkIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3Vw LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VI YW5kbGVTb3VwLmNwcApAQCAtNjk4LDEwICs2OTgsMTQgQEAgdm9pZCBSZXNvdXJjZUhhbmRsZTo6 cGxhdGZvcm1TZXREZWZlcnNMb2FkaW5nKGJvb2wgZGVmZXJzTG9hZGluZykKICAgICBpZiAoIWQt Pm1fc291cE1lc3NhZ2UpCiAgICAgICAgIHJldHVybjsKIAorICAgIFNvdXBNZXNzYWdlKiBzb3Vw TWVzc2FnZSA9IGQtPm1fc291cE1lc3NhZ2UuZ2V0KCk7CisgICAgaWYgKFNPVVBfU1RBVFVTX0lT X1NVQ0NFU1NGVUwoc291cE1lc3NhZ2UtPnN0YXR1c19jb2RlKSkKKyAgICAgICAgcmV0dXJuOwor CiAgICAgaWYgKGRlZmVyc0xvYWRpbmcpCi0gICAgICAgIHNvdXBfc2Vzc2lvbl9wYXVzZV9tZXNz YWdlKGRlZmF1bHRTZXNzaW9uKCksIGQtPm1fc291cE1lc3NhZ2UuZ2V0KCkpOworICAgICAgICBz b3VwX3Nlc3Npb25fcGF1c2VfbWVzc2FnZShkZWZhdWx0U2Vzc2lvbigpLCBzb3VwTWVzc2FnZSk7 CiAgICAgZWxzZQotICAgICAgICBzb3VwX3Nlc3Npb25fdW5wYXVzZV9tZXNzYWdlKGRlZmF1bHRT ZXNzaW9uKCksIGQtPm1fc291cE1lc3NhZ2UuZ2V0KCkpOworICAgICAgICBzb3VwX3Nlc3Npb25f dW5wYXVzZV9tZXNzYWdlKGRlZmF1bHRTZXNzaW9uKCksIHNvdXBNZXNzYWdlKTsKIH0KIAogYm9v bCBSZXNvdXJjZUhhbmRsZTo6bG9hZHNCbG9ja2VkKCkKLS0gCjEuNy4yLjM= 82648 2011-02-16 08:54:20 -0800 2011-02-16 10:15:18 -0800 proposed patch proposed-patch.patch text/plain 1975 pnormand RnJvbSA2OGUxOGJjMTI3YzcwOWFkMmM5MWI4MTRhMGI0YjM1NDZhYTZiMDQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDE2IEZlYiAyMDExIDE3OjEyOjQ2ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogLi4uL3BsYXRmb3JtL25ldHdvcmsv c291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwICAgfCAgICA4ICsrKysrKy0tCiAyIGZpbGVzIGNo YW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDcx YTkxZjkuLmZmYjM5NzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wMi0xNiAg UGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gbGlic291cCBjcml0aWNhbCB3 YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTQ1NTcKKworICAgICAgICBBdm9pZCBwYXVzaW5nIGEgc291cCBtZXNzYWdlIGZvciBhbHJlYWR5 IGRvd25sb2FkZWQgcmVzb3VyY2VzLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3Vw L1Jlc291cmNlSGFuZGxlU291cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRs ZTo6cGxhdGZvcm1TZXREZWZlcnNMb2FkaW5nKToKKwogMjAxMS0wMi0xNiAgQW5kcmVhcyBLbGlu ZyAgPGtsaW5nQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGlyayBTY2h1bHpl LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291 cmNlSGFuZGxlU291cC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAv UmVzb3VyY2VIYW5kbGVTb3VwLmNwcAppbmRleCAzYjFmMTU3Li5hNTVmMzhmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3Vw LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VI YW5kbGVTb3VwLmNwcApAQCAtNjk4LDEwICs2OTgsMTQgQEAgdm9pZCBSZXNvdXJjZUhhbmRsZTo6 cGxhdGZvcm1TZXREZWZlcnNMb2FkaW5nKGJvb2wgZGVmZXJzTG9hZGluZykKICAgICBpZiAoIWQt Pm1fc291cE1lc3NhZ2UpCiAgICAgICAgIHJldHVybjsKIAorICAgIFNvdXBNZXNzYWdlKiBzb3Vw TWVzc2FnZSA9IGQtPm1fc291cE1lc3NhZ2UuZ2V0KCk7CisgICAgaWYgKHNvdXBNZXNzYWdlLT5z dGF0dXNfY29kZSAhPSBTT1VQX1NUQVRVU19OT05FKQorICAgICAgICByZXR1cm47CisKICAgICBp ZiAoZGVmZXJzTG9hZGluZykKLSAgICAgICAgc291cF9zZXNzaW9uX3BhdXNlX21lc3NhZ2UoZGVm YXVsdFNlc3Npb24oKSwgZC0+bV9zb3VwTWVzc2FnZS5nZXQoKSk7CisgICAgICAgIHNvdXBfc2Vz c2lvbl9wYXVzZV9tZXNzYWdlKGRlZmF1bHRTZXNzaW9uKCksIHNvdXBNZXNzYWdlKTsKICAgICBl bHNlCi0gICAgICAgIHNvdXBfc2Vzc2lvbl91bnBhdXNlX21lc3NhZ2UoZGVmYXVsdFNlc3Npb24o KSwgZC0+bV9zb3VwTWVzc2FnZS5nZXQoKSk7CisgICAgICAgIHNvdXBfc2Vzc2lvbl91bnBhdXNl X21lc3NhZ2UoZGVmYXVsdFNlc3Npb24oKSwgc291cE1lc3NhZ2UpOwogfQogCiBib29sIFJlc291 cmNlSGFuZGxlOjpsb2Fkc0Jsb2NrZWQoKQotLSAKMS43LjIuMw==