54553 2011-02-16 07:11:18 -0800 [EFL] Doxygen documentation for ewk cookies 2011-02-17 07:01:47 -0800 1 1 1 Unclassified WebKit Text 528+ (Nightly build) All All RESOLVED FIXED P2 Minor --- 0 g.czajkowski webkit-unassigned commit-queue gyuyoung.kim l.slachciak ryuan.choi oldest_to_newest 352045 0 g.czajkowski 2011-02-16 07:11:18 -0800 Doxygen documentation for ewk_cookies.h and ewk_cookies.cpp has been added. 352053 1 82630 g.czajkowski 2011-02-16 07:24:35 -0800 Created attachment 82630 Doxygen documentation for ewk cookies 352668 2 ryuan.choi 2011-02-17 01:11:10 -0800 I am not a reviewer, but I think that some of c applications can complain c++ styled comments. 352688 3 g.czajkowski 2011-02-17 01:50:06 -0800 Hi Ryuan, I've just wanted to improve current comments and add missing ones to have a html documentation for WebKit-Efl. The comments are compatible with Doxygen documentation system not C or C++ styled comments. 352767 4 ryuan.choi 2011-02-17 05:17:16 -0800 (In reply to comment #3) > Hi Ryuan, > > I've just wanted to improve current comments and add missing ones to have a html documentation for WebKit-Efl. The comments are compatible with Doxygen documentation system not C or C++ styled comments. Although c99, gcc(without -ansi) will not complain ///, I believe that we can avoid it using /**< any comments */ in header files. 352771 5 g.czajkowski 2011-02-17 05:24:40 -0800 (In reply to comment #4) > (In reply to comment #3) > > Hi Ryuan, > > > > I've just wanted to improve current comments and add missing ones to have a html documentation for WebKit-Efl. The comments are compatible with Doxygen documentation system not C or C++ styled comments. > > Although c99, gcc(without -ansi) will not complain ///, I believe that we can avoid it using /**< any comments */ in header files. Ok, I will replace '///' to '/**< */' 352811 6 82630 tkent 2011-02-17 06:41:03 -0800 Comment on attachment 82630 Doxygen documentation for ewk cookies rs=me though I don't know the syntax of Doxygen. 352831 7 82630 commit-queue 2011-02-17 07:01:42 -0800 Comment on attachment 82630 Doxygen documentation for ewk cookies Clearing flags on attachment: 82630 Committed r78823: <http://trac.webkit.org/changeset/78823> 352832 8 commit-queue 2011-02-17 07:01:47 -0800 All reviewed patches have been landed. Closing bug. 82630 2011-02-16 07:24:35 -0800 2011-02-17 07:01:42 -0800 Doxygen documentation for ewk cookies doc_ewk_cookies.patch text/plain 5250 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAwMThiYzM0Li5kYjUxZmM1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMDItMTYgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRG94eWdlbiBkb2N1bWVudGF0aW9uIGZvciBld2sgY29va2llcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ1NTMKKworICAgICAg ICAqIGV3ay9ld2tfY29va2llcy5jcHA6CisgICAgICAgIChld2tfY29va2llc19maWxlX3NldCk6 CisgICAgICAgIChld2tfY29va2llc19wb2xpY3lfc2V0KToKKyAgICAgICAgKGV3a19jb29raWVz X3BvbGljeV9nZXQpOgorICAgICAgICAqIGV3ay9ld2tfY29va2llcy5oOgorCiAyMDExLTAxLTI2 ICBNT1JJVEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IFJ5b3N1a2UgTml3YS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tf Y29va2llcy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2Nvb2tpZXMuY3BwCmluZGV4 IDI1NjRmYzcuLmY2YTdmMTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tf Y29va2llcy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19jb29raWVzLmNwcApA QCAtMzcsMTMgKzM3LDEzIEBACiAKIAogLyoqCi0gKiBTZXQgdGhlIHBhdGggd2hlcmUgdGhlIGNv b2tpZXMgYXJlIGdvaW5nIHRvIGJlIHN0b3JlZC4gVXNlIE5VTEwgZm9yIGtlZXAKKyAqIFNldHMg dGhlIHBhdGggd2hlcmUgdGhlIGNvb2tpZXMgYXJlIGdvaW5nIHRvIGJlIHN0b3JlZC4gVXNlIEBj IE5VTEwgZm9yIGtlZXAKICAqIHRoZW0ganVzdCBpbiBtZW1vcnkuCiAgKgogICogQHBhcmFtIGZp bGVuYW1lIHBhdGggdG8gdGhlIGNvb2tpZXMudHh0IGZpbGUuCiAgKgotICogQHJldHVybnMgRUlO QV9GQUxTRSBpZiBpdCB3YXNuJ3QgcG9zc2libGUgdG8gY3JlYXRlIHRoZSBjb29raWUgamFyLAot ICogICAgICAgICAgRUlOQV9GQUxTRSBvdGhlcndpc2UuCisgKiBAcmV0dXJuIEBjIEVJTkFfRkFM U0UgaWYgaXQgd2Fzbid0IHBvc3NpYmxlIHRvIGNyZWF0ZSB0aGUgY29va2llIGphciwKKyAqICAg ICAgICAgIEBjIEVJTkFfRkFMU0Ugb3RoZXJ3aXNlLgogICovCiBFQVBJIEVpbmFfQm9vbCBld2tf Y29va2llc19maWxlX3NldChjb25zdCBjaGFyICpmaWxlbmFtZSkKIHsKQEAgLTc0LDcgKzc0LDcg QEAgRUFQSSBFaW5hX0Jvb2wgZXdrX2Nvb2tpZXNfZmlsZV9zZXQoY29uc3QgY2hhciAqZmlsZW5h bWUpCiB9CiAKIC8qKgotICogQ2xlYXIgYWxsIHRoZSBjb29raWVzIGZyb20gdGhlIGNvb2tpZSBq YXIuCisgKiBDbGVhcnMgYWxsIHRoZSBjb29raWVzIGZyb20gdGhlIGNvb2tpZSBqYXIuCiAgKi8K IEVBUEkgdm9pZCBld2tfY29va2llc19jbGVhcigpCiB7CkBAIC05NCw3ICs5NCw3IEBAIEVBUEkg dm9pZCBld2tfY29va2llc19jbGVhcigpCiAvKioKICAqIFJldHVybnMgYSBsaXN0IG9mIGNvb2tp ZXMgaW4gdGhlIGNvb2tpZSBqYXIuCiAgKgotICogQHJldHVybnMgYW4gRWluYV9MaXN0IHdpdGgg YWxsIHRoZSBjb29raWVzIGluIHRoZSBjb29raWUgamFyLgorICogQHJldHVybiBhbiBAYyBFaW5h X0xpc3Qgd2l0aCBhbGwgdGhlIGNvb2tpZXMgaW4gdGhlIGNvb2tpZSBqYXIuCiAgKi8KIEVBUEkg RWluYV9MaXN0KiBld2tfY29va2llc19nZXRfYWxsKHZvaWQpCiB7CkBAIC0xMjMsMTMgKzEyMywx MyBAQCBFQVBJIEVpbmFfTGlzdCogZXdrX2Nvb2tpZXNfZ2V0X2FsbCh2b2lkKQogICAgIHJldHVy biBlbDsKIH0KIAotLyoKKy8qKgogICogRGVsZXRlcyBhIGNvb2tpZSBmcm9tIHRoZSBjb29raWUg amFyLgogICoKICAqIE5vdGUgdGhhdCB0aGUgZmllbGRzIG5hbWUsIHZhbHVlLCBkb21haW4gYW5k IHBhdGggYXJlIHVzZWQgdG8gbWF0Y2ggdGhpcwogICogY29va2llIGluIHRoZSBjb29raWUgamFy LgogICoKLSAqIEBwYXJhbSBjb29raWUgYW4gRXdrX0Nvb2tpZSB0aGF0IGhhcyB0aGUgaW5mbyBy ZWxhdGl2ZSB0byB0aGF0IGNvb2tpZS4KKyAqIEBwYXJhbSBjb29raWUgYW4gQGMgRXdrX0Nvb2tp ZSB0aGF0IGhhcyB0aGUgaW5mbyByZWxhdGl2ZSB0byB0aGF0IGNvb2tpZS4KICAqLwogRUFQSSB2 b2lkIGV3a19jb29raWVzX2Nvb2tpZV9kZWwoRXdrX0Nvb2tpZSAqY29va2llKQogewpAQCAtMTU1 LDggKzE1NSw4IEBAIEVBUEkgdm9pZCBld2tfY29va2llc19jb29raWVfZGVsKEV3a19Db29raWUg KmNvb2tpZSkKICNlbmRpZgogfQogCi0vKgotICogRnJlZSB0aGUgbWVtb3J5IHVzZWQgYnkgYSBj b29raWUuCisvKioKKyAqIEZyZWVzIHRoZSBtZW1vcnkgdXNlZCBieSBhIGNvb2tpZS4KICAqCiAg KiBAcGFyYW0gY29va2llIHRoZSBFd2tfQ29va2llIHN0cnVjdCB0aGF0IHdpbGwgYmUgZnJlZWQu CiAgKi8KQEAgLTE3MiwxNSArMTcyLDExIEBAIEVBUEkgdm9pZCBld2tfY29va2llc19jb29raWVf ZnJlZShFd2tfQ29va2llICpjb29raWUpCiAjZW5kaWYKIH0KIAotLyoKLSAqIFNldCB0aGUgY29v a2llcyBhY2NlcHQgcG9saWN5LgotICoKLSAqIFBvc3NpYmxlIHZhbHVlcyBhcmU6IEVXS19DT09L SUVfSkFSX0FDQ0VQVF9BTFdBWVMsIHdoaWNoIGFjY2VwdHMgZXZlcnkKLSAqIGNvb2tpZSBzZW50 IGZyb20gYW55IHBhZ2U7IEVXS19DT09LSUVfSkFSX0FDQ0VQVF9OT19USElSRF9QQVJUWSwgd2hp Y2gKLSAqIGFjY2VwdHMgY29va2llcyBvbmx5IGZyb20gdGhlIG1haW4gcGFnZTsgYW5kIEVXS19D T09LSUVfSkFSX0FDQ0VQVF9ORVZFUiwKLSAqIHdoaWNoIHJlamVjdHMgYWxsIGNvb2tpZXMuCisv KioKKyAqIFNldHMgdGhlIGNvb2tpZXMgYWNjZXB0IHBvbGljeS4KICAqCiAgKiBAcGFyYW0gcCB0 aGUgYWNjZXB0YW5jZSBwb2xpY3kKKyAqIEBzZWUgRXdrX0Nvb2tpZV9Qb2xpY3kKICAqLwogRUFQ SSB2b2lkIGV3a19jb29raWVzX3BvbGljeV9zZXQoRXdrX0Nvb2tpZV9Qb2xpY3kgcCkKIHsKQEAg LTIwNSwxMCArMjAxLDExIEBAIEVBUEkgdm9pZCBld2tfY29va2llc19wb2xpY3lfc2V0KEV3a19D b29raWVfUG9saWN5IHApCiAjZW5kaWYKIH0KIAotLyoKKy8qKgogICogR2V0cyB0aGUgYWNjZXB0 YW5jZSBwb2xpY3kgdXNlZCBpbiB0aGUgY3VycmVudCBjb29raWUgamFyLgogICoKLSAqIEByZXR1 cm5zIHRoZSBjdXJyZW50IGFjY2VwdGFuY2UgcG9saWN5CisgKiBAcmV0dXJuIHRoZSBjdXJyZW50 IGFjY2VwdGFuY2UgcG9saWN5CisgKiBAc2VlIEV3a19Db29raWVfUG9saWN5CiAgKi8KIEVBUEkg RXdrX0Nvb2tpZV9Qb2xpY3kgZXdrX2Nvb2tpZXNfcG9saWN5X2dldCgpCiB7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2Nvb2tpZXMuaCBiL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfY29va2llcy5oCmluZGV4IDZiYTNjOWEuLjE5ZWFjMGYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfY29va2llcy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfY29va2llcy5oCkBAIC0xOCw2ICsxOCwxMSBAQAogICAgIEJvc3RvbiwgTUEgMDIx MTAtMTMwMSwgVVNBLgogKi8KIAorLyoqCisgKiBAZmlsZSAgICBld2tfY29va2llcy5oCisgKiBA YnJpZWYgICBUaGUgRXdrIGNvb2tpZXMgQVBJLgorICovCisKICNpZm5kZWYgZXdrX2Nvb2tpZXNf aAogI2RlZmluZSBld2tfY29va2llc19oCiAKQEAgLTI4LDI0ICszMyw0NCBAQAogZXh0ZXJuICJD IiB7CiAjZW5kaWYKIAorLyoqCisgKiBcc3RydWN0ICBfRXdrX0Nvb2tpZQorICoKKyAqIEBicmll ZiAgIERlc2NyaWJlcyBwcm9wZXJ0aWVzIG9mIGFuIEhUVFAgY29va2llLgorICovCiBzdHJ1Y3Qg X0V3a19Db29raWUgeworICAgIC8vLyB0aGUgY29va2llIG5hbWUKICAgICBjaGFyICpuYW1lOwor ICAgIC8vLyB0aGUgY29va2llIHZhbHVlCiAgICAgY2hhciAqdmFsdWU7CisgICAgLy8vIHRoZSAi ZG9tYWluIiBhdHRyaWJ1dGUsIG9yIGVsc2UgdGhlIGhvc3RuYW1lIHRoYXQgdGhlIGNvb2tpZSBj YW1lIGZyb20KICAgICBjaGFyICpkb21haW47CisgICAgLy8vIHRoZSAicGF0aCIgYXR0cmlidXRl LCBvciBAYyAwCiAgICAgY2hhciAqcGF0aDsKKyAgICAvLy8gdGhlIGNvb2tpZSBleHBpcmF0aW9u IHRpbWUsIG9yIEBjIDAgZm9yIGEgc2Vzc2lvbiBjb29raWUKICAgICB0aW1lX3QgZXhwaXJlczsK KyAgICAvLy8gQGMgRUlOQV9UUlVFIGlmIHRoZSBjb29raWUgc2hvdWxkIG9ubHkgYmUgdHJhbmZl cnJlZCBvdmVyIFNTTAogICAgIEVpbmFfQm9vbCBzZWN1cmU7Ci0gICAgRWluYV9Cb29sIGh0dHBf b25seTsKKyAgICAvLy8gQGMgRUlOQV9UUlVFIGlmIHRoZSBjb29raWUgc2hvdWxkIG5vdCBiZSBl eHBvc2VkIHRvIHNjcmlwdHMKKyAgICBFaW5hX0Jvb2wgaHR0cF9vbmx5OyAgICAKIH07Ci0KKy8v LyBDcmVhdGVzIGEgdHlwZSBuYW1lIGZvciB0aGUgX0V3a19Db29raWUuCiB0eXBlZGVmIHN0cnVj dCBfRXdrX0Nvb2tpZSBFd2tfQ29va2llOwogCisvKioKKyAqIFxlbnVtICAgIF9Fd2tfQ29va2ll X1BvbGljeQorICoKKyAqIEBicmllZiAgIENvbnRhaW5zIGEgcG9saWN5IGZvciB0aGUgY29va2ll cy4KKyAqLwogZW51bSBfRXdrX0Nvb2tpZV9Qb2xpY3kgeworICAgIC8vLyBSZWplY3RzIGFsbCBj b29raWVzLgogICAgIEVXS19DT09LSUVfSkFSX0FDQ0VQVF9ORVZFUiwKKyAgICAvLy8gQWNjZXB0 cyBldmVyeSBjb29raWUgc2VudCBmcm9tIGFueSBwYWdlLgogICAgIEVXS19DT09LSUVfSkFSX0FD Q0VQVF9BTFdBWVMsCisgICAgLy8vIEFjY2VwdHMgY29va2llcyBvbmx5IGZyb20gdGhlIG1haW4g cGFnZS4KICAgICBFV0tfQ09PS0lFX0pBUl9BQ0NFUFRfTk9fVEhJUkRfUEFSVFkKIH07Ci0KKy8v LyBDcmVhdGVzIGEgdHlwZSBuYW1lIGZvciB0aGUgX0V3a19Db29raWVfUG9saWN5LgogdHlwZWRl ZiBlbnVtIF9Fd2tfQ29va2llX1BvbGljeSBFd2tfQ29va2llX1BvbGljeTsKIAogLyoqKioqKioq KioqKioqKioqKioqKioqKioqIEV4cG9ydGVkIGZ1bmN0aW9ucyAqKioqKioqKioqKioqKioqKioq KioqKi8K