54537 2011-02-16 01:30:54 -0800 [Gtk] Add support for layoutTestController.setWillSendRequestClearHeader 2011-02-16 10:24:37 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 svillar svillar abarth eric webkit.review.bot oldest_to_newest 351936 0 svillar 2011-02-16 01:30:54 -0800 [Gtk] Add support for layoutTestController.setWillSendRequestClearHeader 351938 1 82604 svillar 2011-02-16 01:35:14 -0800 Created attachment 82604 Patch 351939 2 svillar 2011-02-16 01:37:37 -0800 I know ChangeLogs are not OK. I used webkit-path upload to upload the patch and didn't realize that I had to edit both. I guess I should change them before committing 352091 3 82604 mrobinson 2011-02-16 08:29:18 -0800 Comment on attachment 82604 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82604&action=review Great stuff. Please consider the following changes befor committing. > Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:95 > + GHashTable* headersHash = g_hash_table_new(g_str_hash, g_str_equal); I think I'd rather this be a Vector<String> or a HashMap<String, int>. You're already converting to String below so you can just reuse that. That will allow you to remove a few lines below. > Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1015 > +static void willSendRequestCallback(WebKitWebView* webView, WebKitWebFrame*, WebKitWebResource* resource, WebKitNetworkRequest* request, WebKitNetworkResponse* redirectResponse) You can remove the "resource' and "redirectResponse" paramter names. 352143 4 svillar 2011-02-16 09:47:39 -0800 Committed r78718: <http://trac.webkit.org/changeset/78718> 352173 5 webkit.review.bot 2011-02-16 10:24:37 -0800 http://trac.webkit.org/changeset/78718 might have broken Qt Linux Release The following tests are not passing: media/controls-without-preload.html 82604 2011-02-16 01:35:14 -0800 2011-02-16 08:29:18 -0800 Patch bug-54537-20110216103512.patch text/plain 6210 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogNzg2ODcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBhOTE0NzE3ZDVjNzUzMTBjZGFkMzhm ZDY3YzExOWRkMDQ5NTI1YmM4Li40MzhmNTc4MzJjYWExYTdkOTU0MGZhMDE2OGZjYzcxNDMwZTRj YjQ3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDItMTYgIFNlcmdpbyBWaWxsYXIgU2Vu aW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW0d0a10gQWRkIHN1cHBvcnQgZm9yIGxheW91dFRlc3RDb250cm9s bGVyLnNldFdpbGxTZW5kUmVxdWVzdENsZWFySGVhZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDUzNworCisgICAgICAgIEFkZGVkIHN1cHBvcnQg Zm9yIHNldFdpbGxTZW5kUmVxdWVzdENsZWFySGVhZGVyIGluIEd0aydzCisgICAgICAgIExheW91 dFRlc3RDb250cm9sbGVyLiBUaGlzIHdpbGwgYWxsb3cgdGVzdHMgdG8gcmVtb3ZlIHNwZWNpZmlj IGhlYWRlcnMgZnJvbSB0aGUKKyAgICAgICAgcmVxdWVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ndGsvU2tpcHBlZDogdW5za2lwcGVkIGh0dHAvdGVzdHMvc2VjdXJpdHkvbm8tcmVmZXJyZXIu aHRtbC4KKwogMjAxMS0wMi0xNSAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgVW5yZXZpZXdlZCwgdGVzdCBleHBlY3RhdGlvbiB1cGRhdGUuCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L2d0ay9Ta2lwcGVkCmluZGV4IGZkNTExZWJkZjgwZTgwODVmMWQ1Y2RiM2UxOWYxMzFlZWM2MmMy ZDEuLmZiNDAwYjczMjM4YjIxMzg4YTc1NmQzNTc1YmM1YWZhOTdmZDM0MTIgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRm b3JtL2d0ay9Ta2lwcGVkCkBAIC0xNTY0LDkgKzE1NjQsNiBAQCBodHRwL3Rlc3RzL3htbGh0dHBy ZXF1ZXN0L3NpbXBsZS1jcm9zcy1vcmlnaW4tcHJvZ3Jlc3MtZXZlbnRzLmh0bWwKICMgRmFpbHMg b24gYW5kIG9mZiAobW9yZSBvZnRlbiBmYWlscykgb24gdGhlIHJlbGVhc2UgYm90CiBtZWRpYS9l dmVudC1hdHRyaWJ1dGVzLmh0bWwKIAotIyBHVEsrIGRvZXMgbm90IGhhdmUgbGF5b3V0VGVzdENv bnRyb2xsZXIuc2V0V2lsbFNlbmRSZXF1ZXN0Q2xlYXJIZWFkZXIuCi1odHRwL3Rlc3RzL3NlY3Vy aXR5L25vLXJlZmVycmVyLmh0bWwKLQogIyBHVEsrIGRvZXMgbm90IGhhdmUgbGF5b3V0VGVzdENv bnRyb2xsZXIuc2V0V2lsbFNlbmRSZXF1ZXN0UmV0dXJuc051bGwuCiBmYXN0L2xvYWRlci9vbmxv YWQtd2lsbFNlbmRSZXF1ZXN0LW51bGwtZm9yLXNjcmlwdC5odG1sCiBmYXN0L2xvYWRlci93aWxs U2VuZFJlcXVlc3QtbnVsbC1mb3ItcHJlbG9hZC5odG1sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTBlNGU3Mjhh YWJjN2M5NTViODI4MmIxMmRkN2QxMjdlNmM0ZWY0OC4uZjgxN2VhOWM0NDBiZjcyMDE4NWFhM2Ri ZmZhOTYyMzU3MWVlOWQyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTAyLTE2 ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHdGtdIEFkZCBzdXBwb3J0IGZv ciBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRXaWxsU2VuZFJlcXVlc3RDbGVhckhlYWRlcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ1MzcKKworICAg ICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlcXVlc3RTb3VwLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdDo6dXBkYXRlRnJvbVNvdXBNZXNzYWdlKToK KwogMjAxMS0wMi0xNSAgSm9obiBTdWxsaXZhbiAgPHN1bGxpdmFuQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBBbnR0aSBLb2l2aXN0by4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlcXVlc3RTb3VwLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlcXVlc3RTb3VwLmNwcApp bmRleCA1MDE2YmYxYWZjNjZiMDVmZDc3ZTA2MThlMTRkZTAxZWM0Y2M2OWQyLi5kNDc4YjUxNGQ2 YmI1Y2ZkMjNkNzc3YjEyMjczMjNiOWQzYjVkZDc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VSZXF1ZXN0U291cC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVxdWVzdFNvdXAuY3Bw CkBAIC05MiwxMCArOTIsMjMgQEAgdm9pZCBSZXNvdXJjZVJlcXVlc3Q6OnVwZGF0ZUZyb21Tb3Vw TWVzc2FnZShTb3VwTWVzc2FnZSogc291cE1lc3NhZ2UpCiAgICAgU291cE1lc3NhZ2VIZWFkZXJz SXRlciBoZWFkZXJzSXRlcjsKICAgICBjb25zdCBjaGFyKiBoZWFkZXJOYW1lOwogICAgIGNvbnN0 IGNoYXIqIGhlYWRlclZhbHVlOworICAgIEdIYXNoVGFibGUqIGhlYWRlcnNIYXNoID0gZ19oYXNo X3RhYmxlX25ldyhnX3N0cl9oYXNoLCBnX3N0cl9lcXVhbCk7CiAKICAgICBzb3VwX21lc3NhZ2Vf aGVhZGVyc19pdGVyX2luaXQoJmhlYWRlcnNJdGVyLCBzb3VwTWVzc2FnZS0+cmVxdWVzdF9oZWFk ZXJzKTsKLSAgICB3aGlsZSAoc291cF9tZXNzYWdlX2hlYWRlcnNfaXRlcl9uZXh0KCZoZWFkZXJz SXRlciwgJmhlYWRlck5hbWUsICZoZWFkZXJWYWx1ZSkpCisgICAgd2hpbGUgKHNvdXBfbWVzc2Fn ZV9oZWFkZXJzX2l0ZXJfbmV4dCgmaGVhZGVyc0l0ZXIsICZoZWFkZXJOYW1lLCAmaGVhZGVyVmFs dWUpKSB7CiAgICAgICAgIG1faHR0cEhlYWRlckZpZWxkcy5zZXQoU3RyaW5nOjpmcm9tVVRGOCho ZWFkZXJOYW1lKSwgU3RyaW5nOjpmcm9tVVRGOChoZWFkZXJWYWx1ZSkpOworICAgICAgICBnX2hh c2hfdGFibGVfaW5zZXJ0KGhlYWRlcnNIYXNoLCAoZ3BvaW50ZXIpIGhlYWRlck5hbWUsIEdJTlRf VE9fUE9JTlRFUigxKSk7CisgICAgfQorCisgICAgaWYgKCFtX2h0dHBIZWFkZXJGaWVsZHMuaXNF bXB0eSgpKSB7CisgICAgICAgIEhUVFBIZWFkZXJNYXA6Oml0ZXJhdG9yIGVuZCA9IG1faHR0cEhl YWRlckZpZWxkcy5lbmQoKTsKKyAgICAgICAgZm9yIChIVFRQSGVhZGVyTWFwOjppdGVyYXRvciBp dCA9IG1faHR0cEhlYWRlckZpZWxkcy5iZWdpbigpOyBpdCAhPSBlbmQ7ICsraXQpIHsKKyAgICAg ICAgICAgIGNvbnN0IGNoYXIqIGhlYWRlck5hbWUgPSBnX3N0cmR1cChpdC0+Zmlyc3Quc3RyaW5n KCkudXRmOCgpLmRhdGEoKSk7CisgICAgICAgICAgICBpZiAoIWdfaGFzaF90YWJsZV9sb29rdXAo aGVhZGVyc0hhc2gsIGhlYWRlck5hbWUpKQorICAgICAgICAgICAgICAgIG1faHR0cEhlYWRlckZp ZWxkcy5yZW1vdmUoaGVhZGVyTmFtZSk7CisgICAgICAgIH0KKyAgICB9CisgICAgZ19oYXNoX3Rh YmxlX3VucmVmKGhlYWRlcnNIYXNoKTsKIAogICAgIGlmIChzb3VwTWVzc2FnZS0+cmVxdWVzdF9i b2R5LT5kYXRhKQogICAgICAgICBtX2h0dHBCb2R5ID0gRm9ybURhdGE6OmNyZWF0ZShzb3VwTWVz c2FnZS0+cmVxdWVzdF9ib2R5LT5kYXRhLCBzb3VwTWVzc2FnZS0+cmVxdWVzdF9ib2R5LT5sZW5n dGgpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4 IDkzYTZjN2JkN2I0NDVmYTcyNTI2MDFhM2FiODM0NDg5NTE0N2RiMWQuLmRmZjEzZmVkM2E3NDYw MTU3MTg4ZGRjMjQ5MTBlYjJlMmFlYTUxNjUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZwor KysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMS0wMi0xNiAgU2VyZ2lv IFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR3RrXSBBZGQgc3VwcG9ydCBmb3IgbGF5b3V0 VGVzdENvbnRyb2xsZXIuc2V0V2lsbFNlbmRSZXF1ZXN0Q2xlYXJIZWFkZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0NTM3CisKKyAgICAgICAgKiBE dW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAod2lsbFNlbmRS ZXF1ZXN0Q2FsbGJhY2spOgorICAgICAgICAoY3JlYXRlV2ViVmlldyk6CisKIDIwMTEtMDItMTUg IFhpYW56aHUgV2FuZyAgPHdhbmd4aWFuemh1QGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgS2VudCBUYW11cmEuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsv RHVtcFJlbmRlclRyZWUuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJU cmVlLmNwcAppbmRleCBmMThmMzVjNWFjY2RkMzNiNmQ1NWMyMjgzM2M3NDg1NmJjMjhkZDRiLi45 NDVhMTU1MjY0NGRhODJlZGZjNDg1NjY5OTQ3ZGQ2ZWMyYTBjNjljIDEwMDY0NAotLS0gYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwCisrKyBiL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKQEAgLTEwMTIsNiArMTAxMiwxNyBAQCBz dGF0aWMgdm9pZCBmcmFtZUNyZWF0ZWRDYWxsYmFjayhXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBX ZWJLaXRXZWJGcmFtZSogd2ViRnJhbQogICAgIGdfc2lnbmFsX2Nvbm5lY3Qod2ViRnJhbWUsICJu b3RpZnk6OmxvYWQtc3RhdHVzIiwgR19DQUxMQkFDSyh3ZWJGcmFtZUxvYWRTdGF0dXNOb3RpZmll ZCksIE5VTEwpOwogfQogCitzdGF0aWMgdm9pZCB3aWxsU2VuZFJlcXVlc3RDYWxsYmFjayhXZWJL aXRXZWJWaWV3KiB3ZWJWaWV3LCBXZWJLaXRXZWJGcmFtZSosIFdlYktpdFdlYlJlc291cmNlKiBy ZXNvdXJjZSwgV2ViS2l0TmV0d29ya1JlcXVlc3QqIHJlcXVlc3QsIFdlYktpdE5ldHdvcmtSZXNw b25zZSogcmVkaXJlY3RSZXNwb25zZSkKK3sKKyAgICBTb3VwTWVzc2FnZSogc291cE1lc3NhZ2Ug PSB3ZWJraXRfbmV0d29ya19yZXF1ZXN0X2dldF9tZXNzYWdlKHJlcXVlc3QpOworCisgICAgaWYg KHNvdXBNZXNzYWdlKSB7CisgICAgICAgIGNvbnN0IHNldDxzdHJpbmc+JiBjbGVhckhlYWRlcnMg PSBnTGF5b3V0VGVzdENvbnRyb2xsZXItPndpbGxTZW5kUmVxdWVzdENsZWFySGVhZGVycygpOwor ICAgICAgICBmb3IgKHNldDxzdHJpbmc+Ojpjb25zdF9pdGVyYXRvciBoZWFkZXIgPSBjbGVhckhl YWRlcnMuYmVnaW4oKTsgaGVhZGVyICE9IGNsZWFySGVhZGVycy5lbmQoKTsgKytoZWFkZXIpCisg ICAgICAgICAgICBzb3VwX21lc3NhZ2VfaGVhZGVyc19yZW1vdmUoc291cE1lc3NhZ2UtPnJlcXVl c3RfaGVhZGVycywgaGVhZGVyLT5jX3N0cigpKTsKKyAgICB9Cit9CisKIHN0YXRpYyBXZWJLaXRX ZWJWaWV3KiBjcmVhdGVXZWJWaWV3KCkKIHsKICAgICBXZWJLaXRXZWJWaWV3KiB2aWV3ID0gV0VC S0lUX1dFQl9WSUVXKHdlYmtpdF93ZWJfdmlld19uZXcoKSk7CkBAIC0xMDQwLDYgKzEwNTEsNyBA QCBzdGF0aWMgV2ViS2l0V2ViVmlldyogY3JlYXRlV2ViVmlldygpCiAgICAgICAgICAgICAgICAg ICAgICAic2lnbmFsOjpkcmFnLWVuZCIsIGRyYWdFbmRDYWxsYmFjaywgMCwKICAgICAgICAgICAg ICAgICAgICAgICJzaWduYWw6OmRyYWctZmFpbGVkIiwgZHJhZ0ZhaWxlZENhbGxiYWNrLCAwLAog ICAgICAgICAgICAgICAgICAgICAgInNpZ25hbDo6ZnJhbWUtY3JlYXRlZCIsIGZyYW1lQ3JlYXRl ZENhbGxiYWNrLCAwLAorICAgICAgICAgICAgICAgICAgICAgInNpZ25hbDo6cmVzb3VyY2UtcmVx dWVzdC1zdGFydGluZyIsIHdpbGxTZW5kUmVxdWVzdENhbGxiYWNrLCAwLAogCiAgICAgICAgICAg ICAgICAgICAgICBOVUxMKTsKICAgICBjb25uZWN0RWRpdGluZ0NhbGxiYWNrcyh2aWV3KTsK