54525 2011-02-15 19:49:08 -0800 webkitpy.common.net.testoutputset_unittest.TestOutputSetTest.test_can_infer_platform_from_path_if_none_provided fails on win32 2011-05-31 18:37:48 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 NEW P2 Normal --- 48728 1 dpranke webkit-unassigned abarth aroben eric koz mihaip tony oldest_to_newest 351837 0 dpranke 2011-02-15 19:49:08 -0800 There's actually a couple of places that get confused by os.path.sep being '\\' on win32, but in this particular test it's not clear what the right fix is, since I'm not sure if zip files should follow the platform, or always use '/'. 353335 1 82902 dpranke 2011-02-17 19:23:14 -0800 Created attachment 82902 Patch 353354 2 dpranke 2011-02-17 19:54:20 -0800 Note that we don't actually want to land/review the patch I just uploaded. We can handle the skipping via the blacklist in bug 54709 and should use this bug to fix it properly. 354010 3 dpranke 2011-02-18 19:32:08 -0800 The issue is that we insert file paths into the zip file with forward slashes as separators, but when we turn the file path into a filesethandle, we use the native filesystem, which on win32 uses backward slashes as separators. Hence we fail to parse the path correctly and don't extract the "win" component properly. I'm not sure what the right fix is. I'm pretty sure zip files will always return forward slashes, so I think that part of the code is acting correctly. Perhaps the TestOutput and TestOutputSet() classes should have a filesystem handles passed to their constructors, and we should always pass it MockFileSystems (or some other filesystem-interface-implement object) when we're extracting zip files using TestOutputSet().from_zip() or TestOutputSet().from_zip_url()? Koz, you wrote this code, does that sound about right? 413062 4 dpranke 2011-05-31 18:37:48 -0700 disclaiming ownership on this, in case anyone else wants to work on it. 82902 2011-02-17 19:23:14 -0800 2011-02-17 19:23:14 -0800 Patch bug-54525-20110217192313.patch text/plain 2042 dpranke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3NGI5 YTNlMWJiZjdlZjBhZTZmZDA0Mjg0MTliZGQ2ZmM0ZDc4NjBjLi5mNmY5NDNjMDIzZTk3MmU2Y2E0 ZWZlNTNiNDdiZTRlNjFlMDE0MjJmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMjAgQEAKIAogICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBTa2lwCisgICAgICAgIHdlYmtpdHB5LmNvbW1vbi5u ZXQudGVzdG91dHB1dHNldF91bml0dGVzdC5UZXN0T3V0cHV0U2V0VGVzdC5cCisgICAgICAgICAg ICB0ZXN0X2Nhbl9pbmZlcl9wbGF0Zm9ybV9mcm9tX3BhdGhfaWZfbm9uZV9wcm92aWRlZCBvbiB3 aW4zMgorICAgICAgICBmb3Igbm93IHNpbmNlIGl0J3MgZmFpbGluZyBhbmQgaXQncyB1bmNsZWFy IHdoYXQgdGhlIHJpZ2h0IGZpeAorICAgICAgICBpcy4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ1MjUKKworICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL25ldC90ZXN0b3V0cHV0c2V0X3VuaXR0ZXN0LnB5OgorCisyMDExLTAyLTE3 ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAgIFNraXAgbWFjLnRlc3Rfc2tpcHBlZF9maWxl X3BhdGhzKCkgd2hlbiBydW5uaW5nIG9uIHdpbjMyOyB0aGUKICAgICAgICAgdGVzdCBoYXMgaGFy ZGNvZGVkICcvJyBkaXJlY3Rvcnkgc2VwYXJhdG9ycyBhbmQgc2luY2UgaXQncyBhCiAgICAgICAg IHBvcnQtc3BlY2lmaWMgdGVzdCBhbmQgd2UgaGF2ZSBjb3ZlcmFnZSBvbiBvdGhlciBwb3J0cyBp dCdzIG5vdApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L3Rl c3RvdXRwdXRzZXRfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9u ZXQvdGVzdG91dHB1dHNldF91bml0dGVzdC5weQppbmRleCBhNzBhNTM5ZTg4YTMwMDg3NWVlYzZk YTU2NmQ3ZjdjNGYwNWFiYTg2Li45YzIwNTA2NDE5YjEwMDgxOGFmNDU5OWMwOGJiNzE0NjA5Y2E1 YTg5IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvdGVzdG91 dHB1dHNldF91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9u ZXQvdGVzdG91dHB1dHNldF91bml0dGVzdC5weQpAQCAtMjIsNiArMjIsOCBAQAogIyAoSU5DTFVE SU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRI RSBVU0UgT0YKICMgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJ TElUWSBPRiBTVUNIIERBTUFHRS4KIAoraW1wb3J0IHN5cworCiBmcm9tIHdlYmtpdHB5LmNvbW1v bi5zeXN0ZW0uemlwX21vY2sgaW1wb3J0IE1vY2taaXAKIGltcG9ydCB0ZXN0b3V0cHV0c2V0CiBp bXBvcnQgdW5pdHRlc3QKQEAgLTcyLDYgKzc0LDkgQEAgY2xhc3MgVGVzdE91dHB1dFNldFRlc3Qo dW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICBzZWxmLmFzc2VydEVxdWFscygyLCBsZW4oYi5v dXRwdXRzX2ZvcignZmFzdC9kb20vdGVzdCcpKSkKIAogICAgIGRlZiB0ZXN0X2Nhbl9pbmZlcl9w bGF0Zm9ybV9mcm9tX3BhdGhfaWZfbm9uZV9wcm92aWRlZChzZWxmKToKKyAgICAgICAgIyBGSVhN RTogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPQorICAgICAgICBpZiBz eXMucGxhdGZvcm0gPT0gJ3dpbjMyJzoKKyAgICAgICAgICAgIHJldHVybgogICAgICAgICB6aXAg PSBNb2NrWmlwKCkKICAgICAgICAgemlwLmluc2VydCgncGxhdGZvcm0vd2luL3NvbWUtdGVzdC1l eHBlY3RlZC5wbmcnLCAnPGltYWdlIGRhdGE+JykKICAgICAgICAgemlwLmluc2VydCgncGxhdGZv cm0vd2luL3NvbWUtdGVzdC1leHBlY3RlZC5jaGVja3N1bScsICdhYmMxMjMnKQo=