54522 2011-02-15 19:34:43 -0800 Fix platform/image-encoders/JPEGImageEncoder.cpp empty_output_buffer() behaviour 2011-03-07 19:16:16 -0800 1 1 1 Unclassified WebKit Images 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 54915 0 aboxhall aboxhall abarth aboxhall commit-queue eric noel.gordon pkasting webkit.review.bot oldest_to_newest 351831 0 aboxhall 2011-02-15 19:34:43 -0800 The libjpeg documentation (e.g. http://trac.imagemagick.org/browser/jpeg/trunk/libjpeg.txt) specifies: [the empty_output_buffer method of a JPEGDestinationManager] "should write out the *entire* buffer (use the saved start address and buffer length; ignore the current state of next_output_byte and free_in_buffer)." Fix jpegEmptyOutputBuffer() by ignoring free_in_buffer value as required. 351846 1 82580 aboxhall 2011-02-15 20:06:26 -0800 Created attachment 82580 Patch 354752 2 82580 abarth 2011-02-21 12:51:55 -0800 Comment on attachment 82580 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82580&action=review > Source/WebCore/ChangeLog:10 > + No new tests. (OOPS!) This line will prevent this patch from landing (because of the OOPS). Can we test this change? If not, please explain why we can't. 354815 3 aboxhall 2011-02-21 14:40:55 -0800 As noted in http://trac.webkit.org/changeset/67606, there is no existing layout test for this file, as it's not actually used by anything yet. 354832 4 abarth 2011-02-21 15:03:43 -0800 If it's not used by anything, then we should delete it, right? 354835 5 aboxhall 2011-02-21 15:08:34 -0800 Ok, I'll prepare a changelist which deletes it. 354852 6 pkasting 2011-02-21 15:43:34 -0800 (In reply to comment #3) > As noted in http://trac.webkit.org/changeset/67606, there is no existing layout test for this file, as it's not actually used by anything yet. Does "yet" mean "this is going to be used soon"? Deleting it doesn't make sense if we're about to re-add it, but if there aren't firm immediate plans, it should go away. 354872 7 aboxhall 2011-02-21 15:59:37 -0800 The file has been untouched since the initial commit 5 months ago, and still nothing is using it; I think it's unlikely to be used soon. 354896 8 aboxhall 2011-02-21 16:26:58 -0800 Created https://bugs.webkit.org/show_bug.cgi?id=54915 with a patch to remove this code. 354909 9 pkasting 2011-02-21 16:51:14 -0800 Closing this, then. 355035 10 82580 ojan 2011-02-21 21:38:11 -0800 Comment on attachment 82580 Patch r- to remove from the review queue. 359719 11 abarth 2011-03-01 00:38:21 -0800 Re-opening because we're not ready to remove this code yet. 359726 12 82580 abarth 2011-03-01 00:43:44 -0800 Comment on attachment 82580 Patch I think this patch is fine, but I'm not sure excited about it. The problem with fixing dead code is that we can't test the change, which means we're likely to regress. We'll need to explain why we can't test this change (and remove the "no new tests" OOPS) before landing. 363628 13 84987 aboxhall 2011-03-07 15:16:07 -0800 Created attachment 84987 Patch 363631 14 aboxhall 2011-03-07 15:20:42 -0800 (In reply to comment #12) > (From update of attachment 82580 [details]) > I think this patch is fine, but I'm not sure excited about it. The problem with fixing dead code is that we can't test the change, which means we're likely to regress. Once this code starts to be used (see bug 39230), the canvas.toDataUrl() tests will test it. > We'll need to explain why we can't test this change (and remove the "no new tests" OOPS) before landing. Done. 363741 15 84987 commit-queue 2011-03-07 18:19:38 -0800 Comment on attachment 84987 Patch Clearing flags on attachment: 84987 Committed r80521: <http://trac.webkit.org/changeset/80521> 363742 16 commit-queue 2011-03-07 18:19:44 -0800 All reviewed patches have been landed. Closing bug. 363771 17 webkit.review.bot 2011-03-07 19:16:16 -0800 http://trac.webkit.org/changeset/80521 might have broken GTK Linux 32-bit Release 82580 2011-02-15 20:06:26 -0800 2011-03-07 15:16:02 -0800 Patch bug-54522-20110216150624.patch text/plain 1714 aboxhall ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ZTQxMjJhYWI3NTUzY2UwNmYxODY4NjNlZTM3ZmJlMTE2NmIyYzEzLi4y ZGQ1MDAwNDYxOTE3ODA4OWIzM2U4N2IyNmM1ZmIzZjE1NTQxZjQ2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTcgQEAKKzIwMTEtMDItMTUgIEFsaWNlIEJveGhhbGwgIDxhYm94aGFsbEBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Rml4IHBsYXRmb3JtL2ltYWdlLWVuY29kZXJzL0pQRUdJbWFnZUVuY29kZXIuY3BwIGVtcHR5X291 dHB1dF9idWZmZXIoKSBiZWhhdmlvdXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU0NTIyCisKKyAgICAgICAgRml4IGpwZWdFbXB0eU91dHB1dEJ1ZmZl cigpIGJ5IGlnbm9yaW5nIGZyZWVfaW5fYnVmZmVyIHZhbHVlIGFzIHJlcXVpcmVkLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZW5j b2RlcnMvSlBFR0ltYWdlRW5jb2Rlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpqcGVnRW1wdHlP dXRwdXRCdWZmZXIpOgorCiAyMDExLTAyLTAyICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuaWVsIEJhdGVzLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZW5jb2RlcnMvSlBFR0ltYWdlRW5jb2Rlci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9KUEVHSW1hZ2VFbmNvZGVy LmNwcAppbmRleCBkNzA3YWE4NmRkM2UwMThhYmViY2Y3YWRhMGM1OGQzYzc2ZTc2YjFhLi5hNGVl NGZkOThkODZkZDVhMjk3ZGM5MDE4YTBkN2M4NjI5MzYyMDcyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9KUEVHSW1hZ2VFbmNvZGVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9KUEVHSW1hZ2VFbmNvZGVy LmNwcApAQCAtNjUsNyArNjUsNyBAQCBzdGF0aWMgdm9pZCBqcGVnSW5pdGlhbGl6ZURlc3RpbmF0 aW9uKGpfY29tcHJlc3NfcHRyIGNvbXByZXNzRGF0YSkKIHN0YXRpYyBib29sZWFuIGpwZWdFbXB0 eU91dHB1dEJ1ZmZlcihqX2NvbXByZXNzX3B0ciBjb21wcmVzc0RhdGEpCiB7CiAgICAgSlBFR0Rl c3RpbmF0aW9uTWFuYWdlciogZGVzdCA9IHN0YXRpY19jYXN0PEpQRUdEZXN0aW5hdGlvbk1hbmFn ZXIqPihjb21wcmVzc0RhdGEtPmRlc3QpOwotICAgIGRlc3QtPm1fZHVtcC5hcHBlbmQoZGVzdC0+ bV9idWZmZXIuZGF0YSgpLCBkZXN0LT5tX2J1ZmZlci5zaXplKCkgLSBkZXN0LT5mcmVlX2luX2J1 ZmZlcik7CisgICAgZGVzdC0+bV9kdW1wLmFwcGVuZChkZXN0LT5tX2J1ZmZlci5kYXRhKCksIGRl c3QtPm1fYnVmZmVyLnNpemUoKSk7CiAgICAgZGVzdC0+bmV4dF9vdXRwdXRfYnl0ZSAgPSByZWlu dGVycHJldF9jYXN0PEpPQ1RFVCo+KGRlc3QtPm1fYnVmZmVyLmRhdGEoKSk7CiAgICAgZGVzdC0+ ZnJlZV9pbl9idWZmZXIgICAgPSBkZXN0LT5tX2J1ZmZlci5zaXplKCk7CiAgICAgcmV0dXJuIFRS VUU7Cg== 84987 2011-03-07 15:16:07 -0800 2011-03-07 18:19:37 -0800 Patch bug-54522-20110308101605.patch text/plain 1859 aboxhall U3VidmVyc2lvbiBSZXZpc2lvbjogODA0NTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzNWJiODMyZGUzYjMyMDMz ZmM5Y2EzMzM4N2UzMDdmMDkzMzYwMzFjLi44ZmNiYjEwY2JkNDY3OThmOTA5MTM2ZGZhZGJjZmI0 ZjBkODVlMWNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDMtMDYgIEFsaWNl IEJveGhhbGwgIDxhYm94aGFsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg QWRhbSBCYXJ0aC4KKworICAgICAgICBGaXggcGxhdGZvcm0vaW1hZ2UtZW5jb2RlcnMvSlBFR0lt YWdlRW5jb2Rlci5jcHAgZW1wdHlfb3V0cHV0X2J1ZmZlcigpIGJlaGF2aW91cgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ1MjIKKworICAgICAgICBG aXgganBlZ0VtcHR5T3V0cHV0QnVmZmVyKCkgYnkgaWdub3JpbmcgZnJlZV9pbl9idWZmZXIgdmFs dWUgYXMgcmVxdWlyZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBhcyB0aGlzIGNvZGUgaXMg bm90IHlldCB1c2VkIGluIFdlYktpdC4gT25jZSB0aGlzIGNvZGUgaXMgdXNlZCB0byBpbXBsZW1l bnQgY2FudmFzLnRvRGF0YVVybCgpLCB0aGUgY2FudmFzIHRlc3RzIHdpbGwgZXhlcmNpc2UgaXQu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9KUEVHSW1hZ2VFbmNvZGVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OmpwZWdFbXB0eU91dHB1dEJ1ZmZlcik6CisKIDIwMTEtMDMt MDYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdl LWVuY29kZXJzL0pQRUdJbWFnZUVuY29kZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v aW1hZ2UtZW5jb2RlcnMvSlBFR0ltYWdlRW5jb2Rlci5jcHAKaW5kZXggZDcwN2FhODZkZDNlMDE4 YWJlYmNmN2FkYTBjNThkM2M3NmU3NmIxYS4uYTRlZTRmZDk4ZDg2ZGQ1YTI5N2RjOTAxOGEwZDdj ODYyOTM2MjA3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZW5j b2RlcnMvSlBFR0ltYWdlRW5jb2Rlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v aW1hZ2UtZW5jb2RlcnMvSlBFR0ltYWdlRW5jb2Rlci5jcHAKQEAgLTY1LDcgKzY1LDcgQEAgc3Rh dGljIHZvaWQganBlZ0luaXRpYWxpemVEZXN0aW5hdGlvbihqX2NvbXByZXNzX3B0ciBjb21wcmVz c0RhdGEpCiBzdGF0aWMgYm9vbGVhbiBqcGVnRW1wdHlPdXRwdXRCdWZmZXIoal9jb21wcmVzc19w dHIgY29tcHJlc3NEYXRhKQogewogICAgIEpQRUdEZXN0aW5hdGlvbk1hbmFnZXIqIGRlc3QgPSBz dGF0aWNfY2FzdDxKUEVHRGVzdGluYXRpb25NYW5hZ2VyKj4oY29tcHJlc3NEYXRhLT5kZXN0KTsK LSAgICBkZXN0LT5tX2R1bXAuYXBwZW5kKGRlc3QtPm1fYnVmZmVyLmRhdGEoKSwgZGVzdC0+bV9i dWZmZXIuc2l6ZSgpIC0gZGVzdC0+ZnJlZV9pbl9idWZmZXIpOworICAgIGRlc3QtPm1fZHVtcC5h cHBlbmQoZGVzdC0+bV9idWZmZXIuZGF0YSgpLCBkZXN0LT5tX2J1ZmZlci5zaXplKCkpOwogICAg IGRlc3QtPm5leHRfb3V0cHV0X2J5dGUgID0gcmVpbnRlcnByZXRfY2FzdDxKT0NURVQqPihkZXN0 LT5tX2J1ZmZlci5kYXRhKCkpOwogICAgIGRlc3QtPmZyZWVfaW5fYnVmZmVyICAgID0gZGVzdC0+ bV9idWZmZXIuc2l6ZSgpOwogICAgIHJldHVybiBUUlVFOwo=