54518 2011-02-15 17:54:20 -0800 Fix race condition in JavaScriptAudioNode 2011-02-15 18:13:23 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 crogers webkit-unassigned kbr oldest_to_newest 351785 0 crogers 2011-02-15 17:54:20 -0800 Fix race condition in JavaScriptAudioNode 351787 1 82564 crogers 2011-02-15 17:56:06 -0800 Created attachment 82564 Patch 351789 2 crogers 2011-02-15 17:58:36 -0800 m_isRequestOutstanding needs to be set before callOnMainThread() to avoid race condition with its value being set in the main thread. This fixes chromium bug: http://code.google.com/p/chromium/issues/detail?id=71702 The race condition could also happen for other ports. 351790 3 82564 kbr 2011-02-15 18:01:12 -0800 Comment on attachment 82564 Patch Looks fine to me. Tricky. 351799 4 crogers 2011-02-15 18:13:23 -0800 Committed r78671: <http://trac.webkit.org/changeset/78671> 82564 2011-02-15 17:56:06 -0800 2011-02-15 18:01:12 -0800 Patch bug-54518-20110215175605.patch text/plain 1357 crogers SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NjYyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMTUgIENocmlzIFJv Z2VycyAgPGNyb2dlcnNAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXggcmFjZSBjb25kaXRpb24gaW4gSmF2YVNjcmlwdEF1ZGlv Tm9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ1 MTgKKworICAgICAgICBObyBuZXcgdGVzdHMgc2luY2UgYXVkaW8gQVBJIGlzIG5vdCB5ZXQgaW1w bGVtZW50ZWQuCisKKyAgICAgICAgKiB3ZWJhdWRpby9KYXZhU2NyaXB0QXVkaW9Ob2RlLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkphdmFTY3JpcHRBdWRpb05vZGU6OnByb2Nlc3MpOgorCiAyMDEx LTAyLTEwICBKZXJlbXkgT3Jsb3cgIDxqb3Jsb3dAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IE5hdGUgQ2hhcGluLgpJbmRleDogU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vSmF2 YVNjcmlwdEF1ZGlvTm9kZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvd2ViYXVk aW8vSmF2YVNjcmlwdEF1ZGlvTm9kZS5jcHAJKHJldmlzaW9uIDc4NjE5KQorKysgU291cmNlL1dl YkNvcmUvd2ViYXVkaW8vSmF2YVNjcmlwdEF1ZGlvTm9kZS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTIwNSw4ICsyMDUsOCBAQCB2b2lkIEphdmFTY3JpcHRBdWRpb05vZGU6OnByb2Nlc3Moc2l6ZV90 CiAgICAgICAgICAgICAKICAgICAgICAgICAgIC8vIEZpcmUgdGhlIGV2ZW50IG9uIHRoZSBtYWlu IHRocmVhZCwgbm90IHRoaXMgb25lICh3aGljaCBpcyB0aGUgcmVhbHRpbWUgYXVkaW8gdGhyZWFk KS4KICAgICAgICAgICAgIG1fZG91YmxlQnVmZmVySW5kZXhGb3JFdmVudCA9IG1fZG91YmxlQnVm ZmVySW5kZXg7Ci0gICAgICAgICAgICBjYWxsT25NYWluVGhyZWFkKGZpcmVQcm9jZXNzRXZlbnRE aXNwYXRjaCwgdGhpcyk7CiAgICAgICAgICAgICBtX2lzUmVxdWVzdE91dHN0YW5kaW5nID0gdHJ1 ZTsKKyAgICAgICAgICAgIGNhbGxPbk1haW5UaHJlYWQoZmlyZVByb2Nlc3NFdmVudERpc3BhdGNo LCB0aGlzKTsKICAgICAgICAgfQogCiAgICAgICAgIHN3YXBCdWZmZXJzKCk7Cg==