54503 2011-02-15 15:36:08 -0800 Plugin mouse capture gets messed up if a dialog pops up while the mouse is down 2011-02-25 11:14:55 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 brettw brettw commit-queue oldest_to_newest 351661 0 brettw 2011-02-15 15:36:08 -0800 The capture logic in WebViewImpl for plugins implicitly sets capture when the mouse goes down on a plugin. If the plugin pops up a dialog in response to that click, the "up" message will be lost and the capture will be stuck. We should try to recover the capture state if we detect there are no mouse buttons down. Chromium issue: http://code.google.com/p/chromium/issues/detail?id=73075 351666 1 82538 brettw 2011-02-15 15:43:09 -0800 Created attachment 82538 Patch 354690 2 82538 commit-queue 2011-02-21 10:52:12 -0800 Comment on attachment 82538 Patch Rejecting attachment 82538 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2 Last 500 characters of output: up to this was: -------------------------- |Index: src/WebViewImpl.cpp |=================================================================== |--- src/WebViewImpl.cpp (revision 78540) |+++ src/WebViewImpl.cpp (working copy) -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored patching file ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Fisher', u'--for..." exit_code: 1 Full output: http://queues.webkit.org/results/7937943 358059 3 brettw 2011-02-25 11:14:55 -0800 Fixed in r79703 82538 2011-02-15 15:43:09 -0800 2011-02-21 10:52:12 -0800 Patch capture.diff text/plain 4204 brettw SW5kZXg6IHNyYy9XZWJWaWV3SW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3JjL1dlYlZpZXdJbXBs LmNwcAkocmV2aXNpb24gNzg1NDApCisrKyBzcmMvV2ViVmlld0ltcGwuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xMTA2LDM2ICsxMTA2LDQ5IEBACiAgICAgbV9jdXJyZW50SW5wdXRFdmVudCA9ICZp bnB1dEV2ZW50OwogCiAgICAgaWYgKG1fbW91c2VDYXB0dXJlTm9kZS5nZXQoKSAmJiBXZWJJbnB1 dEV2ZW50Ojppc01vdXNlRXZlbnRUeXBlKGlucHV0RXZlbnQudHlwZSkpIHsKLSAgICAgICAgLy8g U2F2ZSBtX21vdXNlQ2FwdHVyZU5vZGUgc2luY2UgbW91c2VDYXB0dXJlTG9zdCgpIHdpbGwgY2xl YXIgaXQuCi0gICAgICAgIFJlZlB0cjxOb2RlPiBub2RlID0gbV9tb3VzZUNhcHR1cmVOb2RlOwot Ci0gICAgICAgIC8vIE5vdCBhbGwgcGxhdGZvcm1zIGNhbGwgbW91c2VDYXB0dXJlTG9zdCgpIGRp cmVjdGx5LgotICAgICAgICBpZiAoaW5wdXRFdmVudC50eXBlID09IFdlYklucHV0RXZlbnQ6Ok1v dXNlVXApCisgICAgICAgIGNvbnN0IGludCBtb3VzZUJ1dHRvbk1vZGlmaWVyTWFzayA9IFdlYklu cHV0RXZlbnQ6OkxlZnRCdXR0b25Eb3duIHwgV2ViSW5wdXRFdmVudDo6TWlkZGxlQnV0dG9uRG93 biB8IFdlYklucHV0RXZlbnQ6OlJpZ2h0QnV0dG9uRG93bjsKKyAgICAgICAgaWYgKGlucHV0RXZl bnQudHlwZSA9PSBXZWJJbnB1dEV2ZW50OjpNb3VzZURvd24gfHwKKyAgICAgICAgICAgIChpbnB1 dEV2ZW50Lm1vZGlmaWVycyAmIG1vdXNlQnV0dG9uTW9kaWZpZXJNYXNrKSA9PSAwKSB7CisgICAg ICAgICAgICAvLyBJdCdzIHBvc3NpYmxlIHRoZSBtb3VzZSB3YXMgcmVsZWFzZWQgYW5kIHdlIGRp ZG4ndCBnZXQgdGhlICJ1cCIKKyAgICAgICAgICAgIC8vIG1lc3NhZ2UuIFRoaXMgY2FuIGhhcHBl biBpZiBhIGRpYWxvZyBwb3BzIHVwIHdoaWxlIHRoZSBtb3VzZSBpcworICAgICAgICAgICAgLy8g aGVsZCwgZm9yIGV4YW1wbGUuIFRoaXMgd2lsbCBsZWF2ZSB1cyAic3R1Y2siIGluIGNhcHR1cmUg bW9kZS4KKyAgICAgICAgICAgIC8vIElmIHdlIGdldCBhIG5ldyBtb3VzZSBkb3duIG1lc3NhZ2Ug b3IgYW55IG90aGVyIG1vdXNlIG1lc3NhZ2UKKyAgICAgICAgICAgIC8vIHdoZXJlIG5vICJkb3du IiBmbGFncyBhcmUgc2V0LCB3ZSBrbm93IHRoZSB1c2VyIGlzIG5vIGxvbmdlcgorICAgICAgICAg ICAgLy8gZHJhZ2dpbmcgYW5kIHdlIGNhbiByZWxlYXNlIHRoZSBjYXB0dXJlIGFuZCBmYWxsIHRo cm91Z2ggdG8gdGhlCisgICAgICAgICAgICAvLyByZWd1bGFyIGV2ZW50IHByb2Nlc3NpbmcuCiAg ICAgICAgICAgICBtb3VzZUNhcHR1cmVMb3N0KCk7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAg ICAgICAvLyBTYXZlIG1fbW91c2VDYXB0dXJlTm9kZSBzaW5jZSBtb3VzZUNhcHR1cmVMb3N0KCkg d2lsbCBjbGVhciBpdC4KKyAgICAgICAgICAgIFJlZlB0cjxOb2RlPiBub2RlID0gbV9tb3VzZUNh cHR1cmVOb2RlOwogCi0gICAgICAgIEF0b21pY1N0cmluZyBldmVudFR5cGU7Ci0gICAgICAgIHN3 aXRjaCAoaW5wdXRFdmVudC50eXBlKSB7Ci0gICAgICAgIGNhc2UgV2ViSW5wdXRFdmVudDo6TW91 c2VNb3ZlOgotICAgICAgICAgICAgZXZlbnRUeXBlID0gZXZlbnROYW1lcygpLm1vdXNlbW92ZUV2 ZW50OwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgV2ViSW5wdXRFdmVudDo6TW91 c2VMZWF2ZToKLSAgICAgICAgICAgIGV2ZW50VHlwZSA9IGV2ZW50TmFtZXMoKS5tb3VzZW91dEV2 ZW50OwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgV2ViSW5wdXRFdmVudDo6TW91 c2VEb3duOgotICAgICAgICAgICAgZXZlbnRUeXBlID0gZXZlbnROYW1lcygpLm1vdXNlZG93bkV2 ZW50OwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgV2ViSW5wdXRFdmVudDo6TW91 c2VVcDoKLSAgICAgICAgICAgIGV2ZW50VHlwZSA9IGV2ZW50TmFtZXMoKS5tb3VzZXVwRXZlbnQ7 Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgZGVmYXVsdDoKLSAgICAgICAgICAgIEFTU0VS VF9OT1RfUkVBQ0hFRCgpOworICAgICAgICAgICAgLy8gTm90IGFsbCBwbGF0Zm9ybXMgY2FsbCBt b3VzZUNhcHR1cmVMb3N0KCkgZGlyZWN0bHkuCisgICAgICAgICAgICBpZiAoaW5wdXRFdmVudC50 eXBlID09IFdlYklucHV0RXZlbnQ6Ok1vdXNlVXApCisgICAgICAgICAgICAgICAgbW91c2VDYXB0 dXJlTG9zdCgpOworCisgICAgICAgICAgICBBdG9taWNTdHJpbmcgZXZlbnRUeXBlOworICAgICAg ICAgICAgc3dpdGNoIChpbnB1dEV2ZW50LnR5cGUpIHsKKyAgICAgICAgICAgIGNhc2UgV2ViSW5w dXRFdmVudDo6TW91c2VNb3ZlOgorICAgICAgICAgICAgICAgIGV2ZW50VHlwZSA9IGV2ZW50TmFt ZXMoKS5tb3VzZW1vdmVFdmVudDsKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAg IGNhc2UgV2ViSW5wdXRFdmVudDo6TW91c2VMZWF2ZToKKyAgICAgICAgICAgICAgICBldmVudFR5 cGUgPSBldmVudE5hbWVzKCkubW91c2VvdXRFdmVudDsKKyAgICAgICAgICAgICAgICBicmVhazsK KyAgICAgICAgICAgIGNhc2UgV2ViSW5wdXRFdmVudDo6TW91c2VEb3duOgorICAgICAgICAgICAg ICAgIGV2ZW50VHlwZSA9IGV2ZW50TmFtZXMoKS5tb3VzZWRvd25FdmVudDsKKyAgICAgICAgICAg ICAgICBicmVhazsKKyAgICAgICAgICAgIGNhc2UgV2ViSW5wdXRFdmVudDo6TW91c2VVcDoKKyAg ICAgICAgICAgICAgICBldmVudFR5cGUgPSBldmVudE5hbWVzKCkubW91c2V1cEV2ZW50OworICAg ICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgZGVmYXVsdDoKKyAgICAgICAgICAgICAg ICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgICAgIH0KKworICAgICAgICAgICAgbm9k ZS0+ZGlzcGF0Y2hNb3VzZUV2ZW50KAorICAgICAgICAgICAgICAgICAgUGxhdGZvcm1Nb3VzZUV2 ZW50QnVpbGRlcihtYWluRnJhbWVJbXBsKCktPmZyYW1lVmlldygpLCAqc3RhdGljX2Nhc3Q8Y29u c3QgV2ViTW91c2VFdmVudCo+KCZpbnB1dEV2ZW50KSksCisgICAgICAgICAgICAgICAgICBldmVu dFR5cGUsIHN0YXRpY19jYXN0PGNvbnN0IFdlYk1vdXNlRXZlbnQqPigmaW5wdXRFdmVudCktPmNs aWNrQ291bnQpOworICAgICAgICAgICAgbV9jdXJyZW50SW5wdXRFdmVudCA9IDA7CisgICAgICAg ICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgfQotCi0gICAgICAgIG5vZGUtPmRpc3BhdGNoTW91 c2VFdmVudCgKLSAgICAgICAgICAgICAgUGxhdGZvcm1Nb3VzZUV2ZW50QnVpbGRlcihtYWluRnJh bWVJbXBsKCktPmZyYW1lVmlldygpLCAqc3RhdGljX2Nhc3Q8Y29uc3QgV2ViTW91c2VFdmVudCo+ KCZpbnB1dEV2ZW50KSksCi0gICAgICAgICAgICAgIGV2ZW50VHlwZSwgc3RhdGljX2Nhc3Q8Y29u c3QgV2ViTW91c2VFdmVudCo+KCZpbnB1dEV2ZW50KS0+Y2xpY2tDb3VudCk7Ci0gICAgICAgIG1f Y3VycmVudElucHV0RXZlbnQgPSAwOwotICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKICAg ICBib29sIGhhbmRsZWQgPSB0cnVlOwpJbmRleDogQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIENo YW5nZUxvZwkocmV2aXNpb24gNzg2MzApCisrKyBDaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxNCBAQAorMjAxMS0wMi0xNSAgQnJldHQgV2lsc29uICA8YnJldHR3QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS ZWNvdmVyIHRoZSBtb3VzZSBjYXB0dXJlIHN0YXRlIHdoZW4gd2UgcmVjaWV2ZSBhIG1vdXNlIGV2 ZW50IHdoZXJlIHRoZXJlIGlzIG5vIGxvbmdlciBhIGJ1dHRvbiBkb3duLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ1MDMKKworCisgICAgICAgICog c3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OmhhbmRs ZUlucHV0RXZlbnQpOgorCiAyMDExLTAyLTE1ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCg==