54502 2011-02-15 15:26:58 -0800 media/audio-delete-while-slider-thumb-clicked.html failing on Windows since r78562 2011-02-16 05:55:02 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC Windows 7 RESOLVED FIXED LayoutTestFailure, PlatformOnly, Regression P2 Normal --- 1 sfalken webkit-unassigned aroben pnormand oldest_to_newest 351650 0 sfalken 2011-02-15 15:26:58 -0800 media/audio-delete-while-slider-thumb-clicked.html failing on Windows since r78562. Change http://trac.webkit.org/changeset/78562 refactored the test to use oncanplaythrough. This caused the test to fail on Windows. 351660 1 sfalken 2011-02-15 15:34:36 -0800 Failure message: CONSOLE MESSAGE: line 38: TypeError: 'null' is not an object (evaluating 'audio.parentNode') 351681 2 aroben 2011-02-15 15:53:51 -0800 We normally check in Windows-specific expected failing results in cases like this where the test fails the same way every time and isn't crashing or timing out. That way we can notice when the behavior of the test changes (e.g., if someone fixes it). 351955 3 82607 pnormand 2011-02-16 03:05:16 -0800 Created attachment 82607 proposed patch 351957 4 pnormand 2011-02-16 03:06:43 -0800 Can someone on Windows please try this patch? I think the seeking event was triggered twice so the test tried to delete the audio element twice, leading to that "undefined" error. 351991 5 82607 aroben 2011-02-16 05:00:21 -0800 Comment on attachment 82607 proposed patch This fixes the test on Windows for me. Please remove the test from LayoutTests/platform/win/Skipped, too. 352012 6 pnormand 2011-02-16 05:55:02 -0800 Committed r78701: <http://trac.webkit.org/changeset/78701> 82607 2011-02-16 03:05:16 -0800 2011-02-16 05:00:21 -0800 proposed patch proposed-patch.patch text/plain 1761 pnormand RnJvbSA0MDYzNmQ1ZGM3MWZiYzczYzQyM2U1MDQ4NWIyNTg4ZjkwYjZmYTliIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDE2IEZlYiAyMDExIDEyOjA2OjQwICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDEwICsrKysrKysrKysKIC4uLi9hdWRpby1kZWxldGUtd2hpbGUt c2xpZGVyLXRodW1iLWNsaWNrZWQuaHRtbCAgIHwgICAgNSArKysrLQogMiBmaWxlcyBjaGFuZ2Vk LCAxNCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBhOTE0NzE3Li44MTNk MDVmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDItMTYgIFBoaWxpcHBlIE5vcm1hbmQg IDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIG1lZGlhL2F1ZGlvLWRlbGV0ZS13aGlsZS1zbGlkZXItdGh1bWItY2xp Y2tlZC5odG1sIGZhaWxpbmcgb24gV2luZG93cyBzaW5jZSByNzg1NjIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0NTAyCisKKyAgICAgICAgKiBtZWRp YS9hdWRpby1kZWxldGUtd2hpbGUtc2xpZGVyLXRodW1iLWNsaWNrZWQuaHRtbDogQXZvaWQgZGVs ZXRpbmcgdGhlIGVsZW1lbnQgdHdpY2UuCisKKwogMjAxMS0wMi0xNSAgS2VudCBUYW11cmEgIDx0 a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgdGVzdCBleHBlY3RhdGlv biB1cGRhdGUuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS9hdWRpby1kZWxldGUtd2hp bGUtc2xpZGVyLXRodW1iLWNsaWNrZWQuaHRtbCBiL0xheW91dFRlc3RzL21lZGlhL2F1ZGlvLWRl bGV0ZS13aGlsZS1zbGlkZXItdGh1bWItY2xpY2tlZC5odG1sCmluZGV4IGU3ZTJiZGMuLjk3ODY2 YzkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL21lZGlhL2F1ZGlvLWRlbGV0ZS13aGlsZS1zbGlk ZXItdGh1bWItY2xpY2tlZC5odG1sCisrKyBiL0xheW91dFRlc3RzL21lZGlhL2F1ZGlvLWRlbGV0 ZS13aGlsZS1zbGlkZXItdGh1bWItY2xpY2tlZC5odG1sCkBAIC0zMiw5ICszMiwxMiBAQAogICAg ICAgICAgICAgCiAgICAgICAgICAgICBmdW5jdGlvbiBkZWxldGVBdWRpbygpCiAgICAgICAgICAg ICB7CisgICAgICAgICAgICAgICAgdmFyIGF1ZGlvID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo J2F1ZGlvJyk7CisgICAgICAgICAgICAgICAgaWYgKCFhdWRpbykKKyAgICAgICAgICAgICAgICAg ICAgcmV0dXJuOworCiAgICAgICAgICAgICAgICAgLy8gZGVsZXRlIHRoZSBzZWFyY2gKICAgICAg ICAgICAgICAgICBsb2coIjxicj5kZWxldGluZyBhdWRpbyBlbGVtZW50Iik7Ci0gICAgICAgICAg ICAgICAgdmFyIGF1ZGlvID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2F1ZGlvJyk7CiAgICAg ICAgICAgICAgICAgYXVkaW8ucGFyZW50Tm9kZS5yZW1vdmVDaGlsZChhdWRpbyk7CiAKICAgICAg ICAgICAgICAgICBzZXRUaW1lb3V0KGJ1dHRvbkNsaWNrLCAxMCk7Ci0tIAoxLjcuMi4z