54498 2011-02-15 14:50:05 -0800 Layers stick around in DrawingAreaImpl until we switch out of compositing 2011-02-15 15:02:01 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser andersca simon.fraser oldest_to_newest 351603 0 simon.fraser 2011-02-15 14:50:05 -0800 If DrawingAreaImpl delays its exit from compositing (say if you change m_exitCompositingTimer.startOneShot() to use 3 seconds), then compositing layers stick around for that time, even after they should have been hidden. 351610 1 82527 simon.fraser 2011-02-15 14:56:42 -0800 Created attachment 82527 Patch 351614 2 82527 darin 2011-02-15 14:57:50 -0800 Comment on attachment 82527 Patch Does this mean we’ll see something different onscreen at the moment setRootCompositingLayer is called? 351621 3 simon.fraser 2011-02-15 15:00:44 -0800 I think the zero-delay timer masked this issue, or at least just caused one frame of badness. 351623 4 simon.fraser 2011-02-15 15:02:01 -0800 http://trac.webkit.org/changeset/78623 82527 2011-02-15 14:56:42 -0800 2011-02-15 14:57:49 -0800 Patch bug-54498-20110215145641.patch text/plain 2563 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogNzg2MTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAyMzE4N2Y2ZjkxYzVjN2Q1 Nzc2ZTg5NzZjYzQzZDEyZjIzNzk0Yzc0Li40ZTk2YmVkNDU0YTQ2OTdjNTM2MDU4OWRjOTIwYTE2 NmMzMzE3NzA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDItMTUgIFNpbW9u IEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGF5ZXJzIHN0aWNrIGFyb3VuZCBpbiBEcmF3aW5n QXJlYUltcGwgdW50aWwgd2Ugc3dpdGNoIG91dCBvZiBjb21wb3NpdGluZworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ0OTgKKyAgICAgICAgCisgICAg ICAgIFdoZW4gbGVhdmluZyBjb21wb3NpdGluZyBtb2RlIHNvb24sIHJlbW92ZSBhbGwgdGhlIGNo aWxkIGxheWVycworICAgICAgICBvZiB0aGUgbm9uQ29tcG9zaXRlZENvbnRlbnQgbGF5ZXIgcmln aHQgYXdheSwgc28gdGhleSBkb24ndCBzdGljaworICAgICAgICBhcm91bmQuCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmNwcDoKKyAgICAgICAgKFdlYktp dDo6RHJhd2luZ0FyZWFJbXBsOjpzZXRSb290Q29tcG9zaXRpbmdMYXllcik6CisgICAgICAgICog V2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9MYXllclRyZWVIb3N0TWFjLm1tOgorICAgICAgICAoV2Vi S2l0OjpMYXllclRyZWVIb3N0TWFjOjpzZXRSb290Q29tcG9zaXRpbmdMYXllcik6CisKIDIwMTEt MDItMTUgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmNwcAppbmRleCBjMGNkZjVjNmVlODgxNWFlYTI3 NWY0ZTlmZTJkZWQ1ZjI1YTVhMDNjLi4yMjgyZTAxZDEyNzYzZDk5YmY0YWJlODBkYzNhOWM3NGEx YmM5NjNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJh d2luZ0FyZWFJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv RHJhd2luZ0FyZWFJbXBsLmNwcApAQCAtMTkzLDYgKzE5Myw3IEBAIHZvaWQgRHJhd2luZ0FyZWFJ bXBsOjpzZXRSb290Q29tcG9zaXRpbmdMYXllcihHcmFwaGljc0xheWVyKiBncmFwaGljc0xheWVy KQogICAgICAgICBpZiAobV9sYXllclRyZWVIb3N0KSB7CiAgICAgICAgICAgICAvLyBXZSdsbCBl eGl0IGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIG1vZGUgb24gYSB0aW1lciwgdG8gYXZvaWQgcmUt ZW50ZXJpbmcKICAgICAgICAgICAgIC8vIGNvbXBvc2l0aW5nIGNvZGUgdmlhIGRpc3BsYXkoKSBh bmQgbGF5b3V0LgorICAgICAgICAgICAgbV9sYXllclRyZWVIb3N0LT5zZXRSb290Q29tcG9zaXRp bmdMYXllcigwKTsKICAgICAgICAgICAgIGV4aXRBY2NlbGVyYXRlZENvbXBvc2l0aW5nTW9kZVNv b24oKTsKICAgICAgICAgfQogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9tYWMvTGF5ZXJUcmVlSG9zdE1hYy5tbSBiL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9tYWMvTGF5ZXJUcmVlSG9zdE1hYy5tbQppbmRleCA5NzM0YWVjNDFm MzQ3NzNmMzE5ZjY0NzIwOGU4ZWQ4OTQ4NGEyNGJiLi4yNGNjNjJkODg4NmU1YWQxNDVkNTZmYWJj Yjc4M2ZhN2YyZTk4MzhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvbWFjL0xheWVyVHJlZUhvc3RNYWMubW0KKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL21hYy9MYXllclRyZWVIb3N0TWFjLm1tCkBAIC0xMTgsMTIgKzExOCwxMSBA QCB2b2lkIExheWVyVHJlZUhvc3RNYWM6OnNjaGVkdWxlTGF5ZXJGbHVzaCgpCiAKIHZvaWQgTGF5 ZXJUcmVlSG9zdE1hYzo6c2V0Um9vdENvbXBvc2l0aW5nTGF5ZXIoR3JhcGhpY3NMYXllciogZ3Jh cGhpY3NMYXllcikKIHsKLSAgICBBU1NFUlQoZ3JhcGhpY3NMYXllcik7Ci0KICAgICBtX25vbkNv bXBvc2l0ZWRDb250ZW50TGF5ZXItPnJlbW92ZUFsbENoaWxkcmVuKCk7CiAKICAgICAvLyBBZGQg dGhlIGFjY2VsZXJhdGVkIGxheWVyIHRyZWUgaGllcmFyY2h5LgotICAgIG1fbm9uQ29tcG9zaXRl ZENvbnRlbnRMYXllci0+YWRkQ2hpbGQoZ3JhcGhpY3NMYXllcik7CisgICAgaWYgKGdyYXBoaWNz TGF5ZXIpCisgICAgICAgIG1fbm9uQ29tcG9zaXRlZENvbnRlbnRMYXllci0+YWRkQ2hpbGQoZ3Jh cGhpY3NMYXllcik7CiB9CiAKIHZvaWQgTGF5ZXJUcmVlSG9zdE1hYzo6aW52YWxpZGF0ZSgpCg==