54497 2011-02-15 14:43:13 -0800 [chromium] Canvas-2D-GPU fails on clearRect() w/identity transform and non-full-canvas rectangle 2011-02-15 15:17:28 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco jamesr kbr oldest_to_newest 351595 0 senorblanco 2011-02-15 14:43:13 -0800 [chromium] Canvas-2D-GPU fails on clearRect() w/identity transform and non-full-canvas rectangle 351597 1 82523 senorblanco 2011-02-15 14:43:42 -0800 Created attachment 82523 Patch 351598 2 senorblanco 2011-02-15 14:45:26 -0800 See fast/canvas/canvas-strokeRect.html. 351602 3 82523 jamesr 2011-02-15 14:48:36 -0800 Comment on attachment 82523 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82523&action=review R- for the changelog, but code looks good. Is there a test_expectations.txt line we could flip for this test? > Source/WebCore/ChangeLog:8 > + When doing GPU-Canvas2D clearRect() using the fast path (glClear()), > + we were not correctly converting from canvas to screen coordinates. > + Fixed by inverting the rectangle in Y, and changing > + SharedGraphicsContext3D::scissor to take glScissor-like parameters. need a link to the bug in the ChangeLog 351604 4 82525 senorblanco 2011-02-15 14:51:03 -0800 Created attachment 82525 Patch 351606 5 82525 jamesr 2011-02-15 14:52:31 -0800 Comment on attachment 82525 Patch R=me but please see if there's anything in test_expectations.txt that can ensure this change is covered by our bots. 351617 6 senorblanco 2011-02-15 14:58:42 -0800 (In reply to comment #5) > (From update of attachment 82525 [details]) > R=me but please see if there's anything in test_expectations.txt that can ensure this change is covered by our bots. Yes, fast/canvas/canvas-strokeRect.html covers it. I'll add that to the CL. 351622 7 jamesr 2011-02-15 15:01:12 -0800 (In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 82525 [details] [details]) > > R=me but please see if there's anything in test_expectations.txt that can ensure this change is covered by our bots. > > Yes, fast/canvas/canvas-strokeRect.html covers it. I'll add that to the CL. Are we running that test right now and failing it, is it marked as an expected failure, or do we not run this test in any configuration that would catch this failure? 351624 8 senorblanco 2011-02-15 15:02:16 -0800 (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > (From update of attachment 82525 [details] [details] [details]) > > > R=me but please see if there's anything in test_expectations.txt that can ensure this change is covered by our bots. > > > > Yes, fast/canvas/canvas-strokeRect.html covers it. I'll add that to the CL. > > Are we running that test right now and failing it, is it marked as an expected failure, or do we not run this test in any configuration that would catch this failure? Yes, we're running it now, and it's marked as an expected failure (GPU only). That's how I found this bug. :) 351636 9 82532 senorblanco 2011-02-15 15:10:27 -0800 Created attachment 82532 Patch 351637 10 82532 jamesr 2011-02-15 15:12:44 -0800 Comment on attachment 82532 Patch Sweet! 351641 11 senorblanco 2011-02-15 15:17:28 -0800 Committed r78625: <http://trac.webkit.org/changeset/78625> 82523 2011-02-15 14:43:42 -0800 2011-02-15 14:50:59 -0800 Patch bug-54497-20110215174341.patch text/plain 3228 senorblanco SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NjE0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDItMTUgIFN0ZXBoZW4g V2hpdGUgIDxzZW5vcmJsYW5jb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBkb2luZyBHUFUtQ2FudmFzMkQgY2xlYXJS ZWN0KCkgdXNpbmcgdGhlIGZhc3QgcGF0aCAoZ2xDbGVhcigpKSwKKyAgICAgICAgd2Ugd2VyZSBu b3QgY29ycmVjdGx5IGNvbnZlcnRpbmcgZnJvbSBjYW52YXMgdG8gc2NyZWVuIGNvb3JkaW5hdGVz LiAKKyAgICAgICAgRml4ZWQgYnkgaW52ZXJ0aW5nIHRoZSByZWN0YW5nbGUgaW4gWSwgYW5kIGNo YW5naW5nCisgICAgICAgIFNoYXJlZEdyYXBoaWNzQ29udGV4dDNEOjpzY2lzc29yIHRvIHRha2Ug Z2xTY2lzc29yLWxpa2UgcGFyYW1ldGVycy4KKworICAgICAgICBDb3ZlcmVkIGJ5IGZhc3QvY2Fu dmFzL2NhbnZhcy1zdHJva2VSZWN0Lmh0bWwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9HTEVTMkNhbnZhcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHTEVTMkNhbnZh czo6Y2xlYXJSZWN0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ncHUvU2hhcmVkR3Jh cGhpY3NDb250ZXh0M0QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2hhcmVkR3JhcGhpY3NDb250 ZXh0M0Q6OnNjaXNzb3IpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dwdS9TaGFyZWRH cmFwaGljc0NvbnRleHQzRC5oOgorCiAyMDExLTAyLTE1ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9i aW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9HTEVTMkNhbnZhcy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vR0xFUzJDYW52YXMuY3BwCShyZXZpc2lvbiA3ODYxNCkKKysrIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0dMRVMyQ2FudmFzLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTkxLDcgKzE5MSw3IEBAIHZvaWQgR0xFUzJDYW52YXM6OmNsZWFyUmVjdChjb25zdCBGbG9h dFIKIHsKICAgICBiaW5kRnJhbWVidWZmZXIoKTsKICAgICBpZiAobV9zdGF0ZS0+bV9jdG0uaXNJ ZGVudGl0eSgpICYmICFtX3N0YXRlLT5tX2NsaXBwaW5nRW5hYmxlZCkgewotICAgICAgICBtX2Nv bnRleHQtPnNjaXNzb3IocmVjdCk7CisgICAgICAgIG1fY29udGV4dC0+c2Npc3NvcihyZWN0Lngo KSwgbV9zaXplLmhlaWdodCgpIC0gcmVjdC5oZWlnaHQoKSAtIHJlY3QueSgpLCByZWN0LndpZHRo KCksIHJlY3QuaGVpZ2h0KCkpOwogICAgICAgICBtX2NvbnRleHQtPmVuYWJsZShHcmFwaGljc0Nv bnRleHQzRDo6U0NJU1NPUl9URVNUKTsKICAgICAgICAgbV9jb250ZXh0LT5jbGVhckNvbG9yKENv bG9yKFJHQkEzMigwKSkpOwogICAgICAgICBtX2NvbnRleHQtPmNsZWFyKEdyYXBoaWNzQ29udGV4 dDNEOjpDT0xPUl9CVUZGRVJfQklUKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2dwdS9TaGFyZWRHcmFwaGljc0NvbnRleHQzRC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1NoYXJlZEdyYXBoaWNzQ29udGV4dDNE LmNwcAkocmV2aXNpb24gNzg2MTQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9ncHUvU2hhcmVkR3JhcGhpY3NDb250ZXh0M0QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05NCw5 ICs5NCw5IEBAIHZvaWQgU2hhcmVkR3JhcGhpY3NDb250ZXh0M0Q6Om1ha2VDb250ZXgKICAgICBt X2NvbnRleHQtPm1ha2VDb250ZXh0Q3VycmVudCgpOwogfQogCi12b2lkIFNoYXJlZEdyYXBoaWNz Q29udGV4dDNEOjpzY2lzc29yKGNvbnN0IEZsb2F0UmVjdCYgcmVjdCkKK3ZvaWQgU2hhcmVkR3Jh cGhpY3NDb250ZXh0M0Q6OnNjaXNzb3IoR0MzRGludCB4LCBHQzNEaW50IHksIEdDM0RzaXplaSB3 aWR0aCwgR0MzRHNpemVpIGhlaWdodCkKIHsKLSAgICBtX2NvbnRleHQtPnNjaXNzb3IocmVjdC54 KCksIHJlY3QueSgpLCByZWN0LndpZHRoKCksIHJlY3QuaGVpZ2h0KCkpOworICAgIG1fY29udGV4 dC0+c2Npc3Nvcih4LCB5LCB3aWR0aCwgaGVpZ2h0KTsKIH0KIAogdm9pZCBTaGFyZWRHcmFwaGlj c0NvbnRleHQzRDo6ZW5hYmxlKEdDM0RlbnVtIGNhcGFjaXR5KQpJbmRleDogU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1NoYXJlZEdyYXBoaWNzQ29udGV4dDNELmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1NoYXJlZEdyYXBo aWNzQ29udGV4dDNELmgJKHJldmlzaW9uIDc4NjE0KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3B1L1NoYXJlZEdyYXBoaWNzQ29udGV4dDNELmgJKHdvcmtpbmcgY29weSkK QEAgLTYzLDcgKzYzLDcgQEAgcHVibGljOgogICAgIHZvaWQgbWFrZUNvbnRleHRDdXJyZW50KCk7 CiAgICAgdm9pZCBiaW5kRnJhbWVidWZmZXIoUGxhdGZvcm0zRE9iamVjdCBmcmFtZWJ1ZmZlcik7 CiAgICAgdm9pZCBzZXRWaWV3cG9ydChjb25zdCBJbnRTaXplJik7Ci0gICAgdm9pZCBzY2lzc29y KGNvbnN0IEZsb2F0UmVjdCYpOworICAgIHZvaWQgc2Npc3NvcihHQzNEaW50IHgsIEdDM0RpbnQg eSwgR0MzRHNpemVpIHdpZHRoLCBHQzNEc2l6ZWkgaGVpZ2h0KTsKICAgICB2b2lkIGVuYWJsZShH QzNEZW51bSBjYXBhY2l0eSk7CiAgICAgdm9pZCBkaXNhYmxlKEdDM0RlbnVtIGNhcGFjaXR5KTsK ICAgICB2b2lkIGNsZWFyQ29sb3IoY29uc3QgQ29sb3ImKTsK 82525 2011-02-15 14:51:03 -0800 2011-02-15 15:10:23 -0800 Patch bug-54497-20110215175102.patch text/plain 3353 senorblanco SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NjE0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDItMTUgIFN0ZXBoZW4g V2hpdGUgIDxzZW5vcmJsYW5jb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBjbGVhclJlY3QoKSBpbmNvcnJl Y3QgaW4gYWNjZWxlcmF0ZWQgMkQgY2FudmFzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ0OTcKKworICAgICAgICBXaGVuIGRvaW5nIEdQVS1DYW52 YXMyRCBjbGVhclJlY3QoKSB1c2luZyB0aGUgZmFzdCBwYXRoIChnbENsZWFyKCkpLAorICAgICAg ICB3ZSB3ZXJlIG5vdCBjb3JyZWN0bHkgY29udmVydGluZyBmcm9tIGNhbnZhcyB0byBzY3JlZW4g Y29vcmRpbmF0ZXMuIAorICAgICAgICBGaXhlZCBieSBpbnZlcnRpbmcgdGhlIHJlY3RhbmdsZSBp biBZLCBhbmQgY2hhbmdpbmcKKyAgICAgICAgU2hhcmVkR3JhcGhpY3NDb250ZXh0M0Q6OnNjaXNz b3IgdG8gdGFrZSBnbFNjaXNzb3ItbGlrZSBwYXJhbWV0ZXJzLgorCisgICAgICAgIENvdmVyZWQg YnkgZmFzdC9jYW52YXMvY2FudmFzLXN0cm9rZVJlY3QuaHRtbC4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL0dMRVMyQ2FudmFzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkdMRVMyQ2FudmFzOjpjbGVhclJlY3QpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dw dS9TaGFyZWRHcmFwaGljc0NvbnRleHQzRC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaGFyZWRH cmFwaGljc0NvbnRleHQzRDo6c2Npc3Nvcik6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv Z3B1L1NoYXJlZEdyYXBoaWNzQ29udGV4dDNELmg6CisKIDIwMTEtMDItMTUgIE1hcnRpbiBSb2Jp bnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFhhbiBM b3Blei4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0dM RVMyQ2FudmFzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9HTEVTMkNhbnZhcy5jcHAJKHJldmlzaW9uIDc4NjE0KQorKysgU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vR0xFUzJDYW52YXMuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xOTEsNyArMTkxLDcgQEAgdm9pZCBHTEVTMkNhbnZhczo6Y2xlYXJSZWN0 KGNvbnN0IEZsb2F0UgogewogICAgIGJpbmRGcmFtZWJ1ZmZlcigpOwogICAgIGlmIChtX3N0YXRl LT5tX2N0bS5pc0lkZW50aXR5KCkgJiYgIW1fc3RhdGUtPm1fY2xpcHBpbmdFbmFibGVkKSB7Ci0g ICAgICAgIG1fY29udGV4dC0+c2Npc3NvcihyZWN0KTsKKyAgICAgICAgbV9jb250ZXh0LT5zY2lz c29yKHJlY3QueCgpLCBtX3NpemUuaGVpZ2h0KCkgLSByZWN0LmhlaWdodCgpIC0gcmVjdC55KCks IHJlY3Qud2lkdGgoKSwgcmVjdC5oZWlnaHQoKSk7CiAgICAgICAgIG1fY29udGV4dC0+ZW5hYmxl KEdyYXBoaWNzQ29udGV4dDNEOjpTQ0lTU09SX1RFU1QpOwogICAgICAgICBtX2NvbnRleHQtPmNs ZWFyQ29sb3IoQ29sb3IoUkdCQTMyKDApKSk7CiAgICAgICAgIG1fY29udGV4dC0+Y2xlYXIoR3Jh cGhpY3NDb250ZXh0M0Q6OkNPTE9SX0JVRkZFUl9CSVQpOwpJbmRleDogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1NoYXJlZEdyYXBoaWNzQ29udGV4dDNELmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvU2hhcmVkR3JhcGhp Y3NDb250ZXh0M0QuY3BwCShyZXZpc2lvbiA3ODYxNCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dwdS9TaGFyZWRHcmFwaGljc0NvbnRleHQzRC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTk0LDkgKzk0LDkgQEAgdm9pZCBTaGFyZWRHcmFwaGljc0NvbnRleHQzRDo6bWFrZUNv bnRleAogICAgIG1fY29udGV4dC0+bWFrZUNvbnRleHRDdXJyZW50KCk7CiB9CiAKLXZvaWQgU2hh cmVkR3JhcGhpY3NDb250ZXh0M0Q6OnNjaXNzb3IoY29uc3QgRmxvYXRSZWN0JiByZWN0KQordm9p ZCBTaGFyZWRHcmFwaGljc0NvbnRleHQzRDo6c2Npc3NvcihHQzNEaW50IHgsIEdDM0RpbnQgeSwg R0MzRHNpemVpIHdpZHRoLCBHQzNEc2l6ZWkgaGVpZ2h0KQogewotICAgIG1fY29udGV4dC0+c2Np c3NvcihyZWN0LngoKSwgcmVjdC55KCksIHJlY3Qud2lkdGgoKSwgcmVjdC5oZWlnaHQoKSk7Cisg ICAgbV9jb250ZXh0LT5zY2lzc29yKHgsIHksIHdpZHRoLCBoZWlnaHQpOwogfQogCiB2b2lkIFNo YXJlZEdyYXBoaWNzQ29udGV4dDNEOjplbmFibGUoR0MzRGVudW0gY2FwYWNpdHkpCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvU2hhcmVkR3JhcGhpY3NDb250ZXh0 M0QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUv U2hhcmVkR3JhcGhpY3NDb250ZXh0M0QuaAkocmV2aXNpb24gNzg2MTQpCisrKyBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvU2hhcmVkR3JhcGhpY3NDb250ZXh0M0QuaAkod29y a2luZyBjb3B5KQpAQCAtNjMsNyArNjMsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBtYWtlQ29udGV4 dEN1cnJlbnQoKTsKICAgICB2b2lkIGJpbmRGcmFtZWJ1ZmZlcihQbGF0Zm9ybTNET2JqZWN0IGZy YW1lYnVmZmVyKTsKICAgICB2b2lkIHNldFZpZXdwb3J0KGNvbnN0IEludFNpemUmKTsKLSAgICB2 b2lkIHNjaXNzb3IoY29uc3QgRmxvYXRSZWN0Jik7CisgICAgdm9pZCBzY2lzc29yKEdDM0RpbnQg eCwgR0MzRGludCB5LCBHQzNEc2l6ZWkgd2lkdGgsIEdDM0RzaXplaSBoZWlnaHQpOwogICAgIHZv aWQgZW5hYmxlKEdDM0RlbnVtIGNhcGFjaXR5KTsKICAgICB2b2lkIGRpc2FibGUoR0MzRGVudW0g Y2FwYWNpdHkpOwogICAgIHZvaWQgY2xlYXJDb2xvcihjb25zdCBDb2xvciYpOwo= 82532 2011-02-15 15:10:27 -0800 2011-02-15 15:12:44 -0800 Patch bug-54497-20110215181025.patch text/plain 4863 senorblanco SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NjIzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTEtMDItMTUgIFN0ZXBoZW4g V2hpdGUgIDxzZW5vcmJsYW5jb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisgCisgICAgICAgIFtjaHJvbWl1bV0gY2xlYXJSZWN0KCkgaXMgaW5j b3JyZWN0IGluIGFjY2VsZXJhdGVkIDJEIGNhbnZhcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0NDk3CisKKyAgICAgICAgV2hlbiBkb2luZyBHUFUt Q2FudmFzMkQgY2xlYXJSZWN0KCkgdXNpbmcgdGhlIGZhc3QgcGF0aCAoZ2xDbGVhcigpKSwKKyAg ICAgICAgd2Ugd2VyZSBub3QgY29ycmVjdGx5IGNvbnZlcnRpbmcgZnJvbSBjYW52YXMgdG8gc2Ny ZWVuIGNvb3JkaW5hdGVzLiAKKyAgICAgICAgRml4ZWQgYnkgaW52ZXJ0aW5nIHRoZSByZWN0YW5n bGUgaW4gWSwgYW5kIGNoYW5naW5nCisgICAgICAgIFNoYXJlZEdyYXBoaWNzQ29udGV4dDNEOjpz Y2lzc29yIHRvIHRha2UgZ2xTY2lzc29yLWxpa2UgcGFyYW1ldGVycy4KKworICAgICAgICBDb3Zl cmVkIGJ5IGZhc3QvY2FudmFzL2NhbnZhcy1zdHJva2VSZWN0Lmh0bWwuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9HTEVTMkNhbnZhcy5jcHA6CisgICAgICAgIChXZWJD b3JlOjpHTEVTMkNhbnZhczo6Y2xlYXJSZWN0KToKKyAgICAgICAgRmxpcCB0aGUgWSBjb29yZCBv ZiB0aGUgcmVjdGFuZ2xlIHBhc3NlZCB0byBzY2lzc29yKCkuCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvZ3B1L1NoYXJlZEdyYXBoaWNzQ29udGV4dDNELmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlNoYXJlZEdyYXBoaWNzQ29udGV4dDNEOjpzY2lzc29yKToKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9ncHUvU2hhcmVkR3JhcGhpY3NDb250ZXh0M0QuaDoKKyAgICAgICAgR2l2ZSBz Y2lzc29yKCkgdGhlIHNhbWUgcGFyYW0gdHlwZXMgYXMgR3JhcGhpY3NDb250ZXh0M0Q6OnNjaXNz b3IoKS4KKwogMjAxMS0wMi0xNSAgUHJhdGlrIFNvbGFua2kgIDxwc29sYW5raUBhcHBsZS5jb20+ CiAKICAgICAgICAgTW92ZSBXVEZfVVNFX0NGTkVUV09SSyB0byBQbGF0Zm9ybS5oCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9HTEVTMkNhbnZhcy5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v R0xFUzJDYW52YXMuY3BwCShyZXZpc2lvbiA3ODYyMykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL0dMRVMyQ2FudmFzLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTkxLDcgKzE5MSw3IEBAIHZvaWQgR0xFUzJDYW52YXM6OmNsZWFyUmVjdChjb25zdCBGbG9hdFIK IHsKICAgICBiaW5kRnJhbWVidWZmZXIoKTsKICAgICBpZiAobV9zdGF0ZS0+bV9jdG0uaXNJZGVu dGl0eSgpICYmICFtX3N0YXRlLT5tX2NsaXBwaW5nRW5hYmxlZCkgewotICAgICAgICBtX2NvbnRl eHQtPnNjaXNzb3IocmVjdCk7CisgICAgICAgIG1fY29udGV4dC0+c2Npc3NvcihyZWN0LngoKSwg bV9zaXplLmhlaWdodCgpIC0gcmVjdC5oZWlnaHQoKSAtIHJlY3QueSgpLCByZWN0LndpZHRoKCks IHJlY3QuaGVpZ2h0KCkpOwogICAgICAgICBtX2NvbnRleHQtPmVuYWJsZShHcmFwaGljc0NvbnRl eHQzRDo6U0NJU1NPUl9URVNUKTsKICAgICAgICAgbV9jb250ZXh0LT5jbGVhckNvbG9yKENvbG9y KFJHQkEzMigwKSkpOwogICAgICAgICBtX2NvbnRleHQtPmNsZWFyKEdyYXBoaWNzQ29udGV4dDNE OjpDT0xPUl9CVUZGRVJfQklUKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2dwdS9TaGFyZWRHcmFwaGljc0NvbnRleHQzRC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1NoYXJlZEdyYXBoaWNzQ29udGV4dDNELmNw cAkocmV2aXNpb24gNzg2MjMpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n cHUvU2hhcmVkR3JhcGhpY3NDb250ZXh0M0QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05NCw5ICs5 NCw5IEBAIHZvaWQgU2hhcmVkR3JhcGhpY3NDb250ZXh0M0Q6Om1ha2VDb250ZXgKICAgICBtX2Nv bnRleHQtPm1ha2VDb250ZXh0Q3VycmVudCgpOwogfQogCi12b2lkIFNoYXJlZEdyYXBoaWNzQ29u dGV4dDNEOjpzY2lzc29yKGNvbnN0IEZsb2F0UmVjdCYgcmVjdCkKK3ZvaWQgU2hhcmVkR3JhcGhp Y3NDb250ZXh0M0Q6OnNjaXNzb3IoR0MzRGludCB4LCBHQzNEaW50IHksIEdDM0RzaXplaSB3aWR0 aCwgR0MzRHNpemVpIGhlaWdodCkKIHsKLSAgICBtX2NvbnRleHQtPnNjaXNzb3IocmVjdC54KCks IHJlY3QueSgpLCByZWN0LndpZHRoKCksIHJlY3QuaGVpZ2h0KCkpOworICAgIG1fY29udGV4dC0+ c2Npc3Nvcih4LCB5LCB3aWR0aCwgaGVpZ2h0KTsKIH0KIAogdm9pZCBTaGFyZWRHcmFwaGljc0Nv bnRleHQzRDo6ZW5hYmxlKEdDM0RlbnVtIGNhcGFjaXR5KQpJbmRleDogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1NoYXJlZEdyYXBoaWNzQ29udGV4dDNELmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1NoYXJlZEdyYXBoaWNz Q29udGV4dDNELmgJKHJldmlzaW9uIDc4NjIzKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZ3B1L1NoYXJlZEdyYXBoaWNzQ29udGV4dDNELmgJKHdvcmtpbmcgY29weSkKQEAg LTYzLDcgKzYzLDcgQEAgcHVibGljOgogICAgIHZvaWQgbWFrZUNvbnRleHRDdXJyZW50KCk7CiAg ICAgdm9pZCBiaW5kRnJhbWVidWZmZXIoUGxhdGZvcm0zRE9iamVjdCBmcmFtZWJ1ZmZlcik7CiAg ICAgdm9pZCBzZXRWaWV3cG9ydChjb25zdCBJbnRTaXplJik7Ci0gICAgdm9pZCBzY2lzc29yKGNv bnN0IEZsb2F0UmVjdCYpOworICAgIHZvaWQgc2Npc3NvcihHQzNEaW50IHgsIEdDM0RpbnQgeSwg R0MzRHNpemVpIHdpZHRoLCBHQzNEc2l6ZWkgaGVpZ2h0KTsKICAgICB2b2lkIGVuYWJsZShHQzNE ZW51bSBjYXBhY2l0eSk7CiAgICAgdm9pZCBkaXNhYmxlKEdDM0RlbnVtIGNhcGFjaXR5KTsKICAg ICB2b2lkIGNsZWFyQ29sb3IoY29uc3QgQ29sb3ImKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NjIz KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDItMTUgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0BjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9t aXVtXSBNYXJrIGZhc3QvY2FudmFzL2NhbnZhcy1zdHJva2VSZWN0Lmh0bWwgYXMgcGFzc2luZyBv biB0aGUgR1BVIHBhdGguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01NDQ5NworCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3Rh dGlvbnMudHh0OgorCiAyMDExLTAyLTE1ICBNaWhhaSBQYXJwYXJpdGEgIDxtaWhhaXBAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgY2hyb21pdW0tZ3B1IGV4cGVjdGF0aW9ucyB1 cGRhdGUuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0 aW9ucy50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVz dF9leHBlY3RhdGlvbnMudHh0CShyZXZpc2lvbiA3ODYyMykKKysrIExheW91dFRlc3RzL3BsYXRm b3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMzE3 MSw3ICszMTcxLDYgQEAgQlVHSkFNRVNSIEdQVSBNQUMgOiBjb21wb3NpdGluZy90ZXh0LW9uLQog QlVHV0s0OTYyOSBHUFUgU0tJUCA6IHBsYXRmb3JtL2Nocm9taXVtL2NvbXBvc2l0aW5nL2xvdHMt b2YtaW1nLWxheWVycy5odG1sID0gUEFTUwogQlVHV0s0OTYyOSBHUFUgU0tJUCA6IHBsYXRmb3Jt L2Nocm9taXVtL2NvbXBvc2l0aW5nL2xvdHMtb2YtaW1nLWxheWVycy13aXRoLW9wYWNpdHkuaHRt bCA9IFBBU1MKIAotQlVHQ1I1NzQzMSBHUFUgV0lOIExJTlVYIDogZmFzdC9jYW52YXMvY2FudmFz LXN0cm9rZVJlY3QuaHRtbCA9IFRFWFQKIEJVR0NSNjA5NjUgR1BVIFdJTiBMSU5VWCA6IGZhc3Qv Y2FudmFzL3NldFdpZHRoUmVzZXRBZnRlckZvcmNlZFJlbmRlci5odG1sID0gSU1BR0UrVEVYVAog CiBCVUdOT05FIFNMT1cgR1BVIERFQlVHIFdJTiA6IGZhc3QvY2FudmFzL2NhbnZhcy1nZXRJbWFn ZURhdGEuaHRtbCA9IFBBU1MK