54485 2011-02-15 12:06:17 -0800 Fix spelling of -inProgramaticScroll 2011-02-15 15:52:51 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 23556 54505 1 ddkilzer ddkilzer darin playmobil xji oldest_to_newest 351454 0 82497 ddkilzer 2011-02-15 12:06:17 -0800 Created attachment 82497 Patch Reviewed by NOBODY (OOPS!). * WebView/WebDynamicScrollBarsView.h: * WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from -inProgramaticScroll. * WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]): Corrected method name. --- 4 files changed, 16 insertions(+), 3 deletions(-) 351456 1 82497 darin 2011-02-15 12:07:32 -0800 Comment on attachment 82497 Patch What about callers outside WebKit? 351498 2 ddkilzer 2011-02-15 12:46:00 -0800 (In reply to comment #1) > (From update of attachment 82497 [details]) > What about callers outside WebKit? Safari doesn't use it. I suspect -inProgramaticScroll should have gone in WebDynamicScrollBarsViewInternal.h anyway. Note that this was added in r72852 for Bug 23556. <http://trac.webkit.org/changeset/72852> 351514 3 darin 2011-02-15 13:06:24 -0800 (In reply to comment #2) > I suspect -inProgramaticScroll should have gone in WebDynamicScrollBarsViewInternal.h anyway. OK, we should fix that. We could do other research to make sure nothing at Apple is using it, but maybe there hasn’t been time. 351654 4 ddkilzer 2011-02-15 15:28:08 -0800 Committed r78627: <http://trac.webkit.org/changeset/78627> 351679 5 ddkilzer 2011-02-15 15:52:51 -0800 (In reply to comment #3) > (In reply to comment #2) > > I suspect -inProgramaticScroll should have gone in WebDynamicScrollBarsViewInternal.h anyway. > > OK, we should fix that. We could do other research to make sure nothing at Apple is using it, but maybe there hasn’t been time. I filed Bug 54505 about moving it. 82497 2011-02-15 12:06:17 -0800 2011-02-15 12:07:32 -0800 Patch 20110215120616.patch text/plain 2862 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogNzg0NDAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFj L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwppbmRleCA0YTNjNzRmZTgw MDFkMTA4OGMzMGM5NjAzZWU2OWFjNTk3NTIyYzZkLi4zZDNhNDYzYzI2NGJjYjVkZTk2ZmU0NTVk ODE5MjVjNTA5NzFmODZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEt MDItMTUgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBGaXgg c3BlbGxpbmcgb2YgLWluUHJvZ3JhbWF0aWNTY3JvbGwKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlZpZXcvV2ViRHluYW1pY1Njcm9sbEJhcnNW aWV3Lmg6CisgICAgICAgICogV2ViVmlldy9XZWJEeW5hbWljU2Nyb2xsQmFyc1ZpZXcubW06Cisg ICAgICAgICgtW1dlYkR5bmFtaWNTY3JvbGxCYXJzVmlldyBpblByb2dyYW1tYXRpY1Njcm9sbF0p OiBSZW5hbWVkIGZyb20KKyAgICAgICAgLWluUHJvZ3JhbWF0aWNTY3JvbGwuCisgICAgICAgICog V2ViVmlldy9XZWJIVE1MVmlldy5tbToKKyAgICAgICAgKC1bV2ViSFRNTFZpZXcgX2ZyYW1lT3JC b3VuZHNDaGFuZ2VkXSk6IENvcnJlY3RlZCBtZXRob2QgbmFtZS4KKwogMjAxMS0wMi0xMSAgR2Vv ZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9s aXZlciBIdW50LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJEeW5h bWljU2Nyb2xsQmFyc1ZpZXcuaCBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRHluYW1p Y1Njcm9sbEJhcnNWaWV3LmgKaW5kZXggYjg5NDYyZGM4N2E5Nzc2NGE2OTE5YjhhNzdhNGU0NmQ3 M2MwYjJlZi4uMzU0Mzg2ODI4MDI3NTYzNmU4YWIzMTVkZjQxYTA0ZjI3NzI1NzBmZSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJEeW5hbWljU2Nyb2xsQmFyc1ZpZXcu aAorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkR5bmFtaWNTY3JvbGxCYXJzVmll dy5oCkBAIC02Myw1ICs2Myw1IEBAIHN0cnVjdCBXZWJEeW5hbWljU2Nyb2xsQmFyc1ZpZXdQcml2 YXRlOwogLy8gc2Nyb2xsYmFyLgogLy8gTk9URTogQXMgb3Bwb3NlZCB0byBvdGhlciBwbGFjZXMg aW4gdGhlIGNvZGUsIHByb2dyYW1tYXRpY2FsbHkgbW92aW5nIHRoZQogLy8gc2Nyb2xsZXJzIGZy b20gaW5zaWRlIHRoaXMgY2xhc3Mgc2hvdWxkIG5vdCBmaXJlIEpTIGV2ZW50cy4KLS0gKEJPT0wp aW5Qcm9ncmFtYXRpY1Njcm9sbDsKKy0gKEJPT0wpaW5Qcm9ncmFtbWF0aWNTY3JvbGw7CiBAZW5k CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkR5bmFtaWNTY3JvbGxC YXJzVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRHluYW1pY1Njcm9sbEJh cnNWaWV3Lm1tCmluZGV4IDYxMGNkNDAxMmM4MTE2YzJhMjYzMDJlMDQ4MmIyZGVlZTg5NzFmNTIu LmQzMTM0OWZkYjhhY2NmNzdlZjdlM2NkNWEwODhkMjk0ZWYyMjdiMzQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRHluYW1pY1Njcm9sbEJhcnNWaWV3Lm1tCisrKyBi L1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRHluYW1pY1Njcm9sbEJhcnNWaWV3Lm1tCkBA IC0xNjAsNyArMTYwLDcgQEAgLSAoQk9PTCl2ZXJ0aWNhbFNjcm9sbGluZ0FsbG93ZWQKICAgICBy ZXR1cm4gX3ByaXZhdGUtPnZlcnRpY2FsU2Nyb2xsaW5nQWxsb3dlZEJ1dFNjcm9sbGVySGlkZGVu IHx8IFtzZWxmIGhhc1ZlcnRpY2FsU2Nyb2xsZXJdOwogfQogCi0tIChCT09MKWluUHJvZ3JhbWF0 aWNTY3JvbGwKKy0gKEJPT0wpaW5Qcm9ncmFtbWF0aWNTY3JvbGwKIHsKICAgICByZXR1cm4gX3By aXZhdGUtPmluUHJvZ3JhbW1hdGljU2Nyb2xsOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9tYWMvV2ViVmlldy9XZWJIVE1MVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcv V2ViSFRNTFZpZXcubW0KaW5kZXggZmYxYzQwMDMyOGIzOWI0Mzc3ZWM2ODA0MDM4YmY1YjYwYjJi NzA4MC4uYjdhMDAxMmI1ZWI1YTM4MGY1MTQ1MmNhMDMzZTFkZjZkNjdiOWYxOCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJIVE1MVmlldy5tbQorKysgYi9Tb3VyY2Uv V2ViS2l0L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tCkBAIC0xMjM5LDcgKzEyMzksNyBAQCAt ICh2b2lkKV9mcmFtZU9yQm91bmRzQ2hhbmdlZAogICAgIFdlYkR5bmFtaWNTY3JvbGxCYXJzVmll dyAqc2Nyb2xsVmlldyA9IFtbW3dlYlZpZXcgbWFpbkZyYW1lXSBmcmFtZVZpZXddIF9zY3JvbGxW aWV3XTsKIAogICAgIE5TUG9pbnQgb3JpZ2luID0gW1tzZWxmIHN1cGVydmlld10gYm91bmRzXS5v cmlnaW47Ci0gICAgaWYgKCFOU0VxdWFsUG9pbnRzKF9wcml2YXRlLT5sYXN0U2Nyb2xsUG9zaXRp b24sIG9yaWdpbikgJiYgIVtzY3JvbGxWaWV3IGluUHJvZ3JhbWF0aWNTY3JvbGxdKSB7CisgICAg aWYgKCFOU0VxdWFsUG9pbnRzKF9wcml2YXRlLT5sYXN0U2Nyb2xsUG9zaXRpb24sIG9yaWdpbikg JiYgIVtzY3JvbGxWaWV3IGluUHJvZ3JhbW1hdGljU2Nyb2xsXSkgewogICAgICAgICBpZiAoRnJh bWUqIGNvcmVGcmFtZSA9IGNvcmUoW3NlbGYgX2ZyYW1lXSkpIHsKICAgICAgICAgICAgIGlmIChG cmFtZVZpZXcqIGNvcmVWaWV3ID0gY29yZUZyYW1lLT52aWV3KCkpIHsKICNpZm5kZWYgQlVJTERJ TkdfT05fVElHRVIK