54480 2011-02-15 11:38:48 -0800 REGRESSION (WebKit2): A web page remains unresponsive for a long time after printing 2011-02-15 12:37:38 -0800 1 1 1 Unclassified WebKit Printing 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 1 ap ap andersca darin webkit.review.bot oldest_to_newest 351431 0 ap 2011-02-15 11:38:48 -0800 I can't select, scroll etc for several seconds after dismissing print dialog, even on a small page. Steps to reproduce: 1. Open http://www.apple.com/hotnews/ 2. Cmd+P, Cancel. 3. Try to select text or drag the scroller. Results: the page remains unresponsive for several seconds <rdar://problem/8975229> 351433 1 82492 ap 2011-02-15 11:43:57 -0800 Created attachment 82492 naive fix I don't understand how painting works between AppKit and WebKit2, and it's quite possible that the root cause lies elsewhere. This seems safe though. 351434 2 webkit.review.bot 2011-02-15 11:45:40 -0800 Attachment 82492 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Source/WebKit2/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 351455 3 82492 darin 2011-02-15 12:06:53 -0800 Comment on attachment 82492 naive fix Ideally we’d want to trigger the display timer, not immediate display. So this is a workaround for a bug not a real fix. 351473 4 ap 2011-02-15 12:18:37 -0800 One thing that's good about displaying immediately is that we start relayout when going back to screen mode, so drawing the latest bits from before printing is better than drawing new ones after a short period of time. What's surprising to me is that actions like selecting text on page or even scrolling don't make WebCore call invalidateContentsAndWindow(). 351490 5 ap 2011-02-15 12:37:38 -0800 Committed <http://trac.webkit.org/changeset/78603>. 82492 2011-02-15 11:43:57 -0800 2011-02-15 12:06:53 -0800 naive fix DisplayIfNeeded.txt text/plain 1608 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NTk1KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDItMTUgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU0NDgwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84OTc1MjI5PiBSRUdSRVNTSU9OIChX ZWJLaXQyKTogQSB3ZWIgcGFnZSByZW1haW5zIHVucmVzcG9uc2l2ZSBmb3IgYSBsb25nCisgICAg ICAgIHRpbWUgYWZ0ZXIgcHJpbnRpbmcKKworCQlOb3RoaW5nIHdhcyBwYWludGVkIHVudGlsIG1v dmluZyB0aGUgbW91c2Ugb3ZlciBicm93c2VyIGNocm9tZSwgZGVhY3RpdmF0aW5nIHRoZSB3aW5k b3csCisJCW9yIHRha2luZyBzb21lIG90aGVyIGRyYXN0aWMgbWVhc3VyZSBsaWtlIHRoYXQuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9QYWdlQ2xpZW50SW1wbC5tbTogKFdlYktpdDo6 UGFnZUNsaWVudEltcGw6OnNldEF1dG9kaXNwbGF5KToKKyAgICAgICAgQ2FsbCAtW05TVmlldyBk aXNwbGF5SWZOZWVkZWRdIGFmdGVyIGVuYWJsaW5nIGF1dG9kaXNwbGF5LiBGb3Igc29tZSByZWFz b24sIHRoaXMgbWFrZXMKKyAgICAgICAgV2ViQ29yZSBwdXNoIHVwZGF0ZXMgYWdhaW4uCisKIDIw MTEtMDItMTUgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCiAgICAgICAgIFVu cmV2aWV3ZWQgUXQgYnVpbGQgZml4IGFmdGVyIHI3ODU4OC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvbWFjL1BhZ2VDbGllbnRJbXBsLm1tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1BhZ2VDbGllbnRJbXBsLm1tCShyZXZpc2lvbiA3 ODUxNSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1BhZ2VDbGllbnRJbXBs Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zNzYsNiArMzc2LDEwIEBAIHZvaWQgUGFnZUNsaWVudElt cGw6OnNldEF1dG9kaXNwbGF5KGJvb2wKICAgICAgICAgW21fd2tWaWV3IGRpc3BsYXlJZk5lZWRl ZF07CiAgICAgCiAgICAgW1ttX3drVmlldyB3aW5kb3ddIHNldEF1dG9kaXNwbGF5Om5ld1N0YXRl XTsKKworICAgIC8vIEZvciBzb21lIHJlYXNvbiwgcGFpbnRpbmcgZG9lc24ndCBoYXBwZW4gZm9y IGEgbG9uZyB0aW1lIHdpdGhvdXQgdGhpcyBjYWxsLCA8cmRhcjovL3Byb2JsZW0vODk3NTIyOT4u CisgICAgaWYgKG5ld1N0YXRlKQorICAgICAgICBbbV93a1ZpZXcgZGlzcGxheUlmTmVlZGVkXTsK IH0KIAogQ0dDb250ZXh0UmVmIFBhZ2VDbGllbnRJbXBsOjpjb250YWluaW5nV2luZG93R3JhcGhp Y3NDb250ZXh0KCkK