54466 2011-02-15 09:06:05 -0800 [Qt] Qt build system can't handle removing headers from tree 2011-02-16 07:49:47 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Major --- 1 ossy webkit-unassigned abecsi hausmann kbalazs kenneth kling oldest_to_newest 351328 0 ossy 2011-02-15 09:06:05 -0800 (1) http://trac.webkit.org/changeset/78382 removed JavaScriptCore/runtime/CollectorHeapIterator.h from the tree and it caused an incremental build failure, because this header wasn't added to HEADERS of JavaScriptCore.pro and qmake didn't regenerate makefile: make[1]: *** No rule to make target `../../../Source/JavaScriptCore/runtime/CollectorHeapIterator.h', needed by `obj/release/Debugger.o'. Stop. make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory `/home/oszi/WebKit/WebKitBuild/Release/JavaScriptCore' make: *** [sub-JavaScriptCore-JavaScriptCore-pro-make_default-ordered] Error 2 (2) https://bugs.webkit.org/attachment.cgi?id=82390 in https://bugs.webkit.org/show_bug.cgi?id=54415 removed Source/JavaScriptCore/runtime/GCHandle.h from the tree and it caused an incremental build failure on Qt EWS, because this header wasn't added to HEADERS of WebKit2.pro and qmake didn't regenerate makefile: make[1]: Entering directory `/home/webkit/WebKit-qt-ews/WebKitBuild/Release/WebKit2' make[1]: *** No rule to make target `../../../Source/JavaScriptCore/runtime/GCHandle.h', needed by `obj/release/ConnectionQt.o'. Stop. make[1]: Leaving directory `/home/webkit/WebKit-qt-ews/WebKitBuild/Release/WebKit2' make: *** [sub-WebKit2-WebKit2-pro-make_default-ordered] Error 2 Unfortunately non-existant dependency cause build breakage. :( I have ideas how can we fix this kind of failures: - Remove all MakeFile* from WebKitBuild before building to make qmake regenerate makefiles always - Add all header files to HEADERS. (It's hard to maintain. eg in case (2) we have to add a JavaScriptCore header to WebKit2.pro) - Create a new general header.pri for all header files and include it from all pro files What do you think about this bug? 351348 1 kbalazs 2011-02-15 09:31:44 -0800 I vote for removing Makefiles. 351351 2 abecsi 2011-02-15 09:33:22 -0800 (In reply to comment #0) > Unfortunately non-existant dependency cause build breakage. :( > I have ideas how can we fix this kind of failures: > - Remove all MakeFile* from WebKitBuild before building to make qmake regenerate makefiles always For me this approach seams most feasible, too, since qmake rereads all project files anyhow on incremental builds and regenerating the Makefiles wouldn't cost much more time. 351400 3 82485 ossy 2011-02-15 10:41:42 -0800 Created attachment 82485 proposed fix Removing makefiles won. I tested the patch and works correctly without runtime penalty. 352061 4 82485 kling 2011-02-16 07:42:15 -0800 Comment on attachment 82485 proposed fix > without runtime penalty. I'll trust you on that. r=me 352067 5 ossy 2011-02-16 07:49:33 -0800 Landed in http://trac.webkit.org/changeset/78708 82485 2011-02-15 10:41:42 -0800 2011-02-16 07:49:47 -0800 proposed fix 1.patch text/plain 1243 ossy SW5kZXg6IFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Nj cmlwdHMvYnVpbGQtd2Via2l0CShyZXZpc2lvbiA3ODU4NSkKKysrIFRvb2xzL1NjcmlwdHMvYnVp bGQtd2Via2l0CSh3b3JraW5nIGNvcHkpCkBAIC0zNzIsNiArMzcyLDEwIEBACiAKIG15ICRwcm9k dWN0RGlyID0gcHJvZHVjdERpcigpOwogCisjIFJlbW92ZSBRdCBtYWtlZmlsZXMgZnJvbSBwcm9k dWN0RGlyLgorIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ0NjYK K0ZpbGU6OkZpbmQ6OmZpbmQoc3ViIHt1bmxpbmsgJEZpbGU6OkZpbmQ6Om5hbWUgaWYgJEZpbGU6 OkZpbmQ6Om5hbWUgPX4gbS9NYWtlZmlsZS87fSwgJHByb2R1Y3REaXIpIGlmIChpc1F0KCkgJiYg IWlzU3ltYmlhbigpICYmIC1lICRwcm9kdWN0RGlyKTsKKwogIyBSZW1vdmUgMCBieXRlIHNpemVk IGZpbGVzIGZyb20gcHJvZHVjdERpciBhZnRlciBzbGF2ZSBsb3N0IGZvciBRdCBidWlsZGJvdHMu CiBGaWxlOjpGaW5kOjpmaW5kKFwmdW5saW5rWmVyb0ZpbGVzLCAkcHJvZHVjdERpcikgaWYgKGlz UXQoKSAmJiAhaXNTeW1iaWFuKCkgJiYgLWUgJHByb2R1Y3REaXIpOwogCkluZGV4OiBUb29scy9D aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA3ODU4NSkK KysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEx LTAyLTE1ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBRdCBidWlsZCBzeXN0 ZW0gY2FuJ3QgaGFuZGxlIHJlbW92aW5nIGhlYWRlcnMgZnJvbSB0cmVlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDQ2NgorCisgICAgICAgICogU2Ny aXB0cy9idWlsZC13ZWJraXQ6IFJlbW92ZSBRdCBtYWtlZmlsZXMgZnJvbSBwcm9kdWN0RGlyIGJl Zm9yZSBidWlsZC4KKwogMjAxMS0wMi0xNSAgRGF2aWQgTGV2aW4gIDxsZXZpbkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2hpbmljaGlybyBIYW1hamkuCg==