54447 2011-02-15 04:34:57 -0800 [chromium] add WebIDBFactory::deleteDatabase method 2011-02-15 13:09:30 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jochen jochen commit-queue fishd hans jorlow oldest_to_newest 351189 0 jochen 2011-02-15 04:34:57 -0800 [chromium] add WebIDBFactory::deleteDatabase method 351191 1 82436 jochen 2011-02-15 04:35:33 -0800 Created attachment 82436 Patch 351192 2 82436 hans 2011-02-15 04:41:48 -0800 Comment on attachment 82436 Patch lgtm View in context: https://bugs.webkit.org/attachment.cgi?id=82436&action=review > Source/WebKit/chromium/public/WebIDBFactory.h:57 > WEBKIT_ASSERT_NOT_REACHED(); maybe move this up to keep it all on one line, while you're fixing the style anyway? 351194 3 82437 jochen 2011-02-15 04:48:58 -0800 Created attachment 82437 Patch 351402 4 82437 jorlow 2011-02-15 10:44:23 -0800 Comment on attachment 82437 Patch r=me 351517 5 82437 commit-queue 2011-02-15 13:09:25 -0800 Comment on attachment 82437 Patch Clearing flags on attachment: 82437 Committed r78606: <http://trac.webkit.org/changeset/78606> 351518 6 commit-queue 2011-02-15 13:09:30 -0800 All reviewed patches have been landed. Closing bug. 82436 2011-02-15 04:35:33 -0800 2011-02-15 04:48:53 -0800 Patch bug-54447-20110215133531.patch text/plain 1764 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogNzg1NDcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg MmViZTI1NTA0NDMyYzAyMGIyZWNkZTdmOTNiZGVlNzEwMDEzN2RkYi4uYmMyMzc2MmU3YzllYzc1 YWVjOTBkMWYwMmE3NjZkZDBlMTVhNzkxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNCBAQAorMjAxMS0wMi0xNSAgSm9jaGVuIEVpc2luZ2VyICA8am9jaGVuQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbY2hyb21pdW1dIGFkZCBXZWJJREJGYWN0b3J5OjpkZWxldGVEYXRhYmFzZSBtZXRob2QKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0NDQ3CisKKyAg ICAgICAgKiBwdWJsaWMvV2ViSURCRmFjdG9yeS5oOgorICAgICAgICAoV2ViS2l0OjpXZWJJREJG YWN0b3J5OjpvcGVuKToKKyAgICAgICAgKFdlYktpdDo6V2ViSURCRmFjdG9yeTo6ZGVsZXRlRGF0 YWJhc2UpOgorCiAyMDExLTAxLTI2ICBNT1JJVEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1a2UgTml3YS4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklEQkZhY3RvcnkuaCBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYklEQkZhY3RvcnkuaAppbmRleCAxMGExMzRhYjYyMWViZTNlZDVm YjQ4NTlkNmZlNmRkNDk1YTNmOTAyLi42YTlmNzFhMGQ3YjJmNzg2YjljNTI3YjRiM2Q3Mzk1MTli YzFmNzgxIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJREJG YWN0b3J5LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSURCRmFjdG9y eS5oCkBAIC01MiwxMCArNTIsMTEgQEAgcHVibGljOgogICAgIHZpcnR1YWwgfldlYklEQkZhY3Rv cnkoKSB7IH0KIAogICAgIC8vIFRoZSBXZWJLaXQgaW1wbGVtZW50YXRpb24gb2Ygb3BlbiBpZ25v cmVzIHRoZSBXZWJGcmFtZSogcGFyYW1ldGVyLgotICAgIHZpcnR1YWwgdm9pZCBvcGVuKGNvbnN0 IFdlYlN0cmluZyYgbmFtZSwgV2ViSURCQ2FsbGJhY2tzKiBjYWxsYmFja3MsIGNvbnN0IFdlYlNl Y3VyaXR5T3JpZ2luJiBvcmlnaW4sIFdlYkZyYW1lKiB3ZWJGcmFtZSwgY29uc3QgV2ViU3RyaW5n JiBkYXRhRGlyLCB1bnNpZ25lZCBsb25nIGxvbmcgbWF4aW11bVNpemUpCisgICAgdmlydHVhbCB2 b2lkIG9wZW4oY29uc3QgV2ViU3RyaW5nJiBuYW1lLCBXZWJJREJDYWxsYmFja3MqLCBjb25zdCBX ZWJTZWN1cml0eU9yaWdpbiYsIFdlYkZyYW1lKiwgY29uc3QgV2ViU3RyaW5nJiBkYXRhRGlyLCB1 bnNpZ25lZCBsb25nIGxvbmcgbWF4aW11bVNpemUpCiAgICAgewogICAgICAgICBXRUJLSVRfQVNT RVJUX05PVF9SRUFDSEVEKCk7CiAgICAgfQorICAgIHZpcnR1YWwgdm9pZCBkZWxldGVEYXRhYmFz ZShjb25zdCBXZWJTdHJpbmcmIG5hbWUsIFdlYklEQkNhbGxiYWNrcyosIGNvbnN0IFdlYlNlY3Vy aXR5T3JpZ2luJiwgV2ViRnJhbWUqLCBjb25zdCBXZWJTdHJpbmcmIGRhdGFEaXIpIHsgV0VCS0lU X0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK 82437 2011-02-15 04:48:58 -0800 2011-02-15 13:09:25 -0800 Patch bug-54447-20110215134856.patch text/plain 1796 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogNzg1NDcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg MmViZTI1NTA0NDMyYzAyMGIyZWNkZTdmOTNiZGVlNzEwMDEzN2RkYi4uYmMyMzc2MmU3YzllYzc1 YWVjOTBkMWYwMmE3NjZkZDBlMTVhNzkxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNCBAQAorMjAxMS0wMi0xNSAgSm9jaGVuIEVpc2luZ2VyICA8am9jaGVuQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbY2hyb21pdW1dIGFkZCBXZWJJREJGYWN0b3J5OjpkZWxldGVEYXRhYmFzZSBtZXRob2QKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0NDQ3CisKKyAg ICAgICAgKiBwdWJsaWMvV2ViSURCRmFjdG9yeS5oOgorICAgICAgICAoV2ViS2l0OjpXZWJJREJG YWN0b3J5OjpvcGVuKToKKyAgICAgICAgKFdlYktpdDo6V2ViSURCRmFjdG9yeTo6ZGVsZXRlRGF0 YWJhc2UpOgorCiAyMDExLTAxLTI2ICBNT1JJVEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1a2UgTml3YS4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklEQkZhY3RvcnkuaCBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYklEQkZhY3RvcnkuaAppbmRleCAxMGExMzRhYjYyMWViZTNlZDVm YjQ4NTlkNmZlNmRkNDk1YTNmOTAyLi45Nzc1MTBmMWVmMDgzM2Y0ODg3ZmRhMWJlMDEyNTlkOTdk YzBmYTg5IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJREJG YWN0b3J5LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSURCRmFjdG9y eS5oCkBAIC01MiwxMCArNTIsOCBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB+V2ViSURCRmFjdG9y eSgpIHsgfQogCiAgICAgLy8gVGhlIFdlYktpdCBpbXBsZW1lbnRhdGlvbiBvZiBvcGVuIGlnbm9y ZXMgdGhlIFdlYkZyYW1lKiBwYXJhbWV0ZXIuCi0gICAgdmlydHVhbCB2b2lkIG9wZW4oY29uc3Qg V2ViU3RyaW5nJiBuYW1lLCBXZWJJREJDYWxsYmFja3MqIGNhbGxiYWNrcywgY29uc3QgV2ViU2Vj dXJpdHlPcmlnaW4mIG9yaWdpbiwgV2ViRnJhbWUqIHdlYkZyYW1lLCBjb25zdCBXZWJTdHJpbmcm IGRhdGFEaXIsIHVuc2lnbmVkIGxvbmcgbG9uZyBtYXhpbXVtU2l6ZSkKLSAgICB7Ci0gICAgICAg IFdFQktJVF9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAgICB9CisgICAgdmlydHVhbCB2b2lkIG9w ZW4oY29uc3QgV2ViU3RyaW5nJiBuYW1lLCBXZWJJREJDYWxsYmFja3MqLCBjb25zdCBXZWJTZWN1 cml0eU9yaWdpbiYsIFdlYkZyYW1lKiwgY29uc3QgV2ViU3RyaW5nJiBkYXRhRGlyLCB1bnNpZ25l ZCBsb25nIGxvbmcgbWF4aW11bVNpemUpIHsgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9 CisgICAgdmlydHVhbCB2b2lkIGRlbGV0ZURhdGFiYXNlKGNvbnN0IFdlYlN0cmluZyYgbmFtZSwg V2ViSURCQ2FsbGJhY2tzKiwgY29uc3QgV2ViU2VjdXJpdHlPcmlnaW4mLCBXZWJGcmFtZSosIGNv bnN0IFdlYlN0cmluZyYgZGF0YURpcikgeyBXRUJLSVRfQVNTRVJUX05PVF9SRUFDSEVEKCk7IH0K IH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo=