54430 2011-02-14 20:28:01 -0800 improve line selection in the code review tool 2011-02-17 18:14:25 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth tonikitoo oldest_to_newest 351076 0 ojan 2011-02-14 20:28:01 -0800 improve line selection in the code review tool 351077 1 82411 ojan 2011-02-14 20:29:38 -0800 Created attachment 82411 Patch 351080 2 82411 abarth 2011-02-14 20:44:20 -0800 Comment on attachment 82411 Patch You said you'd written you last patch! 351089 3 ojan 2011-02-14 21:47:02 -0800 Committed r78530: <http://trac.webkit.org/changeset/78530> 352789 4 tonikitoo 2011-02-17 06:06:02 -0800 Btw, line selection is broken in Firefox 4 beta 11. Console output: Error: event is not defined Source File: https://bugs.webkit.org/code-review.js?version=35 Line: 1512 Not sure if it is a regression from this bug, but it used to work fine. 353279 5 ojan 2011-02-17 17:45:36 -0800 (In reply to comment #4) > Btw, line selection is broken in Firefox 4 beta 11. Console output: > > Error: event is not defined > Source File: https://bugs.webkit.org/code-review.js?version=35 > Line: 1512 > > Not sure if it is a regression from this bug, but it used to work fine. Yup. It's a regression from this patch. Fix coming soon. I moved a line up so we're now getting a JS error at the beginning of the mousedown handler instead of at the end of it. :) 353298 6 ojan 2011-02-17 18:14:25 -0800 bug 54702 82411 2011-02-14 20:29:38 -0800 2011-02-14 20:44:20 -0800 Patch bug-54430-20110215152944.patch text/plain 6137 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogNzg1MjgKZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Vi a2l0Lm9yZy9DaGFuZ2VMb2cgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9nCmlu ZGV4IDlhZGMzZDcxYWIyMDViOTFmYzE5NzQyNTc3YzRjYWZmMWI2MGM5ODguLmQ1ZWIwOTRjODQ0 YmFkNTRkMDZmMWY5OTA2MTcxMjI0ZjFiNTE3MjYgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mu d2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTAyLTE0ICBPamFuIFZhZmFpICA8b2phbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgaW1wcm92ZSBsaW5lIHNlbGVjdGlvbiBpbiB0aGUgY29kZSByZXZpZXcgdG9vbAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ0MzAKKworICAgICAg ICAtc2hpZnQrY2xpY2sgbm93IGV4dGVuZHMgdGhlIGNvbW1lbnQgY29udGV4dAorICAgICAgICAt c2VsZWN0aW5nIG91dHNpZGUgb2YgYSBkaWZmIHNlY3Rpb24gbm8gbG9uZ2VyIGNsZWFycyB0aGUg c2VsZWN0ZWQgbGluZXMuCisgICAgICAgICBJbnN0ZWFkIGl0IGp1c3QgcmVzdHJpY3RzIHRoZSBz ZWxlY3RlZCBsaW5lcyB0byB0aGF0IGRpZmYgc2VjdGlvbi4KKworICAgICAgICAqIGNvZGUtcmV2 aWV3LmpzOgorCiAyMDExLTAyLTEwICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1 Z3Mud2Via2l0Lm9yZy9jb2RlLXJldmlldy5qcyBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9j b2RlLXJldmlldy5qcwppbmRleCA0NDM0ODI4NTM0YTk4ZGU1ZjQxYWNiYzk2YWMyMWI4Yjk3OWNh ZjViLi5kZjVhMmVlMzM2ZmZjNGU3YjVmYzVkM2Y2OTg4OWM5ODk4Y2YzY2UxIDEwMDY0NAotLS0g YS9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXcuanMKKysrIGIvV2Vic2l0ZXMv YnVncy53ZWJraXQub3JnL2NvZGUtcmV2aWV3LmpzCkBAIC0xMDIsNiArMTAyLDEwIEBAIHZhciBD T0RFX1JFVklFV19VTklUVEVTVDsKICAgICByZXR1cm4gJChsaW5lKS5wYXJlbnRzKCcuRmlsZURp ZmYnKTsKICAgfQogCisgIGZ1bmN0aW9uIGRpZmZTZWN0aW9uRm9yKGxpbmUpIHsKKyAgICByZXR1 cm4gJChsaW5lKS5wYXJlbnRzKCcuRGlmZlNlY3Rpb24nKTsKKyAgfQorCiAgIGZ1bmN0aW9uIGFj dGl2ZUNvbW1lbnRGb3IobGluZSkgewogICAgIC8vIFNjb3BlIHRvIHRoZSBkaWZmU2VjdGlvbiBh cyBhIHBlcmZvcm1hbmNlIGltcHJvdmVtZW50LgogICAgIHJldHVybiAkKCd0ZXh0YXJlYVtkYXRh LWNvbW1lbnQtZm9yfj0iJyArIGxpbmVbMF0uaWQgKyAnIl0nLCBmaWxlRGlmZkZvcihsaW5lKSk7 CkBAIC0xNDA4LDExICsxNDEyLDYgQEAgdmFyIENPREVfUkVWSUVXX1VOSVRURVNUOwogCiAgIHZh ciBkcmFnX3NlbGVjdF9zdGFydF9pbmRleCA9IC0xOwogCi0gIGZ1bmN0aW9uIHN0b3BEcmFnU2Vs ZWN0KCkgewotICAgICQoJy5zZWxlY3RlZCcpLnJlbW92ZUNsYXNzKCdzZWxlY3RlZCcpOwotICAg IGRyYWdfc2VsZWN0X3N0YXJ0X2luZGV4ID0gLTE7Ci0gIH0KLQogICBmdW5jdGlvbiBsaW5lT2Zm c2V0RnJvbShsaW5lLCBvZmZzZXQpIHsKICAgICB2YXIgZmlsZV9kaWZmID0gbGluZS5wYXJlbnRz KCcuRmlsZURpZmYnKTsKICAgICB2YXIgYWxsX2xpbmVzID0gJCgnLkxpbmUnLCBmaWxlX2RpZmYp OwpAQCAtMTQyOCwxNyArMTQyNyw2OCBAQCB2YXIgQ09ERV9SRVZJRVdfVU5JVFRFU1Q7CiAgICAg cmV0dXJuIGxpbmVPZmZzZXRGcm9tKGxpbmUsIDEpOwogICB9CiAKLSAgJCgnLmxpbmVOdW1iZXIn KS5saXZlKCdjbGljaycsIGZ1bmN0aW9uKCkgeworICAkKGRvY3VtZW50LmJvZHkpLmJpbmQoJ21v dXNldXAnLCBwcm9jZXNzU2VsZWN0ZWRMaW5lcyk7CisKKyAgJCgnLmxpbmVOdW1iZXInKS5saXZl KCdjbGljaycsIGZ1bmN0aW9uKGUpIHsKICAgICB2YXIgbGluZSA9IGxpbmVGcm9tTGluZURlc2Nl bmRhbnQoJCh0aGlzKSk7CiAgICAgaWYgKGxpbmUuaGFzQ2xhc3MoJ2NvbW1lbnRDb250ZXh0Jykp CiAgICAgICB0cmltQ29tbWVudENvbnRleHRUb0JlZm9yZShwcmV2aW91c0xpbmVGb3IobGluZSks IGxpbmUuYXR0cignZGF0YS1jb21tZW50LWJhc2UtbGluZScpKTsKLSAgfSkubGl2ZSgnbW91c2Vk b3duJywgZnVuY3Rpb24oKSB7CisgICAgZWxzZSBpZiAoZS5zaGlmdEtleSkKKyAgICAgIGV4dGVu ZENvbW1lbnRDb250ZXh0VG8obGluZSk7CisgIH0pLmxpdmUoJ21vdXNlZG93bicsIGZ1bmN0aW9u KGUpIHsKKyAgICAvLyBwcmV2ZW50RGVmYXVsdCB0byBhdm9pZCBzZWxlY3RpbmcgdGV4dCB3aGVu IGRyYWdnaW5nIHRvIHNlbGVjdCBjb21tZW50IGNvbnRleHQgbGluZXMuCisgICAgLy8gRklYTUU6 IHNob3VsZCB3ZSB1c2UgdXNlci1tb2RpZnkgQ1NTIGluc3RlYWQ/CisgICAgZXZlbnQucHJldmVu dERlZmF1bHQoKTsKKyAgICBpZiAoZS5zaGlmdEtleSkKKyAgICAgIHJldHVybjsKKwogICAgIHZh ciBsaW5lID0gbGluZUZyb21MaW5lRGVzY2VuZGFudCgkKHRoaXMpKTsKICAgICBkcmFnX3NlbGVj dF9zdGFydF9pbmRleCA9IG51bWJlckZyb20obGluZS5hdHRyKCdpZCcpKTsKICAgICBsaW5lLmFk ZENsYXNzKCdzZWxlY3RlZCcpOwotICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CiAgIH0pOwog CisgICQoJy5MaW5lQ29udGFpbmVyJykubGl2ZSgnbW91c2VlbnRlcicsIGZ1bmN0aW9uKGUpIHsK KyAgICBpZiAoZHJhZ19zZWxlY3Rfc3RhcnRfaW5kZXggPT0gLTEgfHwgZS5zaGlmdEtleSkKKyAg ICAgIHJldHVybjsKKyAgICBzZWxlY3RUb0xpbmVDb250YWluZXIodGhpcyk7CisgIH0pLmxpdmUo J21vdXNldXAnLCBmdW5jdGlvbihlKSB7CisgICAgaWYgKGRyYWdfc2VsZWN0X3N0YXJ0X2luZGV4 ID09IC0xIHx8IGUuc2hpZnRLZXkpCisgICAgICByZXR1cm47CisKKyAgICBzZWxlY3RUb0xpbmVD b250YWluZXIodGhpcyk7CisgICAgcHJvY2Vzc1NlbGVjdGVkTGluZXMoKTsKKyAgfSk7CisKKyAg ZnVuY3Rpb24gZXh0ZW5kQ29tbWVudENvbnRleHRUbyhsaW5lKSB7CisgICAgdmFyIGRpZmZfc2Vj dGlvbiA9IGRpZmZTZWN0aW9uRm9yKGxpbmUpOworICAgIHZhciBsaW5lcyA9ICQoJy5MaW5lJywg ZGlmZl9zZWN0aW9uKTsKKyAgICB2YXIgbGluZXNfdG9fbW9kaWZ5ID0gW107CisgICAgdmFyIGhh dmVfc2Vlbl9zdGFydF9saW5lID0gZmFsc2U7CisgICAgdmFyIGRhdGFfY29tbWVudF9iYXNlX2xp bmUgPSBudWxsOworICAgIGxpbmVzLmVhY2goZnVuY3Rpb24oKSB7CisgICAgICBpZiAoZGF0YV9j b21tZW50X2Jhc2VfbGluZSkKKyAgICAgICAgcmV0dXJuOworCisgICAgICBoYXZlX3NlZW5fc3Rh cnRfbGluZSA9IGhhdmVfc2Vlbl9zdGFydF9saW5lIHx8IHRoaXMgPT0gbGluZVswXTsKKyAgICAg IAorICAgICAgaWYgKGhhdmVfc2Vlbl9zdGFydF9saW5lKSB7CisgICAgICAgIGlmICgkKHRoaXMp Lmhhc0NsYXNzKCdjb21tZW50Q29udGV4dCcpKQorICAgICAgICAgIGRhdGFfY29tbWVudF9iYXNl X2xpbmUgPSAkKHRoaXMpLmF0dHIoJ2RhdGEtY29tbWVudC1iYXNlLWxpbmUnKTsKKyAgICAgICAg ZWxzZQorICAgICAgICAgIGxpbmVzX3RvX21vZGlmeS5wdXNoKHRoaXMpOworICAgICAgfQorICAg IH0pOworICAgIAorICAgIC8vIFRoZXJlIGlzIG5vIGNvbW1lbnQgY29udGV4dCB0byBleHRlbmQu CisgICAgaWYgKCFkYXRhX2NvbW1lbnRfYmFzZV9saW5lKQorICAgICAgcmV0dXJuOworICAgIAor ICAgICQobGluZXNfdG9fbW9kaWZ5KS5lYWNoKGZ1bmN0aW9uKCkgeworICAgICAgJCh0aGlzKS5h ZGRDbGFzcygnY29tbWVudENvbnRleHQnKTsKKyAgICAgICQodGhpcykuYXR0cignZGF0YS1jb21t ZW50LWJhc2UtbGluZScsIGRhdGFfY29tbWVudF9iYXNlX2xpbmUpOworICAgIH0pOworICB9CisK ICAgZnVuY3Rpb24gc2VsZWN0VG8oZm9jdXNfaW5kZXgpIHsKICAgICB2YXIgc2VsZWN0ZWQgPSAk KCcuc2VsZWN0ZWQnKS5yZW1vdmVDbGFzcygnc2VsZWN0ZWQnKTsKICAgICB2YXIgaXNfYmFja3dh cmQgPSBkcmFnX3NlbGVjdF9zdGFydF9pbmRleCA+IGZvY3VzX2luZGV4OwpAQCAtMTQ1MiwyMCAr MTUwMiwyOSBAQCB2YXIgQ09ERV9SRVZJRVdfVU5JVFRFU1Q7CiAKICAgZnVuY3Rpb24gc2VsZWN0 VG9MaW5lQ29udGFpbmVyKGxpbmVfY29udGFpbmVyKSB7CiAgICAgdmFyIGxpbmUgPSBsaW5lRnJv bUxpbmVDb250YWluZXIobGluZV9jb250YWluZXIpOworCisgICAgLy8gRW5zdXJlIHRoYXQgdGhl IHNlbGVjdGVkIGxpbmVzIGFyZSBhbGwgY29udGFpbmVkIGluIHRoZSBzYW1lIERpZmZTZWN0aW9u LgorICAgIHZhciBzZWxlY3RlZF9saW5lcyA9ICQoJy5zZWxlY3RlZCcpOworICAgIHZhciBzZWxl Y3RlZF9kaWZmX3NlY3Rpb24gPSBkaWZmU2VjdGlvbkZvcihzZWxlY3RlZF9saW5lcy5maXJzdCgp KTsKKyAgICB2YXIgbmV3X2RpZmZfc2VjdGlvbiA9IGRpZmZTZWN0aW9uRm9yKGxpbmUpOworICAg IGlmIChuZXdfZGlmZl9zZWN0aW9uWzBdICE9IHNlbGVjdGVkX2RpZmZfc2VjdGlvblswXSkgewor ICAgICAgdmFyIGxpbmVzID0gJCgnLkxpbmUnLCBzZWxlY3RlZF9kaWZmX3NlY3Rpb24pOworICAg ICAgaWYgKG51bWJlckZyb20oc2VsZWN0ZWRfbGluZXMuZmlyc3QoKS5hdHRyKCdpZCcpKSA9PSBk cmFnX3NlbGVjdF9zdGFydF9pbmRleCkKKyAgICAgICAgbGluZSA9IGxpbmVzLmxhc3QoKTsKKyAg ICAgIGVsc2UKKyAgICAgICAgbGluZSA9IGxpbmVzLmZpcnN0KCk7CisgICAgfQorICAgIAogICAg IHNlbGVjdFRvKG51bWJlckZyb20obGluZS5hdHRyKCdpZCcpKSk7CiAgIH0KIAotICAkKCcuTGlu ZUNvbnRhaW5lcicpLmxpdmUoJ21vdXNlZW50ZXInLCBmdW5jdGlvbigpIHsKLSAgICBpZiAoZHJh Z19zZWxlY3Rfc3RhcnRfaW5kZXggPT0gLTEpCi0gICAgICByZXR1cm47Ci0gICAgc2VsZWN0VG9M aW5lQ29udGFpbmVyKHRoaXMpOwotICB9KS5saXZlKCdtb3VzZXVwJywgZnVuY3Rpb24oKSB7Ci0g ICAgaWYgKGRyYWdfc2VsZWN0X3N0YXJ0X2luZGV4ID09IC0xKQotICAgICAgcmV0dXJuOwotCi0g ICAgc2VsZWN0VG9MaW5lQ29udGFpbmVyKHRoaXMpOworICBmdW5jdGlvbiBwcm9jZXNzU2VsZWN0 ZWRMaW5lcygpIHsKKyAgICBkcmFnX3NlbGVjdF9zdGFydF9pbmRleCA9IC0xOwogCiAgICAgdmFy IHNlbGVjdGVkID0gJCgnLnNlbGVjdGVkJyk7CisgICAgaWYgKCFzZWxlY3RlZC5zaXplKCkpCisg ICAgICByZXR1cm47CisgICAgCiAgICAgdmFyIGFscmVhZHlfaGFzX2NvbW1lbnQgPSBzZWxlY3Rl ZC5sYXN0KCkuaGFzQ2xhc3MoJ2NvbW1lbnRDb250ZXh0Jyk7CiAgICAgc2VsZWN0ZWQuYWRkQ2xh c3MoJ2NvbW1lbnRDb250ZXh0Jyk7CiAKQEAgLTE0ODAsMTAgKzE1MzksMTEgQEAgdmFyIENPREVf UkVWSUVXX1VOSVRURVNUOwogCiAgICAgc2VsZWN0ZWQuZWFjaChmdW5jdGlvbigpIHsKICAgICAg IGFkZERhdGFDb21tZW50QmFzZUxpbmUodGhpcywgY29tbWVudF9iYXNlX2xpbmUpOworICAgICAg JCh0aGlzKS5yZW1vdmVDbGFzcygnc2VsZWN0ZWQnKTsKICAgICB9KTsKIAogICAgIHNhdmVEcmFm dENvbW1lbnRzKCk7Ci0gIH0pOworICB9CiAKICAgZnVuY3Rpb24gYWRkRGF0YUNvbW1lbnRCYXNl TGluZShsaW5lLCBpZCkgewogICAgIHZhciB2YWwgPSAkKGxpbmUpLmF0dHIoJ2RhdGEtY29tbWVu dC1iYXNlLWxpbmUnKTsKQEAgLTE1MjUsOCArMTU4NSw2IEBAIHZhciBDT0RFX1JFVklFV19VTklU VEVTVDsKICAgICByZXR1cm4gbGluZTsKICAgfQogCi0gICQoJy5EaWZmU2VjdGlvbicpLmxpdmUo J21vdXNlbGVhdmUnLCBzdG9wRHJhZ1NlbGVjdCkubGl2ZSgnbW91c2V1cCcsIHN0b3BEcmFnU2Vs ZWN0KTsKLQogICBmdW5jdGlvbiBjb250ZXh0U25pcHBldEZvcihsaW5lLCBpbmRlbnQpIHsKICAg ICB2YXIgc25pcHBldHMgPSBbXQogICAgIGNvbnRleHRMaW5lc0ZvcihsaW5lLmF0dHIoJ2lkJyks IGZpbGVEaWZmRm9yKGxpbmUpKS5lYWNoKGZ1bmN0aW9uKCkgewo=