5443 2005-10-20 09:03:55 -0700 REGRESSION highlight left behind when contracting a selection 2005-10-21 11:14:11 -0700 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 RESOLVED FIXED P1 Normal --- 1 mitz hyatt oldest_to_newest 22363 0 mitz 2005-10-20 09:03:55 -0700 The selection highlight is not repainted correctly when contracting the selection by dragging its end. To reproduce: drag across a line of text on this page from left to right and all the way back, starting the selection anywhere *after* the first character. I think this also comes from the latest changes to WebTextRenderer.m (r1.198 or r1.197). Looks like the editing/selection/fake-drag pixel-test detects this regression. 22364 1 4422 mitz 2005-10-20 09:46:17 -0700 Created attachment 4422 compute highlight width correctly This patch also fixes the regression where the drag image for selections that don't start at character 0 was incorrect. 22383 2 4422 darin 2005-10-20 14:16:40 -0700 Comment on attachment 4422 compute highlight width correctly Oops! Thanks. Sorry. 4422 2005-10-20 09:46:17 -0700 2005-10-20 14:16:40 -0700 compute highlight width correctly 5443_r1.patch text/plain 1247 mitz SW5kZXg6IFdlYlRleHRSZW5kZXJlci5tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9X ZWJLaXQvV2ViQ29yZVN1cHBvcnQuc3VicHJvai9XZWJUZXh0UmVuZGVyZXIubSx2CnJldHJpZXZp bmcgcmV2aXNpb24gMS4xOTgKZGlmZiAtcCAtdSAtcjEuMTk4IFdlYlRleHRSZW5kZXJlci5tCi0t LSBXZWJUZXh0UmVuZGVyZXIubQkyMCBPY3QgMjAwNSAwNjowMjozOCAtMDAwMAkxLjE5OAorKysg V2ViVGV4dFJlbmRlcmVyLm0JMjAgT2N0IDIwMDUgMTY6NDg6MTQgLTAwMDAKQEAgLTg2Niw3ICs4 NjYsNyBAQCBzdGF0aWMgdm9pZCBkcmF3R2x5cGhzKE5TRm9udCAqZm9udCwgTlNDCiAgICAgYWR2 YW5jZVdpZHRoSXRlcmF0b3IoJml0LCBydW4tPmZyb20sIDAsIDAsIDApOwogICAgIGZsb2F0IGJl Zm9yZVdpZHRoID0gaXQucnVuV2lkdGhTb0ZhcjsKICAgICBhZHZhbmNlV2lkdGhJdGVyYXRvcigm aXQsIHJ1bi0+dG8sIDAsIDAsIDApOwotICAgIGZsb2F0IGJhY2tncm91bmRXaWR0aCA9IGl0LnJ1 bldpZHRoU29GYXI7CisgICAgZmxvYXQgYmFja2dyb3VuZFdpZHRoID0gaXQucnVuV2lkdGhTb0Zh ciAtIGJlZm9yZVdpZHRoOwogICAgIGlmIChzdHlsZS0+cnRsKSB7CiAgICAgICAgIGFkdmFuY2VX aWR0aEl0ZXJhdG9yKCZpdCwgcnVuLT5sZW5ndGgsIDAsIDAsIDApOwogICAgICAgICBmbG9hdCBh ZnRlcldpZHRoID0gaXQucnVuV2lkdGhTb0ZhcjsKQEAgLTE2NjAsNyArMTY2MCw3IEBAIHN0YXRp YyB2b2lkIGluaXRpYWxpemVXaWR0aEl0ZXJhdG9yKFdpZHQKICAgICAgICAgc3RhcnRQb3NpdGlv blJ1bi50byA9IHJ1bi0+bGVuZ3RoOwogICAgICAgICBXaWR0aEl0ZXJhdG9yIHN0YXJ0UG9zaXRp b25JdGVyYXRvcjsKICAgICAgICAgaW5pdGlhbGl6ZVdpZHRoSXRlcmF0b3IoJnN0YXJ0UG9zaXRp b25JdGVyYXRvciwgcmVuZGVyZXIsICZzdGFydFBvc2l0aW9uUnVuLCBzdHlsZSk7Ci0gICAgICAg IGFkdmFuY2VXaWR0aEl0ZXJhdG9yKCZzdGFydFBvc2l0aW9uSXRlcmF0b3IsIHJ1bi0+dG8sIDAs IDAsIDApOworICAgICAgICBhZHZhbmNlV2lkdGhJdGVyYXRvcigmc3RhcnRQb3NpdGlvbkl0ZXJh dG9yLCBydW4tPmZyb20sIDAsIDAsIDApOwogICAgICAgICBpdGVyYXRvci0+d2lkdGhUb1N0YXJ0 ID0gc3RhcnRQb3NpdGlvbkl0ZXJhdG9yLnJ1bldpZHRoU29GYXI7CiAgICAgfQogfQo=