54418 2011-02-14 15:45:21 -0800 r78499 causes assertion failure in http/tests/xmlhttprequest/cache-override.html 2011-02-15 11:31:06 -0800 1 1 1 Unclassified WebKit Text 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 53898 1 pkasting darin ap koivisto mario psolanki oldest_to_newest 350941 0 pkasting 2011-02-14 15:45:21 -0800 Chromium bots started crashing on this test after r78499 went in (see our test dashboard at http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&group=%40ToT%20-%20chromium.org&tests=http%2Ftests%2Fxmlhttprequest%2Fcache-override.html ). The critical bit is this chunk I copied from the Linux run: ASSERTION FAILED: count > m_partialSequenceSize third_party/WebKit/Source/WebCore/platform/text/TextCodecUTF8.cpp(217) : virtual WTF::String WebCore::TextCodecUTF8::decode(const char*, size_t, bool, bool, bool&) [14203:14203:2241232273962:ERROR:process_util_posix.cc(106)] Received signal 11 351152 1 mario 2011-02-15 02:05:10 -0800 It's also causing crashes in SnowLeopard and GTK bots. See full backtrace as got from the GTK 32-bit debug bot in my last comment in bug 53898: https://bugs.webkit.org/show_bug.cgi?id=53898#c56 351164 2 82431 koivisto 2011-02-15 02:42:09 -0800 Created attachment 82431 check for zero 351171 3 82431 kling 2011-02-15 02:53:07 -0800 Comment on attachment 82431 check for zero r=me 351172 4 82431 koivisto 2011-02-15 02:54:19 -0800 Comment on attachment 82431 check for zero Hmm, no this is not correct. It should still flush the partial sequence and set the error flag. Better leave it for Darin. 351173 5 82431 kling 2011-02-15 02:58:08 -0800 Comment on attachment 82431 check for zero re-r+ing again as agreed on IRC. I don't see a problem with this patch, TextCodecUTF16 has the same check. 351176 6 koivisto 2011-02-15 03:10:03 -0800 http://trac.webkit.org/changeset/78541 I also filed https://bugs.webkit.org/show_bug.cgi?id=54444 Correct handling of end of buffer partial sequence in UFT8 decoder when flushing with zero length 351429 7 pkasting 2011-02-15 11:31:06 -0800 (For clarity, the patch here landed in r78541) 82431 2011-02-15 02:42:09 -0800 2011-02-15 02:58:08 -0800 check for zero utf8-length.patch text/plain 1345 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NTM4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMTUgIEFudHRpIEtv aXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIHI3ODQ5OSBjYXVzZXMgYXNzZXJ0aW9uIGZhaWx1cmUgaW4gaHR0 cC90ZXN0cy94bWxodHRwcmVxdWVzdC9jYWNoZS1vdmVycmlkZS5odG1sCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDQxOAorICAgICAgICAKKyAgICAg ICAgQ2hlY2sgZm9yIHplcm8gYnVmZmVyIGxlbmd0aC4KKworICAgICAgICAqIHBsYXRmb3JtL3Rl eHQvVGV4dENvZGVjVVRGOC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0Q29kZWNVVEY4Ojpk ZWNvZGUpOgorCiAyMDExLTAyLTE1ICBNT1JJVEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29t PgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LgpJbmRleDogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vdGV4dC9UZXh0Q29kZWNVVEY4LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS90ZXh0L1RleHRDb2RlY1VURjguY3BwCShyZXZpc2lvbiA3ODUzNSkKKysr IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvVGV4dENvZGVjVVRGOC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTIwMSw2ICsyMDEsOSBAQCBzdGF0aWMgaW5saW5lIFVDaGFyKiBhcHBlbmRDaGFy YWN0ZXIoVUNoCiAKIFN0cmluZyBUZXh0Q29kZWNVVEY4OjpkZWNvZGUoY29uc3QgY2hhciogYnl0 ZXMsIHNpemVfdCBsZW5ndGgsIGJvb2wgZmx1c2gsIGJvb2wgc3RvcE9uRXJyb3IsIGJvb2wmIHNh d0Vycm9yKQogeworICAgIGlmICghbGVuZ3RoKQorICAgICAgICByZXR1cm4gU3RyaW5nKCk7CisK ICAgICAvLyBFYWNoIGlucHV0IGJ5dGUgbWlnaHQgdHVybiBpbnRvIGEgY2hhcmFjdGVyLgogICAg IC8vIFRoYXQgaW5jbHVkZXMgYWxsIGJ5dGVzIGluIHRoZSBwYXJ0aWFsLXNlcXVlbmNlIGJ1ZmZl ciBiZWNhdXNlCiAgICAgLy8gZWFjaCBieXRlIGluIGFuIGludmFsaWQgc2VxdWVuY2Ugd2lsbCB0 dXJuIGludG8gYSByZXBsYWNlbWVudCBjaGFyYWN0ZXIuCg==