54414 2011-02-14 14:51:44 -0800 [GTK] testwebdatasource test fails in the bots 2011-02-19 11:02:23 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 alex webkit-unassigned webkitbugs.20.dsurawicz oldest_to_newest 350901 0 alex 2011-02-14 14:51:44 -0800 Apparently the uri we get from soup_message_get_uri is not the same we pass to the load uri API: ERROR:../../Source/WebKit/gtk/tests/testwebdatasource.c:95:notify_load_status_cb: assertion failed (webkit_network_request_get_uri(request) == "http://webkit.org/"): ("http://www.webkit.org/" == "http://webkit.org/") It gets the uri the server returns when loading. It works just when the loading process fails (cancelled in this case) because the assertion is not checked, it fails randomly, probably depending on the time the site takes to answer and if it comes before or after the timeout. 350912 1 82368 alex 2011-02-14 15:04:21 -0800 Created attachment 82368 Proposed patch 350915 2 82368 xan.lopez 2011-02-14 15:08:18 -0800 Comment on attachment 82368 Proposed patch Hum, I guess that's OK :) 350945 3 alex 2011-02-14 15:52:21 -0800 Landed http://trac.webkit.org/changeset/78519 354197 4 mrobinson 2011-02-19 11:02:23 -0800 *** Bug 54731 has been marked as a duplicate of this bug. *** 82368 2011-02-14 15:04:21 -0800 2011-02-14 15:08:18 -0800 Proposed patch datasource.patch text/plain 2934 alex ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Z3RrL0NoYW5nZUxvZwppbmRleCAyZmVmZDVkLi5hZGMzZTA0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMDItMTQgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGln YWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW0dUS10gdGVzdHdlYmRhdGFzb3VyY2UgdGVzdCBmYWlscyBpbiB0aGUgYm90cworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ0MTQKKworICAgICAg ICBDaGFuZ2VkIHRoZSB1cmkgd2UgY2hlY2ssIGFkZGVkIHd3dyB0byBhdm9pZCB0aGUgcmV3cml0 ZSB0aGF0IHdlCisgICAgICAgIGdldCB3aGVuIHdlIGFzIHRoZSB1cmkgdG8gdGhlIHJlcXVlc3Qg aW4gY2FzZSBpdCBmaW5pc2hlcy4KKworICAgICAgICAqIHRlc3RzL3Rlc3R3ZWJkYXRhc291cmNl LmM6CisgICAgICAgIChub3RpZnlfbG9hZF9zdGF0dXNfY2IpOgorCiAyMDExLTAyLTExICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByNzgzMzEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay90 ZXN0cy90ZXN0d2ViZGF0YXNvdXJjZS5jIGIvU291cmNlL1dlYktpdC9ndGsvdGVzdHMvdGVzdHdl YmRhdGFzb3VyY2UuYwppbmRleCA5NmQ5NWU0Li5kNjk4MTlmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay90ZXN0cy90ZXN0d2ViZGF0YXNvdXJjZS5jCisrKyBiL1NvdXJjZS9XZWJLaXQv Z3RrL3Rlc3RzL3Rlc3R3ZWJkYXRhc291cmNlLmMKQEAgLTg5LDEzICs4OSwxMyBAQCBzdGF0aWMg dm9pZCBub3RpZnlfbG9hZF9zdGF0dXNfY2IoV2ViS2l0V2ViVmlldyogdmlldywgR1BhcmFtU3Bl YyogcHNwZWMsIEdNYWluTAogICAgIC8qIFRlc3QgZ2V0X3JlcXVlc3QgKi8KICAgICBnX3Rlc3Rf bWVzc2FnZSgiVGVzdGluZyB3ZWJraXRfd2ViX2RhdGFfc291cmNlX2dldF9yZXF1ZXN0Iik7CiAg ICAgV2ViS2l0TmV0d29ya1JlcXVlc3QqIHJlcXVlc3QgPSB3ZWJraXRfd2ViX2RhdGFfc291cmNl X2dldF9yZXF1ZXN0KGRhdGFTb3VyY2UpOwotICAgIGdfYXNzZXJ0X2NtcHN0cih3ZWJraXRfbmV0 d29ya19yZXF1ZXN0X2dldF91cmkocmVxdWVzdCksID09LCAiaHR0cDovL3dlYmtpdC5vcmcvIik7 CisgICAgZ19hc3NlcnRfY21wc3RyKHdlYmtpdF9uZXR3b3JrX3JlcXVlc3RfZ2V0X3VyaShyZXF1 ZXN0KSwgPT0sICJodHRwOi8vd3d3LndlYmtpdC5vcmcvIik7CiAKICAgICAvKiBUZXN0IGdldF9t YWluX3Jlc291cmNlICovCiAgICAgZ190ZXN0X21lc3NhZ2UoIlRlc3Rpbmcgd2Via2l0X3dlYl9k YXRhX3NvdXJjZV9nZXRfbWFpbl9yZXNvdXJjZSIpOwogICAgIFdlYktpdFdlYlJlc291cmNlKiBy ZXNvdXJjZSA9IHdlYmtpdF93ZWJfZGF0YV9zb3VyY2VfZ2V0X21haW5fcmVzb3VyY2UoZGF0YVNv dXJjZSk7CiAgICAgZ19hc3NlcnRfY21wc3RyKCJ0ZXh0L2h0bWwiLCA9PSwgd2Via2l0X3dlYl9y ZXNvdXJjZV9nZXRfbWltZV90eXBlKHJlc291cmNlKSk7Ci0gICAgZ19hc3NlcnRfY21wc3RyKCJo dHRwOi8vd2Via2l0Lm9yZy8iLCA9PSwgd2Via2l0X3dlYl9yZXNvdXJjZV9nZXRfdXJpKHJlc291 cmNlKSk7CisgICAgZ19hc3NlcnRfY21wc3RyKCJodHRwOi8vd3d3LndlYmtpdC5vcmcvIiwgPT0s IHdlYmtpdF93ZWJfcmVzb3VyY2VfZ2V0X3VyaShyZXNvdXJjZSkpOwogCiAgICAgLyogVGVzdCBn ZXRfZGF0YS4gV2UganVzdCB0ZXN0IGlmIGRhdGEgaGFzIGNlcnRhaW4gc2l6ZSBmb3IgdGhlIG1l YW4gdGltZSAqLwogICAgIGdfdGVzdF9tZXNzYWdlKCJUZXN0aW5nIHdlYmtpdF93ZWJfZGF0YV9z b3VyY2VfZ2V0X2RhdGEgaGFzIGNlcnRhaW4gc2l6ZSIpOwpAQCAtMTI0LDcgKzEyNCw3IEBAIHN0 YXRpYyB2b2lkIHRlc3Rfd2Via2l0X3dlYl9kYXRhX3NvdXJjZSgpCiAgICAgZ19vYmplY3RfcmVm X3Npbmsodmlldyk7CiAgICAgbG9vcCA9IGdfbWFpbl9sb29wX25ldyhOVUxMLCBUUlVFKTsKICAg ICBnX3NpZ25hbF9jb25uZWN0KHZpZXcsICJub3RpZnk6OmxvYWQtc3RhdHVzIiwgR19DQUxMQkFD Syhub3RpZnlfbG9hZF9zdGF0dXNfY2IpLCBsb29wKTsKLSAgICB3ZWJraXRfd2ViX3ZpZXdfbG9h ZF91cmkodmlldywgImh0dHA6Ly93ZWJraXQub3JnIik7CisgICAgd2Via2l0X3dlYl92aWV3X2xv YWRfdXJpKHZpZXcsICJodHRwOi8vd3d3LndlYmtpdC5vcmciKTsKIAogICAgIHdhaXRUaW1lciA9 IGdfdGltZW91dF9hZGRfc2Vjb25kcyhkZWZhdWx0VGltZW91dCwgKEdTb3VyY2VGdW5jKXdhaXRf dGltZXJfZmlyZWQsIGxvb3ApOwogCkBAIC0xNjMsNyArMTYzLDcgQEAgc3RhdGljIHZvaWQgdGVz dF93ZWJraXRfd2ViX2RhdGFfc291cmNlX2xpZmV0aW1lKCkKICAgICBnX29iamVjdF9yZWZfc2lu ayh2aWV3KTsKICAgICBsb29wID0gZ19tYWluX2xvb3BfbmV3KE5VTEwsIFRSVUUpOwogICAgIGdf c2lnbmFsX2Nvbm5lY3QodmlldywgIm5vdGlmeTo6bG9hZC1zdGF0dXMiLCBHX0NBTExCQUNLKG5v dGlmeV9sb2FkX3N0YXR1c19saWZldGltZV9jYiksIGxvb3ApOwotICAgIHdlYmtpdF93ZWJfdmll d19sb2FkX3VyaSh2aWV3LCAiaHR0cDovL3dlYmtpdC5vcmciKTsKKyAgICB3ZWJraXRfd2ViX3Zp ZXdfbG9hZF91cmkodmlldywgImh0dHA6Ly93d3cud2Via2l0Lm9yZyIpOwogCiAgICAgd2FpdFRp bWVyID0gZ190aW1lb3V0X2FkZF9zZWNvbmRzKGRlZmF1bHRUaW1lb3V0LCAoR1NvdXJjZUZ1bmMp d2FpdF90aW1lcl9maXJlZCwgbG9vcCk7CiAK