54413 2011-02-14 14:40:42 -0800 Shared memory should be made shared immediately 2011-02-14 15:01:34 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 350895 0 andersca 2011-02-14 14:40:42 -0800 Shared memory should be made shared immediately 350898 1 82366 andersca 2011-02-14 14:42:57 -0800 Created attachment 82366 Patch 350907 2 82366 mitz 2011-02-14 14:58:37 -0800 Comment on attachment 82366 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82366&action=review > Source/WebKit2/Platform/mac/SharedMemoryMac.cpp:109 > + It would be good to assert here the memoryObjectSize is no less than size. 350909 3 andersca 2011-02-14 15:01:34 -0800 Committed r78513: <http://trac.webkit.org/changeset/78513> 82366 2011-02-14 14:42:57 -0800 2011-02-14 14:58:37 -0800 Patch bug-54413-20110214144259.patch text/plain 4614 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NTA5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDItMTQgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBTaGFyZWQgbWVtb3J5IHNob3VsZCBiZSBtYWRlIHNoYXJl ZCBpbW1lZGlhdGVseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTQ0MTMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzg5NzIxNTM+CisKKyAgICAgICAg VW5kZXIgc29tZSBjaXJjdW1zdGFuY2VzLCBtYWNoX21ha2VfbWVtb3J5X2VudHJ5XzY0IG1heSBv bmx5IHJldHVybiBwYXJ0cyBvZiBhCisgICAgICAgIG1lbW9yeSBhbGxvY2F0aW9uLiBXb3JrIGFy b3VuZCB0aGlzIGJ5IGNyZWF0aW5nIGEgbWFjaCBwb3J0IHJlcHJlc2VudGluZyB0aGUgc2hhcmVk IG1lbW9yeQorICAgICAgICByaWdodCBhd2F5LiBBbHNvLCBoYW5kIG91dCB0aGlzIG1hY2ggcG9y dCBpbiBjcmVhdGVIYW5kbGUgd2hlbiB1c2luZyB0aGUgZGVmYXVsdCBtZW1vcnkgcHJvdGVjdGlv bi4KKworICAgICAgICAqIFBsYXRmb3JtL1NoYXJlZE1lbW9yeS5oOgorICAgICAgICAqIFBsYXRm b3JtL21hYy9TaGFyZWRNZW1vcnlNYWMuY3BwOgorICAgICAgICAoV2ViS2l0OjpTaGFyZWRNZW1v cnk6OmNyZWF0ZSk6CisgICAgICAgIChXZWJLaXQ6OlNoYXJlZE1lbW9yeTo6flNoYXJlZE1lbW9y eSk6CisgICAgICAgIChXZWJLaXQ6OlNoYXJlZE1lbW9yeTo6Y3JlYXRlSGFuZGxlKToKKwogMjAx MS0wMi0xNCAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVhY3Qg dG8gYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgY2hhbmdlcyBhbmQgYWxsb2NhdGlvbiBmYWlsdXJl cyBpbiBEcmF3aW5nQXJlYUltcGw6OmRpc3BsYXkKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1BsYXRm b3JtL1NoYXJlZE1lbW9yeS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3Jt L1NoYXJlZE1lbW9yeS5oCShyZXZpc2lvbiA3ODUwNCkKKysrIFNvdXJjZS9XZWJLaXQyL1BsYXRm b3JtL1NoYXJlZE1lbW9yeS5oCSh3b3JraW5nIGNvcHkpCkBAIC05NSw3ICs5NSw5IEBAIHB1Ymxp YzoKIHByaXZhdGU6CiAgICAgc2l6ZV90IG1fc2l6ZTsKICAgICB2b2lkKiBtX2RhdGE7Ci0jaWYg UExBVEZPUk0oV0lOKQorI2lmIFBMQVRGT1JNKE1BQykKKyAgICBtYWNoX3BvcnRfdCBtX3BvcnQ7 CisjZWxpZiBQTEFURk9STShXSU4pCiAgICAgSEFORExFIG1faGFuZGxlOwogI2VsaWYgUExBVEZP Uk0oUVQpCiAgICAgaW50IG1fZmlsZURlc2NyaXB0b3I7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9Q bGF0Zm9ybS9tYWMvU2hhcmVkTWVtb3J5TWFjLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9QbGF0Zm9ybS9tYWMvU2hhcmVkTWVtb3J5TWFjLmNwcAkocmV2aXNpb24gNzg1MDQpCisr KyBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9tYWMvU2hhcmVkTWVtb3J5TWFjLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtOTgsOSArOTgsMTkgQEAgUGFzc1JlZlB0cjxTaGFyZWRNZW1vcnk+IFNoYXJl ZE1lbW9yeTo6YwogICAgIGlmIChrciAhPSBLRVJOX1NVQ0NFU1MpCiAgICAgICAgIHJldHVybiAw OwogCisgICAgLy8gQ3JlYXRlIGEgTWFjaCBwb3J0IHRoYXQgcmVwcmVzZW50cyB0aGUgc2hhcmVk IG1lbW9yeS4KKyAgICBtYWNoX3BvcnRfdCBwb3J0OworICAgIG1lbW9yeV9vYmplY3Rfc2l6ZV90 IG1lbW9yeU9iamVjdFNpemUgPSByb3VuZF9wYWdlKHNpemUpOworICAgIGtyID0gbWFjaF9tYWtl X21lbW9yeV9lbnRyeV82NChtYWNoX3Rhc2tfc2VsZigpLCAmbWVtb3J5T2JqZWN0U2l6ZSwgYWRk cmVzcywgVk1fUFJPVF9ERUZBVUxULCAmcG9ydCwgTUFDSF9QT1JUX05VTEwpOworICAgIGlmIChr ciAhPSBLRVJOX1NVQ0NFU1MpIHsKKyAgICAgICAgbWFjaF92bV9kZWFsbG9jYXRlKG1hY2hfdGFz a19zZWxmKCksIGFkZHJlc3MsIHJvdW5kX3BhZ2Uoc2l6ZSkpOworICAgICAgICByZXR1cm4gZmFs c2U7CisgICAgfQorCiAgICAgUmVmUHRyPFNoYXJlZE1lbW9yeT4gc2hhcmVkTWVtb3J5KGFkb3B0 UmVmKG5ldyBTaGFyZWRNZW1vcnkpKTsKICAgICBzaGFyZWRNZW1vcnktPm1fc2l6ZSA9IHNpemU7 CiAgICAgc2hhcmVkTWVtb3J5LT5tX2RhdGEgPSB0b1BvaW50ZXIoYWRkcmVzcyk7CisgICAgc2hh cmVkTWVtb3J5LT5tX3BvcnQgPSBwb3J0OwogCiAgICAgcmV0dXJuIHNoYXJlZE1lbW9yeS5yZWxl YXNlKCk7CiB9CkBAIC0xMzMsMTcgKzE0MywyMiBAQCBQYXNzUmVmUHRyPFNoYXJlZE1lbW9yeT4g U2hhcmVkTWVtb3J5OjpjCiAgICAgUmVmUHRyPFNoYXJlZE1lbW9yeT4gc2hhcmVkTWVtb3J5KGFk b3B0UmVmKG5ldyBTaGFyZWRNZW1vcnkpKTsKICAgICBzaGFyZWRNZW1vcnktPm1fc2l6ZSA9IGhh bmRsZS5tX3NpemU7CiAgICAgc2hhcmVkTWVtb3J5LT5tX2RhdGEgPSB0b1BvaW50ZXIobWFwcGVk QWRkcmVzcyk7Ci0gICAgCisgICAgc2hhcmVkTWVtb3J5LT5tX3BvcnQgPSBNQUNIX1BPUlRfTlVM TDsKKwogICAgIHJldHVybiBzaGFyZWRNZW1vcnkucmVsZWFzZSgpOwogfQogCiBTaGFyZWRNZW1v cnk6On5TaGFyZWRNZW1vcnkoKQogewotICAgIGlmICghbV9kYXRhKQotICAgICAgICByZXR1cm47 Ci0gICAgCi0gICAga2Vybl9yZXR1cm5fdCBrciA9IG1hY2hfdm1fZGVhbGxvY2F0ZShtYWNoX3Rh c2tfc2VsZigpLCB0b1ZNQWRkcmVzcyhtX2RhdGEpLCByb3VuZF9wYWdlKG1fc2l6ZSkpOwotICAg IEFTU0VSVF9VTlVTRUQoa3IsIGtyID09IEtFUk5fU1VDQ0VTUyk7CisgICAgaWYgKG1fZGF0YSkg eworICAgICAgICBrZXJuX3JldHVybl90IGtyID0gbWFjaF92bV9kZWFsbG9jYXRlKG1hY2hfdGFz a19zZWxmKCksIHRvVk1BZGRyZXNzKG1fZGF0YSksIHJvdW5kX3BhZ2UobV9zaXplKSk7CisgICAg ICAgIEFTU0VSVF9VTlVTRUQoa3IsIGtyID09IEtFUk5fU1VDQ0VTUyk7CisgICAgfQorCisgICAg aWYgKG1fcG9ydCkgeworICAgICAgICBrZXJuX3JldHVybl90IGtyID0gbWFjaF9wb3J0X2RlYWxs b2NhdGUobWFjaF90YXNrX3NlbGYoKSwgbV9wb3J0KTsKKyAgICAgICAgQVNTRVJUX1VOVVNFRChr ciwga3IgPT0gS0VSTl9TVUNDRVNTKTsKKyAgICB9ICAgICAgICAKIH0KICAgICAKIGJvb2wgU2hh cmVkTWVtb3J5OjpjcmVhdGVIYW5kbGUoSGFuZGxlJiBoYW5kbGUsIFByb3RlY3Rpb24gcHJvdGVj dGlvbikKQEAgLTE1NCwxMSArMTY5LDIxIEBAIGJvb2wgU2hhcmVkTWVtb3J5OjpjcmVhdGVIYW5k bGUoSGFuZGxlJiAKICAgICBtYWNoX3ZtX2FkZHJlc3NfdCBhZGRyZXNzID0gdG9WTUFkZHJlc3Mo bV9kYXRhKTsKICAgICBtZW1vcnlfb2JqZWN0X3NpemVfdCBzaXplID0gcm91bmRfcGFnZShtX3Np emUpOwogCi0gICAgLy8gQ3JlYXRlIGEgbWFjaCBwb3J0IHRoYXQgcmVwcmVzZW50cyB0aGUgc2hh cmVkIG1lbW9yeS4KICAgICBtYWNoX3BvcnRfdCBwb3J0OwotICAgIGtlcm5fcmV0dXJuX3Qga3Ig PSBtYWNoX21ha2VfbWVtb3J5X2VudHJ5XzY0KG1hY2hfdGFza19zZWxmKCksICZzaXplLCBhZGRy ZXNzLCBtYWNoUHJvdGVjdGlvbihwcm90ZWN0aW9uKSwgJnBvcnQsIE1BQ0hfUE9SVF9OVUxMKTsK LSAgICBpZiAoa3IgIT0gS0VSTl9TVUNDRVNTKQotICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAg ICBpZiAocHJvdGVjdGlvbiA9PSBSZWFkV3JpdGUgJiYgbV9wb3J0KSB7CisgICAgICAgIC8vIEp1 c3QgcmUtdXNlIHRoZSBwb3J0IHdlIGhhdmUuCisgICAgICAgIHBvcnQgPSBtX3BvcnQ7CisgICAg ICAgIGlmIChtYWNoX3BvcnRfbW9kX3JlZnMobWFjaF90YXNrX3NlbGYoKSwgcG9ydCwgTUFDSF9Q T1JUX1JJR0hUX1NFTkQsIDEpICE9IEtFUk5fU1VDQ0VTUykKKyAgICAgICAgICAgIHJldHVybiBm YWxzZTsKKyAgICB9IGVsc2UgeworICAgICAgICAvLyBDcmVhdGUgYSBtYWNoIHBvcnQgdGhhdCBy ZXByZXNlbnRzIHRoZSBzaGFyZWQgbWVtb3J5LgorICAgICAgICBrZXJuX3JldHVybl90IGtyID0g bWFjaF9tYWtlX21lbW9yeV9lbnRyeV82NChtYWNoX3Rhc2tfc2VsZigpLCAmc2l6ZSwgYWRkcmVz cywgbWFjaFByb3RlY3Rpb24ocHJvdGVjdGlvbiksICZwb3J0LCBNQUNIX1BPUlRfTlVMTCk7Cisg ICAgICAgIGlmIChrciAhPSBLRVJOX1NVQ0NFU1MpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7 CisKKyAgICAgICAgQVNTRVJUKHNpemUgPT0gcm91bmRfcGFnZShtX3NpemUpKTsKKyAgICB9CiAK ICAgICBoYW5kbGUubV9wb3J0ID0gcG9ydDsKICAgICBoYW5kbGUubV9zaXplID0gc2l6ZTsK