54409 2011-02-14 13:20:18 -0800 compositing/direct-image-compositing.html fails after r78484 2011-02-18 19:53:48 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 54143 1 pkasting enne commit-queue enne jamesr kbr mihaip vangelis oldest_to_newest 350844 0 pkasting 2011-02-14 13:20:18 -0800 See test results at http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=compositing%2Fdirect-image-compositing.html&showExpectations=true&group=%40ToT%20GPU%20-%20chromium.org . Notice the difference in how the blurs on the left side of the result page look. 350857 1 pkasting 2011-02-14 13:48:09 -0800 It looks as if the following failures are also caused by this change. Note that in these cases, the difference generally looks like something I'd rebaseline for, but since the test in comment 0 is clearly a significant change I'm going to just mark all these as failing until you can look. compositing/geometry/fixed-position.html compositing/geometry/horizontal-scroll-composited.html compositing/geometry/vertical-scroll-composited.html compositing/masks/masked-ancestor.html compositing/masks/simple-composited-mask.html compositing/overflow/fixed-position-ancestor-clip.html fast/canvas/canvas-text-alignment.html fast/canvas/image-object-in-canvas.html http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=compositing%2Fgeometry%2Ffixed-position.html%2Ccompositing%2Fgeometry%2Fhorizontal-scroll-composited.html%2Ccompositing%2Fgeometry%2Fvertical-scroll-composited.html%2Ccompositing%2Fmasks%2Fmasked-ancestor.html%2Ccompositing%2Fmasks%2Fsimple-composited-mask.html%2Ccompositing%2Foverflow%2Ffixed-position-ancestor-clip.html%2Cfast%2Fcanvas%2Fcanvas-text-alignment.html%2Cfast%2Fcanvas%2Fimage-object-in-canvas.html&showExpectations=true&group=%40ToT%20GPU%20-%20chromium.org 350896 2 enne 2011-02-14 14:41:06 -0800 Thanks for filing this with all the additional cases. It looks like it's an extremely small change and not anything as large as an off-by-one texel issue. The scrollbars on the fixed-position test go from RGB a4a4a4 to a3a3a3. My intuition is that this is floating point error in the texture transform going to the shader causing a minute amount of filtering. 353664 3 82979 enne 2011-02-18 10:42:19 -0800 Created attachment 82979 Patch 353668 4 enne 2011-02-18 10:47:56 -0800 This patch fixes some issues on Linux (but breaks tests because of the recent rebaselining). It fixes some issues on Windows, but I'll point out that it breaks a few issues from the pre-patch rebaselining. However, I think nearest sampling will give more consistent results in the future, so I will rebaseline all of the tests affected by this patch after this lands. Obviously once we have tiled content layers, we can add an option for bilinear filtering on those layers. 353726 5 82979 kbr 2011-02-18 11:57:47 -0800 Comment on attachment 82979 Patch Looks okay to me. 354032 6 82979 commit-queue 2011-02-18 19:53:43 -0800 Comment on attachment 82979 Patch Clearing flags on attachment: 82979 Committed r79084: <http://trac.webkit.org/changeset/79084> 354033 7 commit-queue 2011-02-18 19:53:48 -0800 All reviewed patches have been landed. Closing bug. 82979 2011-02-18 10:42:19 -0800 2011-02-18 19:53:43 -0800 Patch bug-54409-20110218104218.patch text/plain 5040 enne U3VidmVyc2lvbiBSZXZpc2lvbjogNzg4MjUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1OTI3YzVlMDVkMjIwODg4MWQ5YTYx YmY0YWMwYmE0ZjgxOTZjYmI2Li42YjdhZjIzMDA2NzBlNjY2NGI3NzE4MTJhNWFmYWRiNTAwZjEw ZGNlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMTcgIEFkcmllbm5lIFdhbGtlciAg PGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGp1c3QgZXhwZWN0YXRpb25zIGZvciBjaHJvbWl1bSBHUFUgdGVzdHMuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDQwOQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ1MDkKKworICAg ICAgICBDb3JyZWN0IGJhc2VsaW5lcyBmb3IgdGhlIDU0NDA5IGltYWdlcyB3aWxsIGJlIGdlbmVy YXRlZCBhZnRlciB0aGlzIGxhbmRzLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vdGVz dF9leHBlY3RhdGlvbnMudHh0OgorCiAyMDExLTAyLTE3ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5v cm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByZWJhc2VsaW5lIEdUSyB0 ZXN0IHJlc3VsdHMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90 ZXN0X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0 X2V4cGVjdGF0aW9ucy50eHQKb2xkIG1vZGUgMTAwNjQ0Cm5ldyBtb2RlIDEwMDc1NQppbmRleCAw NGJmNTZhODYwMGVmZDhkYzIwODU2MjYwYWQyYTllNTdjMzAxZTRhLi45NzE4ZjgyNTAwYzk1ZDRh ZjhhY2E3YzgxNzBlOGI2YzYwNjMwOTFhCi0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9t aXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJv bWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKQEAgLTMwNDksNyArMzA0OSw2IEBAIEJVR1dLNDcy MzEgR1BVIDogY29tcG9zaXRpbmcvdmlkZW8vdmlkZW8tYmFja2dyb3VuZC1jb2xvci5odG1sID0g VElNRU9VVAogQlVHV0s0NzIzMSBHUFUgOiBjb21wb3NpdGluZy92aWRlby92aWRlby1wb3N0ZXIu aHRtbCA9IFRJTUVPVVQKIAogQlVHV0s0NzkyMyBHUFUgOiBjb21wb3NpdGluZy9nZW9tZXRyeS9s aW1pdC1sYXllci1ib3VuZHMtb3BhY2l0eS10cmFuc2l0aW9uLmh0bWwgPSBUSU1FT1VUCi1CVUdX SzU0NTA5IEdQVSA6IGNvbXBvc2l0aW5nL2NoZWNrZXJib2FyZC5odG1sID0gSU1BR0UKIAogLy8g VGhlIGZvbGxvd2luZyB0ZXN0IGlzIGZsYWt5OyBpdCBvY2Nhc2lvbmFsbHkgdGltZXMgb3V0LCBi dXQgbm90IGFsd2F5cy4KIEJVR1dLNDc5MjQgR1BVIFdJTiBMSU5VWCA6IGNvbXBvc2l0aW5nL2lm cmFtZXMvY29tcG9zaXRlZC1pZnJhbWUtYWxpZ25tZW50Lmh0bWwgPSBUSU1FT1VUIFBBU1MKQEAg LTMxMjgsMTUgKzMxMjcsMTMgQEAgQlVHV0s1MzQ2OSBHUFUgTUFDIDogY29tcG9zaXRpbmcvc2Ny b2xsLXBhaW50ZWQtY29tcG9zaXRlZC1jb250ZW50Lmh0bWwgPSBDUkFTSAogCiBCVUdXSzU0NDA5 IEdQVSBERUJVRyA6IGZhc3QvY2FudmFzL2ltYWdlLW9iamVjdC1pbi1jYW52YXMuaHRtbCA9IElN QUdFCiBCVUdXSzU0NDA5IEdQVSBERUJVRyA6IGZhc3QvY2FudmFzL2NhbnZhcy10ZXh0LWFsaWdu bWVudC5odG1sID0gSU1BR0UKLUJVR1dLNTQ0MDkgR1BVIFdJTiA6IGNvbXBvc2l0aW5nL2RpcmVj dC1pbWFnZS1jb21wb3NpdGluZy5odG1sID0gSU1BR0UKLUJVR1dLNTQ0MDkgR1BVIFdJTiA6IGNv bXBvc2l0aW5nL2dlb21ldHJ5L2ZpeGVkLXBvc2l0aW9uLmh0bWwgPSBJTUFHRQotQlVHV0s1NDQw OSBHUFUgV0lOIDogY29tcG9zaXRpbmcvZ2VvbWV0cnkvaG9yaXpvbnRhbC1zY3JvbGwtY29tcG9z aXRlZC5odG1sID0gSU1BR0UKLUJVR1dLNTQ0MDkgR1BVIE1BQyA6IGNvbXBvc2l0aW5nL2dlb21l dHJ5L3ZlcnRpY2FsLXNjcm9sbC1jb21wb3NpdGVkLmh0bWwgPSBJTUFHRQotQlVHV0s1NDQwOSBH UFUgV0lOIDogY29tcG9zaXRpbmcvbWFza3MvbWFza2VkLWFuY2VzdG9yLmh0bWwgPSBJTUFHRQor QlVHV0s1NDQwOSBHUFUgTElOVVggOiBjb21wb3NpdGluZy9kaXJlY3QtaW1hZ2UtY29tcG9zaXRp bmcuaHRtbCA9IElNQUdFCitCVUdXSzU0NDA5IEdQVSBXSU4gTElOVVggOiBjb21wb3NpdGluZy9n ZW9tZXRyeS9maXhlZC1wb3NpdGlvbi5odG1sID0gSU1BR0UKK0JVR1dLNTQ0MDkgR1BVIFdJTiBM SU5VWCA6IGNvbXBvc2l0aW5nL2dlb21ldHJ5L2hvcml6b250YWwtc2Nyb2xsLWNvbXBvc2l0ZWQu aHRtbCA9IElNQUdFCitCVUdXSzU0NDA5IEdQVSBXSU4gTUFDIExJTlVYIDogY29tcG9zaXRpbmcv Z2VvbWV0cnkvdmVydGljYWwtc2Nyb2xsLWNvbXBvc2l0ZWQuaHRtbCA9IElNQUdFCiBCVUdXSzU0 NDA5IEdQVSBERUJVRyBMSU5VWCA6IGNvbXBvc2l0aW5nL21hc2tzL21hc2tlZC1hbmNlc3Rvci5o dG1sID0gSU1BR0UKLUJVR1dLNTQ0MDkgR1BVIFdJTiA6IGNvbXBvc2l0aW5nL21hc2tzL3NpbXBs ZS1jb21wb3NpdGVkLW1hc2suaHRtbCA9IElNQUdFCiBCVUdXSzU0NDA5IEdQVSBERUJVRyBMSU5V WCA6IGNvbXBvc2l0aW5nL21hc2tzL3NpbXBsZS1jb21wb3NpdGVkLW1hc2suaHRtbCA9IElNQUdF Ci1CVUdXSzU0NDA5IEdQVSA6IGNvbXBvc2l0aW5nL292ZXJmbG93L2ZpeGVkLXBvc2l0aW9uLWFu Y2VzdG9yLWNsaXAuaHRtbCA9IElNQUdFCitCVUdXSzU0NDA5IEdQVSBXSU4gOiBjb21wb3NpdGlu Zy9vdmVyZmxvdy9maXhlZC1wb3NpdGlvbi1hbmNlc3Rvci1jbGlwLmh0bWwgPSBJTUFHRQogCiBC VUdDUjcyMjIzIDogbWVkaWEvdmlkZW8tZnJhbWUtYWNjdXJhdGUtc2Vlay5odG1sID0gSU1BR0Ug UEFTUwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggZGU3YjllMDI4OTI4ZDhiZGM5OThmM2EyYzdlM2EyNzFmMzVi M2Y2MC4uYjVlNzE0ZGViNDlhNDhkMmRhOTgzZjBiNjE5NmM2MWZlNDhhMzFjOCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTAyLTE3ICBBZHJpZW5uZSBXYWxrZXIgIDxlbm5lQGdv b2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW2Nocm9taXVtXSBVc2UgbmVhcmVzdC1uZWlnaGJvciBmaWx0ZXJpbmcgZm9yIHJvb3QgbGF5 ZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDQw OQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ1MDkK KworICAgICAgICBUaGlzIHNldHRpbmcgY3JlYXRlcyBtb3JlIGNvbnNpc3RlbnQgaW1hZ2VzIGZv ciBMYXlvdXRUZXN0cyBhbmQKKyAgICAgICAgcHJldmVudHMgc21hbGwgZmxvYXRpbmcgcG9pbnQg ZXJyb3JzIGluIHRleHR1cmUgY29vcmRpbmF0ZXMgZnJvbQorICAgICAgICBjcmVhdGluZyBvZmYt Ynktb25lIHBpeGVsIGNvbG9yIGRpZmZlcmVuY2VzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vTGF5ZXJUaWxlckNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkxheWVyVGlsZXJDaHJvbWl1bTo6dXBkYXRlKToKKwogMjAxMS0wMi0xNyAgSHVpIEh1YW5nICA8 aHVpLjIuaHVhbmdAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IExhc3psbyBHb21i b3MuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9MYXllclRpbGVyQ2hyb21pdW0uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2hyb21pdW0vTGF5ZXJUaWxlckNocm9taXVtLmNwcAppbmRleCBjOGFjMDIxNjc4MzMzNTVi M2M3NjBkNTRhODc2ZDZkNmQ0N2ZjYTYwLi40NzkzMjg5MjAzMDkyYTMwZjkxNTllMzhmN2Y3ZWM3 OWIyYzc4NTllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9MYXllclRpbGVyQ2hyb21pdW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyVGlsZXJDaHJvbWl1bS5jcHAKQEAgLTM3Myw2ICsz NzMsOSBAQCB2b2lkIExheWVyVGlsZXJDaHJvbWl1bTo6dXBkYXRlKFRpbGVQYWludEludGVyZmFj ZSYgcGFpbnRlciwgY29uc3QgSW50UmVjdCYgY29udAogICAgICAgICAgICAgfQogCiAgICAgICAg ICAgICB0aWxlLT50ZXh0dXJlKCktPmJpbmRUZXh0dXJlKCk7CisgICAgICAgICAgICBHTEMoY29u dGV4dCwgY29udGV4dC0+dGV4UGFyYW1ldGVyaShHcmFwaGljc0NvbnRleHQzRDo6VEVYVFVSRV8y RCwgR3JhcGhpY3NDb250ZXh0M0Q6OlRFWFRVUkVfTUlOX0ZJTFRFUiwgR3JhcGhpY3NDb250ZXh0 M0Q6Ok5FQVJFU1QpKTsKKyAgICAgICAgICAgIEdMQyhjb250ZXh0LCBjb250ZXh0LT50ZXhQYXJh bWV0ZXJpKEdyYXBoaWNzQ29udGV4dDNEOjpURVhUVVJFXzJELCBHcmFwaGljc0NvbnRleHQzRDo6 VEVYVFVSRV9NQUdfRklMVEVSLCBHcmFwaGljc0NvbnRleHQzRDo6TkVBUkVTVCkpOworCiAgICAg ICAgICAgICBHTEMoY29udGV4dCwgY29udGV4dC0+dGV4U3ViSW1hZ2UyRChHcmFwaGljc0NvbnRl eHQzRDo6VEVYVFVSRV8yRCwgMCwgZGVzdFJlY3QueCgpLCBkZXN0UmVjdC55KCksIGRlc3RSZWN0 LndpZHRoKCksIGRlc3RSZWN0LmhlaWdodCgpLCBHcmFwaGljc0NvbnRleHQzRDo6UkdCQSwgR3Jh cGhpY3NDb250ZXh0M0Q6OlVOU0lHTkVEX0JZVEUsIHBpeGVsU291cmNlKSk7CiAKICAgICAgICAg ICAgIHRpbGUtPmNsZWFyRGlydHkoKTsK