54403 2011-02-14 11:28:13 -0800 Should turn off frame pointer omission (FPO) for Release (not Production) builds 2011-03-30 16:04:52 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 aroben webkit-unassigned sfalken oldest_to_newest 350783 0 aroben 2011-02-14 11:28:13 -0800 Should turn off frame pointer omission (FPO) for Release (not Release_LTCG) builds. This would make it easier to profile developer Release builds, while not harming customer builds (which use Release_LTCG). 350785 1 aroben 2011-02-14 11:28:48 -0800 Some people think FPO isn't really worth it, even for customer builds: <http://blogs.msdn.com/b/yvesdolc/archive/2009/09/15/consider-not-using-the-frame-pointer-optimization-when-building-your-software.aspx>. Apparently Microsoft isn't using it for its own software anymore. 350786 2 aroben 2011-02-14 11:29:25 -0800 It would be interesting to run some benchmarks with FPO on and off to see if it's even helping us appreciably. 356114 3 aroben 2011-02-23 08:51:19 -0800 (In reply to comment #2) > It would be interesting to run some benchmarks with FPO on and off to see if it's even helping us appreciably. I filed bug 55051 to cover this aspect. 356115 4 aroben 2011-02-23 08:51:40 -0800 I don't think we need to run benchmarks before turning off FPO for the Release configuration. 356122 5 aroben 2011-02-23 09:05:35 -0800 <rdar://problem/9042187> 376757 6 87633 sfalken 2011-03-30 15:58:19 -0700 Created attachment 87633 Patch 376760 7 87633 aroben 2011-03-30 15:59:02 -0700 Comment on attachment 87633 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87633&action=review > WebKitLibraries/win/tools/vsprops/release.vsprops:10 > + AdditionalOptions="/Oy-" > + OmitFramePointers="false" I think you should add a comment in the ChangeLog about why both of these are being set. 376763 8 aroben 2011-03-30 16:01:21 -0700 *** Bug 57510 has been marked as a duplicate of this bug. *** 376764 9 sfalken 2011-03-30 16:04:52 -0700 http://trac.webkit.org/changeset/82515 87633 2011-03-30 15:58:19 -0700 2011-03-30 15:59:02 -0700 Patch bug-54403-20110330155731.patch text/plain 1167 sfalken SW5kZXg6IFdlYktpdExpYnJhcmllcy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0TGli cmFyaWVzL0NoYW5nZUxvZwkocmV2aXNpb24gODI1MTMpCisrKyBXZWJLaXRMaWJyYXJpZXMvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDMtMzAgIFN0ZXZl IEZhbGtlbmJ1cmcgIDxzZmFsa2VuQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaG91bGQgdHVybiBvZmYgZnJhbWUgcG9pbnRlciBv bWlzc2lvbiAoRlBPKSBmb3IgUmVsZWFzZSAobm90IFByb2R1Y3Rpb24pIGJ1aWxkcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ0MDMKKworICAgICAg ICBMZWF2ZSBpdCBlbmFibGVkIGZvciBXaW5kb3dzIFByb2R1Y3Rpb24gYnVpbGRzLgorICAgICAg ICBEaXNhYmxpbmcgdGhpcyBvcHRpbWl6YXRpb24gaW1wcm92ZXMgc3RhY2sgdHJhY2VzIGZvciBt ZW1vcnkgYW5kIHBlcmZvcm1hbmNlIHRvb2xzIGxpa2UgdW1kaCBhbmQgeHBlcmYuCisKKyAgICAg ICAgKiB3aW4vdG9vbHMvdnNwcm9wcy9yZWxlYXNlLnZzcHJvcHM6CisKIDIwMTEtMDMtMzAgIFN0 ZXZlIEZhbGtlbmJ1cmcgIDxzZmFsa2VuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBBZGFtIFJvYmVuLgpJbmRleDogV2ViS2l0TGlicmFyaWVzL3dpbi90b29scy92c3Byb3BzL3Jl bGVhc2UudnNwcm9wcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRMaWJyYXJpZXMvd2luL3Rvb2xzL3Zz cHJvcHMvcmVsZWFzZS52c3Byb3BzCShyZXZpc2lvbiA4MjUxMCkKKysrIFdlYktpdExpYnJhcmll cy93aW4vdG9vbHMvdnNwcm9wcy9yZWxlYXNlLnZzcHJvcHMJKHdvcmtpbmcgY29weSkKQEAgLTYs NSArNiw3IEBACiAJPgogCTxUb29sCiAJCU5hbWU9IlZDQ0xDb21waWxlclRvb2wiCisJCUFkZGl0 aW9uYWxPcHRpb25zPSIvT3ktIgorCQlPbWl0RnJhbWVQb2ludGVycz0iZmFsc2UiCiAJLz4KIDwv VmlzdWFsU3R1ZGlvUHJvcGVydHlTaGVldD4K