54400 2011-02-14 10:15:26 -0800 Need WebKit API to determine whether we have a site icon for a given URL 2011-02-14 15:20:47 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 bweinstein bweinstein abarth aroben beidson eric webkit.review.bot oldest_to_newest 350734 0 bweinstein 2011-02-14 10:15:26 -0800 We need WebKit API to determine whether we have a site icon for a given URL. This will return true if we do, false if we will use the default icon. 350744 1 82331 bweinstein 2011-02-14 10:24:47 -0800 Created attachment 82331 [PATCH] Fix 350778 2 82331 beidson 2011-02-14 11:20:07 -0800 Comment on attachment 82331 [PATCH] Fix Can you add a space to the current newline instead of adding a new newline? 350782 3 bweinstein 2011-02-14 11:28:04 -0800 (In reply to comment #2) > (From update of attachment 82331 [details]) > Can you add a space to the current newline instead of adding a new newline? The file already had an extra newline, so I was able to delete it instead of adding a new one. Thanks for the review! 350904 4 webkit.review.bot 2011-02-14 14:57:59 -0800 http://trac.webkit.org/changeset/78498 might have broken GTK Linux 64-bit Debug 350926 5 bweinstein 2011-02-14 15:20:47 -0800 Landed in r78498. 82331 2011-02-14 10:24:47 -0800 2011-02-14 11:20:07 -0800 [PATCH] Fix has_site_icon.patch text/plain 3790 bweinstein SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NDg3KQorKysgU291cmNlL1dlYktpdC93 aW4vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDItMTQg IEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5lZWQgV2ViS2l0IEFQSSB0byBkZXRl cm1pbmUgd2hldGhlciB3ZSBoYXZlIGEgc2l0ZSBpY29uIGZvciBhIGdpdmVuIFVSTAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ0MDAKKyAgICAgICAg CisgICAgICAgIFRoaXMgcGF0Y2ggaW1wbGVtZW50cyBJV2ViSWNvbkRhdGFiYXNlOjpoYXNJY29u Rm9yVVJMIHdoaWNoIHRlbGxzIHVzIHdoZXRoZXIgb3Igbm90CisgICAgICAgIHdlIGhhdmUgYSBz aXRlIGljb24gZm9yIHRoZSBnaXZlbiBVUkwuCisKKyAgICAgICAgKiBJbnRlcmZhY2VzL0lXZWJJ Y29uRGF0YWJhc2UuaWRsOiBBZGRlZCBuZXcgZnVuY3Rpb24uCisgICAgICAgICogSW50ZXJmYWNl cy9XZWJLaXQuaWRsOiBUb3VjaGVkIHRvIG1ha2Ugc3VyZSBJbnRlcmZhY2VzIHJlYnVpbGRzLgor ICAgICAgICAqIFdlYkljb25EYXRhYmFzZS5jcHA6CisgICAgICAgIChXZWJJY29uRGF0YWJhc2U6 Omhhc0ljb25Gb3JVUkwpOiBDYWxsIEljb25EYXRhYmFzZTo6aWNvbkZvclBhZ2VVUkwgdG8gbWFr ZSBzdXJlIHdlCisgICAgICAgICAgICBsb2FkIHRoZSBpY29uIGZyb20gZGlzaywgYW5kIGNhbGwg aWNvblVSTEZvclBhZ2VVUkwgdG8gZGV0ZXJtaW5lIHdoZXRoZXIgb3Igbm90CisgICAgICAgICAg ICB3ZSBhY3R1YWxseSBoYXZlIGFuIGljb24uCisgICAgICAgICogV2ViSWNvbkRhdGFiYXNlLmg6 CisKIDIwMTEtMDItMTEgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL1dl Ykljb25EYXRhYmFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC93aW4vV2ViSWNv bkRhdGFiYXNlLmNwcAkocmV2aXNpb24gNzg0ODMpCisrKyBTb3VyY2UvV2ViS2l0L3dpbi9XZWJJ Y29uRGF0YWJhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNjEsNiArMjYxLDI2IEBAIEhSRVNV TFQgU1RETUVUSE9EQ0FMTFRZUEUgV2ViSWNvbkRhdGFiYXMKICAgICByZXR1cm4gU19PSzsKIH0K IAorSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBXZWJJY29uRGF0YWJhc2U6Omhhc0ljb25Gb3JV UkwoCisgICAgICAgIC8qIFtpbl0gKi8gQlNUUiB1cmwsCisgICAgICAgIC8qIFtvdXRdW3JldHZh bF0gKi8gQk9PTCogcmVzdWx0KQoreworICAgIGlmICghdXJsIHx8ICFyZXN1bHQpCisgICAgICAg IHJldHVybiBFX1BPSU5URVI7CisKKyAgICBTdHJpbmcgdXJsU3RyaW5nKHVybCwgU3lzU3RyaW5n TGVuKHVybCkpOworCisgICAgLy8gUGFzc2luZyBhIHNpemUgcGFyYW1ldGVyIG9mIDAsIDAgbWVh bnMgd2UgZG9uJ3QgY2FyZSBhYm91dCB0aGUgcmVzdWx0IG9mIHRoZSBpbWFnZSwgd2UganVzdAor ICAgIC8vIHdhbnQgdG8gbWFrZSBzdXJlIHRoZSByZWFkIGZyb20gZGlzayB0byBsb2FkIHRoZSBp Y29uIGlzIGtpY2tlZCBvZmYuCisgICAgaWNvbkRhdGFiYXNlKCktPmljb25Gb3JQYWdlVVJMKHVy bFN0cmluZywgSW50U2l6ZSgwLCAwKSk7CisKKyAgICAvLyBDaGVjayB0byBzZWUgaWYgd2UgaGF2 ZSBhIG5vbi1lbXB0eSBpY29uIFVSTCBmb3IgdGhlIHBhZ2UsIGFuZCBpZiB3ZSBkbywgd2UgaGF2 ZSBhbiBpY29uIGZvcgorICAgIC8vIHRoZSBwYWdlLgorICAgICpyZXN1bHQgPSAhKGljb25EYXRh YmFzZSgpLT5pY29uVVJMRm9yUGFnZVVSTCh1cmxTdHJpbmcpLmlzRW1wdHkoKSk7CisKKyAgICBy ZXR1cm4gU19PSzsKK30KKwogSEJJVE1BUCBjcmVhdGVESUIoTFBTSVpFIHNpemUpCiB7CiAgICAg Qml0bWFwSW5mbyBibUluZm8gPSBCaXRtYXBJbmZvOjpjcmVhdGUoSW50U2l6ZSgqc2l6ZSkpOwpJ bmRleDogU291cmNlL1dlYktpdC93aW4vV2ViSWNvbkRhdGFiYXNlLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC93aW4vV2ViSWNvbkRhdGFiYXNlLmgJKHJldmlzaW9uIDc4NDgzKQorKysg U291cmNlL1dlYktpdC93aW4vV2ViSWNvbkRhdGFiYXNlLmgJKHdvcmtpbmcgY29weSkKQEAgLTEw Miw2ICsxMDIsMTAgQEAgcHVibGljOgogICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxM VFlQRSBzZXRFbmFibGVkKCAKICAgICAgICAgLyogW2luXSAqLyBCT09MIC8qZmxhZyovKTsKIAor ICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBoYXNJY29uRm9yVVJMKAorICAg ICAgICAvKiBbaW5dICovIEJTVFIgdXJsLAorICAgICAgICAvKiBbcmV0dmFsXVtvdXRdICovIEJP T0wqIHJlc3VsdCk7CisKICAgICAvLyBJY29uRGF0YWJhc2VDbGllbnQKICAgICB2aXJ0dWFsIHZv aWQgZGlzcGF0Y2hEaWRSZW1vdmVBbGxJY29ucygpOwogICAgIHZpcnR1YWwgdm9pZCBkaXNwYXRj aERpZEFkZEljb25Gb3JQYWdlVVJMKGNvbnN0IFdURjo6U3RyaW5nJik7CkluZGV4OiBTb3VyY2Uv V2ViS2l0L3dpbi9JbnRlcmZhY2VzL0lXZWJJY29uRGF0YWJhc2UuaWRsCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQvd2luL0ludGVyZmFjZXMvSVdlYkljb25EYXRhYmFzZS5pZGwJKHJldmlz aW9uIDc4NDgzKQorKysgU291cmNlL1dlYktpdC93aW4vSW50ZXJmYWNlcy9JV2ViSWNvbkRhdGFi YXNlLmlkbAkod29ya2luZyBjb3B5KQpAQCAtMTY0LDQgKzE2NCwxMSBAQCBpbnRlcmZhY2UgSVdl Ykljb25EYXRhYmFzZSA6IElVbmtub3duCiAgICAgICAgIC0gKHZvaWQpc2V0RW5hYmxlZDooQk9P TClmbGFnOwogICAgICovCiAgICAgSFJFU1VMVCBzZXRFbmFibGVkKFtpbl0gQk9PTCBmbGFnKTsK KyAgICAKKyAgICAvKiEKKyAgICAgICAgQG1ldGhvZCBoYXNJY29uRm9yVVJMOgorICAgICAgICBA ZGlzY3Vzc2lvbiBSZXR1cm5zIHdoZXRoZXIgb3Igbm90IHRoZSBpY29uIGRhdGFiYXNlIGhhcyBh biBpY29uIGZvciB0aGlzIFVSTC4KKyAgICAgICAgQHBhcm0gdXJsIFRoZSBVUkwgdG8gdGVzdCBm b3IuCisgICAgKi8KKyAgICBIUkVTVUxUIGhhc0ljb25Gb3JVUkwoW2luXSBCU1RSIHVybCwgW291 dCwgcmV0dmFsXSBCT09MKiByZXN1bHQpOwogfQpJbmRleDogU291cmNlL1dlYktpdC93aW4vSW50 ZXJmYWNlcy9XZWJLaXQuaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvd2luL0ludGVy ZmFjZXMvV2ViS2l0LmlkbAkocmV2aXNpb24gNzg0ODMpCisrKyBTb3VyY2UvV2ViS2l0L3dpbi9J bnRlcmZhY2VzL1dlYktpdC5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTMwMiwzICszMDIsNCBAQCBs aWJyYXJ5IFdlYktpdAogICAgIH0KIH0KIAorCg==