54394 2011-02-14 08:15:22 -0800 [GTK] Bump GTK+3 dependency to 3.0 2011-02-20 01:25:17 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned gustavo mrobinson xan.lopez oldest_to_newest 350666 0 cgarcia 2011-02-14 08:15:22 -0800 Now that GTK+ has been released we should bump the dependency to 3.0. Maybe we should make it the default option now, falling back to gtk+2 when gtk+3 is not present. 350667 1 82318 cgarcia 2011-02-14 08:18:34 -0800 Created attachment 82318 Patch 353202 2 mrobinson 2011-02-17 15:22:33 -0800 This seems reasonable. I'd like to get Xan or Gustavo's approval as well though. 353211 3 xan.lopez 2011-02-17 15:38:03 -0800 I think making the dependency reflect the minimum version we actually need to compile makes sense, so I don't see any reason to do this. 353633 4 cgarcia 2011-02-18 09:42:34 -0800 (In reply to comment #3) > I think making the dependency reflect the minimum version we actually need to compile makes sense, so I don't see any reason to do this. Library name has changed, you won't be using gtk+ 3.0.x unless you bump the dependency to 3.0, I don't think we want to use 2.99.x. 353639 5 xan.lopez 2011-02-18 09:59:35 -0800 (In reply to comment #4) > Library name has changed, you won't be using gtk+ 3.0.x unless you bump the dependency to 3.0, I don't think we want to use 2.99.x. I didn't know they had changed them *again* for 3.0. You should have mentioned it in the bug report, neither me or Martin were aware of this. r=me then. 354261 6 cgarcia 2011-02-20 01:22:28 -0800 Committed r79150: <http://trac.webkit.org/changeset/79150> 354262 7 cgarcia 2011-02-20 01:25:03 -0800 (In reply to comment #5) > (In reply to comment #4) > > Library name has changed, you won't be using gtk+ 3.0.x unless you bump the dependency to 3.0, I don't think we want to use 2.99.x. > > I didn't know they had changed them *again* for 3.0. You should have mentioned it in the bug report, neither me or Martin were aware of this. r=me then. Ok, sorry, I thought that depending on an stable version was enough reason to bump requirements. Pushed now. 82318 2011-02-14 08:18:34 -0800 2011-02-20 01:25:17 -0800 Patch bump-gtk3.diff text/plain 1055 cgarcia ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAwOWZiN2YxLi5iMTMwNWVk IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTEtMDItMTQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEJ1 bXAgR1RLKzMgZGVwZW5kZW5jeSB0byAzLjAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTU0Mzk0CisKKyAgICAgICAgKiBjb25maWd1cmUuYWM6CisKIDIw MTEtMDItMTAgIFBldGVyIFZhcmdhICA8cHZhcmdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgQ3NhYmEgT3N6dHJvZ29uw6FjLgpkaWZmIC0tZ2l0IGEvY29uZmlndXJlLmFjIGIv Y29uZmlndXJlLmFjCmluZGV4IDYxMDQxNmMuLjBmMmM5ODAgMTAwNjQ0Ci0tLSBhL2NvbmZpZ3Vy ZS5hYworKysgYi9jb25maWd1cmUuYWMKQEAgLTE5OSwxNCArMTk5LDE0IEBAIGNhc2UgIiR3aXRo X2d0ayIgaW4KICAgICAgICAgICBHQUlMX1BDX05BTUU9Z2FpbAogICAgICAgICAgIEdBSUxfUkVR VUlSRURfVkVSU0lPTj0xLjgKICAgICAgICAgICA7OwotICAgICAzLjApIEdUS19SRVFVSVJFRF9W RVJTSU9OPTIuOTEuNworICAgICAzLjApIEdUS19SRVFVSVJFRF9WRVJTSU9OPTMuMAogICAgICAg ICAgIEdUS19BUElfVkVSU0lPTj0zLjAKICAgICAgICAgICBXRUJLSVRHVEtfQVBJX01BSk9SX1ZF UlNJT049MwogICAgICAgICAgIFdFQktJVEdUS19BUElfTUlOT1JfVkVSU0lPTj0wCiAgICAgICAg ICAgV0VCS0lUR1RLX0FQSV9WRVJTSU9OPTMuMAogICAgICAgICAgIFdFQktJVEdUS19QQ19OQU1F PXdlYmtpdGd0awogICAgICAgICAgIEdBSUxfUENfTkFNRT1nYWlsLTMuMAotICAgICAgICAgIEdB SUxfUkVRVUlSRURfVkVSU0lPTj0yLjkwLjQKKyAgICAgICAgICBHQUlMX1JFUVVJUkVEX1ZFUlNJ T049My4wCiAgICAgICAgICAgOzsKIGVzYWMKIAo=