54367 2011-02-13 15:43:55 -0800 WebCore fails to build with Clang's -Woverloaded-virtual 2011-02-22 15:36:16 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 54301 54305 54909 54914 54920 54922 54923 54924 1 zwarich webkit-unassigned andersca sam simon.fraser thakis zwarich oldest_to_newest 350470 0 zwarich 2011-02-13 15:43:55 -0800 WebCore fails to build with Clang's -Woverloaded-virtual for a number of reasons. We should fix them all (besides wanting to build with Clang), as they are usually the sign of real bugs. 350471 1 82280 zwarich 2011-02-13 15:47:41 -0800 Created attachment 82280 Patch for one case 350473 2 simon.fraser 2011-02-13 16:01:22 -0800 See bug 23120. 350474 3 zwarich 2011-02-13 16:03:13 -0800 Sorry for not finding the old bug. Unfortunately, this warning is enabled by default with Clang, whereas it is not enabled by default with GCC. ;-) Should we dupe them? 350477 4 zwarich 2011-02-13 16:14:37 -0800 Landed in r78447. 354976 5 thakis 2011-02-21 18:53:57 -0800 The blocker list is (at the moment) a complete list of issues that prevents turning this on for the chromium port. All but one of the blockers have patches waiting for review. 354981 6 thakis 2011-02-21 19:05:17 -0800 …and now they all have patches attached. 355656 7 thakis 2011-02-22 15:36:02 -0800 The chromium port now builds fine with clang. 355657 8 thakis 2011-02-22 15:36:16 -0800 (…with -Woverloaded-virtual, that is) 82280 2011-02-13 15:47:41 -0800 2011-02-13 16:08:19 -0800 Patch for one case ping-loader.patch text/plain 1403 zwarich SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NDQ0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDItMTMgIENhbWVyb24g WndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlYkNvcmUgZmFpbHMgdG8gYnVpbGQgd2l0aCBDbGFuZydz IC1Xb3ZlcmxvYWRlZC12aXJ0dWFsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01NDM2NworCisgICAgICAgICogbG9hZGVyL1BpbmdMb2FkZXIuaDoKKyAg ICAgICAgKFdlYkNvcmU6OlBpbmdMb2FkZXI6OmRpZFJlY2VpdmVEYXRhKTogQ2hhbmdlIHRoZSBt ZXRob2Qgc2lnbmF0dXJlIHRvIG1hdGNoIHRoZSBzaWduYXR1cmUKKyAgICAgICAgaW4gdGhlIGJh c2UgY2xhc3MuCisKIDIwMTEtMDItMTMgIE5pY28gV2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZGVycyBDYXJsc3Nvbi4KSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2xvYWRlci9QaW5nTG9hZGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv bG9hZGVyL1BpbmdMb2FkZXIuaAkocmV2aXNpb24gNzg0MjYpCisrKyBTb3VyY2UvV2ViQ29yZS9s b2FkZXIvUGluZ0xvYWRlci5oCSh3b3JraW5nIGNvcHkpCkBAIC02Miw3ICs2Miw3IEBACiAgICAg UGluZ0xvYWRlcihGcmFtZSosIGNvbnN0IFJlc291cmNlUmVxdWVzdCYpOwogCiAgICAgdm9pZCBk aWRSZWNlaXZlUmVzcG9uc2UoUmVzb3VyY2VIYW5kbGUqLCBjb25zdCBSZXNvdXJjZVJlc3BvbnNl JikgeyBkZWxldGUgdGhpczsgfQotICAgIHZvaWQgZGlkUmVjZWl2ZURhdGEoUmVzb3VyY2VIYW5k bGUqLCBjb25zdCBjaGFyKiwgaW50KSB7IGRlbGV0ZSB0aGlzOyB9CisgICAgdm9pZCBkaWRSZWNl aXZlRGF0YShSZXNvdXJjZUhhbmRsZSosIGNvbnN0IGNoYXIqLCBpbnQsIGludCkgeyBkZWxldGUg dGhpczsgfQogICAgIHZvaWQgZGlkRmluaXNoTG9hZGluZyhSZXNvdXJjZUhhbmRsZSosIGRvdWJs ZSkgeyBkZWxldGUgdGhpczsgfQogICAgIHZvaWQgZGlkRmFpbChSZXNvdXJjZUhhbmRsZSosIGNv bnN0IFJlc291cmNlRXJyb3ImKSB7IGRlbGV0ZSB0aGlzOyB9CiAgICAgdm9pZCB0aW1lb3V0KFRp bWVyPFBpbmdMb2FkZXI+KikgeyBkZWxldGUgdGhpczsgfQo=