54351 2011-02-13 01:16:50 -0800 Unnecessary call to containingBlock() in RenderBoxModelObject::relativePositionOffsetX() 2011-02-13 11:59:25 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 leo.yang.c webkit-unassigned commit-queue kling oldest_to_newest 350364 0 leo.yang.c 2011-02-13 01:16:50 -0800 We don't need to call containningBlock() twice in RenderBoxModelObject::relativePositionOffsetX(). 350365 1 82254 leo.yang.c 2011-02-13 01:31:51 -0800 Created attachment 82254 Patch 350379 2 82254 kling 2011-02-13 03:51:15 -0800 Comment on attachment 82254 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82254&action=review r=me > Source/WebCore/ChangeLog:5 > + Unnecessary call of containningBlock() in RenderBoxModelObject::relativePositionOffsetX() Typo, containingBlock() 350381 3 82257 leo.yang.c 2011-02-13 04:10:23 -0800 Created attachment 82257 Patch - fixed typo 350426 4 commit-queue 2011-02-13 11:31:54 -0800 The commit-queue encountered the following flaky tests while processing attachment 82257: animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch. 350428 5 82257 commit-queue 2011-02-13 11:33:33 -0800 Comment on attachment 82257 Patch - fixed typo Clearing flags on attachment: 82257 Committed r78437: <http://trac.webkit.org/changeset/78437> 82254 2011-02-13 01:31:51 -0800 2011-02-13 11:59:17 -0800 Patch 0001-2011-02-13-Leo-Yang-leo.yang.c-gmail.com.patch text/plain 2562 leo.yang.c RnJvbSBjZGFlZTQ4ZGIzN2Y0ODRlNjNmNThkMGVkYzZhODVhYTI5YmJjOWI3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmcuY0BnbWFpbC5jb20+CkRhdGU6 IFN1biwgMTMgRmViIDIwMTEgMTc6Mjg6NDUgKzA4MDAKU3ViamVjdDogW1BBVENIXSAyMDExLTAy LTEzICBMZW8gWWFuZyAgPGxlby55YW5nLmNAZ21haWwuY29tPgoKICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgVW5uZWNlc3NhcnkgY2FsbCBvZiBjb250YWlubmlu Z0Jsb2NrKCkgaW4gUmVuZGVyQm94TW9kZWxPYmplY3Q6OnJlbGF0aXZlUG9zaXRpb25PZmZzZXRY KCkKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQzNTEK CiAgICAgICAgV2Ugd2VyZSBjYWxsaW5nIGNvbnRhaW5uaW5nQmxvY2soKSB0d2ljZSBpZiB0aGUg bGVmdCBpcyBub3QgYXV0by4gV2Ugb25seSBuZWVkIHRvIGNhbGwgaXQKICAgICAgICBvbmNlIGJl Y2F1c2Ugd2UgY2FuIHVzZSAnY2InIHZhcmlhYmxlIGluIHRoZSBmb2xsb3dpbmcgbGluZS4KCiAg ICAgICAgTm8gZnVuY3Rpb25hbGl0eSBjaGFuZ2UsIG5vIG5ldyB0ZXN0cy4KCiAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwOgogICAgICAgIChXZWJDb3JlOjpSZW5k ZXJCb3hNb2RlbE9iamVjdDo6cmVsYXRpdmVQb3NpdGlvbk9mZnNldFgpOgotLS0KIFNvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE1ICsrKysrKysr KysrKysrKwogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNw cCB8ICAgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggMTMwNmQ2NC4uMDA2ZjVhYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE4IEBACisyMDExLTAyLTEzICBMZW8gWWFuZyAgPGxlby55YW5nLmNAZ21haWwuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVubmVjZXNz YXJ5IGNhbGwgb2YgY29udGFpbm5pbmdCbG9jaygpIGluIFJlbmRlckJveE1vZGVsT2JqZWN0Ojpy ZWxhdGl2ZVBvc2l0aW9uT2Zmc2V0WCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01NDM1MQorCisgICAgICAgIFdlIHdlcmUgY2FsbGluZyBjb250YWlu bmluZ0Jsb2NrKCkgdHdpY2UgaWYgdGhlIGxlZnQgaXMgbm90IGF1dG8uIFdlIG9ubHkgbmVlZCB0 byBjYWxsIGl0CisgICAgICAgIG9uY2UgYmVjYXVzZSB3ZSBjYW4gdXNlICdjYicgdmFyaWFibGUg aW4gdGhlIGZvbGxvd2luZyBsaW5lLgorCisgICAgICAgIE5vIGZ1bmN0aW9uYWxpdHkgY2hhbmdl LCBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmpl Y3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94TW9kZWxPYmplY3Q6OnJlbGF0aXZl UG9zaXRpb25PZmZzZXRYKToKKwogMjAxMS0wMi0xMiAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcAppbmRleCAyMmQ0NDZh Li5mZmJlY2NlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94 TW9kZWxPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hN b2RlbE9iamVjdC5jcHAKQEAgLTM4MSw3ICszODEsNyBAQCBpbnQgUmVuZGVyQm94TW9kZWxPYmpl Y3Q6OnJlbGF0aXZlUG9zaXRpb25PZmZzZXRYKCkgY29uc3QKICAgICAvLyBjYWxsIGF2YWlsYWJs ZVdpZHRoIG9uIG91ciBjb250YWluaW5nIGJsb2NrLgogICAgIGlmICghc3R5bGUoKS0+bGVmdCgp LmlzQXV0bygpKSB7CiAgICAgICAgIFJlbmRlckJsb2NrKiBjYiA9IGNvbnRhaW5pbmdCbG9jaygp OwotICAgICAgICBpZiAoIXN0eWxlKCktPnJpZ2h0KCkuaXNBdXRvKCkgJiYgIWNvbnRhaW5pbmdC bG9jaygpLT5zdHlsZSgpLT5pc0xlZnRUb1JpZ2h0RGlyZWN0aW9uKCkpCisgICAgICAgIGlmICgh c3R5bGUoKS0+cmlnaHQoKS5pc0F1dG8oKSAmJiAhY2ItPnN0eWxlKCktPmlzTGVmdFRvUmlnaHRE aXJlY3Rpb24oKSkKICAgICAgICAgICAgIHJldHVybiAtc3R5bGUoKS0+cmlnaHQoKS5jYWxjVmFs dWUoY2ItPmF2YWlsYWJsZVdpZHRoKCkpOwogICAgICAgICByZXR1cm4gc3R5bGUoKS0+bGVmdCgp LmNhbGNWYWx1ZShjYi0+YXZhaWxhYmxlV2lkdGgoKSk7CiAgICAgfQotLSAKMS43LjAuNAoK 82257 2011-02-13 04:10:23 -0800 2011-02-13 11:33:33 -0800 Patch - fixed typo 0001-2011-02-13-Leo-Yang-leo.yang.c-gmail.com.patch text/plain 2558 leo.yang.c RnJvbSA4MTI3ZTc1MmM2ZWM3MmVkN2FjYWY2OWE2OTIyNThiZTQ1YTQ2OTI4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmcuY0BnbWFpbC5jb20+CkRhdGU6 IFN1biwgMTMgRmViIDIwMTEgMTc6Mjg6NDUgKzA4MDAKU3ViamVjdDogW1BBVENIXSAyMDExLTAy LTEzICBMZW8gWWFuZyAgPGxlby55YW5nLmNAZ21haWwuY29tPgoKICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgVW5uZWNlc3NhcnkgY2FsbCBvZiBjb250YWluaW5n QmxvY2soKSBpbiBSZW5kZXJCb3hNb2RlbE9iamVjdDo6cmVsYXRpdmVQb3NpdGlvbk9mZnNldFgo KQogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDM1MQoK ICAgICAgICBXZSB3ZXJlIGNhbGxpbmcgY29udGFpbmluZ0Jsb2NrKCkgdHdpY2UgaWYgdGhlIGxl ZnQgaXMgbm90IGF1dG8uIFdlIG9ubHkgbmVlZCB0byBjYWxsIGl0CiAgICAgICAgb25jZSBiZWNh dXNlIHdlIGNhbiB1c2UgJ2NiJyB2YXJpYWJsZSBpbiB0aGUgZm9sbG93aW5nIGxpbmUuCgogICAg ICAgIE5vIGZ1bmN0aW9uYWxpdHkgY2hhbmdlLCBubyBuZXcgdGVzdHMuCgogICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcDoKICAgICAgICAoV2ViQ29yZTo6UmVuZGVy Qm94TW9kZWxPYmplY3Q6OnJlbGF0aXZlUG9zaXRpb25PZmZzZXRYKToKLS0tCiBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxNSArKysrKysrKysr KysrKysKIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAg fCAgICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCmluZGV4IDEzMDZkNjQuLmFiZjZjM2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxOCBAQAorMjAxMS0wMi0xMyAgTGVvIFlhbmcgIDxsZW8ueWFuZy5jQGdtYWlsLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbm5lY2Vzc2Fy eSBjYWxsIG9mIGNvbnRhaW5pbmdCbG9jaygpIGluIFJlbmRlckJveE1vZGVsT2JqZWN0OjpyZWxh dGl2ZVBvc2l0aW9uT2Zmc2V0WCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01NDM1MQorCisgICAgICAgIFdlIHdlcmUgY2FsbGluZyBjb250YWluaW5n QmxvY2soKSB0d2ljZSBpZiB0aGUgbGVmdCBpcyBub3QgYXV0by4gV2Ugb25seSBuZWVkIHRvIGNh bGwgaXQKKyAgICAgICAgb25jZSBiZWNhdXNlIHdlIGNhbiB1c2UgJ2NiJyB2YXJpYWJsZSBpbiB0 aGUgZm9sbG93aW5nIGxpbmUuCisKKyAgICAgICAgTm8gZnVuY3Rpb25hbGl0eSBjaGFuZ2UsIG5v IG5ldyB0ZXN0cy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3hNb2RlbE9iamVjdDo6cmVsYXRpdmVQb3Np dGlvbk9mZnNldFgpOgorCiAyMDExLTAyLTEyICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwCmluZGV4IDIyZDQ0NmEuLmZm YmVjY2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2Rl bE9iamVjdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVs T2JqZWN0LmNwcApAQCAtMzgxLDcgKzM4MSw3IEBAIGludCBSZW5kZXJCb3hNb2RlbE9iamVjdDo6 cmVsYXRpdmVQb3NpdGlvbk9mZnNldFgoKSBjb25zdAogICAgIC8vIGNhbGwgYXZhaWxhYmxlV2lk dGggb24gb3VyIGNvbnRhaW5pbmcgYmxvY2suCiAgICAgaWYgKCFzdHlsZSgpLT5sZWZ0KCkuaXNB dXRvKCkpIHsKICAgICAgICAgUmVuZGVyQmxvY2sqIGNiID0gY29udGFpbmluZ0Jsb2NrKCk7Ci0g ICAgICAgIGlmICghc3R5bGUoKS0+cmlnaHQoKS5pc0F1dG8oKSAmJiAhY29udGFpbmluZ0Jsb2Nr KCktPnN0eWxlKCktPmlzTGVmdFRvUmlnaHREaXJlY3Rpb24oKSkKKyAgICAgICAgaWYgKCFzdHls ZSgpLT5yaWdodCgpLmlzQXV0bygpICYmICFjYi0+c3R5bGUoKS0+aXNMZWZ0VG9SaWdodERpcmVj dGlvbigpKQogICAgICAgICAgICAgcmV0dXJuIC1zdHlsZSgpLT5yaWdodCgpLmNhbGNWYWx1ZShj Yi0+YXZhaWxhYmxlV2lkdGgoKSk7CiAgICAgICAgIHJldHVybiBzdHlsZSgpLT5sZWZ0KCkuY2Fs Y1ZhbHVlKGNiLT5hdmFpbGFibGVXaWR0aCgpKTsKICAgICB9Ci0tIAoxLjcuMC40Cgo=