54349 2011-02-12 22:20:29 -0800 Inline some accessors in PrintContext 2011-02-13 11:07:02 -0800 1 1 1 Unclassified WebKit Printing 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue oldest_to_newest 350352 0 ap 2011-02-12 22:20:29 -0800 Strangely, pageRects() is inline, but pageCount() and pageRect() aren't. I don't see any reason why the shouldn't be. 350353 1 82250 ap 2011-02-12 22:22:12 -0800 Created attachment 82250 proposed patch 350416 2 82250 commit-queue 2011-02-13 11:06:57 -0800 Comment on attachment 82250 proposed patch Clearing flags on attachment: 82250 Committed r78434: <http://trac.webkit.org/changeset/78434> 350417 3 commit-queue 2011-02-13 11:07:02 -0800 All reviewed patches have been landed. Closing bug. 82250 2011-02-12 22:22:12 -0800 2011-02-13 11:06:57 -0800 proposed patch InlineAccessors.txt text/plain 2906 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NDI2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDItMTIgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU0MzQ5CisgICAgICAgIElubGluZSBzb21lIGFjY2Vzc29ycyBpbiBQcmludENvbnRleHQK KworICAgICAgICBObyBjaGFuZ2UgaW4gYmVoYXZpb3IsIHNvIG5vIHRlc3RzLgorCisgICAgICAg ICogV2ViQ29yZS5leHAuaW46CisgICAgICAgICogcGFnZS9QcmludENvbnRleHQuY3BwOgorICAg ICAgICAqIHBhZ2UvUHJpbnRDb250ZXh0Lmg6CisgICAgICAgIChXZWJDb3JlOjpQcmludENvbnRl eHQ6OnBhZ2VDb3VudCk6CisgICAgICAgIChXZWJDb3JlOjpQcmludENvbnRleHQ6OnBhZ2VSZWN0 KToKKyAgICAgICAgSW5saW5lIHBhZ2VDb3VudCgpIGFuZCBwYWdlUmVjdCgpIHRvIG1hdGNoIHBh Z2VSZWN0cygpLgorCiAyMDExLTAyLTEyICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L1dlYkNvcmUuZXhwLmluCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhw LmluCShyZXZpc2lvbiA3ODQyNikKKysrIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCSh3 b3JraW5nIGNvcHkpCkBAIC0xMDEwLDggKzEwMTAsNiBAQCBfX1pOSzdXZWJDb3JlMTJFdmVudEhh bmRsZXIyMGN1cnJlbnRLZXliCiBfX1pOSzdXZWJDb3JlMTJJY29uRGF0YWJhc2UxMmRhdGFiYXNl UGF0aEV2CiBfX1pOSzdXZWJDb3JlMTJJY29uRGF0YWJhc2UyNHNob3VsZFN0b3BUaHJlYWRBY3Rp dml0eUV2CiBfX1pOSzdXZWJDb3JlMTJJY29uRGF0YWJhc2U5aXNFbmFibGVkRXYKLV9fWk5LN1dl YkNvcmUxMlByaW50Q29udGV4dDhwYWdlUmVjdEVtCi1fX1pOSzdXZWJDb3JlMTJQcmludENvbnRl eHQ5cGFnZUNvdW50RXYKIF9fWk5LN1dlYkNvcmUxMlJlbmRlck9iamVjdDE0ZW5jbG9zaW5nTGF5 ZXJFdgogX19aTks3V2ViQ29yZTEyUmVuZGVyT2JqZWN0MTVsb2NhbFRvQWJzb2x1dGVFTlNfMTBG bG9hdFBvaW50RWJiCiBfX1pOSzdXZWJDb3JlMTJSZW5kZXJPYmplY3Q0dmlld0V2CkluZGV4OiBT b3VyY2UvV2ViQ29yZS9wYWdlL1ByaW50Q29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcGFnZS9QcmludENvbnRleHQuY3BwCShyZXZpc2lvbiA3ODQyNikKKysrIFNvdXJj ZS9XZWJDb3JlL3BhZ2UvUHJpbnRDb250ZXh0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTUsMTYg KzU1LDYgQEAgUHJpbnRDb250ZXh0Ojp+UHJpbnRDb250ZXh0KCkKICAgICAgICAgZW5kKCk7CiB9 CiAKLXNpemVfdCBQcmludENvbnRleHQ6OnBhZ2VDb3VudCgpIGNvbnN0Ci17Ci0gICAgcmV0dXJu IG1fcGFnZVJlY3RzLnNpemUoKTsKLX0KLQotY29uc3QgSW50UmVjdCYgUHJpbnRDb250ZXh0Ojpw YWdlUmVjdChzaXplX3QgcGFnZU51bWJlcikgY29uc3QKLXsKLSAgICByZXR1cm4gbV9wYWdlUmVj dHNbcGFnZU51bWJlcl07Ci19Ci0KIHZvaWQgUHJpbnRDb250ZXh0Ojpjb21wdXRlUGFnZVJlY3Rz KGNvbnN0IEZsb2F0UmVjdCYgcHJpbnRSZWN0LCBmbG9hdCBoZWFkZXJIZWlnaHQsIGZsb2F0IGZv b3RlckhlaWdodCwgZmxvYXQgdXNlclNjYWxlRmFjdG9yLCBmbG9hdCYgb3V0UGFnZUhlaWdodCwg Ym9vbCBhbGxvd0hvcml6b250YWxUaWxpbmcpCiB7CiAgICAgbV9wYWdlUmVjdHMuY2xlYXIoKTsK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvUHJpbnRDb250ZXh0LmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcGFnZS9QcmludENvbnRleHQuaAkocmV2aXNpb24gNzg0MjYpCisrKyBT b3VyY2UvV2ViQ29yZS9wYWdlL1ByaW50Q29udGV4dC5oCSh3b3JraW5nIGNvcHkpCkBAIC01MCw4 ICs1MCw4IEBAIHB1YmxpYzoKICAgICB2b2lkIGNvbXB1dGVQYWdlUmVjdHNXaXRoUGFnZVNpemUo Y29uc3QgRmxvYXRTaXplJiBwYWdlU2l6ZUluUGl4ZWxzLCBib29sIGFsbG93SG9yaXpvbnRhbFRp bGluZyk7CiAKICAgICAvLyBUaGVzZSBhcmUgb25seSB2YWxpZCBhZnRlciBwYWdlIHJlY3RzIGFy ZSBjb21wdXRlZC4KLSAgICBzaXplX3QgcGFnZUNvdW50KCkgY29uc3Q7Ci0gICAgY29uc3QgSW50 UmVjdCYgcGFnZVJlY3Qoc2l6ZV90IHBhZ2VOdW1iZXIpIGNvbnN0OworICAgIHNpemVfdCBwYWdl Q291bnQoKSBjb25zdCB7IHJldHVybiBtX3BhZ2VSZWN0cy5zaXplKCk7IH0KKyAgICBjb25zdCBJ bnRSZWN0JiBwYWdlUmVjdChzaXplX3QgcGFnZU51bWJlcikgY29uc3QgeyByZXR1cm4gbV9wYWdl UmVjdHNbcGFnZU51bWJlcl07IH0KICAgICBjb25zdCBWZWN0b3I8SW50UmVjdD4mIHBhZ2VSZWN0 cygpIGNvbnN0IHsgcmV0dXJuIG1fcGFnZVJlY3RzOyB9CiAKICAgICBmbG9hdCBjb21wdXRlQXV0 b21hdGljU2NhbGVGYWN0b3IoY29uc3QgRmxvYXRTaXplJiBhdmFpbGFibGVQYXBlclNpemUpOwo=