54348 2011-02-12 22:13:46 -0800 Crash when printing a document with no pages 2011-02-13 11:03:23 -0800 1 1 1 Unclassified WebKit Printing 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue mitz oldest_to_newest 350350 0 ap 2011-02-12 22:13:46 -0800 WKPage always reports at least one page to print, but then it fails to actually print it. 350351 1 82249 ap 2011-02-12 22:16:46 -0800 Created attachment 82249 proposed fix 350355 2 82249 mitz 2011-02-12 22:33:05 -0800 Comment on attachment 82249 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=82249&action=review > Source/WebKit2/ChangeLog:8 > + * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawPagesToPDF): Don't fail on a fake Can you add a newline between the filename and the function name? > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2015 > + CGRect mediaBox = m_printContext->pageCount() ? m_printContext->pageRect(0) : CGRectMake(0, 0, 1, 1); What happens if you use CGRectZero instead? 350356 3 ap 2011-02-12 22:44:49 -0800 > Can you add a newline between the filename and the function name? Not without taking this out of commit queue :) > What happens if you use CGRectZero instead? AppKit prints a blank page without headers and footers, which is probably incorrect. In fact, we end up passing a zero rectangle in -[WKPrintingView rectForPage:] due to IntRect.scale() rounding to zero in the end, and this rounding is not good. However, this is a situation that should not really ever happen, and I only noticed this because of <rdar://problem/8994076>. I don't want to achieve perfect behavior in this impossible situation (or even to file bugs), but I wanted to avoid crashing, and I didn't want to explicitly write incorrect code returning a zero rect. 350414 4 82249 commit-queue 2011-02-13 11:03:19 -0800 Comment on attachment 82249 proposed fix Clearing flags on attachment: 82249 Committed r78432: <http://trac.webkit.org/changeset/78432> 350415 5 commit-queue 2011-02-13 11:03:23 -0800 All reviewed patches have been landed. Closing bug. 82249 2011-02-12 22:16:46 -0800 2011-02-13 11:03:19 -0800 proposed fix PagelessDocument.txt text/plain 1829 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NDI2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDItMTIgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU0MzQ4CisgICAgICAgIENyYXNoIHdoZW4gcHJpbnRpbmcgYSBkb2N1bWVudCB3aXRoIG5v IHBhZ2VzCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6IChXZWJL aXQ6OldlYlBhZ2U6OmRyYXdQYWdlc1RvUERGKTogRG9uJ3QgZmFpbCBvbiBhIGZha2UKKyAgICAg ICAgcGFnZSB0aGF0IGNvbXB1dGVQYWdlc0ZvclByaW50aW5nKCkgYWRkZWQgdG8gYSBwYWdlbGVz cyBkb2N1bWVudC4KKwogMjAxMS0wMi0xMSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCShyZXZpc2lvbiA3 ODQyNikKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjAxMiwxMCArMjAxMiwxMCBAQCB2b2lkIFdlYlBhZ2U6OmRyYXdQ YWdlc1RvUERGKHVpbnQ2NF90IGZyCiAgICAgICAgIC8vIEZJWE1FOiBVc2UgQ0dEYXRhQ29uc3Vt ZXJDcmVhdGUgd2l0aCBjYWxsYmFja3MgdG8gYXZvaWQgY29weWluZyB0aGUgZGF0YS4KICAgICAg ICAgUmV0YWluUHRyPENHRGF0YUNvbnN1bWVyUmVmPiBwZGZEYXRhQ29uc3VtZXIoQWRvcHRDRiwg Q0dEYXRhQ29uc3VtZXJDcmVhdGVXaXRoQ0ZEYXRhKHBkZlBhZ2VEYXRhLmdldCgpKSk7CiAKLSAg ICAgICAgQ0dSZWN0IG1lZGlhQm94ID0gbV9wcmludENvbnRleHQtPnBhZ2VSZWN0KDApOworICAg ICAgICBDR1JlY3QgbWVkaWFCb3ggPSBtX3ByaW50Q29udGV4dC0+cGFnZUNvdW50KCkgPyBtX3By aW50Q29udGV4dC0+cGFnZVJlY3QoMCkgOiBDR1JlY3RNYWtlKDAsIDAsIDEsIDEpOwogICAgICAg ICBSZXRhaW5QdHI8Q0dDb250ZXh0UmVmPiBjb250ZXh0KEFkb3B0Q0YsIENHUERGQ29udGV4dENy ZWF0ZShwZGZEYXRhQ29uc3VtZXIuZ2V0KCksICZtZWRpYUJveCwgMCkpOwogICAgICAgICBmb3Ig KHVpbnQzMl90IHBhZ2UgPSBmaXJzdDsgcGFnZSA8IGZpcnN0ICsgY291bnQ7ICsrcGFnZSkgewot ICAgICAgICAgICAgaWYgKHBhZ2UgPiBtX3ByaW50Q29udGV4dC0+cGFnZUNvdW50KCkpCisgICAg ICAgICAgICBpZiAocGFnZSA+PSBtX3ByaW50Q29udGV4dC0+cGFnZUNvdW50KCkpCiAgICAgICAg ICAgICAgICAgYnJlYWs7CiAKICAgICAgICAgICAgIFJldGFpblB0cjxDRkRpY3Rpb25hcnlSZWY+ IHBhZ2VJbmZvKEFkb3B0Q0YsIENGRGljdGlvbmFyeUNyZWF0ZU11dGFibGUoMCwgMCwgJmtDRlR5 cGVEaWN0aW9uYXJ5S2V5Q2FsbEJhY2tzLCAma0NGVHlwZURpY3Rpb25hcnlWYWx1ZUNhbGxCYWNr cykpOwo=