54345 2011-02-12 15:20:58 -0800 Crash in RenderLayerCompositor::updateCompositingLayers when loading some sites 2011-02-12 16:18:24 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 1 cmarrin cmarrin simon.fraser oldest_to_newest 350325 0 cmarrin 2011-02-12 15:20:58 -0800 Loading sites that have compositing layers with WebKit2 can crash because RenderLayerCompositor::enableCompositingMode sometimes gets re-entered when setting up layers. This only happens with a 32 bit build because it depends on plugins (like Flash) getting a layer. It is also timing related so it doesn't always happen. 350328 1 cmarrin 2011-02-12 15:21:19 -0800 rdar://problem/8975923 350331 2 82243 cmarrin 2011-02-12 15:34:15 -0800 Created attachment 82243 Patch 350335 3 cmarrin 2011-02-12 16:18:24 -0800 Committed r78425: <http://trac.webkit.org/changeset/78425> 82243 2011-02-12 15:34:15 -0800 2011-02-12 15:53:38 -0800 Patch bug-54345-20110212153414.patch text/plain 4751 cmarrin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NDIzKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMDItMTIgIENocmlzIE1h cnJpbiAgPGNtYXJyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENyYXNoIGluIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6dXBkYXRl Q29tcG9zaXRpbmdMYXllcnMgd2hlbiBsb2FkaW5nIHNvbWUgc2l0ZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0MzQ1CisKKyAgICAgICAgU29tZSBz aXRlcyBmbGlwIGJldHdlZW4gY29tcG9zaXRlZCBhbmQgbm9uLWNvbW9zaXRlZCBzdGF0ZSB3aGls ZSBsb2FkaW5nLiBXaGVuIHRoZSB0aW1pbmcgaXMKKyAgICAgICAgcmlnaHQsIHdoZW4gd2UgZmxp cCBvdXQgb2YgY29tcG9zaXRpbmcgd2Ugd2lsbCBuZWVkIHRvIGRvIGEgZGlzcGxheSB3aGlsZSB0 b3NzaW5nIGFsbCB0aGUKKyAgICAgICAgY29tcG9zaXRpbmcgbGF5ZXJzLiBUaGlzIGNhdXNlcyB1 cyB0byByZWVudGVyIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6Y29tcHV0ZUNvbXBvc2l0aW5nUmVx dWlyZW1lbnRzKCkKKyAgICAgICAgd2hpbGUgd2UgYXJlIGluIHRoZSBtaWRkbGUgb2YgdG9zc2lu ZyBsYXllcnMsIHdoaWNoIGxlYWRzIHRvIGEgY3Jhc2guCisKKyAgICAgICAgVGhlIHNvbHV0aW9u IGlzIHRvIGRlZmVyIHRoZSBsb2dpYyBvZiBleGl0aW5nIGNvbXBvc2l0aW5nIG1vZGUgdW50aWwg dGhlIERyYXdpbmdBcmVhIGlzIGZpbmlzaGVkCisgICAgICAgIGRvaW5nIGl0cyBkaXNwbGF5LCB1 c2luZyBhIHRpbWVyLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVh SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkRyYXdpbmdBcmVhSW1wbDo6RHJhd2luZ0FyZWFJ bXBsKToKKyAgICAgICAgKFdlYktpdDo6RHJhd2luZ0FyZWFJbXBsOjpzZXRSb290Q29tcG9zaXRp bmdMYXllcik6CisgICAgICAgIChXZWJLaXQ6OkRyYXdpbmdBcmVhSW1wbDo6ZW50ZXJBY2NlbGVy YXRlZENvbXBvc2l0aW5nTW9kZSk6CisgICAgICAgIChXZWJLaXQ6OkRyYXdpbmdBcmVhSW1wbDo6 ZXhpdEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlKToKKyAgICAgICAgKFdlYktpdDo6RHJhd2lu Z0FyZWFJbXBsOjpleGl0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGVTb29uKToKKyAgICAgICAg KiBXZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmg6CisKIDIwMTEtMDItMTIgIEtl dmluIERlY2tlciAgPGtkZWNrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh biBCZXJuc3RlaW4uCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJh d2luZ0FyZWFJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmNwcAkocmV2aXNpb24gNzgzNDMpCisrKyBTb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNjQsNiArNjQsNyBAQCBEcmF3aW5nQXJlYUltcGw6OkRyYXdpbmdBcmVhSW1wbChX ZWJQYWdlCiAgICAgLCBtX2lzV2FpdGluZ0ZvckRpZFVwZGF0ZShmYWxzZSkKICAgICAsIG1faXNQ YWludGluZ1N1c3BlbmRlZCghcGFyYW1ldGVycy5pc1Zpc2libGUpCiAgICAgLCBtX2Rpc3BsYXlU aW1lcihXZWJQcm9jZXNzOjpzaGFyZWQoKS5ydW5Mb29wKCksIHRoaXMsICZEcmF3aW5nQXJlYUlt cGw6OmRpc3BsYXkpCisgICAgLCBtX2V4aXRDb21wb3NpdGluZ1RpbWVyKFdlYlByb2Nlc3M6OnNo YXJlZCgpLnJ1bkxvb3AoKSwgdGhpcywgJkRyYXdpbmdBcmVhSW1wbDo6ZXhpdEFjY2VsZXJhdGVk Q29tcG9zaXRpbmdNb2RlKQogewogfQogCkBAIC0xODIsMTQgKzE4MywxNSBAQCB2b2lkIERyYXdp bmdBcmVhSW1wbDo6c2V0Um9vdENvbXBvc2l0aW5nCiAgICAgICAgICAgICAvLyBXZSdyZSBhY3R1 YWxseSBlbnRlcmluZyBhY2NlbGVyYXRlZCBjb21wb3NpdGluZyBtb2RlLgogICAgICAgICAgICAg ZW50ZXJBY2NlbGVyYXRlZENvbXBvc2l0aW5nTW9kZShncmFwaGljc0xheWVyKTsKICAgICAgICAg fSBlbHNlIHsKKyAgICAgICAgICAgIG1fZXhpdENvbXBvc2l0aW5nVGltZXIuc3RvcCgpOwogICAg ICAgICAgICAgLy8gV2UncmUgYWxyZWFkeSBpbiBhY2NlbGVyYXRlZCBjb21wb3NpdGluZyBtb2Rl LCBidXQgdGhlIHJvb3QgY29tcG9zaXRpbmcgbGF5ZXIgY2hhbmdlZC4KICAgICAgICAgICAgIG1f bGF5ZXJUcmVlSG9zdC0+c2V0Um9vdENvbXBvc2l0aW5nTGF5ZXIoZ3JhcGhpY3NMYXllcik7CiAg ICAgICAgIH0KICAgICB9IGVsc2UgewogICAgICAgICBpZiAobV9sYXllclRyZWVIb3N0KSB7Ci0g ICAgICAgICAgICAvLyBXZSdyZSBleGl0aW5nIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIG1vZGUu Ci0gICAgICAgICAgICBleGl0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUoKTsKLSAgICAgICAg ICAgIEFTU0VSVCghbV9sYXllclRyZWVIb3N0KTsKKyAgICAgICAgICAgIC8vIFdlJ2xsIGV4aXQg YWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgbW9kZSBvbiBhIHRpbWVyLCB0byBhdm9pZCByZS1lbnRl cmluZworICAgICAgICAgICAgLy8gY29tcG9zaXRpbmcgY29kZSB2aWEgZGlzcGxheSgpIGFuZCBs YXlvdXQuCisgICAgICAgICAgICBleGl0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGVTb29uKCk7 CiAgICAgICAgIH0KICAgICB9CiB9CkBAIC0yNzcsNiArMjc5LDggQEAgdm9pZCBEcmF3aW5nQXJl YUltcGw6OnJlc3VtZVBhaW50aW5nKCkKIAogdm9pZCBEcmF3aW5nQXJlYUltcGw6OmVudGVyQWNj ZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUoR3JhcGhpY3NMYXllciogZ3JhcGhpY3NMYXllcikKIHsK KyAgICBtX2V4aXRDb21wb3NpdGluZ1RpbWVyLnN0b3AoKTsKKwogICAgIEFTU0VSVCghbV9sYXll clRyZWVIb3N0KTsKIAogICAgIG1fbGF5ZXJUcmVlSG9zdCA9IExheWVyVHJlZUhvc3Q6OmNyZWF0 ZShtX3dlYlBhZ2UpOwpAQCAtMjk1LDYgKzI5OSw4IEBAIHZvaWQgRHJhd2luZ0FyZWFJbXBsOjpl bnRlckFjY2VsZXJhdGVkQ28KIAogdm9pZCBEcmF3aW5nQXJlYUltcGw6OmV4aXRBY2NlbGVyYXRl ZENvbXBvc2l0aW5nTW9kZSgpCiB7CisgICAgbV9leGl0Q29tcG9zaXRpbmdUaW1lci5zdG9wKCk7 CisKICAgICBBU1NFUlQobV9sYXllclRyZWVIb3N0KTsKIAogICAgIG1fbGF5ZXJUcmVlSG9zdC0+ aW52YWxpZGF0ZSgpOwpAQCAtMzE3LDYgKzMyMywxNCBAQCB2b2lkIERyYXdpbmdBcmVhSW1wbDo6 ZXhpdEFjY2VsZXJhdGVkQ29tCiAgICAgICAgIG1fd2ViUGFnZS0+c2VuZChNZXNzYWdlczo6RHJh d2luZ0FyZWFQcm94eTo6RXhpdEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlKGdlbmVyYXRlU2Vx dWVuY2VOdW1iZXIoKSwgdXBkYXRlSW5mbykpOwogfQogCit2b2lkIERyYXdpbmdBcmVhSW1wbDo6 ZXhpdEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlU29vbigpCit7CisgICAgaWYgKG1fZXhpdENv bXBvc2l0aW5nVGltZXIuaXNBY3RpdmUoKSkKKyAgICAgICAgcmV0dXJuOworCisgICAgbV9leGl0 Q29tcG9zaXRpbmdUaW1lci5zdGFydE9uZVNob3QoMCk7Cit9CisKIHZvaWQgRHJhd2luZ0FyZWFJ bXBsOjpzY2hlZHVsZURpc3BsYXkoKQogewogICAgIGlmIChtX2lzV2FpdGluZ0ZvckRpZFVwZGF0 ZSkKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9EcmF3aW5nQXJlYUlt cGwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJh d2luZ0FyZWFJbXBsLmgJKHJldmlzaW9uIDc4MzQzKQorKysgU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1wbC5oCSh3b3JraW5nIGNvcHkpCkBAIC02Niw2ICs2 Niw3IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIHJlc3VtZVBhaW50aW5nKCk7CiAKICAg ICB2b2lkIGVudGVyQWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUoV2ViQ29yZTo6R3JhcGhpY3NM YXllciopOworICAgIHZvaWQgZXhpdEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlU29vbigpOwog ICAgIHZvaWQgZXhpdEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlKCk7CiAKICAgICB2b2lkIHNj aGVkdWxlRGlzcGxheSgpOwpAQCAtODgsNiArODksNyBAQCBwcml2YXRlOgogICAgIGJvb2wgbV9p c1BhaW50aW5nU3VzcGVuZGVkOwogCiAgICAgUnVuTG9vcDo6VGltZXI8RHJhd2luZ0FyZWFJbXBs PiBtX2Rpc3BsYXlUaW1lcjsKKyAgICBSdW5Mb29wOjpUaW1lcjxEcmF3aW5nQXJlYUltcGw+IG1f ZXhpdENvbXBvc2l0aW5nVGltZXI7CiAKICAgICAvLyBUaGUgbGF5ZXIgdHJlZSBob3N0IHRoYXQg aGFuZGxlcyBhY2NlbGVyYXRlZCBjb21wb3NpdGluZy4KICAgICBSZWZQdHI8TGF5ZXJUcmVlSG9z dD4gbV9sYXllclRyZWVIb3N0Owo=