54343 2011-02-12 13:51:04 -0800 Web Inspector: audits should not warn about gzip compression for 304s 2011-02-21 10:02:13 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 alex apavlov abarth apavlov bweinstein eric joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 350309 0 alex 2011-02-12 13:51:04 -0800 It appears the audit tool is generating a red "Enable gzip compression" warning even if the resource in question was a "304 Not Modified" response with 0 content length. The gzip compression recommendation should be ignored in this case. 350357 1 ap 2011-02-12 23:27:07 -0800 Maybe that's the reason for bug 33220? 350669 2 alex 2011-02-14 08:29:00 -0800 Based on the patch for 33220, it appears not to be the reason. Which makes sense I guess. Audits are only run upon explicit user request, right? 350678 3 82319 apavlov 2011-02-14 08:38:54 -0800 Created attachment 82319 [PATCH] Suggested fix 350680 4 apavlov 2011-02-14 08:39:27 -0800 (In reply to comment #2) > Based on the patch for 33220, it appears not to be the reason. Which makes sense I guess. Audits are only run upon explicit user request, right? Correct, it's a different thing. 354537 5 82319 yurys 2011-02-21 05:19:12 -0800 Comment on attachment 82319 [PATCH] Suggested fix View in context: https://bugs.webkit.org/attachment.cgi?id=82319&action=review > Source/WebCore/inspector/front-end/AuditRules.js:110 > + var encodings = encodingHeader.split(/\s*,\s*/); Consider replacing this code with a grep search. > Source/WebCore/inspector/front-end/AuditRules.js:121 > + return WebInspector.Resource.Type.isTextType(resource.type) && resource.domain && resource.statusCode !== 304 && resource.resourceSize !== undefined && resource.resourceSize > 150; If 304s have 0 length content then we don't need to check for statusCode here. If resourceSize contains size of the whole response, we need to use another field which provides content length as only the content can be compressed. 354579 6 83161 apavlov 2011-02-21 07:10:40 -0800 Created attachment 83161 [PATCH] Comments addressed 354639 7 apavlov 2011-02-21 09:36:46 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog M Source/WebCore/inspector/front-end/AuditRules.js Committed r79229 354656 8 webkit.review.bot 2011-02-21 10:02:13 -0800 http://trac.webkit.org/changeset/79229 might have broken Qt Linux Release The following tests are not passing: media/controls-without-preload.html 82319 2011-02-14 08:38:54 -0800 2011-02-21 07:10:40 -0800 [PATCH] Suggested fix auditgzip.patch text/plain 2317 apavlov Y29tbWl0IGYzZTU3NTQwMmJjNjliZDVjZTMyNDYxYTFiZDA0YTU3ZGJkYWY3YjgKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBNb24gRmViIDE0 IDE5OjI0OjM4IDIwMTEgKzAzMDAKCiAgICBIYW5kbGUgMzA0IHVuY29tcHJlc3NlZCByZXNvdXJj ZXMKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKaW5kZXggMDQwY2JlMy4uYTQ2ZDI4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE3IEBACisyMDExLTAyLTE0ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Vi IEluc3BlY3RvcjogYXVkaXRzIHNob3VsZCBub3Qgd2FybiBhYm91dCBnemlwIGNvbXByZXNzaW9u IGZvciAzMDRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NDM0MworCisgICAgICAgIERvIG5vdCBydW4gY29tcHJlc3Npb24tcmVsYXRlZCBhdWRpdHMg b24gMzA0IHJlc291cmNlcy4KKyAgICAgICAgRHJpdmUtYnk6IGhhbmRsZSBtdWx0aS1lbmNvZGlu ZyByZXNvdXJjZXMgKENvbnRlbnQtRW5jb2Rpbmc6IHNkaGMsZ3ppcCkgY29ycmVjdGx5LgorCisg ICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9BdWRpdFJ1bGVzLmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLkF1ZGl0UnVsZXMuR3ppcFJ1bGUucHJvdG90eXBlLl9pc0NvbXByZXNzZWQpOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLkF1ZGl0UnVsZXMuR3ppcFJ1bGUucHJvdG90eXBlLl9zaG91 bGRDb21wcmVzcyk6CisKIDIwMTEtMDItMTMgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0F1ZGl0UnVsZXMuanMgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0F1ZGl0UnVsZXMuanMKaW5kZXggYzEyMmJhNC4u MDdlNDQwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9B dWRpdFJ1bGVzLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQXVk aXRSdWxlcy5qcwpAQCAtMTA0LDEzICsxMDQsMjEgQEAgV2ViSW5zcGVjdG9yLkF1ZGl0UnVsZXMu R3ppcFJ1bGUucHJvdG90eXBlID0gewogCiAgICAgX2lzQ29tcHJlc3NlZDogZnVuY3Rpb24ocmVz b3VyY2UpCiAgICAgewotICAgICAgICB2YXIgZW5jb2RpbmcgPSByZXNvdXJjZS5yZXNwb25zZUhl YWRlcnNbIkNvbnRlbnQtRW5jb2RpbmciXTsKLSAgICAgICAgcmV0dXJuIGVuY29kaW5nID09PSAi Z3ppcCIgfHwgZW5jb2RpbmcgPT09ICJkZWZsYXRlIjsKKyAgICAgICAgdmFyIGVuY29kaW5nSGVh ZGVyID0gcmVzb3VyY2UucmVzcG9uc2VIZWFkZXJzWyJDb250ZW50LUVuY29kaW5nIl07CisgICAg ICAgIGlmICghZW5jb2RpbmdIZWFkZXIpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAg ICAgIHZhciBlbmNvZGluZ3MgPSBlbmNvZGluZ0hlYWRlci5zcGxpdCgvXHMqLFxzKi8pOworICAg ICAgICBmb3IgKHZhciBpID0gMDsgaSA8IGVuY29kaW5ncy5sZW5ndGg7ICsraSkgeworICAgICAg ICAgICAgaWYgKGVuY29kaW5nc1tpXSA9PT0gImd6aXAiIHx8IGVuY29kaW5nc1tpXSA9PT0gImRl ZmxhdGUiKQorICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOworICAgICAgICB9CisKKyAgICAg ICAgcmV0dXJuIGZhbHNlOwogICAgIH0sCiAKICAgICBfc2hvdWxkQ29tcHJlc3M6IGZ1bmN0aW9u KHJlc291cmNlKQogICAgIHsKLSAgICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5SZXNvdXJjZS5U eXBlLmlzVGV4dFR5cGUocmVzb3VyY2UudHlwZSkgJiYgcmVzb3VyY2UuZG9tYWluICYmIHJlc291 cmNlLnJlc291cmNlU2l6ZSAhPT0gdW5kZWZpbmVkICYmIHJlc291cmNlLnJlc291cmNlU2l6ZSA+ IDE1MDsKKyAgICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5SZXNvdXJjZS5UeXBlLmlzVGV4dFR5 cGUocmVzb3VyY2UudHlwZSkgJiYgcmVzb3VyY2UuZG9tYWluICYmIHJlc291cmNlLnN0YXR1c0Nv ZGUgIT09IDMwNCAmJiByZXNvdXJjZS5yZXNvdXJjZVNpemUgIT09IHVuZGVmaW5lZCAmJiByZXNv dXJjZS5yZXNvdXJjZVNpemUgPiAxNTA7CiAgICAgfQogfQogCg== 83161 2011-02-21 07:10:40 -0800 2011-02-21 08:53:36 -0800 [PATCH] Comments addressed auditgzip.patch text/plain 2276 apavlov Y29tbWl0IGM3MWM2Mjc2YmYyOTAzMDNmOWRhN2QzYWZjNzRjM2E3NTc5MTAzNzYKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBNb24gRmViIDE0 IDE5OjI0OjM4IDIwMTEgKzAzMDAKCiAgICBIYW5kbGUgMzA0IHVuY29tcHJlc3NlZCByZXNvdXJj ZXMKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKaW5kZXggODcxZDE0NC4uYzcxMTAyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE3IEBACisyMDExLTAyLTE0ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Vi IEluc3BlY3RvcjogYXVkaXRzIHNob3VsZCBub3Qgd2FybiBhYm91dCBnemlwIGNvbXByZXNzaW9u IGZvciAzMDRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NDM0MworCisgICAgICAgIERvIG5vdCBydW4gY29tcHJlc3Npb24tcmVsYXRlZCBhdWRpdHMg b24gMzA0IHJlc291cmNlcy4KKyAgICAgICAgRHJpdmUtYnk6IGhhbmRsZSBtdWx0aS1lbmNvZGlu ZyByZXNvdXJjZXMgKENvbnRlbnQtRW5jb2Rpbmc6IHNkaGMsZ3ppcCkgY29ycmVjdGx5LgorCisg ICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9BdWRpdFJ1bGVzLmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLkF1ZGl0UnVsZXMuR3ppcFJ1bGUucHJvdG90eXBlLmRvUnVuKToKKyAgICAgICAg KFdlYkluc3BlY3Rvci5BdWRpdFJ1bGVzLkd6aXBSdWxlLnByb3RvdHlwZS5faXNDb21wcmVzc2Vk KToKKwogMjAxMS0wMi0yMSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0F1ZGl0UnVsZXMuanMgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0F1ZGl0UnVsZXMuanMKaW5kZXggN2Q0YjhhNS4uM2FiMTAz ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9BdWRpdFJ1 bGVzLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQXVkaXRSdWxl cy5qcwpAQCAtODMsNiArODMsOCBAQCBXZWJJbnNwZWN0b3IuQXVkaXRSdWxlcy5HemlwUnVsZS5w cm90b3R5cGUgPSB7CiAgICAgICAgIHZhciBzdW1tYXJ5ID0gcmVzdWx0LmFkZENoaWxkKCIiLCB0 cnVlKTsKICAgICAgICAgZm9yICh2YXIgaSA9IDAsIGxlbmd0aCA9IHJlc291cmNlcy5sZW5ndGg7 IGkgPCBsZW5ndGg7ICsraSkgewogICAgICAgICAgICAgdmFyIHJlc291cmNlID0gcmVzb3VyY2Vz W2ldOworICAgICAgICAgICAgaWYgKHJlc291cmNlLnN0YXR1c0NvZGUgPT09IDMwNCkKKyAgICAg ICAgICAgICAgICBjb250aW51ZTsgLy8gRG8gbm90IHRlc3QgMzA0IE5vdCBNb2RpZmllZCByZXNv dXJjZXMgYXMgdGhlaXIgY29udGVudHMgYXJlIGFsd2F5cyBlbXB0eS4KICAgICAgICAgICAgIGlm ICh0aGlzLl9zaG91bGRDb21wcmVzcyhyZXNvdXJjZSkpIHsKICAgICAgICAgICAgICAgICB2YXIg c2l6ZSA9IHJlc291cmNlLnJlc291cmNlU2l6ZTsKICAgICAgICAgICAgICAgICBjYW5kaWRhdGVT aXplICs9IHNpemU7CkBAIC0xMDQsOCArMTA2LDExIEBAIFdlYkluc3BlY3Rvci5BdWRpdFJ1bGVz Lkd6aXBSdWxlLnByb3RvdHlwZSA9IHsKIAogICAgIF9pc0NvbXByZXNzZWQ6IGZ1bmN0aW9uKHJl c291cmNlKQogICAgIHsKLSAgICAgICAgdmFyIGVuY29kaW5nID0gcmVzb3VyY2UucmVzcG9uc2VI ZWFkZXJzWyJDb250ZW50LUVuY29kaW5nIl07Ci0gICAgICAgIHJldHVybiBlbmNvZGluZyA9PT0g Imd6aXAiIHx8IGVuY29kaW5nID09PSAiZGVmbGF0ZSI7CisgICAgICAgIHZhciBlbmNvZGluZ0hl YWRlciA9IHJlc291cmNlLnJlc3BvbnNlSGVhZGVyc1siQ29udGVudC1FbmNvZGluZyJdOworICAg ICAgICBpZiAoIWVuY29kaW5nSGVhZGVyKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworCisg ICAgICAgIHJldHVybiAvXGIoPzpnemlwfGRlZmxhdGUpXGIvLnRlc3QoZW5jb2RpbmdIZWFkZXIp OwogICAgIH0sCiAKICAgICBfc2hvdWxkQ29tcHJlc3M6IGZ1bmN0aW9uKHJlc291cmNlKQo=