54342 2011-02-12 12:39:43 -0800 crypto.getRandomValues should support all integer array types 2011-02-12 15:31:06 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth commit-queue eric sam oldest_to_newest 350291 0 abarth 2011-02-12 12:39:43 -0800 crypto.getRandomValues should support all integer array types 350292 1 82239 abarth 2011-02-12 12:40:55 -0800 Created attachment 82239 Patch 350297 2 82239 sam 2011-02-12 13:10:06 -0800 Comment on attachment 82239 Patch I haven't been paying to close attention to all this. Is this in a spec? Why VALIDATION_ERR and not a type error? Otherwise, the patch looks good. 350299 3 abarth 2011-02-12 13:14:06 -0800 > I haven't been paying to close attention to all this. Is this in a spec? It's mostly been a discussion on the whatwg list. I've offered to write it up as a spec. > Why VALIDATION_ERR and not a type error? Otherwise, the patch looks good. Type error is probably better. I'll try to figure out how to throw a type error from WebCore proper. 350300 4 abarth 2011-02-12 13:20:52 -0800 I see XPathException::TYPE_ERR. Is there a non-XPath specific TYPE_ERR I should be using instead? 350301 5 abarth 2011-02-12 13:21:09 -0800 +sam I see XPathException::TYPE_ERR. Is there a non-XPath specific TYPE_ERR I should be using instead? 350315 6 82239 commit-queue 2011-02-12 14:13:29 -0800 Comment on attachment 82239 Patch Clearing flags on attachment: 82239 Committed r78422: <http://trac.webkit.org/changeset/78422> 350316 7 commit-queue 2011-02-12 14:13:33 -0800 All reviewed patches have been landed. Closing bug. 350330 8 sam 2011-02-12 15:31:06 -0800 (In reply to comment #5) > +sam > > I see XPathException::TYPE_ERR. Is there a non-XPath specific TYPE_ERR I should be using instead? TYPE_MISMATCH_ERR is what seems to be used in quite a few places, e.g. the canvas rendering context. 82239 2011-02-12 12:40:55 -0800 2011-02-12 14:13:29 -0800 Patch bug-54342-20110212124054.patch text/plain 4834 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NDE4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDItMTIgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBjcnlwdG8uZ2V0UmFuZG9tVmFsdWVzIHNob3VsZCBzdXBwb3J0IGFs bCBpbnRlZ2VyIGFycmF5IHR5cGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01NDM0MgorCisgICAgICAgIEFzIGRpc2N1c3NlZCBvbiB3aGF0d2csIHdl IHNob3VsZCBzdXBwb3J0IGFsbCB0aGUgaW50ZWdlciBhcnJheSB0eXBlcy4KKworICAgICAgICBU ZXN0OiBzZWN1cml0eS9jcnlwdG8tcmFuZG9tLXZhbHVlcy10eXBlcy5odG1sCisKKyAgICAgICAg KiBwYWdlL0NyeXB0by5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDcnlwdG86OmdldFJhbmRvbVZh bHVlcyk6CisKIDIwMTEtMDItMTIgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgVG9ueSBDaGFuZy4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bh Z2UvQ3J5cHRvLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL0NyeXB0by5j cHAJKHJldmlzaW9uIDc4NDE3KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9DcnlwdG8uY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0zNCw5ICszNCwyMiBAQAogI2luY2x1ZGUgIlVpbnQ4QXJyYXkuaCIK ICNpbmNsdWRlIDx3dGYvQ3J5cHRvZ3JhcGhpY2FsbHlSYW5kb21OdW1iZXIuaD4KIAotCiBuYW1l c3BhY2UgV2ViQ29yZSB7CiAKK25hbWVzcGFjZSB7CisKK2Jvb2wgaXNJbnRlZ2VyQXJyYXkoQXJy YXlCdWZmZXJWaWV3KiBhcnJheSkKK3sKKyAgICByZXR1cm4gYXJyYXktPmlzQnl0ZUFycmF5KCkK KyAgICAgICAgfHwgYXJyYXktPmlzVW5zaWduZWRCeXRlQXJyYXkoKQorICAgICAgICB8fCBhcnJh eS0+aXNTaG9ydEFycmF5KCkKKyAgICAgICAgfHwgYXJyYXktPmlzVW5zaWduZWRTaG9ydEFycmF5 KCkKKyAgICAgICAgfHwgYXJyYXktPmlzSW50QXJyYXkoKQorICAgICAgICB8fCBhcnJheS0+aXNV bnNpZ25lZEludEFycmF5KCk7Cit9CisKK30KKwogQ3J5cHRvOjpDcnlwdG8oKQogewogfQpAQCAt NDQsNyArNTcsNyBAQCBDcnlwdG86OkNyeXB0bygpCiB2b2lkIENyeXB0bzo6Z2V0UmFuZG9tVmFs dWVzKEFycmF5QnVmZmVyVmlldyogYXJyYXksIEV4Y2VwdGlvbkNvZGUmIGVjKQogewogI2lmIFVT RShPU19SQU5ET01ORVNTKQotICAgIGlmICghYXJyYXkgfHwgIWFycmF5LT5pc1Vuc2lnbmVkQnl0 ZUFycmF5KCkpIHsKKyAgICBpZiAoIWFycmF5IHx8ICFpc0ludGVnZXJBcnJheShhcnJheSkpIHsK ICAgICAgICAgZWMgPSBWQUxJREFUSU9OX0VSUjsKICAgICAgICAgcmV0dXJuOwogICAgIH0KSW5k ZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHJldmlzaW9uIDc4NDE4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMTIgIEFkYW0gQmFydGggIDxhYmFydGhA d2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBjcnlwdG8uZ2V0UmFuZG9tVmFsdWVzIHNob3VsZCBzdXBwb3J0IGFsbCBpbnRlZ2VyIGFy cmF5IHR5cGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NDM0MgorCisgICAgICAgIFRlc3Qgd2hpY2ggdHlwZXMgb2YgYXJyYXlzIHdvcmsgd2l0aCBj cnlwdG8uZ2V0UmFuZG9tVmFsdWVzLgorCisgICAgICAgICogc2VjdXJpdHkvY3J5cHRvLXJhbmRv bS12YWx1ZXMtdHlwZXMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBzZWN1cml0eS9j cnlwdG8tcmFuZG9tLXZhbHVlcy10eXBlcy5odG1sOiBBZGRlZC4KKwogMjAxMS0wMi0xMiAgSm9j aGVuIEVpc2luZ2VyICA8am9jaGVuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBKZXJlbXkgT3Jsb3cuCkluZGV4OiBMYXlvdXRUZXN0cy9zZWN1cml0eS9jcnlwdG8tcmFuZG9t LXZhbHVlcy10eXBlcy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc2Vj dXJpdHkvY3J5cHRvLXJhbmRvbS12YWx1ZXMtdHlwZXMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvc2VjdXJpdHkvY3J5cHRvLXJhbmRvbS12YWx1ZXMtdHlwZXMtZXhw ZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE4IEBACitUZXN0cyB3aGljaCB0eXBl cyBhcmUgdmFsaWQgZm9yIGNyeXB0by5yYW5kb21WYWx1ZXMuCisKK09uIHN1Y2Nlc3MsIHlvdSB3 aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENP TVBMRVRFIi4KKworCitQQVNTICdjcnlwdG8nIGluIHdpbmRvdyBpcyB0cnVlCitQQVNTICdnZXRS YW5kb21WYWx1ZXMnIGluIHdpbmRvdy5jcnlwdG8gaXMgdHJ1ZQorUEFTUyBjcnlwdG8uZ2V0UmFu ZG9tVmFsdWVzKG5ldyBVaW50OEFycmF5KDMpKSBpcyB1bmRlZmluZWQuCitQQVNTIGNyeXB0by5n ZXRSYW5kb21WYWx1ZXMobmV3IEludDhBcnJheSgzKSkgaXMgdW5kZWZpbmVkLgorUEFTUyBjcnlw dG8uZ2V0UmFuZG9tVmFsdWVzKG5ldyBVaW50MTZBcnJheSgzKSkgaXMgdW5kZWZpbmVkLgorUEFT UyBjcnlwdG8uZ2V0UmFuZG9tVmFsdWVzKG5ldyBJbnQxNkFycmF5KDMpKSBpcyB1bmRlZmluZWQu CitQQVNTIGNyeXB0by5nZXRSYW5kb21WYWx1ZXMobmV3IFVpbnQzMkFycmF5KDMpKSBpcyB1bmRl ZmluZWQuCitQQVNTIGNyeXB0by5nZXRSYW5kb21WYWx1ZXMobmV3IEludDMyQXJyYXkoMykpIGlz IHVuZGVmaW5lZC4KK1BBU1MgY3J5cHRvLmdldFJhbmRvbVZhbHVlcyhuZXcgRmxvYXQzMkFycmF5 KDMpKSB0aHJldyBleGNlcHRpb24gRXJyb3I6IFZBTElEQVRJT05fRVJSOiBET00gRXhjZXB0aW9u IDE2LgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisK SW5kZXg6IExheW91dFRlc3RzL3NlY3VyaXR5L2NyeXB0by1yYW5kb20tdmFsdWVzLXR5cGVzLmh0 bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc2VjdXJpdHkvY3J5cHRvLXJhbmRvbS12YWx1 ZXMtdHlwZXMuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3NlY3VyaXR5L2NyeXB0 by1yYW5kb20tdmFsdWVzLXR5cGVzLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzUgQEAK KzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIg aHJlZj0iLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdCBz cmM9Ii4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3Jp cHQgc3JjPSJyZXNvdXJjZXMvdXRpbGl0aWVzLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5 PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxz Y3JpcHQ+CitkZXNjcmlwdGlvbigiVGVzdHMgd2hpY2ggdHlwZXMgYXJlIHZhbGlkIGZvciBjcnlw dG8ucmFuZG9tVmFsdWVzLiIpOworCitpZiAoIXdpbmRvdy5BcnJheUJ1ZmZlcikKKyAgICBkZWJ1 ZygiVGhpcyB0ZXN0IHJlcXVyZXMgQXJyYXlCdWZmZXJzIHRvIHJ1biEiKTsKKworc2hvdWxkQmUo IidjcnlwdG8nIGluIHdpbmRvdyIsICJ0cnVlIik7CitzaG91bGRCZSgiJ2dldFJhbmRvbVZhbHVl cycgaW4gd2luZG93LmNyeXB0byIsICJ0cnVlIik7CisKK3Nob3VsZEJlVW5kZWZpbmVkKCJjcnlw dG8uZ2V0UmFuZG9tVmFsdWVzKG5ldyBVaW50OEFycmF5KDMpKSIpOworc2hvdWxkQmVVbmRlZmlu ZWQoImNyeXB0by5nZXRSYW5kb21WYWx1ZXMobmV3IEludDhBcnJheSgzKSkiKTsKK3Nob3VsZEJl VW5kZWZpbmVkKCJjcnlwdG8uZ2V0UmFuZG9tVmFsdWVzKG5ldyBVaW50MTZBcnJheSgzKSkiKTsK K3Nob3VsZEJlVW5kZWZpbmVkKCJjcnlwdG8uZ2V0UmFuZG9tVmFsdWVzKG5ldyBJbnQxNkFycmF5 KDMpKSIpOworc2hvdWxkQmVVbmRlZmluZWQoImNyeXB0by5nZXRSYW5kb21WYWx1ZXMobmV3IFVp bnQzMkFycmF5KDMpKSIpOworc2hvdWxkQmVVbmRlZmluZWQoImNyeXB0by5nZXRSYW5kb21WYWx1 ZXMobmV3IEludDMyQXJyYXkoMykpIik7CisKK3Nob3VsZFRocm93KCJjcnlwdG8uZ2V0UmFuZG9t VmFsdWVzKG5ldyBGbG9hdDMyQXJyYXkoMykpIik7CisKK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQg PSB0cnVlOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMt dGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KKworCg==