54341 2011-02-12 12:12:50 -0800 optionally scale snapshots in document view coordinates 2011-06-18 12:43:47 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 kdecker kdecker darin oldest_to_newest 350288 0 kdecker 2011-02-12 12:12:50 -0800 Optionally scale snapshots in document view coordinates. 350289 1 82238 kdecker 2011-02-12 12:17:45 -0800 Created attachment 82238 proposed fix 350290 2 82238 mitz 2011-02-12 12:25:13 -0800 Comment on attachment 82238 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=82238&action=review > Source/WebKit2/ChangeLog:6 > + https://bugs.webkit.org/show_bug.cgi?id=54341 > + <rdar://problem/8990069> Need to add the bug title above the URLs 82238 2011-02-12 12:17:45 -0800 2011-02-12 12:25:13 -0800 proposed fix patch.txt text/plain 5356 kdecker SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NDE3KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDItMTIgIEtldmluIERl Y2tlciAgPGtkZWNrZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NDM0MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODk5MDA2OT4KKyAgICAgICAgCisgICAg ICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2UuY3BwOgor ICAgICAgICAoV0tCdW5kbGVQYWdlQ3JlYXRlU2NhbGVkU25hcHNob3RJbkRvY3VtZW50Q29vcmRp bmF0ZXMpOgorICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5k bGVQYWdlLmg6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJQYWdlOjpzY2FsZWRTbmFwc2hvdEluRG9jdW1lbnRDb29yZGluYXRl cyk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OnNuYXBzaG90SW5Eb2N1bWVudENvb3JkaW5h dGVzKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oOgorCiAyMDExLTAy LTExICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgTWFjaWVqIFN0YWNob3dpYWsuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBh Z2UuY3BwCShyZXZpc2lvbiA3ODQxNykKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5q ZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVQYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjAw LDYgKzIwMCwxMiBAQCBXS0ltYWdlUmVmIFdLQnVuZGxlUGFnZUNyZWF0ZVNuYXBzaG90SW5ECiAg ICAgcmV0dXJuIHRvQVBJKHdlYkltYWdlLnJlbGVhc2UoKS5sZWFrUmVmKCkpOwogfQogCitXS0lt YWdlUmVmIFdLQnVuZGxlUGFnZUNyZWF0ZVNjYWxlZFNuYXBzaG90SW5Eb2N1bWVudENvb3JkaW5h dGVzKFdLQnVuZGxlUGFnZVJlZiBwYWdlUmVmLCBXS1JlY3QgcmVjdCwgZG91YmxlIHNjYWxlRmFj dG9yLCBXS0ltYWdlT3B0aW9ucyBvcHRpb25zKQoreworICAgIFJlZlB0cjxXZWJJbWFnZT4gd2Vi SW1hZ2UgPSB0b0ltcGwocGFnZVJlZiktPnNjYWxlZFNuYXBzaG90SW5Eb2N1bWVudENvb3JkaW5h dGVzKHRvSW50UmVjdChyZWN0KSwgc2NhbGVGYWN0b3IsIHRvSW1hZ2VPcHRpb25zKG9wdGlvbnMp KTsKKyAgICByZXR1cm4gdG9BUEkod2ViSW1hZ2UucmVsZWFzZSgpLmxlYWtSZWYoKSk7Cit9CisK ICNpZiBkZWZpbmVkKEVOQUJMRV9JTlNQRUNUT1IpICYmIEVOQUJMRV9JTlNQRUNUT1IKIFdLQnVu ZGxlSW5zcGVjdG9yUmVmIFdLQnVuZGxlUGFnZUdldEluc3BlY3RvcihXS0J1bmRsZVBhZ2VSZWYg cGFnZVJlZikKIHsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5k bGUvQVBJL2MvV0tCdW5kbGVQYWdlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2UuaAkocmV2aXNpb24gNzg0 MTcpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dL QnVuZGxlUGFnZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNTQsNiArMjU0LDcgQEAgV0tfRVhQT1JU IGJvb2wgV0tCdW5kbGVQYWdlRmluZFN0cmluZyhXSwogCiBXS19FWFBPUlQgV0tJbWFnZVJlZiBX S0J1bmRsZVBhZ2VDcmVhdGVTbmFwc2hvdEluVmlld0Nvb3JkaW5hdGVzKFdLQnVuZGxlUGFnZVJl ZiBwYWdlLCBXS1JlY3QgcmVjdCwgV0tJbWFnZU9wdGlvbnMgb3B0aW9ucyk7CiBXS19FWFBPUlQg V0tJbWFnZVJlZiBXS0J1bmRsZVBhZ2VDcmVhdGVTbmFwc2hvdEluRG9jdW1lbnRDb29yZGluYXRl cyhXS0J1bmRsZVBhZ2VSZWYgcGFnZSwgV0tSZWN0IHJlY3QsIFdLSW1hZ2VPcHRpb25zIG9wdGlv bnMpOworV0tfRVhQT1JUIFdLSW1hZ2VSZWYgV0tCdW5kbGVQYWdlQ3JlYXRlU2NhbGVkU25hcHNo b3RJbkRvY3VtZW50Q29vcmRpbmF0ZXMoV0tCdW5kbGVQYWdlUmVmIHBhZ2UsIFdLUmVjdCByZWN0 LCBkb3VibGUgc2NhbGVGYWN0b3IsIFdLSW1hZ2VPcHRpb25zIG9wdGlvbnMpOwogCiAjaWYgZGVm aW5lZChFTkFCTEVfSU5TUEVDVE9SKSAmJiBFTkFCTEVfSU5TUEVDVE9SCiBXS19FWFBPUlQgV0tC dW5kbGVJbnNwZWN0b3JSZWYgV0tCdW5kbGVQYWdlR2V0SW5zcGVjdG9yKFdLQnVuZGxlUGFnZVJl ZiBwYWdlKTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdl LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5jcHAJKHJldmlzaW9uIDc4NDE3KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL1dlYlBhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NTQsNyArNzU0LDcgQEAgUGFz c1JlZlB0cjxXZWJJbWFnZT4gV2ViUGFnZTo6c25hcHNob3RJbgogICAgIHJldHVybiBzbmFwc2hv dC5yZWxlYXNlKCk7CiB9CiAKLVBhc3NSZWZQdHI8V2ViSW1hZ2U+IFdlYlBhZ2U6OnNuYXBzaG90 SW5Eb2N1bWVudENvb3JkaW5hdGVzKGNvbnN0IEludFJlY3QmIHJlY3QsIEltYWdlT3B0aW9ucyBv cHRpb25zKQorUGFzc1JlZlB0cjxXZWJJbWFnZT4gV2ViUGFnZTo6c2NhbGVkU25hcHNob3RJbkRv Y3VtZW50Q29vcmRpbmF0ZXMoY29uc3QgSW50UmVjdCYgcmVjdCwgZG91YmxlIHNjYWxlRmFjdG9y LCBJbWFnZU9wdGlvbnMgb3B0aW9ucykKIHsKICAgICBGcmFtZVZpZXcqIGZyYW1lVmlldyA9IG1f bWFpbkZyYW1lLT5jb3JlRnJhbWUoKS0+dmlldygpOwogICAgIGlmICghZnJhbWVWaWV3KQpAQCAt NzY1LDExICs3NjUsMTkgQEAgUGFzc1JlZlB0cjxXZWJJbWFnZT4gV2ViUGFnZTo6c25hcHNob3RJ bgogICAgIFBhaW50QmVoYXZpb3Igb2xkQmVoYXZpb3IgPSBmcmFtZVZpZXctPnBhaW50QmVoYXZp b3IoKTsKICAgICBmcmFtZVZpZXctPnNldFBhaW50QmVoYXZpb3Iob2xkQmVoYXZpb3IgfCBQYWlu dEJlaGF2aW9yRmxhdHRlbkNvbXBvc2l0aW5nTGF5ZXJzKTsKIAotICAgIFJlZlB0cjxXZWJJbWFn ZT4gc25hcHNob3QgPSBXZWJJbWFnZTo6Y3JlYXRlKHJlY3Quc2l6ZSgpLCBvcHRpb25zKTsKLSAg ICBPd25QdHI8V2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0PiBncmFwaGljc0NvbnRleHQgPSBzbmFw c2hvdC0+Yml0bWFwKCktPmNyZWF0ZUdyYXBoaWNzQ29udGV4dCgpOworICAgIGJvb2wgc2NhbGUg PSBzY2FsZUZhY3RvciA+IDE7CisgICAgSW50U2l6ZSBzaXplID0gcmVjdC5zaXplKCk7CisgICAg aWYgKHNjYWxlKSAKKyAgICAgICAgc2l6ZSA9IEludFNpemUoY2VpbChyZWN0LndpZHRoKCkgKiBz Y2FsZUZhY3RvciksIGNlaWwocmVjdC5oZWlnaHQoKSAqIHNjYWxlRmFjdG9yKSk7CiAKKyAgICBS ZWZQdHI8V2ViSW1hZ2U+IHNuYXBzaG90ID0gV2ViSW1hZ2U6OmNyZWF0ZShzaXplLCBvcHRpb25z KTsKKyAgICBPd25QdHI8V2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0PiBncmFwaGljc0NvbnRleHQg PSBzbmFwc2hvdC0+Yml0bWFwKCktPmNyZWF0ZUdyYXBoaWNzQ29udGV4dCgpOwogICAgIGdyYXBo aWNzQ29udGV4dC0+c2F2ZSgpOwogICAgIGdyYXBoaWNzQ29udGV4dC0+dHJhbnNsYXRlKC1yZWN0 LngoKSwgLXJlY3QueSgpKTsKKyAgICAKKyAgICBpZiAoc2NhbGUpCisgICAgICAgIGdyYXBoaWNz Q29udGV4dC0+c2NhbGUoRmxvYXRTaXplKHNjYWxlRmFjdG9yLCBzY2FsZUZhY3RvcikpOworICAg ICAgICAKICAgICBmcmFtZVZpZXctPnBhaW50Q29udGVudHMoZ3JhcGhpY3NDb250ZXh0LmdldCgp LCByZWN0KTsKICAgICBncmFwaGljc0NvbnRleHQtPnJlc3RvcmUoKTsKIApAQCAtNzc4LDYgKzc4 NiwxMSBAQCBQYXNzUmVmUHRyPFdlYkltYWdlPiBXZWJQYWdlOjpzbmFwc2hvdEluCiAgICAgcmV0 dXJuIHNuYXBzaG90LnJlbGVhc2UoKTsKIH0KIAorUGFzc1JlZlB0cjxXZWJJbWFnZT4gV2ViUGFn ZTo6c25hcHNob3RJbkRvY3VtZW50Q29vcmRpbmF0ZXMoY29uc3QgSW50UmVjdCYgcmVjdCwgSW1h Z2VPcHRpb25zIG9wdGlvbnMpCit7CisgICAgcmV0dXJuIHNjYWxlZFNuYXBzaG90SW5Eb2N1bWVu dENvb3JkaW5hdGVzKHJlY3QsIDEsIG9wdGlvbnMpOworfQorCiB2b2lkIFdlYlBhZ2U6OnBhZ2VE aWRTY3JvbGwoKQogewogICAgIC8vIEhpZGUgdGhlIGZpbmQgaW5kaWNhdG9yLgpJbmRleDogU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCShyZXZpc2lvbiA3ODQx NykKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgJKHdvcmtp bmcgY29weSkKQEAgLTIzOSw2ICsyMzksNyBAQCBwdWJsaWM6CiAKICAgICBQYXNzUmVmUHRyPFdl YkltYWdlPiBzbmFwc2hvdEluVmlld0Nvb3JkaW5hdGVzKGNvbnN0IFdlYkNvcmU6OkludFJlY3Qm LCBJbWFnZU9wdGlvbnMpOwogICAgIFBhc3NSZWZQdHI8V2ViSW1hZ2U+IHNuYXBzaG90SW5Eb2N1 bWVudENvb3JkaW5hdGVzKGNvbnN0IFdlYkNvcmU6OkludFJlY3QmLCBJbWFnZU9wdGlvbnMpOwor ICAgIFBhc3NSZWZQdHI8V2ViSW1hZ2U+IHNjYWxlZFNuYXBzaG90SW5Eb2N1bWVudENvb3JkaW5h dGVzKGNvbnN0IFdlYkNvcmU6OkludFJlY3QmLCBkb3VibGUgc2NhbGVGYWN0b3IsIEltYWdlT3B0 aW9ucyk7CiAKICAgICBzdGF0aWMgY29uc3QgV2ViRXZlbnQqIGN1cnJlbnRFdmVudCgpOwogCg==