<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>54339</bug_id>
          
          <creation_ts>2011-02-12 09:26:56 -0800</creation_ts>
          <short_desc>[Qt][WK2] Need implementation of ResourceRequest and ResourceResponse serialization</short_desc>
          <delta_ts>2011-02-14 01:28:19 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt, QtTriaged</keywords>
          <priority>P1</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Balazs Kelemen">kbalazs</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>benjamin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>350274</commentid>
    <comment_count>0</comment_count>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2011-02-12 09:26:56 -0800</bug_when>
    <thetext>After r77974 Qt WebKit2 implementation is not more functional, i.e. MiniBrowser does not load a simple page.
The reason is that we lack serialization for ResourceRequest and ResourceResponse so WebFrameLoaderClient
cannot do it&apos;s job.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>350336</commentid>
    <comment_count>1</comment_count>
      <attachid>82245</attachid>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2011-02-12 16:22:10 -0800</bug_when>
    <thetext>Created attachment 82245
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>350337</commentid>
    <comment_count>2</comment_count>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2011-02-12 16:27:36 -0800</bug_when>
    <thetext>The patch is just a dummy implementation that returns with true from decode
so the core can go with it. 
I do not think it is a good idea to implement this until we know how would
we use it. I am wondering about even the possibility of serializing and reusing
a request or a reply in another process with the Qt network stack.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>350559</commentid>
    <comment_count>3</comment_count>
      <attachid>82245</attachid>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2011-02-14 01:28:12 -0800</bug_when>
    <thetext>Comment on attachment 82245
Patch

Clearing flags on attachment: 82245

Committed r78458: &lt;http://trac.webkit.org/changeset/78458&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>350560</commentid>
    <comment_count>4</comment_count>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2011-02-14 01:28:19 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>82245</attachid>
            <date>2011-02-12 16:22:10 -0800</date>
            <delta_ts>2011-02-14 01:28:12 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-54339-20110213002209.patch</filename>
            <type>text/plain</type>
            <size>2237</size>
            <attacher name="Balazs Kelemen">kbalazs</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogNzg0MjQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA0NWI2ZmY4MTcyNjdiZDgw
YTk5ZjMzMGEwOTA0OTY2OTNmNTE5OGZiLi5jNmY4MWUxMjYyZjkwZDBiNzkyNmRhYzMxNTc2ZjJm
YTgyZDY0ZTZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMTIgIEJhbGF6
cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gTmVlZCBpbXBsZW1lbnRhdGlvbiBvZiBSZXNv
dXJjZVJlcXVlc3QgYW5kIFJlc291cmNlUmVzcG9uc2Ugc2VyaWFsaXphdGlvbgorICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQzMzkKKworICAgICAgICBB
ZGQgZHVtbXkgaW1wbGVtZW50YXRpb24gd2l0aCBGSVhNRSBhbmQgbGV0IHRoZSBjb3JlIGdvIHdp
dGggaXQgZm9yIG5vdy4KKyAgICAgICAgKiBTaGFyZWQvcXQvV2ViQ29yZUFyZ3VtZW50Q29kZXJz
UXQuY3BwOgorICAgICAgICAoQ29yZUlQQzo6ZGVjb2RlUmVzb3VyY2VSZXF1ZXN0KToKKyAgICAg
ICAgKENvcmVJUEM6OmRlY29kZVJlc291cmNlUmVzcG9uc2UpOgorCiAyMDExLTAyLTEyICBLZXZp
biBEZWNrZXIgIDxrZGVja2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4g
QmVybnN0ZWluLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL3F0L1dlYkNvcmVB
cmd1bWVudENvZGVyc1F0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9xdC9XZWJDb3JlQXJn
dW1lbnRDb2RlcnNRdC5jcHAKaW5kZXggNDRjZGJlYWY4NWI0ZTRlZjMwMmM5YmQxNTYxNWUzNDRm
MTU5ZDBlMS4uZTk4NGU4Y2JhMTcyNGVlMjk4ZDM3MmZiZTA0MTI3NmEzODUxMTQ4ZiAxMDA2NDQK
LS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL3F0L1dlYkNvcmVBcmd1bWVudENvZGVyc1F0LmNw
cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvcXQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzUXQu
Y3BwCkBAIC0yNSw3ICsyNSw5IEBACiAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJX
ZWJDb3JlQXJndW1lbnRDb2RlcnMuaCIKKwogI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCisj
aW5jbHVkZSA8V2ViQ29yZS9SZXNvdXJjZVJlc3BvbnNlLmg+CiAKIG5hbWVzcGFjZSBDb3JlSVBD
IHsKIApAQCAtMzcsNyArMzksMTEgQEAgdm9pZCBlbmNvZGVSZXNvdXJjZVJlcXVlc3QoQXJndW1l
bnRFbmNvZGVyKiBlbmNvZGVyLCBjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXUKIGJvb2wgZGVj
b2RlUmVzb3VyY2VSZXF1ZXN0KEFyZ3VtZW50RGVjb2RlciogZGVjb2RlciwgV2ViQ29yZTo6UmVz
b3VyY2VSZXF1ZXN0JiByZXNvdXJjZVJlcXVlc3QpCiB7CiAgICAgbm90SW1wbGVtZW50ZWQoKTsK
LSAgICByZXR1cm4gZmFsc2U7CisKKyAgICAvLyBGSVhNRTogQWRkIHJlYWwgaW1wbGVtZW50YXRp
b24gd2hlbiB3ZSB3YW50IHRvIGltcGxlbWVudCBzb21ldGhpbmcgdGhhdAorICAgIC8vIGRlcGVu
ZHMgb24gdGhpcyBsaWtlIHRoZSBwb2xpY3kgY2xpZW50LgorICAgIHJlc291cmNlUmVxdWVzdCA9
IFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCgpOworICAgIHJldHVybiB0cnVlOwogfQogCiB2b2lk
IGVuY29kZVJlc291cmNlUmVzcG9uc2UoQXJndW1lbnRFbmNvZGVyKiBlbmNvZGVyLCBjb25zdCBX
ZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlJiByZXNvdXJjZVJlc3BvbnNlKQpAQCAtNDgsNyArNTQs
MTAgQEAgdm9pZCBlbmNvZGVSZXNvdXJjZVJlc3BvbnNlKEFyZ3VtZW50RW5jb2RlciogZW5jb2Rl
ciwgY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXMKIGJvb2wgZGVjb2RlUmVzb3VyY2VSZXNwb25z
ZShBcmd1bWVudERlY29kZXIqIGRlY29kZXIsIFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2UmIHJl
c291cmNlUmVzcG9uc2UpCiB7CiAgICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICByZXR1cm4gZmFs
c2U7CisKKyAgICAvLyBGSVhNRTogRGl0dG8uCisgICAgcmVzb3VyY2VSZXNwb25zZSA9IFdlYkNv
cmU6OlJlc291cmNlUmVzcG9uc2UoKTsKKyAgICByZXR1cm4gdHJ1ZTsKIH0KIAogfSAvLyBuYW1l
c3BhY2UgQ29yZUlQQwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>