54336 2011-02-12 01:16:01 -0800 PlatformContextSkia::applyAntiAliasedClipPaths does not work for paths which have evenOdd property 2011-02-16 16:50:51 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED http://www.w3.org/Graphics/SVG/Test/20021112/htmlframe/full-masking-path-05-f.html P2 Normal --- 0 robin.webkit webkit-unassigned agl bsalomon commit-queue jamesr reed robin.webkit senorblanco oldest_to_newest 350252 0 robin.webkit 2011-02-12 01:16:01 -0800 PlatformContextSkia::applyAntiAliasedClipPaths does not work for paths which have evenOdd property. This test (http://www.w3.org/Graphics/SVG/Test/20021112/htmlframe/full-masking-path-05-f.html) fails on Chrome. I have a fix for this. Will upload soon. 351005 1 82393 robin.webkit 2011-02-14 17:26:05 -0800 Created attachment 82393 patch We need to take fill type of paths into account in applyAntiAliasedClipPaths. 351011 2 jamesr 2011-02-14 17:40:27 -0800 I think this fine - could one of you (Mike/Stephen/Brian) sanity check it? 351015 3 jamesr 2011-02-14 17:43:09 -0800 This is marked as a failure on win/linux in chromium currently: http://code.google.com/p/chromium/issues/detail?id=25208 351255 4 reed 2011-02-15 07:50:16 -0800 SkPath::toggleInverseFillType() is a helper that does exactly this. 351268 5 senorblanco 2011-02-15 08:02:28 -0800 +agl, since I think he wrote this code. This looks ok to me (although we should probably use the helper fn, as Mike suggests). 351523 6 agl 2011-02-15 13:19:18 -0800 LGTM if updated with Mike's suggestion. (Of course, I still hope that Skia gets immediate anti-aliased clipping at some point :) Shouldn't this either include updated baselines or new layout tests? Or are they to follow in a different patch? 351540 7 jamesr 2011-02-15 13:52:46 -0800 svg/W3C-SVG-1.1/masking-path-05-f.svg covers this test. Robin, could you remove the line referencing this test from LayoutTests/platform/chromium/test_expectations.txt when you update this patch? Thanks! 351543 8 82393 jamesr 2011-02-15 13:53:13 -0800 Comment on attachment 82393 patch Marking this one R- since it should use the helper function. 351798 9 robin.webkit 2011-02-15 18:13:20 -0800 (In reply to comment #7) > Robin, could you remove the line referencing this test from LayoutTests/platform/chromium/test_expectations.txt when you update this patch? Thanks! I can do this. One question is that i only work on linux at the moment and do i have to update baselines for chromium-win? 351801 10 jamesr 2011-02-15 18:15:12 -0800 Oh, that is a bummer. Just leave the test_expectations.txt line alone and we (meaning probably me) will take care of the baselines. 351811 11 82570 robin.webkit 2011-02-15 18:50:18 -0800 Created attachment 82570 updated patch Use the helper function to toggle fill type of paths. 352201 12 agl 2011-02-16 11:08:52 -0800 LGTM. (Note I am not a WK reviewer. You need an r+ from a real reviewer also.) 352226 13 82570 jamesr 2011-02-16 11:33:26 -0800 Comment on attachment 82570 updated patch R=me. Thanks again! 352459 14 commit-queue 2011-02-16 16:49:12 -0800 The commit-queue encountered the following flaky tests while processing attachment 82570: http/tests/misc/uncacheable-script-repeated.html bug 51009 (author: koivisto@iki.fi) The commit-queue is continuing to process your patch. 352461 15 82570 commit-queue 2011-02-16 16:50:46 -0800 Comment on attachment 82570 updated patch Clearing flags on attachment: 82570 Committed r78751: <http://trac.webkit.org/changeset/78751> 352463 16 commit-queue 2011-02-16 16:50:51 -0800 All reviewed patches have been landed. Closing bug. 82393 2011-02-14 17:26:05 -0800 2011-02-15 18:50:18 -0800 patch clip-path.patch text/plain 1620 robin.webkit SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NTIzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDItMTQgIFJvYmluIENh byAgPHJvYmluLmNhb0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGxhdGZvcm1Db250ZXh0U2tpYTo6YXBwbHlBbnRp QWxpYXNlZENsaXBQYXRocyBkb2VzIG5vdCB3b3JrIGZvciBwYXRocyB3aGljaCBoYXZlIGV2ZW5P ZGQgcHJvcGVydHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU0MzM2CisKKyAgICAgICAgV2UgbmVlZCB0byB0YWtlIGZpbGwgdHlwZSBvZiBwYXRocyBp bnRvIGFjY291bnQgd2hlbiBkcmF3aW5nIHRoZW0uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBj b3ZlcmVkIGJ5IHN2Zy9XM0MtU1ZHLTEuMS9tYXNraW5nLXBhdGgtMDUtZi5zdmcuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UGxhdGZvcm1Db250ZXh0U2tpYTo6YXBwbHlBbnRpQWxpYXNlZENsaXBQ YXRocyk6CisKIDIwMTEtMDItMTQgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4K IAogICAgICAgICBDb3B5L3Bhc3RlIGZyb20gYSBXZWJLaXQgd2luZG93IHRvIGEgVGV4dEVkaXQg d2luZG93IGxvc2VzIGZvbnRzLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwCShyZXZp c2lvbiA3ODQ1NykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxh dGZvcm1Db250ZXh0U2tpYS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY4OCw3ICs2ODgsNyBAQCB2 b2lkIFBsYXRmb3JtQ29udGV4dFNraWE6OmFwcGx5QW50aUFsaWFzCiAgICAgcGFpbnQuc2V0U3R5 bGUoU2tQYWludDo6a0ZpbGxfU3R5bGUpOwogCiAgICAgZm9yIChzaXplX3QgaSA9IHBhdGhzLnNp emUoKSAtIDE7IGkgPCBwYXRocy5zaXplKCk7IC0taSkgewotICAgICAgICBwYXRoc1tpXS5zZXRG aWxsVHlwZShTa1BhdGg6OmtJbnZlcnNlV2luZGluZ19GaWxsVHlwZSk7CisgICAgICAgIHBhdGhz W2ldLnNldEZpbGxUeXBlKHBhdGhzW2ldLmdldEZpbGxUeXBlKCkgPT0gU2tQYXRoOjprV2luZGlu Z19GaWxsVHlwZSA/IFNrUGF0aDo6a0ludmVyc2VXaW5kaW5nX0ZpbGxUeXBlIDogU2tQYXRoOjpr SW52ZXJzZUV2ZW5PZGRfRmlsbFR5cGUpOwogICAgICAgICBtX2NhbnZhcy0+ZHJhd1BhdGgocGF0 aHNbaV0sIHBhaW50KTsKICAgICB9CiAK 82570 2011-02-15 18:50:18 -0800 2011-02-16 16:50:45 -0800 updated patch clip-path-v2.patch text/plain 1509 robin.webkit SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NTIzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDItMTQgIFJvYmluIENh byAgPHJvYmluLmNhb0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGxhdGZvcm1Db250ZXh0U2tpYTo6YXBwbHlBbnRp QWxpYXNlZENsaXBQYXRocyBkb2VzIG5vdCB3b3JrIGZvciBwYXRocyB3aGljaCBoYXZlIGV2ZW5P ZGQgcHJvcGVydHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU0MzM2CisKKyAgICAgICAgV2UgbmVlZCB0byB0YWtlIGZpbGwgdHlwZSBvZiBwYXRocyBp bnRvIGFjY291bnQgd2hlbiBkcmF3aW5nIHRoZW0uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBj b3ZlcmVkIGJ5IHN2Zy9XM0MtU1ZHLTEuMS9tYXNraW5nLXBhdGgtMDUtZi5zdmcuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UGxhdGZvcm1Db250ZXh0U2tpYTo6YXBwbHlBbnRpQWxpYXNlZENsaXBQ YXRocyk6CisKIDIwMTEtMDItMTQgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4K IAogICAgICAgICBDb3B5L3Bhc3RlIGZyb20gYSBXZWJLaXQgd2luZG93IHRvIGEgVGV4dEVkaXQg d2luZG93IGxvc2VzIGZvbnRzLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwCShyZXZp c2lvbiA3ODQ1NykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxh dGZvcm1Db250ZXh0U2tpYS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY4OCw3ICs2ODgsNyBAQCB2 b2lkIFBsYXRmb3JtQ29udGV4dFNraWE6OmFwcGx5QW50aUFsaWFzCiAgICAgcGFpbnQuc2V0U3R5 bGUoU2tQYWludDo6a0ZpbGxfU3R5bGUpOwogCiAgICAgZm9yIChzaXplX3QgaSA9IHBhdGhzLnNp emUoKSAtIDE7IGkgPCBwYXRocy5zaXplKCk7IC0taSkgewotICAgICAgICBwYXRoc1tpXS5zZXRG aWxsVHlwZShTa1BhdGg6OmtJbnZlcnNlV2luZGluZ19GaWxsVHlwZSk7CisgICAgICAgIHBhdGhz W2ldLnRvZ2dsZUludmVyc2VGaWxsVHlwZSgpOwogICAgICAgICBtX2NhbnZhcy0+ZHJhd1BhdGgo cGF0aHNbaV0sIHBhaW50KTsKICAgICB9CiAK