54321 2011-02-11 15:43:04 -0800 [chromium] Allow turning off multisampling through web reference settings 2011-02-12 12:46:59 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zmo zmo enne kbr oldest_to_newest 350112 0 zmo 2011-02-11 15:43:04 -0800 So later we could hook up chromium side through a command line flag "--disable-gl-multisampling". Note that I also have the chromium side CL ready for review. I tested that with patches on both side, "--disable-gl-multisampling" will turn off multisampling in WebGL in chromium. 350124 1 82203 zmo 2011-02-11 15:53:27 -0800 Created attachment 82203 Patch 350194 2 82203 kbr 2011-02-11 18:09:18 -0800 Comment on attachment 82203 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82203&action=review Basically looks fine with a couple of nits. Appreciate your fixing upon commit. > Source/WebCore/ChangeLog:5 > + [chromium] Allow turning off multisampling through web reference settings reference -> preference > Source/WebCore/ChangeLog:10 > + * page/Settings.cpp: Add a fflag for multisampling preference. typo: fflag > Source/WebCore/ChangeLog:14 > + (WebCore::Settings::setGLMultisamplingEnabled): > + * page/Settings.h: Ditto. > + (WebCore::Settings::GLMultisamplingEnabled): These don't match WebKit capitalization conventions. I'd suggest "setOpenGLMultisamplingEnabled" / "openGLMultisamplingEnabled". > Source/WebKit/chromium/ChangeLog:5 > + [chromium] Allow turning off multisampling through web reference settings again, reference -> preference 350293 3 zmo 2011-02-12 12:46:59 -0800 Committed r78419: <http://trac.webkit.org/changeset/78419> 82203 2011-02-11 15:53:27 -0800 2011-02-11 18:09:18 -0800 Patch bug-54321-20110211155326.patch text/plain 6429 zmo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4Mzg1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDItMTEgIFpoZW55YW8g TW8gIDx6bW9AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbY2hyb21pdW1dIEFsbG93IHR1cm5pbmcgb2ZmIG11bHRpc2FtcGxpbmcg dGhyb3VnaCB3ZWIgcmVmZXJlbmNlIHNldHRpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDMyMQorCisgICAgICAgICogaHRtbC9jYW52YXMvV2Vi R0xSZW5kZXJpbmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMUmVuZGVyaW5n Q29udGV4dDo6Y3JlYXRlKTogRGlzYWJsZSBtdWx0aXNhbXBsaW5nIGluIFdlYkdMIGlmIHdlYiBy ZWZlcmVuY2Ugc2F5cyBzby4KKyAgICAgICAgKiBwYWdlL1NldHRpbmdzLmNwcDogQWRkIGEgZmZs YWcgZm9yIG11bHRpc2FtcGxpbmcgcHJlZmVyZW5jZS4KKyAgICAgICAgKFdlYkNvcmU6OlNldHRp bmdzOjpTZXR0aW5ncyk6CisgICAgICAgIChXZWJDb3JlOjpTZXR0aW5nczo6c2V0R0xNdWx0aXNh bXBsaW5nRW5hYmxlZCk6CisgICAgICAgICogcGFnZS9TZXR0aW5ncy5oOiBEaXR0by4KKyAgICAg ICAgKFdlYkNvcmU6OlNldHRpbmdzOjpHTE11bHRpc2FtcGxpbmdFbmFibGVkKToKKwogMjAxMS0w Mi0xMSAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgQWRhbSBCYXJ0aC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVu ZGVyaW5nQ29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9jYW52 YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAkocmV2aXNpb24gNzgzMDkpCisrKyBTb3VyY2Uv V2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC00OCw2ICs0OCw3IEBACiAjaW5jbHVkZSAiT0VTVGV4dHVyZUZsb2F0LmgiCiAjaW5j bHVkZSAiUmVuZGVyQm94LmgiCiAjaW5jbHVkZSAiUmVuZGVyTGF5ZXIuaCIKKyNpbmNsdWRlICJT ZXR0aW5ncy5oIgogI2luY2x1ZGUgIlVpbnQxNkFycmF5LmgiCiAjaW5jbHVkZSAiV2ViR0xBY3Rp dmVJbmZvLmgiCiAjaW5jbHVkZSAiV2ViR0xCdWZmZXIuaCIKQEAgLTM1NCw2ICszNTUsMTMgQEAg UGFzc093blB0cjxXZWJHTFJlbmRlcmluZ0NvbnRleHQ+IFdlYkdMUgogewogICAgIEhvc3RXaW5k b3cqIGhvc3RXaW5kb3cgPSBjYW52YXMtPmRvY3VtZW50KCktPnZpZXcoKS0+cm9vdCgpLT5ob3N0 V2luZG93KCk7CiAgICAgR3JhcGhpY3NDb250ZXh0M0Q6OkF0dHJpYnV0ZXMgYXR0cmlidXRlcyA9 IGF0dHJzID8gYXR0cnMtPmF0dHJpYnV0ZXMoKSA6IEdyYXBoaWNzQ29udGV4dDNEOjpBdHRyaWJ1 dGVzKCk7CisKKyAgICBpZiAoYXR0cmlidXRlcy5hbnRpYWxpYXMpIHsKKyAgICAgICAgUGFnZSog cCA9IGNhbnZhcy0+ZG9jdW1lbnQoKS0+cGFnZSgpOworICAgICAgICBpZiAocCAmJiAhcC0+c2V0 dGluZ3MoKS0+R0xNdWx0aXNhbXBsaW5nRW5hYmxlZCgpKQorICAgICAgICAgICAgYXR0cmlidXRl cy5hbnRpYWxpYXMgPSBmYWxzZTsKKyAgICB9CisKICAgICBSZWZQdHI8R3JhcGhpY3NDb250ZXh0 M0Q+IGNvbnRleHQoR3JhcGhpY3NDb250ZXh0M0Q6OmNyZWF0ZShhdHRyaWJ1dGVzLCBob3N0V2lu ZG93KSk7CiAKICAgICBpZiAoIWNvbnRleHQpIHsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2Uv U2V0dGluZ3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3Mu Y3BwCShyZXZpc2lvbiA3ODMwOSkKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0xNTYsNiArMTU2LDcgQEAgU2V0dGluZ3M6OlNldHRpbmdzKFBh Z2UqIHBhZ2UpCiAgICAgLCBtX3Nob3dSZXBhaW50Q291bnRlcihmYWxzZSkKICAgICAsIG1fZXhw ZXJpbWVudGFsTm90aWZpY2F0aW9uc0VuYWJsZWQoZmFsc2UpCiAgICAgLCBtX3dlYkdMRW5hYmxl ZChmYWxzZSkKKyAgICAsIG1fR0xNdWx0aXNhbXBsaW5nRW5hYmxlZCh0cnVlKQogICAgICwgbV93 ZWJBdWRpb0VuYWJsZWQoZmFsc2UpCiAgICAgLCBtX2FjY2VsZXJhdGVkQ2FudmFzMmRFbmFibGVk KGZhbHNlKQogICAgICwgbV9sb2FkRGVmZXJyaW5nRW5hYmxlZCh0cnVlKQpAQCAtNjY2LDYgKzY2 NywxMSBAQCB2b2lkIFNldHRpbmdzOjpzZXRXZWJHTEVuYWJsZWQoYm9vbCBlbmFiCiAgICAgbV93 ZWJHTEVuYWJsZWQgPSBlbmFibGVkOwogfQogCit2b2lkIFNldHRpbmdzOjpzZXRHTE11bHRpc2Ft cGxpbmdFbmFibGVkKGJvb2wgZW5hYmxlZCkKK3sKKyAgICBtX0dMTXVsdGlzYW1wbGluZ0VuYWJs ZWQgPSBlbmFibGVkOworfQorCiB2b2lkIFNldHRpbmdzOjpzZXRBY2NlbGVyYXRlZDJkQ2FudmFz RW5hYmxlZChib29sIGVuYWJsZWQpCiB7CiAgICAgbV9hY2NlbGVyYXRlZENhbnZhczJkRW5hYmxl ZCA9IGVuYWJsZWQ7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5oCShyZXZpc2lvbiA3ODMwOSkK KysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuaAkod29ya2luZyBjb3B5KQpAQCAtMzE4 LDYgKzMxOCw5IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdm9pZCBzZXRXZWJHTEVu YWJsZWQoYm9vbCk7CiAgICAgICAgIGJvb2wgd2ViR0xFbmFibGVkKCkgY29uc3QgeyByZXR1cm4g bV93ZWJHTEVuYWJsZWQ7IH0KIAorICAgICAgICB2b2lkIHNldEdMTXVsdGlzYW1wbGluZ0VuYWJs ZWQoYm9vbCk7CisgICAgICAgIGJvb2wgR0xNdWx0aXNhbXBsaW5nRW5hYmxlZCgpIGNvbnN0IHsg cmV0dXJuIG1fR0xNdWx0aXNhbXBsaW5nRW5hYmxlZDsgfQorCiAgICAgICAgIHZvaWQgc2V0QWNj ZWxlcmF0ZWQyZENhbnZhc0VuYWJsZWQoYm9vbCk7CiAgICAgICAgIGJvb2wgYWNjZWxlcmF0ZWQy ZENhbnZhc0VuYWJsZWQoKSBjb25zdCB7IHJldHVybiBtX2FjY2VsZXJhdGVkQ2FudmFzMmRFbmFi bGVkOyB9CiAKQEAgLTQzNyw2ICs0NDAsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAg IGJvb2wgbV9zaG93UmVwYWludENvdW50ZXIgOiAxOwogICAgICAgICBib29sIG1fZXhwZXJpbWVu dGFsTm90aWZpY2F0aW9uc0VuYWJsZWQgOiAxOwogICAgICAgICBib29sIG1fd2ViR0xFbmFibGVk IDogMTsKKyAgICAgICAgYm9vbCBtX0dMTXVsdGlzYW1wbGluZ0VuYWJsZWQgOiAxOwogICAgICAg ICBib29sIG1fd2ViQXVkaW9FbmFibGVkIDogMTsKICAgICAgICAgYm9vbCBtX2FjY2VsZXJhdGVk Q2FudmFzMmRFbmFibGVkIDogMTsKICAgICAgICAgYm9vbCBtX2xvYWREZWZlcnJpbmdFbmFibGVk IDogMTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA3ODM4NSkKKysr IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMDItMTEgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIEFs bG93IHR1cm5pbmcgb2ZmIG11bHRpc2FtcGxpbmcgdGhyb3VnaCB3ZWIgcmVmZXJlbmNlIHNldHRp bmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDMy MQorCisgICAgICAgICogcHVibGljL1dlYlNldHRpbmdzLmg6IEFkZCBhIGZsYWcgZm9yIG11bHRp c2FtcGxpbmcgc2V0dGluZy4KKyAgICAgICAgKiBzcmMvV2ViU2V0dGluZ3NJbXBsLmNwcDogRGl0 dG8uCisgICAgICAgIChXZWJLaXQ6OldlYlNldHRpbmdzSW1wbDo6c2V0R0xNdWx0aXNhbXBsaW5n RW5hYmxlZCk6CisgICAgICAgICogc3JjL1dlYlNldHRpbmdzSW1wbC5oOiBEaXR0by4KKwogMjAx MS0wMi0xMSAgQWRhbSBLbGVpbiAgPGFkYW1rQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEYXJpbiBGaXNoZXIuCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJTZXR0aW5ncy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVi bGljL1dlYlNldHRpbmdzLmgJKHJldmlzaW9uIDc4MzA5KQorKysgU291cmNlL1dlYktpdC9jaHJv bWl1bS9wdWJsaWMvV2ViU2V0dGluZ3MuaAkod29ya2luZyBjb3B5KQpAQCAtOTMsNiArOTMsNyBA QCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHNldE9mZmxpbmVXZWJBcHBsaWNhdGlvbkNhY2hl RW5hYmxlZChib29sKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHNldFdlYkF1ZGlvRW5hYmxlZChi b29sKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHNldEV4cGVyaW1lbnRhbFdlYkdMRW5hYmxlZChi b29sKSA9IDA7CisgICAgdmlydHVhbCB2b2lkIHNldEdMTXVsdGlzYW1wbGluZ0VuYWJsZWQoYm9v bCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXRTaG93RGVidWdCb3JkZXJzKGJvb2wpID0gMDsK ICAgICB2aXJ0dWFsIHZvaWQgc2V0RWRpdGluZ0JlaGF2aW9yKEVkaXRpbmdCZWhhdmlvcikgPSAw OwogICAgIHZpcnR1YWwgdm9pZCBzZXRBY2NlbGVyYXRlZENvbXBvc2l0aW5nRW5hYmxlZChib29s KSA9IDA7CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdz SW1wbC5jcHAJKHJldmlzaW9uIDc4MzA5KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViU2V0dGluZ3NJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjc0LDYgKzI3NCwxMSBAQCB2 b2lkIFdlYlNldHRpbmdzSW1wbDo6c2V0RXhwZXJpbWVudGFsV2ViCiAgICAgbV9zZXR0aW5ncy0+ c2V0V2ViR0xFbmFibGVkKGVuYWJsZWQpOwogfQogCit2b2lkIFdlYlNldHRpbmdzSW1wbDo6c2V0 R0xNdWx0aXNhbXBsaW5nRW5hYmxlZChib29sIGVuYWJsZWQpCit7CisgICAgbV9zZXR0aW5ncy0+ c2V0R0xNdWx0aXNhbXBsaW5nRW5hYmxlZChlbmFibGVkKTsKK30KKwogdm9pZCBXZWJTZXR0aW5n c0ltcGw6OnNldFNob3dEZWJ1Z0JvcmRlcnMoYm9vbCBzaG93KQogewogICAgIG1fc2V0dGluZ3Mt PnNldFNob3dEZWJ1Z0JvcmRlcnMoc2hvdyk7CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJTZXR0aW5nc0ltcGwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuaAkocmV2aXNpb24gNzgzMDkpCisrKyBTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuaAkod29ya2luZyBjb3B5KQpAQCAtODYs NiArODYsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHNldE9mZmxpbmVXZWJBcHBsaWNh dGlvbkNhY2hlRW5hYmxlZChib29sKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0V2ViQXVkaW9FbmFi bGVkKGJvb2wpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRFeHBlcmltZW50YWxXZWJHTEVuYWJsZWQo Ym9vbCk7CisgICAgdmlydHVhbCB2b2lkIHNldEdMTXVsdGlzYW1wbGluZ0VuYWJsZWQoYm9vbCk7 CiAgICAgdmlydHVhbCB2b2lkIHNldFNob3dEZWJ1Z0JvcmRlcnMoYm9vbCk7CiAgICAgdmlydHVh bCB2b2lkIHNldEVkaXRpbmdCZWhhdmlvcihFZGl0aW5nQmVoYXZpb3IpOwogICAgIHZpcnR1YWwg dm9pZCBzZXRBY2NlbGVyYXRlZENvbXBvc2l0aW5nRW5hYmxlZChib29sKTsK