54305 2011-02-11 12:33:31 -0800 GIFImageDecoder::setSize() tries to override the superclass method but fails 2011-02-21 19:57:49 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 54367 1 thakis thakis commit-queue darin dglazkov webkit.review.bot oldest_to_newest 349920 0 thakis 2011-02-11 12:33:31 -0800 GIFImageDecoder::setSize() tries to override the superclass method but fails 349922 1 82160 thakis 2011-02-11 12:34:37 -0800 Created attachment 82160 Patch 349923 2 thakis 2011-02-11 12:34:53 -0800 Found by a new clang warning: In file included from /b/build/slave/mac_clang/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../platform/image-decoders/ImageDecoder.cpp:30: ../platform/image-decoders/gif/GIFImageDecoder.h:48:22:error: 'WebCore::GIFImageDecoder::setSize' hides overloaded virtual function [-Woverloaded-virtual] virtual bool setSize(int width, int height); ^ In file included from /b/build/slave/mac_clang/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../platform/image-decoders/ImageDecoder.cpp:24: ../platform/image-decoders/ImageDecoder.h:274:22: note: hidden overloaded virtual function 'WebCore::ImageDecoder::setSize' declared here virtual bool setSize(unsigned width, unsigned height) ^ 1 error generated. 349924 3 thakis 2011-02-11 12:36:58 -0800 The only thing the subclass does is initialize caches if necessary. So according to the guideline in bug 54301 comment 6, this means this patch doesn't need a patch (if I got the guideline right). 349926 4 thakis 2011-02-11 12:38:24 -0800 *doesn't need a test 349927 5 webkit.review.bot 2011-02-11 12:38:49 -0800 Attachment 82160 did not build on chromium: Build output: http://queues.webkit.org/results/7869729 349935 6 82160 thakis 2011-02-11 12:47:18 -0800 Comment on attachment 82160 Patch r- for bot failure. Won't be able to clean this up in the near future. 350086 7 webkit.review.bot 2011-02-11 15:19:23 -0800 Attachment 82160 did not build on chromium: Build output: http://queues.webkit.org/results/7870784 354836 8 83223 thakis 2011-02-21 15:13:40 -0800 Created attachment 83223 Patch 354932 9 83223 tkent 2011-02-21 17:38:30 -0800 Comment on attachment 83223 Patch looks reasonable. 355008 10 83223 commit-queue 2011-02-21 19:57:44 -0800 Comment on attachment 83223 Patch Clearing flags on attachment: 83223 Committed r79282: <http://trac.webkit.org/changeset/79282> 355009 11 commit-queue 2011-02-21 19:57:49 -0800 All reviewed patches have been landed. Closing bug. 82160 2011-02-11 12:34:37 -0800 2011-02-21 15:13:37 -0800 Patch bug-54305-20110211123436.patch text/plain 2487 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogNzgzNTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmOWYzOWY5OTA3MzQyOWNh Zjk0ZmExMTFkZGVkMjNhYTIzZjNkOWMwLi42OTY5NDkyYTk0NGRhZWI3OTk2MDQ0N2YzNjdiMTNm YzU4OTAwZGFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDItMTEgIE5pY28g V2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEdJRkltYWdlRGVjb2Rlcjo6c2V0U2l6ZSgpIHRyaWVzIHRv IG92ZXJyaWRlIHRoZSBzdXBlcmNsYXNzIG1ldGhvZCBidXQgZmFpbHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0MzA1CisKKyAgICAgICAgVGhlIHN1 cGVyY2xhc3MgdXNlcyB1bnNpZ25lZCBpbnN0ZWFkIG9mIGludCBmb3IgaXRzIHBhcmFtZXRlcnMs IHNvCisgICAgICAgIEdJRkltYWdlRGVjb2Rlcjo6c2V0U2l6ZSgpIHdhcyBhbiBvdmVybG9hZCwg bm90IGFuIG92ZXJyaWRlLgorCisgICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvZ2lm L0dJRkltYWdlRGVjb2Rlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHSUZJbWFnZURlY29kZXI6 OnNldFNpemUpOgorICAgICAgICAqIHBsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2dpZi9HSUZJbWFn ZURlY29kZXIuaDoKKwogMjAxMS0wMi0xMSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJv dEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjc4MzMxLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvZ2lmL0dJ RkltYWdlRGVjb2Rlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVy cy9naWYvR0lGSW1hZ2VEZWNvZGVyLmNwcAppbmRleCA3ZTMzNGE5NTI5N2MzYmRkN2Q2OGMwNTM3 MTM1ODAyMGYyYjJjOTg3Li5hZTFmNjk1ZTgxYzg2ZGRjMzdkYTUyOTBkZDk2Njk4NzZhZGI1OGYy IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9naWYv R0lGSW1hZ2VEZWNvZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1k ZWNvZGVycy9naWYvR0lGSW1hZ2VEZWNvZGVyLmNwcApAQCAtNjEsNyArNjEsNyBAQCBib29sIEdJ RkltYWdlRGVjb2Rlcjo6aXNTaXplQXZhaWxhYmxlKCkKICAgICByZXR1cm4gSW1hZ2VEZWNvZGVy Ojppc1NpemVBdmFpbGFibGUoKTsKIH0KIAotYm9vbCBHSUZJbWFnZURlY29kZXI6OnNldFNpemUo aW50IHdpZHRoLCBpbnQgaGVpZ2h0KQorYm9vbCBHSUZJbWFnZURlY29kZXI6OnNldFNpemUodW5z aWduZWQgd2lkdGgsIHVuc2lnbmVkIGhlaWdodCkKIHsKICAgICBpZiAoSW1hZ2VEZWNvZGVyOjpp c1NpemVBdmFpbGFibGUoKSAmJiBzaXplKCkud2lkdGgoKSA9PSB3aWR0aCAmJiBzaXplKCkuaGVp Z2h0KCkgPT0gaGVpZ2h0KQogICAgICAgICByZXR1cm4gdHJ1ZTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2dpZi9HSUZJbWFnZURlY29kZXIuaCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2dpZi9HSUZJbWFnZURlY29k ZXIuaAppbmRleCBkZDQwMWI4MzliZmNjOWY1YzhlMzgzOWQ3Y2E0YWVjZDQ1YjFhNzczLi4xNWJk OTlmNjg2MjM0YWRjMzlhZmVhZmI2ZTEwNWMxNzliMzI5MDcxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9naWYvR0lGSW1hZ2VEZWNvZGVyLmgKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvZ2lmL0dJRkltYWdlRGVj b2Rlci5oCkBAIC00NSw3ICs0NSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdmly dHVhbCBTdHJpbmcgZmlsZW5hbWVFeHRlbnNpb24oKSBjb25zdCB7IHJldHVybiAiZ2lmIjsgfQog ICAgICAgICB2aXJ0dWFsIHZvaWQgc2V0RGF0YShTaGFyZWRCdWZmZXIqIGRhdGEsIGJvb2wgYWxs RGF0YVJlY2VpdmVkKTsKICAgICAgICAgdmlydHVhbCBib29sIGlzU2l6ZUF2YWlsYWJsZSgpOwot ICAgICAgICB2aXJ0dWFsIGJvb2wgc2V0U2l6ZShpbnQgd2lkdGgsIGludCBoZWlnaHQpOworICAg ICAgICB2aXJ0dWFsIGJvb2wgc2V0U2l6ZSh1bnNpZ25lZCB3aWR0aCwgdW5zaWduZWQgaGVpZ2h0 KTsKICAgICAgICAgdmlydHVhbCBzaXplX3QgZnJhbWVDb3VudCgpOwogICAgICAgICB2aXJ0dWFs IGludCByZXBldGl0aW9uQ291bnQoKSBjb25zdDsKICAgICAgICAgdmlydHVhbCBJbWFnZUZyYW1l KiBmcmFtZUJ1ZmZlckF0SW5kZXgoc2l6ZV90IGluZGV4KTsK 83223 2011-02-21 15:13:40 -0800 2011-02-21 19:57:44 -0800 Patch bug-54305-20110221151339.patch text/plain 2620 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogNzkxOTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3NTJiNDczNWIwYzJiMmVm NjQ3YmU5OTNlNTkxN2Y4NmUwNjZhM2I3Li5jZDlhMGVjZjQ1YjhhMjg2NmQyNzJmM2U1YWVlZWVl MjI3NDMxNmQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDItMTEgIE5pY28g V2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEdJRkltYWdlRGVjb2Rlcjo6c2V0U2l6ZSgpIHRyaWVzIHRv IG92ZXJyaWRlIHRoZSBzdXBlcmNsYXNzIG1ldGhvZCBidXQgZmFpbHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0MzA1CisKKyAgICAgICAgVGhlIHN1 cGVyY2xhc3MgdXNlcyB1bnNpZ25lZCBpbnN0ZWFkIG9mIGludCBmb3IgaXRzIHBhcmFtZXRlcnMs IHNvCisgICAgICAgIEdJRkltYWdlRGVjb2Rlcjo6c2V0U2l6ZSgpIHdhcyBhbiBvdmVybG9hZCwg bm90IGFuIG92ZXJyaWRlLgorCisgICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvZ2lm L0dJRkltYWdlRGVjb2Rlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHSUZJbWFnZURlY29kZXI6 OnNldFNpemUpOgorICAgICAgICAqIHBsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2dpZi9HSUZJbWFn ZURlY29kZXIuaDoKKwogMjAxMS0wMi0yMSAgQW5kb25pIE1vcmFsZXMgQWxhc3RydWV5ICA8YW1v cmFsZXNAZmx1bW90aW9uLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5z b24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9n aWYvR0lGSW1hZ2VEZWNvZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRl Y29kZXJzL2dpZi9HSUZJbWFnZURlY29kZXIuY3BwCmluZGV4IDdlMzM0YTk1Mjk3YzNiZGQ3ZDY4 YzA1MzcxMzU4MDIwZjJiMmM5ODcuLmUzNTA2MDVjYzM5ZDllNWEwZjU0NDI0NjIwMDhjOTQzMGQ3 NWRkOTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJz L2dpZi9HSUZJbWFnZURlY29kZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lt YWdlLWRlY29kZXJzL2dpZi9HSUZJbWFnZURlY29kZXIuY3BwCkBAIC02MSw5ICs2MSw5IEBAIGJv b2wgR0lGSW1hZ2VEZWNvZGVyOjppc1NpemVBdmFpbGFibGUoKQogICAgIHJldHVybiBJbWFnZURl Y29kZXI6OmlzU2l6ZUF2YWlsYWJsZSgpOwogfQogCi1ib29sIEdJRkltYWdlRGVjb2Rlcjo6c2V0 U2l6ZShpbnQgd2lkdGgsIGludCBoZWlnaHQpCitib29sIEdJRkltYWdlRGVjb2Rlcjo6c2V0U2l6 ZSh1bnNpZ25lZCB3aWR0aCwgdW5zaWduZWQgaGVpZ2h0KQogewotICAgIGlmIChJbWFnZURlY29k ZXI6OmlzU2l6ZUF2YWlsYWJsZSgpICYmIHNpemUoKS53aWR0aCgpID09IHdpZHRoICYmIHNpemUo KS5oZWlnaHQoKSA9PSBoZWlnaHQpCisgICAgaWYgKEltYWdlRGVjb2Rlcjo6aXNTaXplQXZhaWxh YmxlKCkgJiYgc2l6ZSgpID09IEludFNpemUod2lkdGgsIGhlaWdodCkpCiAgICAgICAgIHJldHVy biB0cnVlOwogCiAgICAgaWYgKCFJbWFnZURlY29kZXI6OnNldFNpemUod2lkdGgsIGhlaWdodCkp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9naWYv R0lGSW1hZ2VEZWNvZGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVy cy9naWYvR0lGSW1hZ2VEZWNvZGVyLmgKaW5kZXggZGQ0MDFiODM5YmZjYzlmNWM4ZTM4MzlkN2Nh NGFlY2Q0NWIxYTc3My4uMTViZDk5ZjY4NjIzNGFkYzM5YWZlYWZiNmUxMDVjMTc5YjMyOTA3MSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvZ2lmL0dJ RkltYWdlRGVjb2Rlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29k ZXJzL2dpZi9HSUZJbWFnZURlY29kZXIuaApAQCAtNDUsNyArNDUsNyBAQCBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAgICAgICAgIHZpcnR1YWwgU3RyaW5nIGZpbGVuYW1lRXh0ZW5zaW9uKCkgY29uc3Qg eyByZXR1cm4gImdpZiI7IH0KICAgICAgICAgdmlydHVhbCB2b2lkIHNldERhdGEoU2hhcmVkQnVm ZmVyKiBkYXRhLCBib29sIGFsbERhdGFSZWNlaXZlZCk7CiAgICAgICAgIHZpcnR1YWwgYm9vbCBp c1NpemVBdmFpbGFibGUoKTsKLSAgICAgICAgdmlydHVhbCBib29sIHNldFNpemUoaW50IHdpZHRo LCBpbnQgaGVpZ2h0KTsKKyAgICAgICAgdmlydHVhbCBib29sIHNldFNpemUodW5zaWduZWQgd2lk dGgsIHVuc2lnbmVkIGhlaWdodCk7CiAgICAgICAgIHZpcnR1YWwgc2l6ZV90IGZyYW1lQ291bnQo KTsKICAgICAgICAgdmlydHVhbCBpbnQgcmVwZXRpdGlvbkNvdW50KCkgY29uc3Q7CiAgICAgICAg IHZpcnR1YWwgSW1hZ2VGcmFtZSogZnJhbWVCdWZmZXJBdEluZGV4KHNpemVfdCBpbmRleCk7Cg==