54288 2011-02-11 08:49:01 -0800 WebKit2: No icon shown for <input type=file> 2011-03-14 09:47:34 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED data:text/html,<input type=file> InRadar P2 Normal --- 1 aroben webkit-unassigned adele andersca sam oldest_to_newest 349793 0 aroben 2011-02-11 08:49:01 -0800 To reproduce: 1. Go to data:text/html,<input type=file> 2. Choose a file No icon is shown for the file! 349795 1 aroben 2011-02-11 08:49:38 -0800 I think this is happening because WebChromeClient::chooseIconForFiles is unimplemented. (It looks like a lot of other WebChromeClient functions are unimplemented as well; I wonder if we have bugs for all of them?) 349796 2 aroben 2011-02-11 08:50:05 -0800 <rdar://problem/8988982> 366798 3 85636 sam 2011-03-13 19:43:06 -0700 Created attachment 85636 Patch 367025 4 sam 2011-03-14 09:47:34 -0700 Landed in r81032. 85636 2011-03-13 19:43:06 -0700 2011-03-13 19:58:38 -0700 Patch bug-54288-20110313194305.patch text/plain 1838 sam SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwOTg4KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDMtMTMgIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXZWJLaXQyOiBObyBpY29uIHNob3duIGZvciA8aW5wdXQgdHlwZT1maWxl PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODk4ODk4Mj4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0Mjg4CisKKyAgICAgICAgKiBXZWJQcm9jZXNz L1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNsaWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl YkNocm9tZUNsaWVudDo6Y2hvb3NlSWNvbkZvckZpbGVzKToKKyAgICAgICAgQWRkIGltcGxlbWVu dGF0aW9uIGZvciBjaG9vc2VJY29uRm9yRmlsZXMgd2hpY2ggY2FsbHMgZG93biB0byBJY29uOjpj cmVhdGVJY29uRm9yRmlsZXMuCisKIDIwMTEtMDMtMTMgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0 Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNsaWVudC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9X ZWJDaHJvbWVDbGllbnQuY3BwCShyZXZpc2lvbiA4MDk4MykKKysrIFNvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNTIsNiArNTIsNyBAQAogI2luY2x1ZGUgPFdlYkNvcmUvRnJhbWVWaWV3Lmg+CiAjaW5j bHVkZSA8V2ViQ29yZS9IVE1MTmFtZXMuaD4KICNpbmNsdWRlIDxXZWJDb3JlL0hUTUxQbHVnSW5J bWFnZUVsZW1lbnQuaD4KKyNpbmNsdWRlIDxXZWJDb3JlL0ljb24uaD4KICNpbmNsdWRlIDxXZWJD b3JlL05vdEltcGxlbWVudGVkLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9QYWdlLmg+CiAjaW5jbHVk ZSA8V2ViQ29yZS9TZWN1cml0eU9yaWdpbi5oPgpAQCAtNjEwLDkgKzYxMSw5IEBAIHZvaWQgV2Vi Q2hyb21lQ2xpZW50OjpydW5PcGVuUGFuZWwoRnJhbWUKICAgICBtX3BhZ2UtPnNlbmQoTWVzc2Fn ZXM6OldlYlBhZ2VQcm94eTo6UnVuT3BlblBhbmVsKHN0YXRpY19jYXN0PFdlYkZyYW1lTG9hZGVy Q2xpZW50Kj4oZnJhbWUtPmxvYWRlcigpLT5jbGllbnQoKSktPndlYkZyYW1lKCktPmZyYW1lSUQo KSwgcGFyYW1ldGVycykpOwogfQogCi12b2lkIFdlYkNocm9tZUNsaWVudDo6Y2hvb3NlSWNvbkZv ckZpbGVzKGNvbnN0IFZlY3RvcjxTdHJpbmc+JiwgRmlsZUNob29zZXIqKQordm9pZCBXZWJDaHJv bWVDbGllbnQ6OmNob29zZUljb25Gb3JGaWxlcyhjb25zdCBWZWN0b3I8U3RyaW5nPiYgZmlsZW5h bWVzLCBGaWxlQ2hvb3NlciogY2hvb3NlcikKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAg IGNob29zZXItPmljb25Mb2FkZWQoSWNvbjo6Y3JlYXRlSWNvbkZvckZpbGVzKGZpbGVuYW1lcykp OwogfQogCiB2b2lkIFdlYkNocm9tZUNsaWVudDo6c2V0Q3Vyc29yKGNvbnN0IFdlYkNvcmU6OkN1 cnNvciYgY3Vyc29yKQo=