54283 2011-02-11 06:39:32 -0800 Web Inspector: command line API $0 regressed. 2011-02-11 07:38:31 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman webkit-unassigned abarth apavlov bweinstein eric joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 349745 0 pfeldman 2011-02-11 06:39:32 -0800 Patch to follow. 349754 1 82131 pfeldman 2011-02-11 06:52:03 -0800 Created attachment 82131 Patch 349755 2 82131 yurys 2011-02-11 06:53:32 -0800 Comment on attachment 82131 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82131&action=review > LayoutTests/inspector/command-line-api.html:18 > + if (!expressions.length) { wrong alignment 349756 3 pfeldman 2011-02-11 06:55:24 -0800 Committed r78335: <http://trac.webkit.org/changeset/78335> 349769 4 webkit.review.bot 2011-02-11 07:38:31 -0800 http://trac.webkit.org/changeset/78335 might have broken Qt Linux Release The following tests are not passing: inspector/command-line-api.html 82131 2011-02-11 06:52:03 -0800 2011-02-11 06:53:32 -0800 Patch bug-54283-20110211175201.patch text/plain 5120 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogNzgzMzQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0YTJiODI1MjY2ODNiNDdmMTQxMDQ3 NmQ4Nzk3NzRmMmFiM2Q2ZDg4Li4xOTA5ZjYzZTNkYzdlNTZhMzFmNzU3MDYzYTZjNWUwNmZkMGM1 MGVkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDItMTEgIFBhdmVsIEZlbGRtYW4gIDxw ZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogY29tbWFuZCBsaW5lIEFQSSAkMCByZWdyZXNz ZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDI4 MworCisgICAgICAgICogaW5zcGVjdG9yL2NvbW1hbmQtbGluZS1hcGktZXhwZWN0ZWQudHh0Ogor ICAgICAgICAqIGluc3BlY3Rvci9jb21tYW5kLWxpbmUtYXBpLmh0bWw6CisKIDIwMTEtMDItMTEg IE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IFhhbiBMb3Blei4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9j b21tYW5kLWxpbmUtYXBpLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb21t YW5kLWxpbmUtYXBpLWV4cGVjdGVkLnR4dAppbmRleCBlZGUyZDVlODQ3NjIyMzM1ZDhlNmVmYzlm YjVlYjFmMjI3ZTU1NjJiLi42ZDlhOGZkMjg4MGI1ODI3ZmMwNmYxMWQ0ODI5N2JkZDQ5NDJkOTBj IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29tbWFuZC1saW5lLWFwaS1leHBl Y3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbW1hbmQtbGluZS1hcGktZXhw ZWN0ZWQudHh0CkBAIC0xLDUgKzEsOCBAQAogVGVzdHMgdGhhdCBjb21tYW5kIGxpbmUgYXBpIHdv cmtzLgogCiskMC50b1N0cmluZygpID0gIltvYmplY3QgSFRNTEJvZHlFbGVtZW50XSIKIGtleXMo WzMsNF0pLnRvU3RyaW5nKCkgPSAiMCwxIgogdmFsdWVzKFszLDRdKS50b1N0cmluZygpID0gIjMs NCIKKyQoJ2ZvbycpLnRvU3RyaW5nKCkgPSAiW29iamVjdCBIVE1MUGFyYWdyYXBoRWxlbWVudF0i CiskJCgncCNmb28nKS50b1N0cmluZygpID0gIltvYmplY3QgTm9kZUxpc3RdIgogCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29tbWFuZC1saW5lLWFwaS5odG1sIGIvTGF5b3V0 VGVzdHMvaW5zcGVjdG9yL2NvbW1hbmQtbGluZS1hcGkuaHRtbAppbmRleCAyMDJiMjNiZWQzOThm NGNhYmQ2YWM0OGZhNzgxNDI3MTg5YTdkN2NmLi5mZmZkZDIzZTBmNDdkM2E5ZTMyMjFiMjU3NGU2 MjlmYzk4ZjFmNTk4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29tbWFuZC1s aW5lLWFwaS5odG1sCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb21tYW5kLWxpbmUtYXBp Lmh0bWwKQEAgLTUsMjQgKzUsMzIgQEAKIAogdmFyIHRlc3QgPSBmdW5jdGlvbigpCiB7Ci0gICAg SW5zcGVjdG9yVGVzdC5ldmFsdWF0ZUluQ29uc29sZUFuZER1bXAoImtleXMoWzMsNF0pLnRvU3Ry aW5nKCkiLCBzdGVwMik7CisJdmFyIGV4cHJlc3Npb25zID0gWworCSAgICAiJDAudG9TdHJpbmco KSIsCisJICAgICJrZXlzKFszLDRdKS50b1N0cmluZygpIiwKKwkgICAgInZhbHVlcyhbMyw0XSku dG9TdHJpbmcoKSIsCisJICAgICIkKCdmb28nKS50b1N0cmluZygpIiwKKwkgICAgIiQkKCdwI2Zv bycpLnRvU3RyaW5nKCkiCisJXTsKIAotICAgIGZ1bmN0aW9uIHN0ZXAyKCkKLSAgICB7Ci0gICAg ICAgIEluc3BlY3RvclRlc3QuZXZhbHVhdGVJbkNvbnNvbGVBbmREdW1wKCJ2YWx1ZXMoWzMsNF0p LnRvU3RyaW5nKCkiLCBzdGVwMyk7Ci0gICAgfQotCi0gICAgZnVuY3Rpb24gc3RlcDMoKQotICAg IHsKLSAgICAgICAgSW5zcGVjdG9yVGVzdC5jb21wbGV0ZVRlc3QoKTsKLSAgICB9CisgICAgZnVu Y3Rpb24gZXZhbEV4cHJlc3Npb25zKCkKKwl7CisJCWlmICghZXhwcmVzc2lvbnMubGVuZ3RoKSB7 CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmNvbXBsZXRlVGVzdCgpOworCQkJcmV0dXJuOwor CQl9CisJCXZhciBleHByZXNzaW9uID0gZXhwcmVzc2lvbnNbMF07CisJCWV4cHJlc3Npb25zLnNw bGljZSgwLCAxKTsKKwkgICAgSW5zcGVjdG9yVGVzdC5ldmFsdWF0ZUluQ29uc29sZUFuZER1bXAo ZXhwcmVzc2lvbiwgZXZhbEV4cHJlc3Npb25zKTsKKwl9CisJZXZhbEV4cHJlc3Npb25zKCk7CiB9 CiAKIDwvc2NyaXB0PgogPC9oZWFkPgogCiA8Ym9keSBvbmxvYWQ9InJ1blRlc3QoKSI+Ci08cD4K KzxwIGlkPSJmb28iPgogVGVzdHMgdGhhdCBjb21tYW5kIGxpbmUgYXBpIHdvcmtzLgogPC9wPgog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKaW5kZXggNGUzMzEzYmU3NmUzNzI1MDRmZjEzMGY2NWJmMjFmMmZlY2Y0M2I4YS4u MDQ0N2JiZmViNzEzMTU5NTc5MzEwY2JhNjBhM2VlYjE2M2ZlMzQ4NiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDEyIEBACisyMDExLTAyLTExICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdlYiBJbnNwZWN0b3I6IGNvbW1hbmQgbGluZSBBUEkgJDAgcmVncmVzc2VkLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQyODMKKworICAgICAgICAq IGluc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qczoKKwogMjAxMS0wMi0xMSAgSmFubmUg S29za2luZW4gIDxqYW5uZS5wLmtvc2tpbmVuQGRpZ2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBBbmRyZWFzIEtsaW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0luamVjdGVkU2NyaXB0U291cmNlLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luamVj dGVkU2NyaXB0U291cmNlLmpzCmluZGV4IDAzZGQzODU1NWFlZDEyOTU4N2E4YzllZWZjNTk3N2U0 NDkxMzE0NzIuLmM4OGU4ZTRhMmM0ODAxNDQ1ZTkzODA2MTdlMTc4ZDc1MWNiMDYwNzAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qcwor KysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2UuanMKQEAg LTU5MywxMyArNTkzLDE5IEBAIGZ1bmN0aW9uIENvbW1hbmRMaW5lQVBJKGNvbW1hbmRMaW5lQVBJ SW1wbCwgY2FsbEZyYW1lKQogCiAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBDb21tYW5kTGluZUFQ SS5tZW1iZXJzXy5sZW5ndGg7ICsraSkgewogICAgICAgICB2YXIgbWVtYmVyID0gQ29tbWFuZExp bmVBUEkubWVtYmVyc19baV07Ci0gICAgICAgIGlmIChtZW1iZXIgaW4gaW5zcGVjdGVkV2luZG93 KQotICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgIGlmIChpblNjb3BlVmFyaWFibGVzKG1l bWJlcikpCisgICAgICAgIGlmIChtZW1iZXIgaW4gaW5zcGVjdGVkV2luZG93IHx8IGluU2NvcGVW YXJpYWJsZXMobWVtYmVyKSkKICAgICAgICAgICAgIGNvbnRpbnVlOwogCiAgICAgICAgIHRoaXNb bWVtYmVyXSA9IGJpbmQoY29tbWFuZExpbmVBUElJbXBsLCBjb21tYW5kTGluZUFQSUltcGxbbWVt YmVyXSk7CiAgICAgfQorCisgICAgZm9yICh2YXIgaSA9IDA7IGkgPCA1OyArK2kpIHsKKyAgICAg ICAgdmFyIG1lbWJlciA9ICIkIiArIGk7CisgICAgICAgIGlmIChtZW1iZXIgaW4gaW5zcGVjdGVk V2luZG93IHx8IGluU2NvcGVWYXJpYWJsZXMobWVtYmVyKSkKKyAgICAgICAgICAgIGNvbnRpbnVl OworCisgICAgICAgIHRoaXMuX19kZWZpbmVHZXR0ZXJfXygiJCIgKyBpLCBiaW5kKGNvbW1hbmRM aW5lQVBJSW1wbCwgY29tbWFuZExpbmVBUElJbXBsLl9pbnNwZWN0ZWROb2RlLCBpKSk7CisgICAg fQogfQogCiBDb21tYW5kTGluZUFQSS5tZW1iZXJzXyA9IFsKQEAgLTYwOSw4ICs2MTUsNiBAQCBD b21tYW5kTGluZUFQSS5tZW1iZXJzXyA9IFsKIAogZnVuY3Rpb24gQ29tbWFuZExpbmVBUElJbXBs KCkKIHsKLSAgICBmb3IgKHZhciBpID0gMDsgaSA8IDU7ICsraSkKLSAgICAgICAgdGhpcy5fX2Rl ZmluZUdldHRlcl9fKCIkIiArIGksIHRoaXMuX2JpbmRUb1NjcmlwdCh0aGlzLl9pbnNwZWN0ZWRO b2RlLCBpKSk7CiB9CiAKIENvbW1hbmRMaW5lQVBJSW1wbC5wcm90b3R5cGUgPSB7CkBAIC03MjMs MjMgKzcyNywxMCBAQCBDb21tYW5kTGluZUFQSUltcGwucHJvdG90eXBlID0gewogICAgICAgICBJ bmplY3RlZFNjcmlwdEhvc3QuY2xlYXJDb25zb2xlTWVzc2FnZXMoKTsKICAgICB9LAogCi0gICAg X2JpbmRUb1NjcmlwdDogZnVuY3Rpb24oZnVuYykKLSAgICB7Ci0gICAgICAgIHZhciBhcmdzID0g QXJyYXkucHJvdG90eXBlLnNsaWNlLmNhbGwoYXJndW1lbnRzLCAxKTsKLSAgICAgICAgZnVuY3Rp b24gYm91bmQoKQotICAgICAgICB7Ci0gICAgICAgICAgICByZXR1cm4gZnVuYy5hcHBseShpbmpl Y3RlZFNjcmlwdCwgYXJncy5jb25jYXQoQXJyYXkucHJvdG90eXBlLnNsaWNlLmNhbGwoYXJndW1l bnRzKSkpOwotICAgICAgICB9Ci0gICAgICAgIGJvdW5kLnRvU3RyaW5nID0gZnVuY3Rpb24oKSB7 Ci0gICAgICAgICAgICByZXR1cm4gImJvdW5kOiAiICsgZnVuYzsKLSAgICAgICAgfTsKLSAgICAg ICAgcmV0dXJuIGJvdW5kOwotICAgIH0sCi0KICAgICBfaW5zcGVjdGVkTm9kZTogZnVuY3Rpb24o bnVtKQogICAgIHsKICAgICAgICAgdmFyIG5vZGVJZCA9IEluamVjdGVkU2NyaXB0SG9zdC5pbnNw ZWN0ZWROb2RlKG51bSk7Ci0gICAgICAgIHJldHVybiB0aGlzLl9ub2RlRm9ySWQobm9kZUlkKTsK KyAgICAgICAgcmV0dXJuIGluamVjdGVkU2NyaXB0Ll9ub2RlRm9ySWQobm9kZUlkKTsKICAgICB9 LAogCiAgICAgX25vcm1hbGl6ZUV2ZW50VHlwZXM6IGZ1bmN0aW9uKHR5cGVzKQo=