54265 2011-02-10 19:02:10 -0800 update-webkit hangs in a git-only checkout 2011-02-14 15:59:57 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth eric evan shishir oldest_to_newest 349569 0 dpranke 2011-02-10 19:02:10 -0800 update-webkit hangs in a git-only checkout 349570 1 82090 dpranke 2011-02-10 19:03:18 -0800 Created attachment 82090 Patch 349571 2 dpranke 2011-02-10 19:04:56 -0800 dunno who the best person to review this would be ... 349607 3 abarth 2011-02-10 20:50:23 -0800 Looks good to me, but +evmar for git ninja thoughts. 349626 4 82090 eric 2011-02-10 21:23:02 -0800 Comment on attachment 82090 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82090&action=review > Tools/Scripts/update-webkit:129 > + if (`git config --get svn-remote.svn.fetch 2>& 1`) { I would have made this a subroutine called isGitSVNCheckout or something. But it's also OK. 350916 5 82369 dpranke 2011-02-14 15:08:22 -0800 Created attachment 82369 refactor shell-callout into a subroutine per suggestion from eseidel 350918 6 dpranke 2011-02-14 15:09:04 -0800 (In reply to comment #4) > I would have made this a subroutine called isGitSVNCheckout or something. But it's also OK. Good suggestion. Done. 350934 7 82369 abarth 2011-02-14 15:30:45 -0800 Comment on attachment 82369 refactor shell-callout into a subroutine per suggestion from eseidel My git foo isn't that strong, but dpranke tell me evmar has blessed this incantation. One question: do we want to declare this function at the top of the file? 350936 8 dpranke 2011-02-14 15:31:37 -0800 I will add the declaration. 350947 9 82376 dpranke 2011-02-14 15:54:39 -0800 Created attachment 82376 move isGitSvnCheckout into VCSUtils.pm, rename to isGitSVN for consistency 350950 10 dpranke 2011-02-14 15:59:57 -0800 Committed r78520: <http://trac.webkit.org/changeset/78520> 82090 2011-02-10 19:03:18 -0800 2011-02-14 15:08:19 -0800 Patch bug-54265-20110210190317.patch text/plain 1605 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogNzgxNTkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyNTYxNjE1Y2VjN2Y5NmZjNDI1MThkYTg0NTY5ZWJiZjg3 MDRhNTVmLi4xNjJiNTc0YzYwZGM5OGYxMmZmYTM4MjI0ODg1YTYwNzgyMjZjN2E1IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDItMTAgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgdXBkYXRlLXdlYmtp dCBoYW5ncyBpbiBhIGdpdC1vbmx5IGNoZWNrb3V0CisKKyAgICAgICAgUHJldmlvdXNseSBpdCB3 b3VsZCBoYW5nIGZvcmV2ZXIgdHJ5aW5nIHRvIGRvIGEgJ2dpdCBzdm4KKyAgICAgICAgcmViYXNl Jy4gTm93LCBpdCB3aWxsIGRlZmF1bHQgdG8gYSAnZ2l0IHB1bGwnIGlmIHRoZQorICAgICAgICBz dm4tcmVtb3RlLnN2bi5mZXRjaCB2YXJpYWJsZSBpc24ndCBzZXQsIGFuZCBiYWlsIG91dCBpZiBp dAorICAgICAgICBkb2Vzbid0IGtub3cgd2hlcmUgdG8gcHVsbCBmcm9tLgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDI2NQorCisgICAgICAgICog U2NyaXB0cy91cGRhdGUtd2Via2l0OgorCiAyMDExLTAyLTA5ICBEaXJrIFByYW5rZSAgPGRwcmFu a2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcuCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQgYi9Ub29scy9TY3JpcHRzL3VwZGF0 ZS13ZWJraXQKaW5kZXggYWNhNTZiOGMxODFiZTcxMjE0ZWQ0OTU4MTJjZGFlZDZjMzdhYjhhZS4u MTA5YTEyYzQ5MGU0MDY4ZjQ5OGEwZDE2OTdhMTNhNTUwZDJjM2UxOCAxMDA3NTUKLS0tIGEvVG9v bHMvU2NyaXB0cy91cGRhdGUtd2Via2l0CisrKyBiL1Rvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtp dApAQCAtMTI2LDUgKzEyNiwxMSBAQCBzdWIgcnVuR2l0VXBkYXRlKCkKICAgICAjIERvaW5nIGEg Z2l0IGZldGNoIGZpcnN0IGFsbG93cyBzZXR1cHMgd2l0aCBzdm4tcmVtb3RlLnN2bi5mZXRjaCA9 IHRydW5rOnJlZnMvcmVtb3Rlcy9vcmlnaW4vbWFzdGVyCiAgICAgIyB0byBwZXJmb3JtIHRoZSBy ZWJhc2UgbXVjaCBtdWNoIGZhc3Rlci4KICAgICBzeXN0ZW0oImdpdCIsICJmZXRjaCIpID09IDAg b3IgZGllOwotICAgIHN5c3RlbSgiZ2l0IiwgInN2biIsICJyZWJhc2UiKSA9PSAwIG9yIGRpZTsK KyAgICBpZiAoYGdpdCBjb25maWcgLS1nZXQgc3ZuLXJlbW90ZS5zdm4uZmV0Y2ggMj4mIDFgKSB7 CisgICAgICAgIHN5c3RlbSgiZ2l0IiwgInN2biIsICJyZWJhc2UiKSA9PSAwIG9yIGRpZTsKKyAg ICB9IGVsc2UgeworICAgICAgICAjIFRoaXMgd2lsbCBkaWUgaWYgYnJhbmNoLiRCUkFOQ0hOQU1F Lm1lcmdlIGlzbid0IHNldCwgd2hpY2ggaXMKKyAgICAgICAgIyBhbG1vc3QgY2VydGFpbmx5IHdo YXQgd2Ugd2FudC4KKyAgICAgICAgc3lzdGVtKCJnaXQiLCAicHVsbCIpID09IDAgb3IgZGllOwor ICAgIH0KIH0K 82369 2011-02-14 15:08:22 -0800 2011-02-14 15:54:36 -0800 refactor shell-callout into a subroutine per suggestion from eseidel bug-54265-20110214150821.patch text/plain 1894 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogNzgxNTkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyNTYxNjE1Y2VjN2Y5NmZjNDI1MThkYTg0NTY5ZWJiZjg3 MDRhNTVmLi4xNjJiNTc0YzYwZGM5OGYxMmZmYTM4MjI0ODg1YTYwNzgyMjZjN2E1IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDItMTAgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgdXBkYXRlLXdlYmtp dCBoYW5ncyBpbiBhIGdpdC1vbmx5IGNoZWNrb3V0CisKKyAgICAgICAgUHJldmlvdXNseSBpdCB3 b3VsZCBoYW5nIGZvcmV2ZXIgdHJ5aW5nIHRvIGRvIGEgJ2dpdCBzdm4KKyAgICAgICAgcmViYXNl Jy4gTm93LCBpdCB3aWxsIGRlZmF1bHQgdG8gYSAnZ2l0IHB1bGwnIGlmIHRoZQorICAgICAgICBz dm4tcmVtb3RlLnN2bi5mZXRjaCB2YXJpYWJsZSBpc24ndCBzZXQsIGFuZCBiYWlsIG91dCBpZiBp dAorICAgICAgICBkb2Vzbid0IGtub3cgd2hlcmUgdG8gcHVsbCBmcm9tLgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDI2NQorCisgICAgICAgICog U2NyaXB0cy91cGRhdGUtd2Via2l0OgorCiAyMDExLTAyLTA5ICBEaXJrIFByYW5rZSAgPGRwcmFu a2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcuCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQgYi9Ub29scy9TY3JpcHRzL3VwZGF0 ZS13ZWJraXQKaW5kZXggYWNhNTZiOGMxODFiZTcxMjE0ZWQ0OTU4MTJjZGFlZDZjMzdhYjhhZS4u MzU3ZmZkZDA3ODdjODAyMWIxYjQ1YWEzYjQ5MjMxNzc1Y2MxNjgyMyAxMDA3NTUKLS0tIGEvVG9v bHMvU2NyaXB0cy91cGRhdGUtd2Via2l0CisrKyBiL1Rvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtp dApAQCAtMTI2LDUgKzEyNiwyMCBAQCBzdWIgcnVuR2l0VXBkYXRlKCkKICAgICAjIERvaW5nIGEg Z2l0IGZldGNoIGZpcnN0IGFsbG93cyBzZXR1cHMgd2l0aCBzdm4tcmVtb3RlLnN2bi5mZXRjaCA9 IHRydW5rOnJlZnMvcmVtb3Rlcy9vcmlnaW4vbWFzdGVyCiAgICAgIyB0byBwZXJmb3JtIHRoZSBy ZWJhc2UgbXVjaCBtdWNoIGZhc3Rlci4KICAgICBzeXN0ZW0oImdpdCIsICJmZXRjaCIpID09IDAg b3IgZGllOwotICAgIHN5c3RlbSgiZ2l0IiwgInN2biIsICJyZWJhc2UiKSA9PSAwIG9yIGRpZTsK KyAgICBpZiAoaXNHaXRTdm5DaGVja291dCgpKSB7CisgICAgICAgIHN5c3RlbSgiZ2l0IiwgInN2 biIsICJyZWJhc2UiKSA9PSAwIG9yIGRpZTsKKyAgICB9IGVsc2UgeworICAgICAgICAjIFRoaXMg d2lsbCBkaWUgaWYgYnJhbmNoLiRCUkFOQ0hOQU1FLm1lcmdlIGlzbid0IHNldCwgd2hpY2ggaXMK KyAgICAgICAgIyBhbG1vc3QgY2VydGFpbmx5IHdoYXQgd2Ugd2FudC4KKyAgICAgICAgc3lzdGVt KCJnaXQiLCAicHVsbCIpID09IDAgb3IgZGllOworICAgIH0KK30KKworc3ViIGlzR2l0U3ZuQ2hl Y2tvdXQoKQoreworICAgICMgVGhlcmUgZG9lc24ndCBzZWVtIHRvIGJlIGFuIG9mZmljaWFsbHkg ZG9jdW1lbnRlZCB3YXkgdG8gZGV0ZXJtaW5lCisgICAgIyBpZiB5b3UncmUgaW4gYSBnaXQtc3Zu IGNoZWNrb3V0LiBUaGUgYmVzdCBzdWdnZXN0aW9ucyBzZWVuIHNvIGZhcgorICAgICMgYWxsIHVz ZSBzb21ldGhpbmcgbGlrZSB0aGUgZm9sbG93aW5nOgorICAgIG15ICRvdXRwdXQgPSBgZ2l0IGNv bmZpZyAtLWdldCBzdm4tcmVtb3RlLnN2bi5mZXRjaCAyPiYgMWA7CisgICAgcmV0dXJuICRvdXRw dXQgbmUgJyc7CiB9Cg== 82376 2011-02-14 15:54:39 -0800 2011-02-14 15:54:39 -0800 move isGitSvnCheckout into VCSUtils.pm, rename to isGitSVN for consistency bug-54265-20110214155438.patch text/plain 2708 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogNzg1MTcKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwNzQxNzU2ZDFjZmZkNjE5ZWMxNzNhZjJiOTkwMWI4MzMz NWNlYmQwLi4yYmFlNWVmN2Q3YTY0ZmEwZGUyMzY1OTMxYWY4MGFiYjJmNDM5NTMwIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEg QEAKIDIwMTEtMDItMTQgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKKyAg ICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KKworICAgICAgICB1cGRhdGUtd2Via2l0IGhh bmdzIGluIGEgZ2l0LW9ubHkgY2hlY2tvdXQKKworICAgICAgICBQcmV2aW91c2x5IGl0IHdvdWxk IGhhbmcgZm9yZXZlciB0cnlpbmcgdG8gZG8gYSAnZ2l0IHN2bgorICAgICAgICByZWJhc2UnLiBO b3csIGl0IHdpbGwgZGVmYXVsdCB0byBhICdnaXQgcHVsbCcgaWYgdGhlCisgICAgICAgIHN2bi1y ZW1vdGUuc3ZuLmZldGNoIHZhcmlhYmxlIGlzbid0IHNldCwgYW5kIGJhaWwgb3V0IGlmIGl0Cisg ICAgICAgIGRvZXNuJ3Qga25vdyB3aGVyZSB0byBwdWxsIGZyb20uCisKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0MjY1CisKKyAgICAgICAgKiBTY3Jp cHRzL3VwZGF0ZS13ZWJraXQ6CisgICAgICAgICogU2NyaXB0cy9WQ1NVdGlscy5wbToKKworMjAx MS0wMi0xNCAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KKwogICAgICAgICBS ZXZpZXdlZCBieSBNaWhhaSBQYXJwYXJpdGEuCiAKICAgICAgICAgVGhpcyBwYXRjaCBtb2RpZmll cyBOUldUJ3MgV29ya2VyIGNsYXMgdG8gdXNlIHRoZSBuZXcKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvVkNTVXRpbHMucG0gYi9Ub29scy9TY3JpcHRzL1ZDU1V0aWxzLnBtCmluZGV4IDcwZTlh Y2QxMDg1NDM4Njc5OTJjNTVjOWNhZjBiYzQ5ODAyNTRjNjkuLmEwNWE3NWQ2NDczZWIzNDJlMjEw ZTIwZWVkMTE1YjIxZDY2OGYzODQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvVkNTVXRpbHMu cG0KKysrIGIvVG9vbHMvU2NyaXB0cy9WQ1NVdGlscy5wbQpAQCAtNTksNiArNTksNyBAQCBCRUdJ TiB7CiAgICAgICAgICZnaXRCcmFuY2gKICAgICAgICAgJmdpdGRpZmYyc3ZuZGlmZgogICAgICAg ICAmaXNHaXQKKyAgICAgICAgJmlzR2l0U1ZOCiAgICAgICAgICZpc0dpdEJyYW5jaEJ1aWxkCiAg ICAgICAgICZpc0dpdERpcmVjdG9yeQogICAgICAgICAmaXNTVk4KQEAgLTg4LDYgKzg5LDcgQEAg b3VyIEBFWFBPUlRfT0s7CiBteSAkZ2l0QnJhbmNoOwogbXkgJGdpdFJvb3Q7CiBteSAkaXNHaXQ7 CitteSAkaXNHaXRTVk47CiBteSAkaXNHaXRCcmFuY2hCdWlsZDsKIG15ICRpc1NWTjsKIG15ICRz dm5WZXJzaW9uOwpAQCAtMjAxLDYgKzIwMywxOCBAQCBzdWIgaXNHaXQoKQogICAgIHJldHVybiAk aXNHaXQ7CiB9CiAKK3N1YiBpc0dpdFNWTigpCit7CisgICAgcmV0dXJuICRpc0dpdFNWTiBpZiBk ZWZpbmVkICRpc0dpdFNWTjsKKworICAgICMgVGhlcmUgZG9lc24ndCBzZWVtIHRvIGJlIGFuIG9m ZmljaWFsbHkgZG9jdW1lbnRlZCB3YXkgdG8gZGV0ZXJtaW5lCisgICAgIyBpZiB5b3UncmUgaW4g YSBnaXQtc3ZuIGNoZWNrb3V0LiBUaGUgYmVzdCBzdWdnZXN0aW9ucyBzZWVuIHNvIGZhcgorICAg ICMgYWxsIHVzZSBzb21ldGhpbmcgbGlrZSB0aGUgZm9sbG93aW5nOgorICAgIG15ICRvdXRwdXQg PSBgZ2l0IGNvbmZpZyAtLWdldCBzdm4tcmVtb3RlLnN2bi5mZXRjaCAyPiYgMWA7CisgICAgJGlz R2l0U1ZOID0gJG91dHB1dCBuZSAnJzsKKyAgICByZXR1cm4gJGlzR2l0U1ZOOworfQorCiBzdWIg Z2l0QnJhbmNoKCkKIHsKICAgICB1bmxlc3MgKGRlZmluZWQgJGdpdEJyYW5jaCkgewpkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0IGIvVG9vbHMvU2NyaXB0cy91cGRhdGUt d2Via2l0CmluZGV4IGFjYTU2YjhjMTgxYmU3MTIxNGVkNDk1ODEyY2RhZWQ2YzM3YWI4YWUuLmM2 ZTU0ZjMzOTNhNDMzOTNjYzYyOTEwYmJkMWI1MzVjOWFmOTM4OTEgMTAwNzU1Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvdXBkYXRlLXdlYmtpdAorKysgYi9Ub29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQK QEAgLTEyNiw1ICsxMjYsMTEgQEAgc3ViIHJ1bkdpdFVwZGF0ZSgpCiAgICAgIyBEb2luZyBhIGdp dCBmZXRjaCBmaXJzdCBhbGxvd3Mgc2V0dXBzIHdpdGggc3ZuLXJlbW90ZS5zdm4uZmV0Y2ggPSB0 cnVuazpyZWZzL3JlbW90ZXMvb3JpZ2luL21hc3RlcgogICAgICMgdG8gcGVyZm9ybSB0aGUgcmVi YXNlIG11Y2ggbXVjaCBmYXN0ZXIuCiAgICAgc3lzdGVtKCJnaXQiLCAiZmV0Y2giKSA9PSAwIG9y IGRpZTsKLSAgICBzeXN0ZW0oImdpdCIsICJzdm4iLCAicmViYXNlIikgPT0gMCBvciBkaWU7Cisg ICAgaWYgKGlzR2l0U1ZOKCkpIHsKKyAgICAgICAgc3lzdGVtKCJnaXQiLCAic3ZuIiwgInJlYmFz ZSIpID09IDAgb3IgZGllOworICAgIH0gZWxzZSB7CisgICAgICAgICMgVGhpcyB3aWxsIGRpZSBp ZiBicmFuY2guJEJSQU5DSE5BTUUubWVyZ2UgaXNuJ3Qgc2V0LCB3aGljaCBpcworICAgICAgICAj IGFsbW9zdCBjZXJ0YWlubHkgd2hhdCB3ZSB3YW50LgorICAgICAgICBzeXN0ZW0oImdpdCIsICJw dWxsIikgPT0gMCBvciBkaWU7CisgICAgfQogfQo=