54254 2011-02-10 15:54:29 -0800 webkit2 pages gobble up cmd-I as an editing command in some cases where it shouldn't 2011-06-18 12:41:18 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 alice.barraclough alice.barraclough darin oldest_to_newest 349468 0 alice.barraclough 2011-02-10 15:54:29 -0800 In WebKit, [WebHTMLView _handleStyleKeyEquivalent] returned early if [WebHTMLView _canEdit] was false. We're missing this early return case in WebKit2, in [WKView _handleStyleKeyEquivalent] [WebHTMLView _canEdit] boils down to checking if the current selection is in an editable region. <rdar://problem/8980859> 349470 1 82065 alice.barraclough 2011-02-10 15:57:25 -0800 Created attachment 82065 patch 349474 2 82065 enrica 2011-02-10 16:00:43 -0800 Comment on attachment 82065 patch Looks good to me. 349550 3 82065 darin 2011-02-10 18:06:45 -0800 Comment on attachment 82065 patch View in context: https://bugs.webkit.org/attachment.cgi?id=82065&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:992 > + if (!_data->_page->selectionState().isContentEditable) I think that longer term we might want this only if content is “richly” editable. No reason to enable these inside, say, an <input type=text>. 423180 4 darin 2011-06-18 12:41:18 -0700 http://trac.webkit.org/changeset/78288 82065 2011-02-10 15:57:25 -0800 2011-02-10 18:06:45 -0800 patch cmdIbug.txt text/plain 1229 alice.barraclough SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4Mjc5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDItMTAgIEFsaWNlIExp dSAgPGFsaWNlLmxpdUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgV2ViS2l0MiBwYWdlcyBnb2JibGUgdXAgY21kLUkgYXMgYW4gZWRp dGluZyBjb21tYW5kIGluIHNvbWUgY2FzZXMgd2hlcmUgaXQgc2hvdWxkbid0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDI1NAorCisgICAgICAgICog VUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tOgorICAgICAgICAoLVtXS1ZpZXcgX2hhbmRsZVN0 eWxlS2V5RXF1aXZhbGVudDpdKToKKyAgICAgICAgUmV0dXJuIGVhcmx5IGlmIHdlJ3JlIG5vdCBp biBhbiBlZGl0YWJsZSByZWdpb24uCisKIDIwMTEtMDItMTAgIEFuZHJlYXMgS2xpbmcgIDxrbGlu Z0B3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgUXQgYnVpbGQgZml4LgpJbmRleDog U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkocmV2aXNpb24gNzc5 OTcpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHdvcmtp bmcgY29weSkKQEAgLTk4OSw2ICs5ODksOSBAQCAtICh2b2lkKWluc2VydFRleHQ6KGlkKXN0cmlu ZwogCiAtIChCT09MKV9oYW5kbGVTdHlsZUtleUVxdWl2YWxlbnQ6KE5TRXZlbnQgKilldmVudAog eworICAgIGlmICghX2RhdGEtPl9wYWdlLT5zZWxlY3Rpb25TdGF0ZSgpLmlzQ29udGVudEVkaXRh YmxlKQorICAgICAgICByZXR1cm4gTk87CisKICAgICBpZiAoKFtldmVudCBtb2RpZmllckZsYWdz XSAmIE5TRGV2aWNlSW5kZXBlbmRlbnRNb2RpZmllckZsYWdzTWFzaykgIT0gTlNDb21tYW5kS2V5 TWFzaykKICAgICAgICAgcmV0dXJuIE5POwogICAgIAo=