54242 2011-02-10 13:44:50 -0800 [Qt] Ensure WebView press delay timer is cancelled when grab is taken 2011-02-17 06:21:28 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 ademar ademar commit-queue kling laszlo.gombos webkit.review.bot oldest_to_newest 349342 0 ademar 2011-02-10 13:44:50 -0800 See http://bugreports.qt.nokia.com/browse/QTBUG-15529 for a working test case. """ Flickable steals the grab, but the timer was not stopped and the keepGrab flag is set and the mouse grabbed. This means that the WebView now has the grab and subsequent clicks on another element are ignored. """ Patch for webkit (based on the patch already submited to Qt) is on the way. 349344 1 82041 ademar 2011-02-10 13:48:18 -0800 Created attachment 82041 patch 349350 2 webkit.review.bot 2011-02-10 13:51:39 -0800 Attachment 82041 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1 Source/WebKit/qt/declarative/qdeclarativewebview_p.h:73: The parameter name "event" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 349385 3 82041 commit-queue 2011-02-10 14:32:19 -0800 Comment on attachment 82041 patch Clearing flags on attachment: 82041 Committed r78270: <http://trac.webkit.org/changeset/78270> 349386 4 commit-queue 2011-02-10 14:32:23 -0800 All reviewed patches have been landed. Closing bug. 350817 5 ademar 2011-02-14 12:08:18 -0800 Revision r78270 cherry-picked into qtwebkit-2.1 with commit 830d494 <http://gitorious.org/webkit/qtwebkit/commit/830d494> 352798 6 ademar 2011-02-17 06:21:04 -0800 Revision r78270 cherry-picked into qtwebkit-2.0 with commit dc72f20 <http://gitorious.org/webkit/qtwebkit/commit/dc72f20> 82041 2011-02-10 13:48:18 -0800 2011-02-10 14:32:18 -0800 patch 0001-Ensure-WebView-press-delay-timer-is-cancelled-when-g.patch text/plain 3451 ademar RnJvbSAzYWJhN2FiNWM0YTU1Yzc1YjQ5ZWMwMjIyNTliNGJmOGYyY2E3ZDcxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVtYXIgZGUgU291emEgUmVpcyBKciA8YWRlbWFyLnJlaXNA b3BlbmJvc3NhLm9yZz4KRGF0ZTogVGh1LCAxMCBGZWIgMjAxMSAxODo0NTowMCAtMDMwMApTdWJq ZWN0OiBbUEFUQ0hdIEVuc3VyZSBXZWJWaWV3IHByZXNzIGRlbGF5IHRpbWVyIGlzIGNhbmNlbGxl ZCB3aGVuIGdyYWIgaXMgdGFrZW4KCkFzIHJlcG9ydGVkIGluOgpodHRwOi8vYnVncmVwb3J0cy5x dC5ub2tpYS5jb20vYnJvd3NlL1FUQlVHLTE1NTI5CgpGbGlja2FibGUgc3RlYWxzIHRoZSBncmFi LCBidXQgdGhlIHRpbWVyIHdhcyBub3Qgc3RvcHBlZCBhbmQgdGhlCmtlZXBHcmFiIGZsYWcgaXMg c2V0IGFuZCB0aGUgbW91c2UgZ3JhYmJlZC4gVGhpcyBtZWFucyB0aGF0IHRoZSBXZWJWaWV3Cm5v dyBoYXMgdGhlIGdyYWIgYW5kIHN1YnNlcXVlbnQgY2xpY2tzIG9uIGFub3RoZXIgZWxlbWVudCBh cmUgaWdub3JlZC4KCk9yaWdpbmFsIHBhdGNoIGZyb20gTWFydGluIEpvbmVzIDxtYXJ0aW4uam9u ZXNAbm9raWEuY29tPgpyZXZpZXdlZCAodGhlcmUpIGJ5IEpvb25hIFBldHJlbGwKNTIwNjhmNTdm OWMzMjA5OGE5MGNjMjE3NzMwYTUzMGY4NTU5MGY2NQotLS0KIFNvdXJjZS9XZWJLaXQvcXQvQ2hh bmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAyMiArKysrKysrKysrKysrKysrKysr KwogLi4uL1dlYktpdC9xdC9kZWNsYXJhdGl2ZS9xZGVjbGFyYXRpdmV3ZWJ2aWV3LmNwcCAgfCAg IDEwICsrKysrKysrKwogLi4uL1dlYktpdC9xdC9kZWNsYXJhdGl2ZS9xZGVjbGFyYXRpdmV3ZWJ2 aWV3X3AuaCAgfCAgICAyICsKIDMgZmlsZXMgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwgMCBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDhjODA0ZjAuLmY5OTU5NzMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hh bmdlTG9nCkBAIC0yLDYgKzIsMjggQEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KIAorICAgICAgICBbUXRdIEVuc3VyZSBXZWJWaWV3IHByZXNzIGRlbGF5IHRpbWVyIGlz IGNhbmNlbGxlZCB3aGVuIGdyYWIgaXMgdGFrZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTU0MjQyCisKKyAgICAgICAgQXMgcmVwb3J0ZWQgaW46Cisg ICAgICAgIGh0dHA6Ly9idWdyZXBvcnRzLnF0Lm5va2lhLmNvbS9icm93c2UvUVRCVUctMTU1MjkK KworICAgICAgICBGbGlja2FibGUgc3RlYWxzIHRoZSBncmFiLCBidXQgdGhlIHRpbWVyIHdhcyBu b3Qgc3RvcHBlZCBhbmQgdGhlCisgICAgICAgIGtlZXBHcmFiIGZsYWcgaXMgc2V0IGFuZCB0aGUg bW91c2UgZ3JhYmJlZC4gVGhpcyBtZWFucyB0aGF0IHRoZSBXZWJWaWV3CisgICAgICAgIG5vdyBo YXMgdGhlIGdyYWIgYW5kIHN1YnNlcXVlbnQgY2xpY2tzIG9uIGFub3RoZXIgZWxlbWVudCBhcmUg aWdub3JlZC4KKworICAgICAgICBPcmlnaW5hbCBwYXRjaCBmcm9tIE1hcnRpbiBKb25lcyA8bWFy dGluLmpvbmVzQG5va2lhLmNvbT4KKyAgICAgICAgcmV2aWV3ZWQgKHRoZXJlKSBieSBKb29uYSBQ ZXRyZWxsCisgICAgICAgIDUyMDY4ZjU3ZjljMzIwOThhOTBjYzIxNzczMGE1MzBmODU1OTBmNjUK KworICAgICAgICAqIGRlY2xhcmF0aXZlL3FkZWNsYXJhdGl2ZXdlYnZpZXcuY3BwOgorICAgICAg ICAoR3JhcGhpY3NXZWJWaWV3OjpzY2VuZUV2ZW50KToKKyAgICAgICAgKiBkZWNsYXJhdGl2ZS9x ZGVjbGFyYXRpdmV3ZWJ2aWV3X3AuaDoKKworMjAxMS0wMi0xMCAgQWRlbWFyIGRlIFNvdXphIFJl aXMgSnIgIDxhZGVtYXIucmVpc0BvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAgIFtRdF0gRml4IGFzc2VydCBpbiBRRGVjbGFyYXRp dmVXZWJWaWV3CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NDI0MAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L2RlY2xhcmF0aXZlL3FkZWNs YXJhdGl2ZXdlYnZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9xdC9kZWNsYXJhdGl2ZS9xZGVjbGFy YXRpdmV3ZWJ2aWV3LmNwcAppbmRleCBkNzRmYjlhLi5iY2MxZjFjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L3F0L2RlY2xhcmF0aXZlL3FkZWNsYXJhdGl2ZXdlYnZpZXcuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvcXQvZGVjbGFyYXRpdmUvcWRlY2xhcmF0aXZld2Vidmlldy5jcHAKQEAgLTE0 MSw2ICsxNDEsMTYgQEAgdm9pZCBHcmFwaGljc1dlYlZpZXc6Om1vdXNlTW92ZUV2ZW50KFFHcmFw aGljc1NjZW5lTW91c2VFdmVudCogZXZlbnQpCiAgICAgICAgIFFHcmFwaGljc1dlYlZpZXc6Om1v dXNlTW92ZUV2ZW50KGV2ZW50KTsKIH0KIAorYm9vbCBHcmFwaGljc1dlYlZpZXc6OnNjZW5lRXZl bnQoUUV2ZW50ICpldmVudCkKK3sKKyAgICBib29sIHJ2ID0gUUdyYXBoaWNzV2ViVmlldzo6c2Nl bmVFdmVudChldmVudCk7CisgICAgaWYgKGV2ZW50LT50eXBlKCkgPT0gUUV2ZW50OjpVbmdyYWJN b3VzZSkgeworICAgICAgICBwcmVzc1RpbWVyLnN0b3AoKTsKKyAgICAgICAgcGFyZW50LT5zZXRL ZWVwTW91c2VHcmFiKGZhbHNlKTsKKyAgICB9CisgICAgcmV0dXJuIHJ2OworfQorCiAvKiEKICAg ICBccW1sY2xhc3MgV2ViVmlldyBRRGVjbGFyYXRpdmVXZWJWaWV3CiAgICAgXGluZ3JvdXAgcW1s LXZpZXctZWxlbWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvZGVjbGFyYXRpdmUv cWRlY2xhcmF0aXZld2Vidmlld19wLmggYi9Tb3VyY2UvV2ViS2l0L3F0L2RlY2xhcmF0aXZlL3Fk ZWNsYXJhdGl2ZXdlYnZpZXdfcC5oCmluZGV4IGIyMDU1YmYuLmNhMTVhMWUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvcXQvZGVjbGFyYXRpdmUvcWRlY2xhcmF0aXZld2Vidmlld19wLmgKKysr IGIvU291cmNlL1dlYktpdC9xdC9kZWNsYXJhdGl2ZS9xZGVjbGFyYXRpdmV3ZWJ2aWV3X3AuaApA QCAtNzAsNiArNzAsOCBAQCBwcm90ZWN0ZWQ6CiAgICAgdm9pZCBtb3VzZU1vdmVFdmVudChRR3Jh cGhpY3NTY2VuZU1vdXNlRXZlbnQqIGV2ZW50KTsKICAgICB2b2lkIG1vdXNlRG91YmxlQ2xpY2tF dmVudChRR3JhcGhpY3NTY2VuZU1vdXNlRXZlbnQgKmV2ZW50KTsKICAgICB2b2lkIHRpbWVyRXZl bnQoUVRpbWVyRXZlbnQqIGV2ZW50KTsKKyAgICBib29sIHNjZW5lRXZlbnQoUUV2ZW50ICpldmVu dCk7CisKIFFfU0lHTkFMUzoKICAgICB2b2lkIGRvdWJsZUNsaWNrKGludCBjbGlja1gsIGludCBj bGlja1kpOwogcHJpdmF0ZToKLS0gCjEuNy4zLjQKCg==