54240 2011-02-10 13:31:02 -0800 [Qt] Fix assert in QDeclarativeWebView 2011-02-17 06:20:55 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 ademar ademar commit-queue kling laszlo.gombos webkit.review.bot oldest_to_newest 349323 0 ademar 2011-02-10 13:31:02 -0800 From: http://bugreports.qt.nokia.com/browse/QTBUG-14278 In a debug build this will trigger an assert: import QtWebKit 1.0 WebView { width: 640 height: 480 WebView { } } Patch for webkit (based on the patch already submited to Qt) is on the way. 349327 1 82036 ademar 2011-02-10 13:32:49 -0800 Created attachment 82036 patch 349330 2 webkit.review.bot 2011-02-10 13:35:04 -0800 Attachment 82036 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1 Source/WebKit/qt/declarative/qdeclarativewebview.cpp:252: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebKit/qt/declarative/qdeclarativewebview.cpp:253: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebKit/qt/declarative/qdeclarativewebview.cpp:254: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 349376 3 82036 commit-queue 2011-02-10 14:17:42 -0800 Comment on attachment 82036 patch Clearing flags on attachment: 82036 Committed r78269: <http://trac.webkit.org/changeset/78269> 349377 4 commit-queue 2011-02-10 14:17:47 -0800 All reviewed patches have been landed. Closing bug. 350816 5 ademar 2011-02-14 12:07:46 -0800 Revision r78269 cherry-picked into qtwebkit-2.1 with commit 96da807 <http://gitorious.org/webkit/qtwebkit/commit/96da807> 352797 6 ademar 2011-02-17 06:20:50 -0800 Revision r78269 cherry-picked into qtwebkit-2.0 with commit 61982c8 <http://gitorious.org/webkit/qtwebkit/commit/61982c8> 82036 2011-02-10 13:32:49 -0800 2011-02-10 14:17:42 -0800 patch 0001-Fix-assert-in-QDeclarativeWebView.patch text/plain 2541 ademar RnJvbSBlNDFmOTZhMWIyMWI3Y2I0MTM0NzgwNWUzM2Y4MGE0ODJiNThmNWMzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVtYXIgZGUgU291emEgUmVpcyBKciA8YWRlbWFyLnJlaXNA b3BlbmJvc3NhLm9yZz4KRGF0ZTogVGh1LCAxMCBGZWIgMjAxMSAxODoyODoxNyAtMDMwMApTdWJq ZWN0OiBbUEFUQ0hdIEZpeCBhc3NlcnQgaW4gUURlY2xhcmF0aXZlV2ViVmlldwoKQXMgcmVwb3J0 ZWQgaW46Cmh0dHA6Ly9idWdyZXBvcnRzLnF0Lm5va2lhLmNvbS9icm93c2UvUVRCVUctMTQyNzgK Ckluc3RhbnRpYXRpbmcgYSBRRGVjbGFyYXRpdmVXZWJWaWV3IHR3aWNlIHdpbGwgdHJpZ2dlciBh biBhc3NlcnRpb24Kd2hlbiBpbiBkZWJ1ZyBtb2RlLgoKT3JpZ2luYWwgcGF0Y2ggZnJvbSBUaG9t YXMgSGFydG1hbm4gPFRob21hcy5IYXJ0bWFubkBub2tpYS5jb20+LApyZXZpZXdlZCAodGhlcmUp IGJ5IEFhcm9uIEtlbm5lZHkKZjUzMjY3OWNhMTE5MTRiNDUzZTIyMzQyZjJhZTVlOWY3OTBjZTQ3 YQotLS0KIFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAg IHwgICAyMCArKysrKysrKysrKysrKysrKysrKwogLi4uL1dlYktpdC9xdC9kZWNsYXJhdGl2ZS9x ZGVjbGFyYXRpdmV3ZWJ2aWV3LmNwcCAgfCAgICA2ICsrKysrLQogMiBmaWxlcyBjaGFuZ2VkLCAy NSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggM2U2NTU0 ZC4uOGM4MDRmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyNiBAQAogCiAgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIFtRdF0gRml4IGFzc2VydCBpbiBR RGVjbGFyYXRpdmVXZWJWaWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD01NDI0MAorCisgICAgICAgIEFzIHJlcG9ydGVkIGluOgorICAgICAgICBodHRw Oi8vYnVncmVwb3J0cy5xdC5ub2tpYS5jb20vYnJvd3NlL1FUQlVHLTE0Mjc4CisKKyAgICAgICAg SW5zdGFudGlhdGluZyBhIFFEZWNsYXJhdGl2ZVdlYlZpZXcgdHdpY2Ugd2lsbCB0cmlnZ2VyIGFu IGFzc2VydGlvbgorICAgICAgICB3aGVuIGluIGRlYnVnIG1vZGUuCisKKyAgICAgICAgT3JpZ2lu YWwgcGF0Y2ggZnJvbSBUaG9tYXMgSGFydG1hbm4gPFRob21hcy5IYXJ0bWFubkBub2tpYS5jb20+ LAorICAgICAgICByZXZpZXdlZCAodGhlcmUpIGJ5IEFhcm9uIEtlbm5lZHkKKyAgICAgICAgZjUz MjY3OWNhMTE5MTRiNDUzZTIyMzQyZjJhZTVlOWY3OTBjZTQ3YQorCisgICAgICAgICogZGVjbGFy YXRpdmUvcWRlY2xhcmF0aXZld2Vidmlldy5jcHA6CisgICAgICAgIChRRGVjbGFyYXRpdmVXZWJW aWV3Ojppbml0KToKKworMjAxMS0wMi0xMCAgQWRlbWFyIGRlIFNvdXphIFJlaXMgSnIgIDxhZGVt YXIucmVpc0BvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCiAgICAgICAgIFtRdF0gTWlzYyBkb2N1bWVudGF0aW9uIGZpeGVzL3VwZGF0ZXMKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0MjM2CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvZGVjbGFyYXRpdmUvcWRlY2xhcmF0aXZld2Vidmll dy5jcHAgYi9Tb3VyY2UvV2ViS2l0L3F0L2RlY2xhcmF0aXZlL3FkZWNsYXJhdGl2ZXdlYnZpZXcu Y3BwCmluZGV4IDczZmU2NjEuLmQ3NGZiOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQv ZGVjbGFyYXRpdmUvcWRlY2xhcmF0aXZld2Vidmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9x dC9kZWNsYXJhdGl2ZS9xZGVjbGFyYXRpdmV3ZWJ2aWV3LmNwcApAQCAtMjQ5LDcgKzI0OSwxMSBA QCB2b2lkIFFEZWNsYXJhdGl2ZVdlYlZpZXc6OmluaXQoKQogewogICAgIGQgPSBuZXcgUURlY2xh cmF0aXZlV2ViVmlld1ByaXZhdGUodGhpcyk7CiAKLSAgICBRV2ViU2V0dGluZ3M6OmVuYWJsZVBl cnNpc3RlbnRTdG9yYWdlKCk7CisgICAgaWYgKFFXZWJTZXR0aW5nczo6aWNvbkRhdGFiYXNlUGF0 aCgpLmlzTnVsbCgpICYmCisgICAgICAgIFFXZWJTZXR0aW5nczo6Z2xvYmFsU2V0dGluZ3MoKS0+ bG9jYWxTdG9yYWdlUGF0aCgpLmlzTnVsbCgpICYmCisgICAgICAgIFFXZWJTZXR0aW5nczo6b2Zm bGluZVN0b3JhZ2VQYXRoKCkuaXNOdWxsKCkgJiYKKyAgICAgICAgUVdlYlNldHRpbmdzOjpvZmZs aW5lV2ViQXBwbGljYXRpb25DYWNoZVBhdGgoKS5pc051bGwoKSkKKyAgICAgICAgUVdlYlNldHRp bmdzOjplbmFibGVQZXJzaXN0ZW50U3RvcmFnZSgpOwogCiAgICAgc2V0QWNjZXB0ZWRNb3VzZUJ1 dHRvbnMoUXQ6OkxlZnRCdXR0b24pOwogICAgIHNldEZsYWcoUUdyYXBoaWNzSXRlbTo6SXRlbUhh c05vQ29udGVudHMsIHRydWUpOwotLSAKMS43LjMuNAoK