54239 2011-02-10 13:00:18 -0800 Move code to dispatch an incoming message out into a new function 2011-02-10 13:04:39 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 349299 0 andersca 2011-02-10 13:00:18 -0800 Move code to dispatch an incoming message out into a new function 349300 1 82032 andersca 2011-02-10 13:01:47 -0800 Created attachment 82032 Patch 349303 2 82032 aroben 2011-02-10 13:03:54 -0800 Comment on attachment 82032 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82032&action=review > Source/WebKit2/Platform/CoreIPC/Connection.cpp:461 > // Dispatch messages. You can probably get rid of this comment now. 349306 3 andersca 2011-02-10 13:04:39 -0800 Committed r78260: <http://trac.webkit.org/changeset/78260> 82032 2011-02-10 13:01:47 -0800 2011-02-10 13:03:54 -0800 Patch bug-54239-20110210130147.patch text/plain 4403 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4MjU5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDItMTAgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBNb3ZlIGNvZGUgdG8gZGlzcGF0Y2ggYW4gaW5jb21pbmcg bWVzc2FnZSBvdXQgaW50byBhIG5ldyBmdW5jdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQyMzkKKworICAgICAgICBUaGlzIGFsc28gZml4ZXMg YSBsZWFrIHdoZXJlIHdlIHdvdWxkbid0IGZyZWUgQXJndW1lbnREZWNvZGVyIG9iamVjdHMKKyAg ICAgICAgYWZ0ZXIgYSBjb25uZWN0aW9uIGhhcyBiZWVuIGludmFsaWRhdGVkLgorICAgICAgICAK KyAgICAgICAgKiBQbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3BwOgorICAgICAgICAoQ29y ZUlQQzo6Q29ubmVjdGlvbjo6ZGlzcGF0Y2hNZXNzYWdlKToKKyAgICAgICAgKENvcmVJUEM6OkNv bm5lY3Rpb246OmRpc3BhdGNoTWVzc2FnZXMpOgorICAgICAgICAqIFBsYXRmb3JtL0NvcmVJUEMv Q29ubmVjdGlvbi5oOgorCiAyMDExLTAyLTEwICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBh cHBsZS5jb20+CiAKICAgICAgICAgVHJ5IGFnYWluIHRvIGZpeCB0aGUgUXQgYnVpbGQuCkluZGV4 OiBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5jcHAJKHJl dmlzaW9uIDc4MDc4KQorKysgU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0 aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDIxLDYgKzQyMSwzNCBAQCB2b2lkIENvbm5lY3Rp b246OmRpc3BhdGNoU3luY01lc3NhZ2UoTWVzCiAgICAgc2VuZFN5bmNSZXBseShyZXBseUVuY29k ZXIpOwogfQogCit2b2lkIENvbm5lY3Rpb246OmRpc3BhdGNoTWVzc2FnZShJbmNvbWluZ01lc3Nh Z2UmIG1lc3NhZ2UpCit7CisgICAgT3duUHRyPEFyZ3VtZW50RGVjb2Rlcj4gYXJndW1lbnRzID0g bWVzc2FnZS5yZWxlYXNlQXJndW1lbnRzKCk7CisKKyAgICAvLyBJZiB0aGVyZSdzIG5vIGNsaWVu dCwgcmV0dXJuLiBXZSBkbyB0aGlzIGFmdGVyIGNhbGxpbmcgcmVsZWFzZUFyZ3VtZW50cyBzbyB0 aGF0CisgICAgLy8gdGhlIEFyZ3VtZW50RGVjb2RlciBtZXNzYWdlIHdpbGwgYmUgZnJlZWQuCisg ICAgaWYgKCFtX2NsaWVudCkKKyAgICAgICAgcmV0dXJuOworCisgICAgbV9pbkRpc3BhdGNoTWVz c2FnZUNvdW50Kys7CisKKyAgICBib29sIG9sZERpZFJlY2VpdmVJbnZhbGlkTWVzc2FnZSA9IG1f ZGlkUmVjZWl2ZUludmFsaWRNZXNzYWdlOworICAgIG1fZGlkUmVjZWl2ZUludmFsaWRNZXNzYWdl ID0gZmFsc2U7CisKKyAgICBpZiAobWVzc2FnZS5tZXNzYWdlSUQoKS5pc1N5bmMoKSkKKyAgICAg ICAgZGlzcGF0Y2hTeW5jTWVzc2FnZShtZXNzYWdlLm1lc3NhZ2VJRCgpLCBhcmd1bWVudHMuZ2V0 KCkpOworICAgIGVsc2UKKyAgICAgICAgbV9jbGllbnQtPmRpZFJlY2VpdmVNZXNzYWdlKHRoaXMs IG1lc3NhZ2UubWVzc2FnZUlEKCksIGFyZ3VtZW50cy5nZXQoKSk7CisKKyAgICBtX2RpZFJlY2Vp dmVJbnZhbGlkTWVzc2FnZSB8PSBhcmd1bWVudHMtPmlzSW52YWxpZCgpOworICAgIG1faW5EaXNw YXRjaE1lc3NhZ2VDb3VudC0tOworCisgICAgaWYgKG1fZGlkUmVjZWl2ZUludmFsaWRNZXNzYWdl ICYmIG1fY2xpZW50KQorICAgICAgICBtX2NsaWVudC0+ZGlkUmVjZWl2ZUludmFsaWRNZXNzYWdl KHRoaXMsIG1lc3NhZ2UubWVzc2FnZUlEKCkpOworCisgICAgbV9kaWRSZWNlaXZlSW52YWxpZE1l c3NhZ2UgPSBvbGREaWRSZWNlaXZlSW52YWxpZE1lc3NhZ2U7Cit9CisKIHZvaWQgQ29ubmVjdGlv bjo6ZGlzcGF0Y2hNZXNzYWdlcygpCiB7CiAgICAgVmVjdG9yPEluY29taW5nTWVzc2FnZT4gaW5j b21pbmdNZXNzYWdlczsKQEAgLTQzMSwzMiArNDU5LDggQEAgdm9pZCBDb25uZWN0aW9uOjpkaXNw YXRjaE1lc3NhZ2VzKCkKICAgICB9CiAKICAgICAvLyBEaXNwYXRjaCBtZXNzYWdlcy4KLSAgICBm b3IgKHNpemVfdCBpID0gMDsgaSA8IGluY29taW5nTWVzc2FnZXMuc2l6ZSgpOyArK2kpIHsKLSAg ICAgICAgLy8gSWYgc29tZW9uZSBjYWxscyBpbnZhbGlkYXRlIHdoaWxlIHdlJ3JlIGludmFsaWRh dGluZyBtZXNzYWdlcywgd2Ugc2hvdWxkIHN0b3AuCi0gICAgICAgIGlmICghbV9jbGllbnQpCi0g ICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIAotICAgICAgICBJbmNvbWluZ01lc3NhZ2UmIG1l c3NhZ2UgPSBpbmNvbWluZ01lc3NhZ2VzW2ldOwotICAgICAgICBPd25QdHI8QXJndW1lbnREZWNv ZGVyPiBhcmd1bWVudHMgPSBtZXNzYWdlLnJlbGVhc2VBcmd1bWVudHMoKTsKLQotICAgICAgICBt X2luRGlzcGF0Y2hNZXNzYWdlQ291bnQrKzsKLQotICAgICAgICBib29sIG9sZERpZFJlY2VpdmVJ bnZhbGlkTWVzc2FnZSA9IG1fZGlkUmVjZWl2ZUludmFsaWRNZXNzYWdlOwotICAgICAgICBtX2Rp ZFJlY2VpdmVJbnZhbGlkTWVzc2FnZSA9IGZhbHNlOwotCi0gICAgICAgIGlmIChtZXNzYWdlLm1l c3NhZ2VJRCgpLmlzU3luYygpKQotICAgICAgICAgICAgZGlzcGF0Y2hTeW5jTWVzc2FnZShtZXNz YWdlLm1lc3NhZ2VJRCgpLCBhcmd1bWVudHMuZ2V0KCkpOwotICAgICAgICBlbHNlCi0gICAgICAg ICAgICBtX2NsaWVudC0+ZGlkUmVjZWl2ZU1lc3NhZ2UodGhpcywgbWVzc2FnZS5tZXNzYWdlSUQo KSwgYXJndW1lbnRzLmdldCgpKTsKLQotICAgICAgICBtX2RpZFJlY2VpdmVJbnZhbGlkTWVzc2Fn ZSB8PSBhcmd1bWVudHMtPmlzSW52YWxpZCgpOwotICAgICAgICBtX2luRGlzcGF0Y2hNZXNzYWdl Q291bnQtLTsKLQotICAgICAgICBpZiAobV9kaWRSZWNlaXZlSW52YWxpZE1lc3NhZ2UpCi0gICAg ICAgICAgICBtX2NsaWVudC0+ZGlkUmVjZWl2ZUludmFsaWRNZXNzYWdlKHRoaXMsIG1lc3NhZ2Uu bWVzc2FnZUlEKCkpOwotCi0gICAgICAgIG1fZGlkUmVjZWl2ZUludmFsaWRNZXNzYWdlID0gb2xk RGlkUmVjZWl2ZUludmFsaWRNZXNzYWdlOwotICAgIH0KKyAgICBmb3IgKHNpemVfdCBpID0gMDsg aSA8IGluY29taW5nTWVzc2FnZXMuc2l6ZSgpOyArK2kpCisgICAgICAgIGRpc3BhdGNoTWVzc2Fn ZShpbmNvbWluZ01lc3NhZ2VzW2ldKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgQ29yZUlQQwpJbmRl eDogU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmgJKHJldmlz aW9uIDc4MjQ3KQorKysgU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9u LmgJKHdvcmtpbmcgY29weSkKQEAgLTE4OSw4ICsxODksMTEgQEAgcHJpdmF0ZToKICAgICBib29s IHNlbmRPdXRnb2luZ01lc3NhZ2UoTWVzc2FnZUlELCBQYXNzT3duUHRyPEFyZ3VtZW50RW5jb2Rl cj4pOwogICAgIHZvaWQgY29ubmVjdGlvbkRpZENsb3NlKCk7CiAgICAgCisgICAgdHlwZWRlZiBN ZXNzYWdlPEFyZ3VtZW50RGVjb2Rlcj4gSW5jb21pbmdNZXNzYWdlOworCiAgICAgLy8gQ2FsbGVk IG9uIHRoZSBsaXN0ZW5lciB0aHJlYWQuCiAgICAgdm9pZCBkaXNwYXRjaENvbm5lY3Rpb25EaWRD bG9zZSgpOworICAgIHZvaWQgZGlzcGF0Y2hNZXNzYWdlKEluY29taW5nTWVzc2FnZSYpOwogICAg IHZvaWQgZGlzcGF0Y2hNZXNzYWdlcygpOwogICAgIHZvaWQgZGlzcGF0Y2hTeW5jTWVzc2FnZShN ZXNzYWdlSUQsIEFyZ3VtZW50RGVjb2RlciopOwogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAKQEAgLTIwOCw4ICsyMTEsNiBAQCBwcml2YXRlOgogICAgIGJvb2wgbV9kaWRSZWNlaXZlSW52 YWxpZE1lc3NhZ2U7CiAKICAgICAvLyBJbmNvbWluZyBtZXNzYWdlcy4KLSAgICB0eXBlZGVmIE1l c3NhZ2U8QXJndW1lbnREZWNvZGVyPiBJbmNvbWluZ01lc3NhZ2U7Ci0KICAgICBNdXRleCBtX2lu Y29taW5nTWVzc2FnZXNMb2NrOwogICAgIFZlY3RvcjxJbmNvbWluZ01lc3NhZ2U+IG1faW5jb21p bmdNZXNzYWdlczsKIAo=